#
✕ nick:rmk
#asahi-dev · 2023-01-03 20:55
rmkmarcan: good bye
#asahi-dev · 2022-11-15 10:38
rmkguessing doesn't always work
#asahi-dev · 2022-11-15 10:38
rmksven: for printk stuff... if it's size_t, that's unsigned, so %zu. if it's ptrdiff_t, that's signed, so use %zd. the z flag works like l, telling printf to use whatever is the implementation's requirement for size_t or ptrdiff_t
#asahi-dev · 2022-11-08 17:53
rmkhttps://patchwork.kernel.org/project/linux-arm-kernel/list/?series=693313
#asahi-dev · 2022-11-08 16:37
rmklooks for the nearest bunker to shelter in. :D
#asahi-dev · 2022-11-08 16:36
rmkand damn, I forgot to delete the in-reply-to in the cover
#asahi-dev · 2022-11-08 16:36
rmkand I now have 8 out-of-office responses
#asahi-dev · 2022-11-08 16:33
rmkok, lets see what kind of response we get from this set.
#asahi-dev · 2022-11-08 16:26
rmkanyone here willing to confirm that's correct?
#asahi-dev · 2022-11-08 16:26
rmkkey_info definitely needs some initialisation...
#asahi-dev · 2022-11-08 16:23
rmkplease point me to the fixes
#asahi-dev · 2022-11-08 16:04
rmkI'm guessing Lee will want the drivers/platform stuff split from the drivers/mfd bits, so I better split those before sending this round of patches
#asahi-dev · 2022-11-08 15:34
rmkwe need to select MFD_CORE anyway
#asahi-dev · 2022-11-08 15:32
rmkor would it make sense to have APPLE_SMC_RTKIT select MFD_MACSMC ?
#asahi-dev · 2022-11-08 15:32
rmkok, so I'll basically move the whole APPLE_SMC thing to mfd/Kconfig and kill APPLE_SMC entirely
#asahi-dev · 2022-11-08 15:28
rmkwonders if marcan saw my question yesterday
#asahi-dev · 2022-11-07 14:39
rmkmarcan: re making MFD_MACSMC the main symbol, how do you see that fitting in with the APPLE_PLATFORMS menuconfig?
#asahi-dev · 2022-11-04 09:25
rmkwhat was more recently suggested to be dropped was the t8103 specific compatible, not the generic one
#asahi-dev · 2022-11-04 09:25
rmkthere was a discussion about this in the initial posting, and the decision there was rather than messing about in each client, we'd add compatibles - that came from the review of the DT bindings iirc.
#asahi-dev · 2022-11-04 09:24
rmkmarcan: if we don't have DT compatibles in the mfd cell, MFD doesn't populate the of_node/fw_node in the device.
#asahi-dev · 2022-11-03 19:06
rmkthat last patch... I just added and I'm still pondering whether it's a good idea or not
#asahi-dev · 2022-11-03 19:05
rmkthat's my patch queue for this - obviously, the two mailbox patches have already been accepted via the mailbox tree
#asahi-dev · 2022-11-03 19:04
rmkmarcan: http://git.armlinux.org.uk/cgit/linux-arm.git/log/?h=apple-macsmc
#asahi-dev · 2022-11-03 16:29
rmkif I make up compatibles for them now, I can see complaints about missing binding documentation being the next hold-up.
#asahi-dev · 2022-11-03 16:26
rmkmarcan: I'm wondering what to do about the other MFD cells, the ones we currently don't have a compatible against yet... we'll need to fix those up eventually, so should we drop those and add them when merging the driver(s)... ?
#asahi-dev · 2022-11-03 14:03
rmkif we're going to call the mfd part macsmc, I think renaming to macsmc_rtkit is probably sensible to make it clear that it's apple mac stuff
#asahi-dev · 2022-11-03 14:01
rmkok, let me do that move and resubmit... I think we'll have to move the smc.h into linux/mfd/macsmc.h
#asahi-dev · 2022-11-03 14:01
rmkgood thing I kept these tweaks as patches on top :)
#asahi-dev · 2022-11-03 14:00
rmkok, I thought he was against that, but if he's not then that's a simple solution
#asahi-dev · 2022-11-03 14:00
rmkoh, great.
#asahi-dev · 2022-11-03 13:22
rmk(I've got quite a few patches like that which introduce various helpers for phylink - network stuff - but I'm refraining from pushing them without the corresponding users, which can be a pain when the helper gets used in a diverse range of places in networking code
#asahi-dev · 2022-11-03 13:19
rmkplease bear in mind that we've had code in the past that people have been pushy to get merged, but the result has been rather incomplete because the bits that make use of that code never end up being merged.
#asahi-dev · 2022-11-03 13:16
rmkI would encourage the Intel backend to be written though - which I think would've helped the case to show why the code is structured this way.
#asahi-dev · 2022-11-03 13:14
rmkpersonally, I think your code structure is correct and clean, and I don't entirely understand where Lee is coming from, so I think that switching it to a platform device is the best way forward at this point.
#asahi-dev · 2022-11-03 13:13
rmkand yes, I do think that pushing that stuff into a header file really isn't a good idea (I think I said as much in my email with the patch)
#asahi-dev · 2022-11-03 13:12
rmkI'm happy to try switching it to a platform device though.
#asahi-dev · 2022-11-03 13:11
rmkI haven't sent another version of that because I was hoping to get a way forward for the macsmc bits
#asahi-dev · 2022-11-03 13:11
rmkI think we're almost there with gpio-macsmc + dt binding (I need to drop the t8103 specific compatible there)
#asahi-dev · 2022-11-03 13:11
rmkmarcan: let me send you the patches - which will probably be a little later today.
#asahi-dev · 2022-11-02 14:12
rmkI think it would help to see what a different backend would look like - not having another backend and makes trying to argue for this code structure quite difficult.
#asahi-dev · 2022-11-02 14:11
rmkwhen I mooted the idea of not using mfd, Lee didn't seem to be keen on that idea either
#asahi-dev · 2022-11-02 14:11
rmkkettenis: I'm thinking if we can have another backend soon, then it boosts the case for this abstraction
#asahi-dev · 2022-11-02 12:47
rmkmarcan: is there another backend for smc_core written at the moment to prove out the current code structure?
#asahi-dev · 2022-10-31 19:49
rmkmarcan: please don't reply to Lee! I've invited him to chat with me on irc about it, I suspect he's completely misunderstood the code structure, which would explain a lot of his comments.
#asahi-dev · 2022-10-31 14:40
rmkyep, I think we can implement this without too much hassle without involving mfd if that's where we get to.
#asahi-dev · 2022-10-31 14:33
rmkmarcan: honestly, I think we could get away with converting this code to create and remove the platform devices directly without involving mfd without it needing too much effort, and then Lee's mfd stuff is completely out the loop.
#asahi-dev · 2022-10-31 14:23
rmkkettenis: so you think we shouldn't have the apple,t8103-smc-gpio compatible?
#asahi-dev · 2022-10-31 13:47
rmkI'm not particularly happy with Lee calling my attempt a "hack" when it seemed to be somewhat closer to the solution he seemed to be asking for.
#asahi-dev · 2022-10-31 13:45
rmkmarcan: I guess if Lee doesn't reply, the next thing to try is to see whether moving smc_core.c into drivers/mfd satisfies the issue. If that fails, then try all of drivers/platform/apple/*.[ch] into drivers/mfd maybe drivers/mfd/apple... if that doesn't work for Lee, I'm then at a complete loss - and I suggest at that point we effectively re-implement the mfd part to get around the blockage.
#asahi-dev · 2022-10-29 08:08
rmkmarcan: I've been talking to robh in private about improving the dt schema checks, and it sounds like some of my suggestions are being acted on... quite different from Krzysztof's attitude.

plus ›