#
…

2022-11-15

00:03millenialhacker has quit [Ping timeout: 484 seconds]
01:05Dcow_ has quit [Remote host closed the connection]
01:06Dcow has joined #asahi-dev
01:11user982492_ has joined #asahi-dev
01:14Dcow has quit [Ping timeout: 480 seconds]
01:16user982492 has quit [Ping timeout: 480 seconds]
01:35atipls has joined #asahi-dev
01:37millenialhacker has joined #asahi-dev
01:43atipls has quit [Ping timeout: 480 seconds]
01:45millenialhacker has quit [Ping timeout: 480 seconds]
02:02zalyx has quit [Quit: later alligator]
02:04zalyx has joined #asahi-dev
03:03millenialhacker has joined #asahi-dev
03:11millenialhacker has quit [Ping timeout: 480 seconds]
03:14atipls has joined #asahi-dev
03:22atipls has quit [Ping timeout: 480 seconds]
03:37user982492_ has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:03zalyx has quit [Quit: later alligator]
04:04zalyx has joined #asahi-dev
04:17user982492 has joined #asahi-dev
04:32Dcow has joined #asahi-dev
04:40Dcow has quit [Ping timeout: 480 seconds]
04:51capta1nt0ad has joined #asahi-dev
05:00c10l has quit [Quit: Bye o/]
05:01c10l has joined #asahi-dev
05:05user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:29millenialhacker has joined #asahi-dev
05:37millenialhacker has quit [Ping timeout: 480 seconds]
05:40princesszoey has quit [Quit: The Lounge - https://thelounge.chat]
05:40princesszoey has joined #asahi-dev
05:42greguu has joined #asahi-dev
05:46pthariensflame has joined #asahi-dev
05:47pthariensflame has quit []
05:53princesszoey has quit [Quit: The Lounge - https://thelounge.chat]
05:54princesszoey has joined #asahi-dev
06:15Retr0id7 has joined #asahi-dev
06:15Retr0id has quit [Read error: Connection reset by peer]
06:15Retr0id7 is now known as Retr0id
06:17marcanok, I think we're well overdue for a release. I'm going to write up a progress report.
06:17marcanthinking of releasing the current asahi-dev kernel (which has enough fixes and is otherwise well tested I think), just rebased on the latest -rc
06:18marcanand then merging all the fancy new DCP and USB3/ATC updates and making a linux-asahi-edge or something package (name suggestions? thinking we might want to use something other than "dev" to stop overloads)
06:30cylm has quit [Ping timeout: 480 seconds]
06:44jannaumarcan: sounds good. disabling of disp0_dart could be still useful to prevent breaking display scanout for the broken old m1n1 + new devicetree case
06:45marcanjannau: in the DT you mean?
06:45marcanyeah, probably a good idea
06:46jannauit shouldn't be necessary but if people even run into that when actively trying dcp it could prevent some support effort
06:48marcanyeah, sounds good. I might pull it in as an out-of-tree patch in the PKGBUILD. that way I can keep my plan of using the same tree with different configs for different packages.
06:50Dcow has joined #asahi-dev
06:50jannauI think it would be good to have the change in the tree to prevent issues in downstream projects
06:50marcanoh, the idea is enabling it in m1n1?
06:51marcanmakes sense
06:51millenialhacker has joined #asahi-dev
06:52jannauin asahi it should be enough if the kernel depends >=m1n1-1.1.7
06:52jannauwith enabling it in m1n1 it is guaranteed to be in safe state. it's either disabled or locked
06:54marcanjannau: do we need to transfer those backlight properties dynamically? do they vary machine to machine?
06:55capta1nt0ad has quit [Quit: Konversation terminated!]
06:56jannauI'd expect it be static per model so we could hardcode it in dts
06:58marcanI think it makes more sense to hardcode then. we can check the template devicetrees at least.
06:58Dcow has quit [Ping timeout: 480 seconds]
06:59marcanjannau: yeah, they're in the static templates
06:59marcanwe should just hardcode it then
06:59marcan(in general we don't transfer properties unless they are dynamic)
06:59marcanuser-accessible-max-nits only seems to exist on J314/316
07:00millenialhacker has quit [Ping timeout: 480 seconds]
07:00marcanjannau: DeviceTree.j316sap.adt.txt
07:01marcanthe second one for the 13" MBPs is for the DFR, that one you can ignore (for now)
07:01marcanbad copypasta
07:19jannauyeah, it was something like dynamic filling would be required for the calibration data so I can be lazy and don't need to look at the template ADT
07:20jannauyes, user-accessible-max-nits is just on j314/j316 for the desktop vs. HDR max brightness
07:21jannauLmaxProduct is the maximum for HDR. 1600 nits
07:21jannauI'll update kernel and m1n1 PRs tonight accordingly
07:21marcanthanks :)
07:23marcanjannau: calib ended up not being necessary?
07:27jannauno, I suspect iboot does that. the firmware appears to have afk methods for that (judging by strings in the fw)
07:28jannaumacos doesn't use those. I still have no idea what those set_block_dcp calls do but backlight control works without them
07:38marcaniBoot has to set the brightness to the one stored in nvram, so it makes sense that it has to take care of calibration
07:39gladiac has joined #asahi-dev
07:40svenI’ll prepare something for usb3/atc. No m2 support unless someone gets the fuses though
07:41svenDP/dcpext is still much too unstable imho
07:41marcanyeah, usb3 would be good to get in soon
07:41marcandoesn't have to be for this release in the main kernel
07:42svenyeah, and that’s pretty damn stable
07:42svenive been playing around with it the past days and can’t break it anymore
07:42marcanif you think usb3 is good enough to ship that would be nice
07:42marcanwe can get it into today's release and at least have people test it 2 days
07:42svenlet me prepare something later then
07:42marcanidea is to get everything ready today and ship on thursday if nothing explodes
07:43marcansven: what do you need for M2?
07:43svensee #asahi-re
07:43svensomeone needs to throw a t8112 kext into ghidra and extract like 10 bit locations for fuses
07:44svenunfortunately It’s not a table so it’s a bit anoying
07:47SSJ_GZ has joined #asahi-dev
07:50millenialhacker has joined #asahi-dev
07:58millenialhacker has quit [Ping timeout: 480 seconds]
08:09capta1nt0ad has joined #asahi-dev
08:21amarioguy2 has joined #asahi-dev
08:24amarioguy has quit [Ping timeout: 480 seconds]
08:33bisko has quit [Read error: Connection reset by peer]
08:34bisko has joined #asahi-dev
08:51marcanjannau: I'm cherry picking the enable commit for now into m1n1
08:53mpsmarcan: what about pwm for keyboard backlight https://github.com/AsahiLinux/linux/pull/57
08:54mpsI'm using it for about month on m1pro macbook and tested on m1 mackbook also
08:54mpslooks like it could be merged
08:55svenmost important new features: lights!
09:00mpswould be nice if I could celebrate full year usage macbook as workstation with all important features ;)
09:30MajorBiscuit has joined #asahi-dev
09:37bluetail has quit [Quit: The Lounge - https://thelounge.chat]
09:41bluetail has joined #asahi-dev
09:43svenmarcan: so I guess the easiest way to prepare usb3 for you to merge is to just base it on the current asahi-dev? it's just a few commits so it shouldn't conflict with anything (revert the old role switch quirk, add the new role switch quirk, add atcphy, add two lines to tipd, device tree updates)
09:44atipls has joined #asahi-dev
09:45marcansven: sure, I just updated it
09:46svenok, let me prepare something during this very important meeting :>
09:46_jannau_sven: add the extcon fix, it was not in rc5
09:46svenoh, right!
09:46sventhat one should hopefully stick around this time and not get reverted by accident again
09:48mpssven: I've got this warning when build kernel https://tpaste.us/pnPm think it is related to tipd
09:48sveni think that one's marcan's fault :D
09:48mpsasahi-wip branch
09:48svenalso very harmless
09:49mpsright, it works fine
09:49svenit's just about printf format specifiers. the way to get them right is to first just use %d, then compile and let the warning tell you what you should've used
09:49mpsyes, I see, easy to fix
09:52atipls has quit [Ping timeout: 480 seconds]
09:54bluetail has quit [Quit: The Lounge - https://thelounge.chat]
09:54millenialhacker has joined #asahi-dev
09:55marcanalready fixed
09:55marcansven: also that doesn't work, you actually need to read printk-formats :p
09:55marcane.g. size_t is special
09:55svenfair enough
09:55svenpaddr_t and friends as well
09:56svenlet me fix that statement above then: the way to get them right for local hacks is to compile and then just use whatever it tells you :P
09:58marcanthird kernel build, hopefully this one will work
09:58marcanI'm building two packages, -edge enables DCP and turns the smc/gpio stuff into modules (since that was built in only for simpledrm's backlight stuff)
09:59bluetail has joined #asahi-dev
09:59marcanalso both packages get CONFIG_RUST now (though no actual rust drivers)
10:03millenialhacker has quit [Ping timeout: 480 seconds]
10:09svenoh.. you have that other weird tipd irq fix in asahi-wip. let's see, i think jannau had a conflict resolution for that somewhere
10:09svenor I guess I just skip the additional tipd fixes and just do that 2 line mux commit
10:12_jannau_I have a revert for the irq fix. Is yours not in rc5?
10:12svendon't think greg sent the pull request yet
10:12svenbut i've just dropped my tipd fix commits for now and will just do a quick change that only does typec_set_mode
10:12svenwe don't need that altmode mess yet
10:13svenhttps://lore.kernel.org/linux-usb/20221114174449.34634-1-sven@svenpeter.dev/ irq+fix + those are essentially only required if I want to apply my current altmode mess
10:13svenbut I can just skip all that for now
10:14kettenis_sven: I noticed that some of the atc phy code is gpl-only instead of dual gpl+mit
10:14kettenis_is that intentional?
10:15svenjust copy/paste fail
10:16sveni'll fix the license headers as well
10:18svenkettenis_: once you implement it make sure you get the order of what happens in usb3_mux_set and phy_power_on correct
10:18svenyou first need to bring up the PHY, then dwc3, then do the pipehandler dance when initializing
10:18svenand when shutting down first undo the pipehandler dance and then shut down the PHY
10:18kettenis_it is unlikely that I'll copy any of the code, but there are so many registers that I may end up copying those bits
10:19kettenis_sven: thanks
10:19svenotherwise it only works sometimes
10:19svenit's very subtle unfortunately and that's the only order that works reliably so far
10:19marcan_jannau_: ack
10:20sveni think you can get away with just switching the phy mode from usb3-only to usb3/dp without shutting down dwc though
10:21kettenis_marcan: did you see my comment about the pmgr registers in the device tree last week?
10:21svenand you may need to do that if you're faster than the tps6598x thingy can negotiate the altmode
10:21marcankettenis_: I think I missed that
10:21kettenis_pmgr on the 8112 has:
10:21svendrivers/gpio/gpio-macsmc.c: In function 'macsmc_gpio_event':
10:21svendrivers/gpio/gpio-macsmc.c:220:6: error: void value not ignored as it ought to be
10:21marcansven: already fixed
10:21kettenis_reg = <0x2 0x3b700000 0 0x10000>;
10:21svenah, let me fetch again then
10:22kettenis_and then ps_disp0_cpu0 has:
10:22kettenis_reg = <0x10000 4>;
10:22marcanoh whoops
10:23svenoh, and I still need to update the tunables format in m1n1. the current atcphy code supports both but I want to move the new format I have to be consistent with the thunderbolt/acio tunables
10:24marcankettenis_: fixed
10:24kettenis_marcan: I suppose the size of the region should be maede bigger, but I couln't quickly find out what it should be
10:25marcankettenis_: t8103 has 0x14000 and the same offset for cpu0 so I just used 0x14000
10:25marcannot sure how I ended up reducing it for M2
10:26_jannau_sven: atcphy probing failed with the m1n1 tunable format pull request on t6001, I didn't look into why
10:26svenbecause I changed the format again and never tested it :D
10:26kettenis_we had an OpenBSD hackathon last week and I made some good progress on implementing "s2idle" for OpenBSD/arm64
10:26svenI’ll just drop the warn_on for now
10:28kettenis_we're also putting the infsrastructure in place to update the stage2 m1n1 from OpenBSD
10:38rmksven: for printk stuff... if it's size_t, that's unsigned, so %zu. if it's ptrdiff_t, that's signed, so use %zd. the z flag works like l, telling printf to use whatever is the implementation's requirement for size_t or ptrdiff_t
10:38rmkguessing doesn't always work
10:39svenI never though if z as a modifier which is why I could never remember the correct thing for size_t. that makes a lot of sense, thanks!
10:40kov has quit [Quit: Coyote finally caught me]
10:44svenbah... and I brought this cheap compile vm on hetzner down again. I should really move to compiling my kernels on the m1 as well
10:46marcanup to 6th try at a kernel tag... sigh
10:51Dcow has joined #asahi-dev
10:53joske has joined #asahi-dev
10:56joske has quit [Remote host closed the connection]
10:57joske has joined #asahi-dev
10:58joskemarcan: was brightness control supposed to be in? I just built asahi-wip of 10 minutes ago, and no brightness
10:58marcanno, not yet
10:58joskeah that explains it
10:58marcanI thought you were going to respin that with the data in the DTs?
10:58marcaner jannau I meant
10:58joskethought so ;-)
11:04joskekeyboard backlight is working, but when I log into mate (X11), screen is black. Same with xfce. GNOME wayland works
11:04joskeGDM login manager
11:06_jannau_is it fixed byt switching to a tty (Ctrl + Option (+ Fn) + F3) and back?
11:07joskethat seems to get me back to lock screen
11:08joskeif I enter PW again, same black screen, or bits of mate desktop, but no movement
11:08joske(X11 works with release asahi 5.19 kernel)
11:10svenmarcan: https://github.com/AsahiLinux/linux/commits/atcphy-for-asahi-wip briefly tested on t8103, probably work on t6k but can't test it there and can't get myself to care about t8112 :D
11:11sven*works
11:11kov has joined #asahi-dev
11:12svenif you test it note that there's always a ~5 seconds delay after xhci is up and when the SuperSpeed device is recognized
11:12svenno idea why yet or if that's the case on macos as well
11:13svenalso note that dwc3 won't come up at all at boot time if you have nothing connected. that's expected behavior.
11:13svenit'll come up after the first plug is connected
11:14_jannau_sven: I think the 5 second delay was fixed in the current dcpext branch
11:14svenhuh, really? wtf. how :D
11:15svenbecause right now it happens again. but if it's fixed in that branch i'll see if I can diff what fixed it
11:23mpslatest tag asahi-6.1-rc5-6 release works on m1pro, though drm is slow when switching virtual screens and mpv switching to full screen
11:23mpsbut all in all everything is fine
11:24mpsto get screen brightness control I tbink I will need to build m1n1 with patch
11:26jannausven: 350ms from "xHCI Host Controller" to "usb 2-1: new SuperSpeed USB" with 949e272b9ebdaf44478c7d56b3a0d8721a85f8d4 on t6001
11:26jannauthat is asahi-6.1-rc3-1.x-dcp-altmode
11:27jannaumps: display backlight control is not merged
11:29svenhuh. wonder what’s different there
11:29mpsjannau: I know. I used your PR as patch
11:29svenI thought I just renamed some registers and moved the pipehandler stuff from configure to power on which is called like 5 lines above from dwc3
11:29mpsand it is not important till it is merged
11:37joskemy friend built current asahi-wip on m2 air, and simpledrm is not loading : https://photos.app.goo.gl/hWEYEPu4FmsJNayP6
11:39jannausven: I thought the init changes you did the weekend a week ago was supposed to fix it
11:39svenyeah, but it didn't
11:39svenit just made it stable
11:41joskescratch that, he pulled again and now working
11:42jannauiirc it superspeed initialization was fast then but very unstable for me on t6001
11:42svenah, yes, that was a bug where I didn't transition the pipehandler to the disabled state sometimes
11:42svenso it kept usb3 despite shutting down atcphy
11:42joskesven: M1 mba: plugged my USB flash drive and it says high speed
11:42svenwhich made it sometimes fast but unstable
11:43svenjoske: full dmesg please
11:43jannaujoske: is it usb 3 flash drive?
11:43joskefull full or only the USB stuff?
11:43joskeit is USB3, it was recognized as superspeed on your branch ;-)
11:44svenand ideally boot with "tp_printk trace_event=appletypecphy:*"
11:44svenor look into that trace log somewhere in debugfs
11:44sven /sys/kernel/debug/tracing/trace i think
11:45svenbut there's something wrong with my tracing code there so dmesg is better
11:45joskethis is without the bootflag
11:45svenwhich commit is that?
11:47joskewhich commit built?
11:47joskecommit ee8536243118f3eb6c07df079cec6caec5c013d5 (HEAD -> asahi-wip, tag: asahi-6.1-rc5-6, origin/asahi-wip)
11:47sven*sigh*
11:48svenatcphy isn't in there
11:50joskeah I thought you meant marcan needed to pull that in
11:50svenyes, exactly
11:50svenbecause it contains atcphy
11:51joskeok, so normal it doesn't work then
11:57joske has quit [Remote host closed the connection]
11:58joske has joined #asahi-dev
11:59marcancan we please stop building random kernels while I'm literally in the middle of a rebase and merge cycle?
11:59marcanit just wastes everyone's times
11:59marcanI haven't even tested it myself, I'm still working out the PKGBUILD stuff for edge
12:00joskesorry I was just trying to help
12:01svenat least we've graduated from people compiling kernels with wrong .config options and then complaining that things don't work and that it must be a bug :D
12:05marcanwell that's interesting
12:05marcancrw-rw----+ 1 root video 226, 0 Nov 15 21:03 card0
12:05marcancrw-rw----+ 1 root video 226, 1 Nov 15 21:03 card1
12:05marcancrw-rw-rw- 1 root render 226, 128 Nov 15 21:03 renderD128
12:05marcanI thought dcp was supposed to take over simpledrm and cause it to disappear, and also where did the render node come from?
12:05marcanI'm pretty sure I haven't merged lina's driver yet
12:05jannaumarcan: I think we have vgem built-in in the asahi config
12:06jannauor some other virtual device
12:06jannauvkms maybe
12:06marcanwell that would do it
12:06marcanvgem yeah
12:08marcanI guess we should just turn that off in -edge
12:08marcanand leave it on in the default one (not sure if it would load as a module?)
12:10marcanheh, display performance really is much worse with DCP. I'm not sure if this is a mode issue or an expensive redraws issue...
12:12marcanokay, so "re-use screen content" in KWin is broken. not sure whose fault that is.
12:13marcan60Hz is smooth
12:13marcan120Hz is choppy
12:14marcanno wait, 120Hz is smooth
12:14marcan... or is it
12:15chadmeddid you merge "working" EAS by any chance?
12:15marcan120Hz was smooth for a while, then it stopped.
12:15marcanchadmed: you think it's EAS?
12:15chadmedit reliably destroys software rendering performance on my 14"
12:16chadmedwithout it dcp is smooth in x11 but sucks in wayland
12:17marcanfor me dcp is smooth at 60Hz
12:17marcanat 120Hz it starts out smooth but then tends to flip into choppy mode
12:18marcanwhy do I get the feeling 120Hz is special...
12:18marcananyway, I'll drop the EAS patches
12:19chadmedunless you picked viresh's fix from linux-pm then EAS wouldnt be registering anyway
12:19marcandon't think I did unless it's in -rc5
12:20jannaumarcan: dcp limits the swaps in 120Hz to 60Hz anyway
12:20marcanjannau: it looks to me like it randomly decides to limit the swaps to like 15Hz
12:20marcanI suspect shenanigans, like some other dynamic switching/controls we don't do yet
12:20marcanwe might want to hide the 120Hz mode for now
12:21jannaumarcan: simpledrm uses a shadow fb and updates only damaged parts. that seems to be much faster
12:21marcanas I said, 120Hz starts out smooth then drops to like 15Hz
12:21marcanthat doesn't sound like a rendering/damage issue
12:21jannaualso llvmpipe is slow
12:21marcanthat sounds like DCP
12:21marcanif it were a rendering issue it would be slow from the get go
12:21marcanand 60Hz is fine
12:22marcanI'm rebuilding without EAS and without VGEM for -edge, but you can try installing linux-asahi-edge from asahi-dev if you want
12:22jannauso you add additional problems since the swap waits randomly
12:22marcanit should coexist with linux-asahi and you get both options in GRUB (make sure to update-grub)
12:22marcananyway, I should get some dinner :p
12:22chadmedthe EM shouldnt register on rc5 anyway since that fix didnt make it in
12:23jannaudcp is slow on large repaints with an external 50 HZ display
12:23marcanthat still doesn't explain why it's fast initially and then slow...
12:23* marcanoff to dinner
12:25capta1nt0ad has quit [Quit: Leaving...]
12:26capta1nt0ad has joined #asahi-dev
12:27jannauI'm not sure I see what you see. dcp is choppy on large repaints like moving a large window or maximizing windows but otherwise it is okay-ish
12:28jannauhave you looked at the "show fps" desktop effect
12:29jannauI think it is an rendering issue because I don't see any issues in combination with lina's and alyssa's opengl driver
12:30capta1nt0ad has quit []
12:30capta1nt0ad has joined #asahi-dev
12:30jannaubits/000-devicetree and bits/200-dcp are refreshed for backlight control
12:31jannaum1n1 change has only python changes and can wait
12:45marcanjannau: even the mouse cursor is choppy
12:45marcanbut it's choppy a few seconds after switching to 120Hz
12:49marcan"show fps" says 60Hz at 60Hz; at 120Hz it actually says more like 90Hz while moving the mouse, but it's actually choppier (both the mouse and the graph) once it triggers
12:49marcaninitially it's smooth
12:49marcanwhen it becomes choppy it's an instant transition
12:50jannauplasma/x11 or wayland? what I said about swap applies only to wayland
12:50marcanplasma/x11
12:52marcanI also don't know why it stutters so badly when e.g. fullscreening a window. there's no way it takes that long to render the single frame where it stalls. something's weird there.
12:52marcanlike it stalls for a whole second
12:52millenialhacker has joined #asahi-dev
12:53marcanmakes me want to say it's a memory allocation issue with the surface size changing
12:53jannauresizing a window is bad with 120Hz / x11
12:53marcanit's also bad with 60Hz
12:54kazuki has joined #asahi-dev
12:54* marcanback to dinner
12:54jannaubut moving the same window not great but ok
12:54kazukichadmed marcan: EAS doesn't slow down rendering on my PC
12:55kazukiIt's 60hz though
12:55jannaukazuki: I don't think this issue is EAS related
12:57jannaudcp framebuffers are allocated with write combine. I'm not sure 100% if I set the uncached bit in the dart PTEs
12:59jannauresizing windows plasma/wayland is ok
13:00millenialhacker has quit [Ping timeout: 480 seconds]
13:14zalyx has quit [Quit: later alligator]
13:15zalyx has joined #asahi-dev
13:47atipls has joined #asahi-dev
13:47atipls has quit []
14:03_jannau_marcan: not sure what the x11 issue could be but iirc there is not driver <-> dcp communication involved after the initial modeset
14:50millenialhacker has joined #asahi-dev
14:58millenialhacker has quit [Ping timeout: 480 seconds]
15:00SSJ_GZ has quit [Ping timeout: 480 seconds]
15:05SSJ_GZ has joined #asahi-dev
15:31bluetail has quit [Quit: The Lounge - https://thelounge.chat]
15:34joske has quit [Remote host closed the connection]
15:35bluetail has joined #asahi-dev
15:39gladiac has quit [Quit: k thx bye]
16:09millenialhacker has joined #asahi-dev
16:14atipls has joined #asahi-dev
16:17millenialhacker has quit [Ping timeout: 480 seconds]
16:23atipls has quit [Remote host closed the connection]
16:23atipls has joined #asahi-dev
16:41marcanok, I merged atcphy and backlight, tagged and pushed. doing a build now
16:41roxfan2 has joined #asahi-dev
16:45roxfan has quit [Ping timeout: 480 seconds]
16:46marcanthe plan right now is that linux-asahi gets ATCPHY, -edge on top of that gets suspend/s2idle, DCP, and SMC and the chain of RTKit dependencies go y->m due to the removal of simpledrm backlight.
16:56r0ni_ has joined #asahi-dev
17:02r0ni has quit [Ping timeout: 480 seconds]
17:04_jannau_sound good. missed https://github.com/AsahiLinux/linux/pull/66 (dart reserved region fix)
17:06_jannau_I'll look int the dcp x111 performance. I mostly looked at wayland since there's continous communication with dcp
17:06MajorBiscuit has quit [Ping timeout: 480 seconds]
17:07_jannau_first suspect for the atrotious performance is the missing vblank irq
17:13kazuki_ has joined #asahi-dev
17:15mpswhat version of m1n1 is needed for latest asahi-wip
17:16kazuki has quit [Ping timeout: 480 seconds]
17:16_jannau_1.1.8 but maybe wait
17:17mpsfine, I already have 1.1.8, but ofc I can wait
17:26___nick___ has joined #asahi-dev
17:26___nick___ has quit []
17:28___nick___ has joined #asahi-dev
17:28marcan_jannau_: merged
17:28svenjust in case you didn’t notice: I didn’t add the atcphy nodes for t8112
17:29svenSounds good otherwise
17:29marcansven: I did, don't have time to do it myself right now, hoping you get bored enough to do it :>
17:29svenlol :D
17:29marcanit's 2:30AM and my plan after kicking off a build is to take a bath and go to sleep :p
17:29svensounds good as well
17:30marcangetting one PKGBUILD to build two kernels trying to reuse part of the build and also have them properly installable side-to-side took a bit more work than expected
17:32r0ni_ has quit [Ping timeout: 480 seconds]
17:32svensounds like my adventures in the typec subsystem. That’s also gonna take more work that expected
17:33marcanwhat little I saw of that subsystem looked kind of crazy... I guess I wasn't wrong about that.
17:35millenialhacker has joined #asahi-dev
17:35marcan_jannau_: wait, so x11 doesn't do any swaps after the initial one?
17:36svennope, my current idea about that subsystem is batshit crazy unless I’m missing something
17:36marcanare we sure that's kosher in the general case? there could well be dynamic PSR involved, such that framebuffer updates don't actually make it to the display in a timely fashion
17:37marcanI wouldn't be surprised if 120Hz mode specifically enables that kind of thing...
17:38svenmy favorite part is an ops struct that is shared by two separate components. and each of those is really only allow to implement a distinct subset of callbacks afaict. don’t ask me why it’s not two ops struct then
17:38svenmaybe there’s a reason for that but that reason is very much not obvious then
17:40marcan_jannau_: also fyi:
17:40marcan/home/marcan/asahi/git/PKGBUILDs/linux-asahi/src/linux-asahi-6.1-rc5-9/drivers/gpu/drm/apple/dcp.c: In function ‘dcp_start’:
17:40marcan/home/marcan/asahi/git/PKGBUILDs/linux-asahi/src/linux-asahi-6.1-rc5-9/drivers/gpu/drm/apple/dcp.c:249:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
17:40marcan 249 | if (ret)
17:40marcan/home/marcan/asahi/git/PKGBUILDs/linux-asahi/src/linux-asahi-6.1-rc5-9/drivers/gpu/drm/apple/dcp.c:251:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
17:40marcan 251 | return ret;
17:40marcanthat one's been around for a while
17:41marcanjust bad indentation I think, maybe it only shows up with my compiler?
17:43_jannau_I need to check but I'm reasonable sure that there is no dcp rtkit traffic. so what I've seen with the window resize shouldn't be a scanout issue. the show fps effect reports a frame rate of 4 fps
17:43marcanI'm talking about the choppiness at 120Hz after a while
17:43marcanthe window resize probably isn't a scanout issue, yeah
17:43millenialhacker has quit [Ping timeout: 480 seconds]
17:45_jannau_waarning looks legit to me and I'd it misses braces but doesn't make a difference
17:46_jannau_not sure I've seen the choppiness yet
17:47marcanit reliably starts happening for me on xorg after a while
17:47marcanjust pushed another build to asahi-dev
17:48marcanrunning edge from there on a j314
17:49marcanincidentally, the brightness control looks like nits-linear to me. is it supposed to be? it feels quite lopsided (normally you'd have some gamma applied to get a reasonable brightness curve, but I don't know if Linux has any standards for this)
17:50_jannau_I'll take a look. I've tested x11 only briefly since it looked unintersting
17:50_jannau_yes, it's nits linear and annotated as such. scale is nits
17:51marcanok, I guess then we can blame KDE for not making it more human-friendly
17:51_jannau_there is no standard and no annotation for the unit
17:52marcan[ 336.387906] usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd
17:52tpw_rulesit's always felt kind of nonlinear in macos
17:52marcanthat looks good, though I do get the 5s delay
17:52tpw_rulesthere's a couple humps in the scale
17:54marcan_jannau_: I get a black screen after suspend/resume, but closing the lid and opening it brings it back. suspect missing backlight restore?
17:55marcansven: s2idle kills atcphy I think, though a hotplug brings it back
17:55marcanI *think* prior to this usb2 did survive but with a bus reset (xhci still errored out but recovered)
17:56svenhrm, yeah, that’s not surprising
17:56svenusually when you break atcphy either usb2 or usb3 survives
17:56_jannau_for the brightness hotkeys apple uses their marketing table with around 17 entries. those dteps are probably not linear
17:56atipls has quit [Quit: My laptop probably went to sleep.]
17:57marcanok, so basically things are Mostly Breaking As Expected in -edge
17:57svenI’ll look into suspend for atcphy after that typec mess for altmode is done
17:57marcanI need to relax a bit and sleep, but I would appreciate testing with both the regular kernel and -edge (available in asahi-dev)
17:57mpslsusb.py gives 2-1 1058:264f 00 1IF [USB 3.20, 10000 Mbps, 896mA] (Western Digital.....
17:57mpsvery nice
17:57marcanif the regular one is stable with atcphy (sans suspend) and doesn't otherwise regress things, this is releasable this week
17:59svenfamous last words but I think at this stage atcphy can always recover with a hotplug in the worst case
17:59svenI haven’t even seen it complain about anything on t8103 in the last days though
18:01marcanoh yeah, keyboard backlight works too :>
18:02sventhe most important feature next to backlight ;p
18:02mpsmarcan: yes, if you need hacky daemon for kbd backlight I can post it
18:03marcanwhy would I need a daemon? KDE supports it out of the box
18:03jannaumps: kde handles it fine
18:03mpsah, didn't knew
18:03mpsprobably because I don't use KDE ;)
18:05jannauno usb3 on m2 with linux-asahi, maybe the atcphy .compatible.
18:05marcanjannau: the DT isn't done at all, unless you did?
18:05marcansee < sven> just in case you didn’t notice: I didn’t add the atcphy nodes for t8112
18:05jannauno, I did not
18:05svenmarcan did the hard part of finding the fuses
18:06marcanI pasted the fuse bits in -re, needs adding everything else
18:06jannauoh, I misunderstood you
18:06marcan(which might well be a 1:1 copypaste of m1)
18:07r0ni has joined #asahi-dev
18:07jannauI stopped reading after the "I did" and missed that it was for the notice
18:34mpshm, no much difference between 120 and 60 Hz refresh rate with xorg on my m1pro macbook
18:53jannauusb3 works on m2 but m1n1 doesn't disable the atcphy on its usb port
18:54jannauseems to be faster than m1 but with 5s delay
18:55MajorBiscuit has joined #asahi-dev
19:08MajorBiscuit has quit [Ping timeout: 480 seconds]
19:29svenI’ll have to take a look at macOS and see if it also has that 5s delay
19:29svenbut I don’t think it does
19:30svenit’s probably something dumb again
19:46as400_ has joined #asahi-dev
19:50as400_ has quit [Remote host closed the connection]
19:53blazrasven: I was trying USB3 by plugging my flash disk to the 14" mbp and in one case it broke. However, replug fixed it. Dmesg: https://paste.debian.net/1260812/. Kernel 6.1.0-rc5-asahi-9-1-edge-ARCH from the asahi-dev/linux-asahi-edge package.
19:54bluetail has quit [Quit: The Lounge - https://thelounge.chat]
19:54blazragenerally it works - this was like one in 50 tries...
19:55bluetail has joined #asahi-dev
19:57svenso it just didn’t show up? Or how did it break?
19:58svenoh… pipehandler lock failed :/
19:58blazraYes, the flash disk didn't show up.
19:58svenis there anything earlier in the dmesg? it looms like xhci already didn’t come up
19:59svenit looks like xhci timed out waiting for something
20:01svenand I assume you didn’t suspend the mbp or anything?
20:02blazraearlier there is previous plug that worked fine https://paste.debian.net/1260813/
20:02blazraI didn't suspend the mbp - I was just plugging and unplugging the drive
20:03svencan you paste the full dmesg?
20:04jannausven: https://github.com/jannau/linux/tree/asahi-6.1-rc5-9-m2-atcphy contains a fix for t8103 efuse unit address
20:04svenand can you reproduce it? if yes it would be interesting to see what’s going on while enabling more debug messages
20:05svenjannau: ah, whoops, thanks!
20:05blazraI will paste the full dmesg, but unfortunately I can't reproduce it.
20:05sven“unfortunately” ;)
20:06svenit looks like there might be a race when you unplugged it
20:06svenbecause it claims xhci probe fails just after the unplug
20:07jannauefuse base changed on m2 otherwise it's identical to m1
20:08svenstill surprised the same atcphy code works everywhere so far
20:10blazraI have to apologize for playing with the brightness setting and therefore polluting the log :D
20:12svenno worries, I can use grep ;)
20:12jannaumacos does additional writes on t6001 for DP but it works at least partially without that
20:13blazraI don't know if it's related, but sometimes with the port on the right side I get two of these: "[ 732.609484] phy-apple-atc f03000000.phy: timed out waiting for ACIOPHY_TOP_PHY_STAT_LN0_UNK23"
20:13svenyeah, just saw that
20:13svenmaybe t6k actually needs some additional setup to work properly
20:13svenI never saw that on t8103
20:17sven[ 834.513132] xhci-hcd xhci-hcd.0.auto: USB bus 1 deregistered
20:17sven[ 834.513144] xhci-hcd: probe of xhci-hcd.0.auto failed with error -110
20:17sventhat really looks like some kind of race
20:17svenoh.. wait
20:17svennah, it just prints the error from above again
20:18jannauI don't think there was anything unknown for usb3 in the macos atc trace
20:19sventhere's still that weird ACIOPHY_TOP_BIST_READ_CTRL_LN0_PHY_STATUS_RE behavior I see on t8103
20:20svenguess i'll try hotplugging some usb3 device >50 times tomorrow and see if I can provoke that -110 error
20:21svenstill happy that the pipehandler sequence seems to be stable enough to recover even if that lock fails now
20:52jluthra has quit [Remote host closed the connection]
20:52jluthra has joined #asahi-dev
21:07___nick___ has quit [Ping timeout: 480 seconds]
21:18millenialhacker has joined #asahi-dev
21:28millenialhacker has quit [Ping timeout: 480 seconds]
21:34coutego has joined #asahi-dev
22:09weitcis has joined #asahi-dev
22:13coutego has left #asahi-dev [#asahi-dev]
22:52pthariensflame has joined #asahi-dev
22:52SSJ_GZ has quit [Ping timeout: 480 seconds]
22:56pthariensflame has quit []
23:10pjakobsson has quit [Ping timeout: 480 seconds]
23:11pjakobsson has joined #asahi-dev
23:14millenialhacker has joined #asahi-dev
23:19jannaumarcan: I only see choppiness with certain rendering operations (window resize, log out screen, ...) but no issues with the mouse pointer at 120Hz
23:20jannauwindow resize seems to be render limited. I see very high CPU use due to fast_composite_src_x888_8888() (pixman) when resizing konsole
23:22jannauhttps://github.com/jannau/linux/tree/asahi-6.1-rc5-9-dcp removes the 120Hz mode and fixes the indent warning
23:22millenialhacker has quit [Ping timeout: 480 seconds]
…