2022-10-31
00:07Method has joined #asahi-dev
00:08winter has joined #asahi-dev
00:12Etrien has quit [Read error: No route to host]
00:12Etrien has joined #asahi-dev
00:25thelounge7571340 has joined #asahi-dev
00:26thelounge7571340 has quit [Remote host closed the connection]
00:26r0ni has quit [Quit: Leaving]
00:32nicolas17 has joined #asahi-dev
00:45jannaumarcan: https://github.com/jannau/linux/tree/dcp-backlight-wip and https://github.com/jannau/m1n1/tree/dcp-brightness hacked together backlight control, not for testing
00:48jannaudcp appears to report the brightness in nits, unsure what we have to do to set the brightness in nits
00:51jannaubest guess from the ADT backloight node is that DCP sets a DAC register, a look up table provides current and there are coefficients to calculate nits from current
00:52uur has quit [Ping timeout: 480 seconds]
00:52* jannaucurses apple for not always clearing the shmem. this looked so random in the dumps that I thought it was leftover
01:04uur has joined #asahi-dev
01:13uur has quit [Ping timeout: 480 seconds]
01:15nicolas17 has quit [Remote host closed the connection]
01:17ccs1 has quit [Ping timeout: 480 seconds]
01:21uur has joined #asahi-dev
01:26brentr123 has quit [Quit: Connection closed for inactivity]
01:28thelounge7571340 has joined #asahi-dev
01:28thelounge7571340 has quit [Remote host closed the connection]
01:33ccs1 has joined #asahi-dev
01:58uur has quit [Ping timeout: 480 seconds]
02:24uur has joined #asahi-dev
02:28thelounge7571340 has joined #asahi-dev
02:29thelounge7571340 has quit [Remote host closed the connection]
02:32uur has quit [Ping timeout: 480 seconds]
02:58uur has joined #asahi-dev
03:04tpw_rulesalso is https://github.com/AsahiLinux/linux/tree/gpu/rust-wip supposed to build? i am getting modpost errors. just wanted to make sure my rust infra was up to snuff
03:06uur has quit [Ping timeout: 480 seconds]
03:29thelounge7571340 has joined #asahi-dev
03:29thelounge7571340 has quit [Remote host closed the connection]
04:23uur has joined #asahi-dev
04:31uur has quit [Ping timeout: 480 seconds]
04:38Glanzmann has joined #asahi-dev
04:39uur has joined #asahi-dev
04:40Glanzmanntpw_rules: This works for me: https://pbot.rmdir.de/brmgQa1O2bh4efW_yI7EGA Full build output: https://pbot.rmdir.de/YGiYtZW102oeF-7BhjMCAw Howto setup rust for Linux kernel: https://www.kernel.org/doc/html/next/rust/quick-start.html
04:41thelounge7571340 has joined #asahi-dev
04:41thelounge7571340 has quit [Remote host closed the connection]
04:44Glanzmanntpw_rules: But the asahi gpu driver fails to probe for me on the mini, so I'm not using it.
04:44Glanzmann has quit [Quit: EOF]
04:48uur has quit [Ping timeout: 480 seconds]
04:54nickchan has joined #asahi-dev
05:00Core2718 has joined #asahi-dev
05:01Glanzmann has joined #asahi-dev
05:01Core9066 has quit [Read error: No route to host]
05:01Core9066 has joined #asahi-dev
05:02Glanzmanntpw_rules: The first time I tried, I used gcc. But it is not supported with rust, so I switched to clang which I never used before knowlingly. Anyway the LLVM=-14 tells the kernel build infrastructure to use 'clang-14' as compiler. So with the example I pasted, no I did not use gcc but used clang-14.
05:08Core2718 has quit [Ping timeout: 480 seconds]
05:26nickchan has quit [Quit: nickchan]
05:27uur has joined #asahi-dev
05:28uur has quit []
05:35Etrien__ has joined #asahi-dev
05:38Etrien has quit [Ping timeout: 480 seconds]
05:47thelounge7571340 has joined #asahi-dev
05:48thelounge7571340 has quit [Remote host closed the connection]
05:58l3k has quit [Remote host closed the connection]
06:08nickchan has joined #asahi-dev
06:17Etrien has joined #asahi-dev
06:22Etrien__ has quit [Ping timeout: 480 seconds]
06:28Dementor has quit [Quit: Ping timeout (120 seconds)]
06:39Dementor has joined #asahi-dev
06:44jannautpw_rules: it would be far too dim if it was the same unit and scale. not even sure if chnaging the nvram value did anything. not really worth looking at atm
06:45jannautpw_rules: at some point the gpu couldn't be build as module due to the rust bindings, not sure if that is still the case
06:51thelounge7571340 has joined #asahi-dev
06:51thelounge7571340 has quit [Remote host closed the connection]
06:53SSJ_GZ has joined #asahi-dev
06:55marcantpw_rules: it's conceivable we will add something to u-boot to load xHCI firmware in the future (once PCI xHCI works at all)
06:56marcanbut even without that, there is a general issue because distros will want to put xhci_pci in the initramfs, so that on *other* platforms you can use those controllers at least
06:57marcanso it doesn't matter if we don't expect AS users to use xHCI in the initramfs for installers because it's broken in u-boot right now; it needs the firmware because the module is going to be in there anyway, and if it loads without the firmware then xHCI won't work *at all*
06:57Dementor has quit [Quit: Ping timeout (120 seconds)]
07:04Dementor has joined #asahi-dev
07:24Dementor has quit [Quit: Ping timeout (120 seconds)]
07:27ccs1 has quit [Ping timeout: 480 seconds]
07:34Dementor has joined #asahi-dev
07:53thelounge7571340 has joined #asahi-dev
07:54thelounge7571340 has quit [Remote host closed the connection]
08:02nullroute has quit [Max SendQ exceeded]
08:02nullroute has joined #asahi-dev
08:26nickchan has quit [Quit: nickchan]
08:27nickchan has joined #asahi-dev
08:28nickchan has quit []
08:43Etrien__ has joined #asahi-dev
08:46Etrien has quit [Ping timeout: 480 seconds]
08:54thelounge7571340 has joined #asahi-dev
08:55thelounge7571340 has quit [Remote host closed the connection]
09:03povikccs1: there was ilya who expressed interest some ten days ago and i gave them a walkthrough of the task. though they didn't have an imac but wanted to try to start writing the driver still. i don't expect them to finish it lacking hardware to test on
09:28riker77 has quit [Quit: Quitting IRC - gone for good...]
09:43riker77 has joined #asahi-dev
09:47riker77 has quit []
09:56thelounge7571340 has joined #asahi-dev
09:56thelounge7571340 has quit [Remote host closed the connection]
10:30Etrien__ has quit [Read error: Connection reset by peer]
10:31Etrien has joined #asahi-dev
10:38riker77 has joined #asahi-dev
11:02thelounge7571340 has joined #asahi-dev
11:02thelounge7571340 has quit [Remote host closed the connection]
11:53Core8048 has joined #asahi-dev
11:59Core9066 has quit [Ping timeout: 480 seconds]
12:04thelounge7571340 has joined #asahi-dev
12:04thelounge7571340 has quit [Remote host closed the connection]
12:13amarioguy2 has joined #asahi-dev
12:22mrkajetanp has joined #asahi-dev
12:56Esmil has joined #asahi-dev
12:58amarioguy2 has quit [Ping timeout: 480 seconds]
13:01gabuscus_ has joined #asahi-dev
13:04svenurgh.. so the replayed xnu trace and my atcphy.c do the same pokes but the first one works and the latter one doesn't.
13:04sveni wonder if there's some delay() missing somewhere that I just don't see in the MMIO trace but replaying it with python happens to be slow enough :(
13:04gabuscus has quit [Ping timeout: 480 seconds]
13:10gabuscus_ has quit [Ping timeout: 480 seconds]
13:15thelounge7571340 has joined #asahi-dev
13:15thelounge7571340 has quit [Remote host closed the connection]
13:20gabuscus has joined #asahi-dev
13:34marcandoes macos read anything? maybe it's polling for a bit to flip but when you trace it's slow enough it always is already done?
13:40svenlol, if I run the macos trace before I boot into linux and still run the atcphy.c it still works
13:45rmkmarcan: I guess if Lee doesn't reply, the next thing to try is to see whether moving smc_core.c into drivers/mfd satisfies the issue. If that fails, then try all of drivers/platform/apple/*.[ch] into drivers/mfd maybe drivers/mfd/apple... if that doesn't work for Lee, I'm then at a complete loss - and I suggest at that point we effectively re-implement the mfd part to get around the blockage.
13:47rmkI'm not particularly happy with Lee calling my attempt a "hack" when it seemed to be somewhat closer to the solution he seemed to be asking for.
13:57tanty has quit [Remote host closed the connection]
13:57tanty has joined #asahi-dev
14:01amarioguy2 has joined #asahi-dev
14:07kettenisnot sure I can provide much more context other than that the old code was clearly buggy and that I gave up with switching the FPU registers in a clever way
14:08kettenisgiven the way modern compilers generate code with vector instructions all over the place, I'm not sure if there is any benefit in trying to be clever
14:16kettenisrmk: related to the smc stuff, I'm not sure what conclusion was reached for the dt bindings
14:17kettenisI think I wanted to point out at some point that including the SoC in the compatible names for sub-nodes didn't make a lot of sense since these are firmware interfaces controlling (mostly) off-SoC hardware
14:18Gaspare has joined #asahi-dev
14:20jannaumarcan: backlight-marketing-table seems to 16.16 display brightness values in nits. those might be the steps used by the brightness keys
14:27marcanrmk: if Lee doesn't reply I'd rather just resubmit it as platform and not Cc him, because he clearly doesn't want to work with us and I'm not interested in playing a guessing game with no feedback
14:29marcanhe doesn't know what he wants, and he hasn't bothered to actually read and understand how the driver works
14:29marcanhe probably thinks this should be using regmaps or shared memory or something like most other MFD devices
14:30kevans91_kettenis: thanks (and no worried, re: delay); think I'm going to switch over to debugging the different issue we hit under the hypervisor, then circle back to this later
14:30kevans91_it's actually the first write we do, to q1, where the cpu just apparently hangs (no exception afaict)
14:30marcanso if he doesn't play ball, we try to sneak it in because using MFD is clearly the correct solution, regardless of what the maintainer says; and if he blocks that, then we have no choice but to reinvent the MFD wheel because a Linux subsystem maintainer has decided some people shouldn't use his subsystem
14:33rmkmarcan: honestly, I think we could get away with converting this code to create and remove the platform devices directly without involving mfd without it needing too much effort, and then Lee's mfd stuff is completely out the loop.
14:34marcanright. it's more code, and therefore obviously a bad solution, but it sounds like the maintainer of the subsystem intended for this purpose doesn't actually want his subsystem used for this purpose so...
14:34amarioguy2 has quit [Ping timeout: 480 seconds]
14:35marcan(sorry, I'm in a bad mood dealing with this after the argument last week, bad upstreaming interactions make me cranky)
14:35marcan(I can deal with code reviews and design bikeshedding and whatever, but this kind of silliness gets to me)
14:36thelounge7571340 has joined #asahi-dev
14:36thelounge7571340 has quit [Remote host closed the connection]
14:40rmkyep, I think we can implement this without too much hassle without involving mfd if that's where we get to.
14:46Method is now known as Method_
14:57amarioguy2 has joined #asahi-dev
15:19svenaaand it was something at least silly. clear vs. set in the crossbar for one register that's CLK_N_EN instead of CLK_EN.
15:23zzywysm has quit [Read error: Connection reset by peer]
15:24zzywysm has joined #asahi-dev
15:25svenpretty sure it's missing some important delays somewhere. just adding a mdelay(10) to every single register write seems to help a lot
15:30DarkShadow4444 has quit [Quit: ZNC - https://znc.in]
15:30DarkShadow44 has joined #asahi-dev
15:34Gaspare has quit [Quit: Gaspare]
15:37thelounge7571340 has joined #asahi-dev
15:38thelounge7571340 has quit [Read error: Connection reset by peer]
15:50Core9066 has joined #asahi-dev
15:51Core3870 has joined #asahi-dev
15:52Core4262 has joined #asahi-dev
15:53Core9066 has quit [Read error: No route to host]
15:57Core8048 has quit [Ping timeout: 480 seconds]
16:00Core3870 has quit [Ping timeout: 480 seconds]
16:05qyliss has quit [Quit: bye]
16:09qyliss has joined #asahi-dev
16:12amarioguy2 has quit [Ping timeout: 480 seconds]
16:52thelounge7571340 has joined #asahi-dev
16:52EricCurtin[m] has quit [Write error: connection closed]
16:55thelounge7571340 has quit [Remote host closed the connection]
16:58amarioguy has quit [Ping timeout: 480 seconds]
16:58Gaspare has joined #asahi-dev
17:57Gaspare has quit [Quit: Gaspare]
18:01Gaspare has joined #asahi-dev
18:02amarioguy has joined #asahi-dev
18:11Glanzmann has quit [Quit: EOF]
18:13svenalright, seems to work reliable with delays at the correct positions now. at least for HBR.
18:14nvflash_ has joined #asahi-dev
18:15nvflash_I installed Asahi on my MBP M2 13" a few days ago, but the keyboard does't work with Grub, I see from a twitter post there is a fix. Can I pull the fix to my install?
18:19thelounge7571340 has joined #asahi-dev
18:19thelounge7571340 has quit [Remote host closed the connection]
18:37nvflash_ has quit [Remote host closed the connection]
18:42bluetail7 has joined #asahi-dev
18:44dottedmag has left #asahi-dev [#asahi-dev]
18:47bluetail has quit [Ping timeout: 480 seconds]
18:47bluetail7 is now known as bluetail
19:13nicolas17 has joined #asahi-dev
19:14bluetail has quit [Ping timeout: 480 seconds]
19:20thelounge7571340 has joined #asahi-dev
19:20thelounge7571340 has quit [Remote host closed the connection]
19:46thelounge7571340 has joined #asahi-dev
19:46thelounge7571340 has quit [Remote host closed the connection]
19:49rmkmarcan: please don't reply to Lee! I've invited him to chat with me on irc about it, I suspect he's completely misunderstood the code structure, which would explain a lot of his comments.
20:46jluthra has quit [Remote host closed the connection]
20:46jluthra has joined #asahi-dev
20:55thelounge7571340 has joined #asahi-dev
20:57thelounge7571340 has quit [Remote host closed the connection]
21:34yamii has quit [Quit: WeeChat 3.6]
21:35yamii has joined #asahi-dev
22:01thelounge7571340 has joined #asahi-dev
22:01thelounge7571340 has quit [Remote host closed the connection]
22:21Gaspare has quit [Quit: Gaspare]
22:42Core9066 has joined #asahi-dev
22:49Core4262 has quit [Ping timeout: 480 seconds]
23:02thelounge7571340 has joined #asahi-dev
23:02thelounge7571340 has quit [Remote host closed the connection]
23:20SSJ_GZ has quit [Ping timeout: 480 seconds]
23:50DarkShadow4444 has joined #asahi-dev