2022-11-03
00:02bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:04elvishjerricco has joined #asahi-dev
00:16kettenis has quit [Ping timeout: 480 seconds]
00:33Dcow_ has quit [Remote host closed the connection]
00:33Dcow has joined #asahi-dev
00:44thelounge7571340 has joined #asahi-dev
00:45thelounge7571340 has quit [Remote host closed the connection]
00:49Dcow has quit [Remote host closed the connection]
00:49Dcow has joined #asahi-dev
00:49princesszoey has quit [Quit: The Lounge - https://thelounge.chat]
00:50princesszoey has joined #asahi-dev
00:59Dcow has quit [Ping timeout: 480 seconds]
01:03Dcow has joined #asahi-dev
01:11thelounge7571340 has joined #asahi-dev
01:11thelounge7571340 has quit [Remote host closed the connection]
01:12Dcow has quit [Ping timeout: 480 seconds]
01:36Dcow has joined #asahi-dev
01:44Dcow has quit [Ping timeout: 480 seconds]
01:49kettenis has joined #asahi-dev
01:59marcanrmk: no, I was hoping to get this sorted out before trying to figure out how to do a T2 one (or for someone else to work on that from t2linux)
02:01marcanbut I think we're well past the point where it's worth arguing with lee just for the sake of replacing a for loop calling platform_device_register
02:05marcanand I have no confidence left that we will find a solution that he finds acceptable that doesn't annoy *me* as the author and maintainer of this particular driver
02:08marcanhe clearly has his own ideas about what being an mfd means, and they do not fit this particular combination of hardware platforms
02:09marcanand I'm not going to make a mess of the code (putting the core into header files, what? that's supposed to be for inlining for performance, not because someone doesn't like the code in their tree)
02:09Dcow has joined #asahi-dev
02:10marcanin the end if we end up with everything split up weirdly, that will just mean more reviews and more acks to coordinate and honestly I don't really want to deal with him any more
02:15thelounge7571340 has joined #asahi-dev
02:16thelounge7571340 has quit [Remote host closed the connection]
02:17chadmed has quit [Quit: Konversation terminated!]
02:18Dcow has quit [Ping timeout: 480 seconds]
02:20chadmed has joined #asahi-dev
02:26Dcow has joined #asahi-dev
02:35Dcow has quit [Ping timeout: 480 seconds]
02:44Dcow has joined #asahi-dev
02:53Dcow has quit [Ping timeout: 480 seconds]
03:07Dcow has joined #asahi-dev
03:13thelounge7571340 has joined #asahi-dev
03:13thelounge7571340 has quit [Remote host closed the connection]
03:15Dcow has quit [Ping timeout: 480 seconds]
03:19ccs1 has joined #asahi-dev
03:40Dcow has joined #asahi-dev
03:45ccs1_ has joined #asahi-dev
03:48Dcow has quit [Ping timeout: 480 seconds]
03:51ccs1 has quit [Ping timeout: 480 seconds]
03:51ccs1_ is now known as ccs1
03:54nicolas17 has quit [Quit: Konversation terminated!]
03:59Dcow has joined #asahi-dev
04:07Dcow has quit [Ping timeout: 480 seconds]
04:15Dcow has joined #asahi-dev
04:15thelounge7571340 has joined #asahi-dev
04:15thelounge7571340 has quit [Remote host closed the connection]
04:23Dcow has quit [Ping timeout: 480 seconds]
04:32Dcow has joined #asahi-dev
04:40Dcow has quit [Ping timeout: 480 seconds]
04:49SSJ_GZ has joined #asahi-dev
04:50Dcow has joined #asahi-dev
04:52ccs1 has quit [Ping timeout: 480 seconds]
04:58Dcow has quit [Ping timeout: 480 seconds]
05:04snowcra5h has joined #asahi-dev
05:09Amulet has joined #asahi-dev
05:17thelounge7571340 has joined #asahi-dev
05:18thelounge7571340 has quit [Remote host closed the connection]
05:21SSJ_GZ has quit [Ping timeout: 480 seconds]
05:25Dcow has joined #asahi-dev
05:28ajv009 has joined #asahi-dev
05:33Dcow has quit [Ping timeout: 480 seconds]
05:58Dcow has joined #asahi-dev
06:06Dcow has quit [Ping timeout: 480 seconds]
06:22thelounge7571340 has joined #asahi-dev
06:22thelounge7571340 has quit [Remote host closed the connection]
06:30Dcow has joined #asahi-dev
06:39Dcow has quit [Ping timeout: 480 seconds]
06:48Dcow has joined #asahi-dev
06:49ccs1 has joined #asahi-dev
06:57Dcow has quit [Ping timeout: 480 seconds]
07:22thelounge7571340 has joined #asahi-dev
07:23thelounge7571340 has quit [Remote host closed the connection]
07:23Dcow has joined #asahi-dev
07:27kujeger has quit [Quit: ZNC 1.8.2 - https://znc.in]
07:31Dcow has quit [Ping timeout: 480 seconds]
07:33snowcra5h has quit [Quit: B1tch eX]
07:39kettenis has quit [Remote host closed the connection]
07:43kettenis has joined #asahi-dev
07:43mps has quit [Ping timeout: 480 seconds]
07:49ccs1 has quit [Ping timeout: 480 seconds]
07:56Dcow has joined #asahi-dev
08:05Dcow has quit [Ping timeout: 480 seconds]
08:16SSJ_GZ has joined #asahi-dev
08:25thelounge7571340 has joined #asahi-dev
08:25thelounge7571340 has quit [Remote host closed the connection]
08:28Dcow has joined #asahi-dev
08:37Dcow has quit [Ping timeout: 480 seconds]
08:46Dcow has joined #asahi-dev
08:47kujeger has joined #asahi-dev
08:51mps has joined #asahi-dev
08:54Dcow has quit [Ping timeout: 480 seconds]
09:04Dcow has joined #asahi-dev
09:08bluetail3 has joined #asahi-dev
09:09bluetail3 has quit []
09:09bluetail has quit [Ping timeout: 480 seconds]
09:09bluetail3 has joined #asahi-dev
09:10bluetail3 is now known as bluetail
09:10bluetail has quit []
09:10bluetail3 has joined #asahi-dev
09:10bluetail3 is now known as bluetail
09:12Dcow has quit [Ping timeout: 480 seconds]
09:25Dcow has joined #asahi-dev
09:26thelounge7571340 has joined #asahi-dev
09:27psykose has quit [Ping timeout: 480 seconds]
09:28psykose has joined #asahi-dev
09:29thelounge7571340 has quit [Remote host closed the connection]
09:33Dcow has quit [Ping timeout: 480 seconds]
09:44Dcow has joined #asahi-dev
09:52Dcow has quit [Ping timeout: 480 seconds]
09:54Dcow has joined #asahi-dev
10:11bisko has joined #asahi-dev
10:19bisko has quit [Ping timeout: 480 seconds]
10:21bisko has joined #asahi-dev
10:28MajorBiscuit has joined #asahi-dev
10:40thelounge7571340 has joined #asahi-dev
10:40thelounge7571340 has quit [Remote host closed the connection]
10:45yuyichao_ has joined #asahi-dev
10:49yuyichao has quit [Ping timeout: 480 seconds]
11:21svenokay, oob hpd forwarding to drm works when I represent the connection using the of graph bindings
11:22svenhotplug works exactly once, probably because I don’t know how to shut the previous connection down yet :D
11:30ajv009 has quit [Ping timeout: 480 seconds]
11:47thelounge7571340 has joined #asahi-dev
11:47thelounge7571340 has quit [Remote host closed the connection]
12:21bisko has quit [Remote host closed the connection]
12:22bisko has joined #asahi-dev
12:24r0ni has joined #asahi-dev
12:30espo has quit [Remote host closed the connection]
12:32bisko has quit [Remote host closed the connection]
12:32bisko has joined #asahi-dev
12:32chadmedlooks like Viresh doesn't want opp_parse_supplies() to return anything valid without a microvolt property since that breaks some consumers of the regulator struct
12:34chadmedwhy it was added to all of that is a mystery to me since it was added specifically for platforms that do not express their regulators in the DT...
12:50thelounge7571340 has joined #asahi-dev
12:50thelounge7571340 has quit [Read error: Connection reset by peer]
12:56marcanchadmed: "I have included your patch in my series now, cc'd you." did he change his mind?
12:57sveneverything else i've seen usually is just "design decisions taken years/decades ago that aren't valid anymore and haven't been cleaned up yet"
12:58marcansven: there's quite a bit of "this one thing was done in a dumb way recently without thinking about it, and needs to be redone"
12:59svenyeah, writing something for x and then realizing it doesn't work for y happens all the time
12:59chadmedmarcan: no, that patch series does not change the behaviour of that code path at all. it just shuffles stuff around
13:01chadmedyeah he needs to delete the stuff in the commit message about it fixing AS, see my reply to 5/5
13:08marcanin other news, I just had an IRC chat with Lee, looks like we resolved the MFD issue (cc rmk)
13:08marcanrmk: do you want to work this out or should I take over and let you rest a bit from this one? :)
13:09marcanif you have a most recent tree with review comments, I can take care of merging it with whatever and resubmitting
13:09marcan(I think you've done enough to help with this one, but I won't stop you if you want to see it through the end ;))
13:11rmkI think we're almost there with gpio-macsmc + dt binding (I need to drop the t8103 specific compatible there)
13:11rmkI haven't sent another version of that because I was hoping to get a way forward for the macsmc bits
13:13rmkand yes, I do think that pushing that stuff into a header file really isn't a good idea (I think I said as much in my email with the patch)
13:14rmkpersonally, I think your code structure is correct and clean, and I don't entirely understand where Lee is coming from, so I think that switching it to a platform device is the best way forward at this point.
13:16ashi has joined #asahi-dev
13:16rmkI would encourage the Intel backend to be written though - which I think would've helped the case to show why the code is structured this way.
13:17ccs1 has joined #asahi-dev
13:19rmkplease bear in mind that we've had code in the past that people have been pushy to get merged, but the result has been rather incomplete because the bits that make use of that code never end up being merged.
13:22rmk(I've got quite a few patches like that which introduce various helpers for phylink - network stuff - but I'm refraining from pushing them without the corresponding users, which can be a pain when the helper gets used in a diverse range of places in networking code
14:01rmkok, let me do that move and resubmit... I think we'll have to move the smc.h into linux/mfd/macsmc.h
14:02svenhah, so inserting/removing the HDMI side of the type-c->hdmi adapter works. for some reason inserting/removing the type-c side breaks something though and dcpext ends up complaining about "device busy timeout"
14:02marcansmc_rtkit I think can stay named like that in platform/apple, though macsmc_rtkit would work too if you think it's better
14:03thelounge7571340 has joined #asahi-dev
14:03thelounge7571340 has quit [Remote host closed the connection]
14:03rmkif we're going to call the mfd part macsmc, I think renaming to macsmc_rtkit is probably sensible to make it clear that it's apple mac stuff
14:03marcanyeah, I think its location in the tree implies that but the module wouldn't, so that's fair
14:04marcan(I was hoping for someone to have some opinion on this; the original naming was inconsistent and I wasn't sure what to do about it, so thank you :p)
14:06marcanfor the legacy backend I *could* pull out a positively ancient and slow as molasses Mac Mini I have lying around, or borrow a friend's old MBP. but it's entirely possible none of the current subdevice drivers will actually be useful on those platforms as-is (the big one that should work for all 3 is hwmon, not written yet, and maybe some hid/input stuff could be shared too?)
14:06bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
14:06marcanthe T2 Macs with the ACPI backend are the bridge between both worlds, I think they can use more of the M1 subdevice work
14:07marcanbut the only T2 I have semi-access to is a friend's main machine, so I can only borrow it for this stuff sporadically (and in particular right now probably not until next year)
14:14bisko has joined #asahi-dev
14:15svenlol, if i just remove the dcp disconnect handling dcp gets very confused when I remove/insert the type-c plug and just connect again, tries to set the link rate 2-3 times but finally works again :D
14:15ashi has quit [Quit: Leaving]
14:18jannauthere is a smc hwmon driver: https://github.com/jfbortolotti/linux/commit/f0c16a1402eab04b59283c2fb1b2ace3ca5c3500
14:22bisko has quit [Ping timeout: 480 seconds]
14:23_jannau_sven: quite possible that we have forward hpd explicitly to dcpext. is there anything interesting in a macos trace for an unplug?
14:45marcanjannau: in particular fan control is what I meant for the older machines, I don't see that there (and also all those keys need to be in the DT for DT platforms, or we need to just autodiscover somehow and shrug for non-DT platforms)
14:50chadmedthere was actually one issue with viresh's patch, but now with that fixed cpufreq tries to add multiple opp tables per cpu which causes the new parsing stuff to error out since an opp table already exists
14:50ChaosPrincessIs the smc interface same on t2 and pre-t2 macs?
14:57bisko has joined #asahi-dev
14:57lkron has joined #asahi-dev
15:04Dcow has quit [Remote host closed the connection]
15:05Dcow has joined #asahi-dev
15:05thelounge7571340 has joined #asahi-dev
15:05thelounge7571340 has quit [Remote host closed the connection]
15:06Dcow has quit [Remote host closed the connection]
15:06Dcow has joined #asahi-dev
15:06cylm has joined #asahi-dev
15:08bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:21cylm_ has joined #asahi-dev
15:23cylm has quit [Ping timeout: 480 seconds]
15:24ajv009 has joined #asahi-dev
15:55ccs1 has quit [Ping timeout: 480 seconds]
16:02bisko has joined #asahi-dev
16:04MajorBiscuit has quit [Ping timeout: 480 seconds]
16:10thelounge7571340 has joined #asahi-dev
16:10bluetail2 has joined #asahi-dev
16:11thelounge7571340 has quit [Remote host closed the connection]
16:16bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:16bisko has joined #asahi-dev
16:18bluetail has quit [Ping timeout: 480 seconds]
16:18bluetail2 is now known as bluetail
16:19ccs1 has joined #asahi-dev
16:22zzywysmchadmed: i wonder if the issue in the viresh patches was that the tester didn't update their dtbs properly after applying it?
16:22amarioguy2 has joined #asahi-dev
16:24nicolas17 has joined #asahi-dev
16:26rmkmarcan: I'm wondering what to do about the other MFD cells, the ones we currently don't have a compatible against yet... we'll need to fix those up eventually, so should we drop those and add them when merging the driver(s)... ?
16:29rmkif I make up compatibles for them now, I can see complaints about missing binding documentation being the next hold-up.
17:11thelounge7571340 has joined #asahi-dev
17:13thelounge7571340 has quit [Remote host closed the connection]
17:38bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:38bisko has joined #asahi-dev
17:40svenapple-dcp 271c00000.dcp: RTKit: syslog message: DPTXController.cpp:2788: AppleDCPDPTXController::handleInterrupt(): FIFO error interrupt COMMON_INT_STA_3=0x00000010
17:52bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:52amarioguy2 has quit [Ping timeout: 480 seconds]
18:00lamlam has joined #asahi-dev
18:08ajv009 has quit [Ping timeout: 480 seconds]
18:13lamlami know the following explanation is subpar but i'm just excited to share bear with me (3am here haha) https://bashify.io/images/C4Cn1D
18:13lamlamstarting from the first block (b1XXXXX): anecpu bootstraps by writing 10001bfc into L2C_ERR_STS, then L2C_ERR_ADR (26b10008, same mmio range), and then some other HID impls. the 4 regs starting with ce across 16 & 17 are 24hz clocks. the 2nd block (b4XXXXX) is the actual asc base i believe. controller is @ +44 & idle/wfi status @ +48, which is a similar layout to https://github.com/AsahiLinux/docs/wiki/HW:ASC, but none of the vals are.
18:13lamlaminit call is a single write32 of 0x10 to the controller after all the dart/vmem mapping/power data stuff. this wfi status is where i was stuck at.
18:13lamlamgpio regs are 4c-64 in the 3rd block (b84XXXX). init/deinit communication uses these. init protocol is done by zeroing out these regs (+ some tunables), to which the anecpu should write back a "magic" number of 0x8042006 in the last gpio.
18:14lamlamisp uses a similar protocol (https://github.com/patjak/facetimehd/blob/master/fthd_isp.c); the two are very similar in design actually.
18:14lamlammagic number means the fw successfully allocated ipc channels: 1st reg (7) is the # of chans, and 2nd (f340) is the size, 4th is heap size etc. now i can make it work for me :P
18:14lamlami have been consistently hitting the magic number since, but currently i'm relying on ~400 unknown numbers to fill the dpe regs (dynamic power estimation, the last reg actually). i can account for other parts though.
18:18lethalnyan has joined #asahi-dev
18:18lethalbit has quit [Read error: Connection reset by peer]
18:22thelounge7571340 has joined #asahi-dev
18:22thelounge7571340 has quit [Remote host closed the connection]
18:25ccs1 has quit [Ping timeout: 480 seconds]
18:41lamlam has quit [Quit: Page closed]
18:43ajv009 has joined #asahi-dev
18:59___nick___ has joined #asahi-dev
18:59___nick___ has quit []
18:59cylm has joined #asahi-dev
19:01___nick___ has joined #asahi-dev
19:04cylm_ has quit [Ping timeout: 480 seconds]
19:05rmkthat's my patch queue for this - obviously, the two mailbox patches have already been accepted via the mailbox tree
19:28amarioguy2 has joined #asahi-dev
19:28amarioguy2 has quit [Remote host closed the connection]
19:32bisko has joined #asahi-dev
19:33thelounge7571340 has joined #asahi-dev
19:33thelounge7571340 has quit [Remote host closed the connection]
19:40bisko has quit [Ping timeout: 480 seconds]
19:53millenialhacker has joined #asahi-dev
19:58espo has joined #asahi-dev
20:04millenialhackerlamlam, ISP also uses 0x8042006 as init ACK, I actually use that value in ISP tracer to start dumping channel structs
20:09millenialhacker_ has joined #asahi-dev
20:16millenialhacker_ has quit [Remote host closed the connection]
20:16millenialhacker_ has joined #asahi-dev
20:18millenialhacker_ has quit [Remote host closed the connection]
20:19millenialhacker_ has joined #asahi-dev
20:25millenialhacker_ has quit [Remote host closed the connection]
20:26kettenis_ has joined #asahi-dev
20:27bisko has joined #asahi-dev
20:28kettenis has quit [Ping timeout: 480 seconds]
20:33millenialhacker has quit [Remote host closed the connection]
20:34thelounge7571340 has joined #asahi-dev
20:35thelounge7571340 has quit [Remote host closed the connection]
20:35bisko has quit [Ping timeout: 480 seconds]
20:47jluthra has quit [Remote host closed the connection]
20:48jluthra has joined #asahi-dev
20:54snowcra5h has joined #asahi-dev
21:06millenialhacker has joined #asahi-dev
21:07___nick___ has quit [Ping timeout: 480 seconds]
21:14millenialhacker has quit [Ping timeout: 480 seconds]
21:33nicolas17 has quit [Quit: Konversation terminated!]
21:35ajv009 has quit [Remote host closed the connection]
21:38thelounge7571340 has joined #asahi-dev
21:39thelounge7571340 has quit [Remote host closed the connection]
21:50millenialhacker has joined #asahi-dev
22:01millenialhacker has quit [Ping timeout: 480 seconds]
22:46thelounge7571340 has joined #asahi-dev
22:47thelounge7571340 has quit [Remote host closed the connection]
22:47SSJ_GZ has quit [Ping timeout: 480 seconds]
22:56rqou_ has quit [Remote host closed the connection]
22:56saithomas has joined #asahi-dev
23:17os has quit [Ping timeout: 480 seconds]
23:21saithomas has quit [Remote host closed the connection]
23:49nicolas17 has joined #asahi-dev
23:50thelounge7571340 has joined #asahi-dev
23:50thelounge7571340 has quit [Remote host closed the connection]