#
✕ nick:j`ey
#asahi-dev · 2022-02-19 15:22
j`eyjeffmiw: "bad cell count" errors are currently expected. MBA here too
#asahi-dev · 2022-02-19 15:14
j`ey(for rtc I mean, and dcp)
#asahi-dev · 2022-02-19 15:14
j`eyjeffmiw: but upgrading is needed anyway soo
#asahi-dev · 2022-02-19 15:14
j`eyjeffmiw: shutdown worked for me in the end, also 11.x. make sure you had all the SPMI/MFD/NVMEM options
#asahi-dev · 2022-02-19 11:38
j`eydid poweroff also rely on 12.x firmware, or just rtc?
#asahi-dev · 2022-02-19 11:15
j`ey>_<
#asahi-dev · 2022-02-19 10:32
j`eyI thought a decent amount of arm machines didnt
#asahi-dev · 2022-02-19 10:32
j`eyhow can that not be breaking more things.
#asahi-dev · 2022-02-19 10:24
j`eyat least you found it quickly
#asahi-dev · 2022-02-19 10:14
j`eysounds too EXTREME for regular use
#asahi-dev · 2022-02-19 10:14
j`eyoh, I do too lol
#asahi-dev · 2022-02-19 10:14
j`eyyou have CONFIG_SPARSEMEM_EXTREME?
#asahi-dev · 2022-02-19 10:02
j`eythanks to git push -f, it never happened!
#asahi-dev · 2022-02-19 10:00
j`eykfree(buf); should be p_off
#asahi-dev · 2022-02-19 10:00
j`eymarcan: copy paste fail again in smc :P
#asahi-dev · 2022-02-19 09:27
j`ey#defines seems to be the usual way, but maybe this subsystem does it like that? *shrug*
#asahi-dev · 2022-02-19 09:26
j`eyyou just use them as ints in ac_power_mode_map[]
#asahi-dev · 2022-02-19 09:26
j`eymarcan: not sure for the reason of having an 'enum pm_setting'
#asahi-dev · 2022-02-19 09:21
j`eyseems to be spaces, not tabs
#asahi-dev · 2022-02-19 09:20
j`eybad indentation
#asahi-dev · 2022-02-19 09:20
j`eymarcan: https://github.com/AsahiLinux/linux/commit/9acbb166b4985ddc54786a1ecd2923abda05f177#diff-c97feab6d65c3eb9cf18d7cd08e205d8ff6022dff5fd02e570a55d0b05b7c950R89
#asahi-dev · 2022-02-19 09:17
j`eyI mean, if youre about to reboot or powroff anyway...
#asahi-dev · 2022-02-19 09:16
j`eymarcan: I suppose that means that nvmem_cell_get_u8 is leaking too, in macsmc-reboot
#asahi-dev · 2022-02-19 09:11
j`eyalso theres a double newline before macsmc_rtc_probe if youre editing that file
#asahi-dev · 2022-02-19 09:08
j`eynvmem_cell_read() states buffer should be freed by the consumer with a kfree().
#asahi-dev · 2022-02-19 09:08
j`eymarcan: I think macsmc_rtc_get_time is leaking p_off
#asahi-dev · 2022-02-19 08:53
j`eymarcan: see 147ab5376f18045da9f22a8262185707745bbf77
#asahi-dev · 2022-02-19 08:52
j`eymarcan: 13bff188e3817dbede4fbb458d3e48847058a42e is not needed anymore, fixed in next
#asahi-dev · 2022-02-19 08:49
j`eylooking
#asahi-dev · 2022-02-19 08:39
j`eyGlanzmann: he was trying to cover a range of models :)
#asahi-dev · 2022-02-19 08:38
j`eymarcan: btw are either of your m1 max/pro the lower core models?
#asahi-dev · 2022-02-19 08:37
j`eymarcan: theres also https://git.kernel.dk/cgit/linux-block/commit/?h=m1-test&id=6b70875739979358439ec81f8736cba9e24b0575 for nvme, I think sven has informally acked that
#asahi-dev · 2022-02-19 08:33
j`eythat sounds reasonable
#asahi-dev · 2022-02-19 08:27
j`eypovik: next-20220217
#asahi-dev · 2022-02-19 08:27
j`eythe 'defer nvme flush' commit has the interval defaulting to 1s, there was talk of that actually defaulting to 0s (aka always flush)
#asahi-dev · 2022-02-19 07:45
j`eyalyssa: desole mais tu viens de parler en francais aussi!
#asahi-dev · 2022-02-18 23:58
j`eyjeffmiw: de rien
#asahi-dev · 2022-02-18 23:45
j`eyjeffmiw: markan was only testing on t6000, I guess he'll merge t8301 in the next few days
#asahi-dev · 2022-02-18 23:45
j`eyjeffmiw: https://github.com/jannau/linux/tree/spmi/work
#asahi-dev · 2022-02-17 17:14
j`ey:-)
#asahi-dev · 2022-02-17 14:49
j`eymarcan: lul nice
#asahi-dev · 2022-02-16 19:38
j`eyespecially a non-invasive one
#asahi-dev · 2022-02-16 13:13
j`eyaxboe: just the messenger, sven wrote that while you were away
#asahi-dev · 2022-02-16 13:12
j`eyaxboe: < sven> jannau: / axboe: so... uh.. can you guys try to set the nvme irq to IRQ_TYPE_EDGE_RISING and see if you can still reproduce the timeouts?
#asahi-dev · 2022-02-15 21:46
j`eythe code after /* last chance to complete any requests before nvme_cancel_request */ wont be useful if its removed
#asahi-dev · 2022-02-15 21:44
j`eyaxboe: 'force' in apple_nvme_handle_cq is unused now
#asahi-dev · 2022-02-15 19:12
j`eyjannau: for the atomic thing did you actually get the sleep-during-atomic BUG, or just from manual inspection?
#asahi-dev · 2022-02-15 19:11
j`eyand smc is mostly about the bindings
#asahi-dev · 2022-02-15 18:59
j`eyhaha ok :D
#asahi-dev · 2022-02-15 18:55
j`ey.. did I just realise that the first 'h' stands for Herr?

plus ›