#
…

2022-02-19

00:30boardwalk has quit [Quit: The Lounge - https://thelounge.chat]
00:32alyssaj`ey: on parle seulement l'anglais, merci beaucoup :-p
01:06yuyichao_ has quit [Ping timeout: 480 seconds]
02:00DragoonAethis has quit [Quit: hej-hej!]
02:00DragoonAethis has joined #asahi-dev
02:20Emantor has quit [Quit: ZNC - http://znc.in]
02:20Emantor has joined #asahi-dev
03:16yuyichao has joined #asahi-dev
03:26PhilippvK has joined #asahi-dev
03:29phiologe has quit [Ping timeout: 480 seconds]
03:48kov has quit [Quit: Coyote finally caught me]
03:51kov has joined #asahi-dev
04:12axboe_ has quit [Quit: leaving]
06:17Glanzmannpovik: mini and air target are online.
06:43sirn- has joined #asahi-dev
06:49sirn has quit [Ping timeout: 480 seconds]
06:49sirn has joined #asahi-dev
06:56sirn- has quit [Ping timeout: 480 seconds]
07:08rkjnsnmarcan, yeah, 300-600 IOPS isn't great, but it's a lot better than 46 for cases where one wants to ensure internal consistency but doesn't care about losing a second or two of writes. It's almost certainly the mode I'll end up using for fsync if we provide it as an option.
07:27willemml has joined #asahi-dev
07:40marcanrkjnsn: that's partially a filesystem thing; according to axboe linux doesn't really do barriers these days
07:41rkjnsnRight. I mean if there was an option to translate fsyncs into drive barriers instead of full flushes.
07:41marcanI don't think drive barriers are a thing
07:41marcanthe barrier flush thing in macos is probably just something it constructs on top of the cow/journal of the filesystems
07:42marcanand it's still slow because it still has to flush once in a while, but can probably enforce barrier semantics across multiple writes through the metadata without flushing every time
07:42Glanzmannmarcan: I don't know if that is relevant, but if you repeat the random test with the files in place I get 70k IOPS: https://pbot.rmdir.de/NAZqGckf6JqZoyrwOvlMnQ
07:43marcanno --fsync?
07:45marcannot sure what test sven was doing but I'm pretty sure you aren't flushing each write that way if you're getting that performance
07:45j`eyalyssa: desole mais tu viens de parler en francais aussi!
07:46rkjnsnWithout some way to pass the barrier on to the ANS, how would it enforce ordering to persistent storage without requiring individual flushes?
07:46Glanzmannmarcan: This was with axboes patch, I just wanted to show the file system overhead.
07:46marcanoh, well then yeah
07:52rkjnsnMaybe it's worth seeing if there's a similar speedup for F_BARRIERFSYNC vs F_BARRIERFSYNC on an HFS+ partition, which presumably can't be doing any CoW shenanigans try to enforce ordering with fewer flushes.
08:22marcanalright, so things for the next asahi
08:23marcanam I forgetting anything other than what was already in spmi/work and jannau's spi fixes?
08:23marcansven: nvme stuff? I think RTKit is already in order in the spmi branch, right?
08:23Glanzmannmarcan: Two patches from axboe:
08:24marcanpovik: any new audio updates?
08:25marcanah right, that bug
08:25GlanzmannYep, without the first patch with cpufreq 'nvme' hangs. Second one for performance.
08:25jannaurtkit should be covered by spmi/work and works for nvme, smc, and dcp
08:26povikyes, some fixes at the very least
08:26povikmarcan: you doing this right now?
08:27povikwhat's the base? latest next?
08:27j`eythe 'defer nvme flush' commit has the interval defaulting to 1s, there was talk of that actually defaulting to 0s (aka always flush)
08:27jannaunot sure if you count the two top commints in https://github.com/jannau/linux/commits/bits/010-devicetree under the spi fixes
08:27j`eypovik: next-20220217
08:27willemml has quit [Quit: willemml]
08:28marcanpovik: I pushed asahi-soc/next, that
08:28marcan(which is what j`ey said)
08:28marcanjannau: ah, thanks, missed thsoe
08:29rkjnsnAs a random person on the internet, I would feel better defaulting to always flushing.
08:29mpsrkjnsn: +1
08:30povikthen one or two audio fixes will be there already :-)
08:30poviklet me prepare a 'for-marcan' then
08:30rkjnsn(I also think abxoe mentioned that flushing by default would be needed for it to be accepted upstream.)
08:31Glanzmannrkjnsn: Yes, he did.
08:31mps(I prefer consistency and correctness over performance)
08:32marcanI think I'm going to make the default deferring flushes *this time* just so people test that codepath
08:33marcanif you're concerned about consistency/safety you probably shouldn't be running this kernel anyway for a myriad of other reasons :-)
08:33marcanbut it will not be the default down the road, at least not on desktops
08:33j`eythat sounds reasonable
08:33Glanzmannmarcan: \o/
08:33mpsmarcan: yes, for current status it is not important
08:35marcandone with the merges so far, fixing build issues due to conflicts now
08:35marcanI think that's just povik's changes left :)
08:36povikit will take me half an hour let's say
08:36povikthere are changes that i want to keep out and i need to test the result
08:38marcanah, just a fixup, sure
08:38GlanzmannYes, he did. Small performance improvement.
08:38j`eymarcan: btw are either of your m1 max/pro the lower core models?
08:39Glanzmannj`ey: You should no him better than that.
08:39marcanj`ey: noipe
08:39marcanand yeah, I need to fix m1n1 for that
08:39j`eyGlanzmann: he was trying to cover a range of models :)
08:40marcanI can simulate it with the HV though, easily
08:40marcanjust nuke nodes there
08:40marcanwe already do it for !SMP mode anyway
08:42marcanfor now I pushed updated bits/*, in case anyone wants to take a look
08:49* j`eylooking
08:50mpswhich branch? asahi-soc/next?
08:51* mpsgoes to prepare tea and after that build and test
08:51jannaumps: just the bits branches for now
08:51jannaustill waiting for audio fixes
08:51jannauasahi-soc/next is just the base
08:52mpsjannau: aha, I see. thanks
08:52mpssorry j`ey ^
08:52Glanzmannjannau: Are your dtsi and spi patched for the device tree for u-boot in?
08:52j`eymarcan: 13bff188e3817dbede4fbb458d3e48847058a42e is not needed anymore, fixed in next
08:53j`eymarcan: see 147ab5376f18045da9f22a8262185707745bbf77
08:53marcanah, thought so but I didn't check :)
08:54marcandropped it
08:57marcanthey are already squashed if they're fixups
08:57jannauGlanzmann: the changes are squashed in the main commits
09:05jannaumarcan: https://lore.kernel.org/all/e6b80669-20f3-06e7-9ed5-8951a9c6db6f@kernel.dk/ is not yet in next and prevents un-ackable irqs on macbook pro 14/16 where tps6598x fails to probe for all ports except magsafe
09:06jannaulooks good otherwise
09:07marcanthanks, I'll throw it in misc
09:08j`eymarcan: I think macsmc_rtc_get_time is leaking p_off
09:08j`eynvmem_cell_read() states buffer should be freed by the consumer with a kfree().
09:09Glanzmannjannau: I see, thanks. I did not know.
09:10marcanj`ey: indeed, good catch
09:10* marcanis not a fan of APIs that return newly allocated buffers...
09:11j`eyalso theres a double newline before macsmc_rtc_probe if youre editing that file
09:12marcanthanks :)
09:15marcanfwiw, the asahi diffstat:
09:15marcan 165 files changed, 18045 insertions(+), 559 deletions(-)
09:16j`eymarcan: I suppose that means that nvmem_cell_get_u8 is leaking too, in macsmc-reboot
09:17psykose has quit [Remote host closed the connection]
09:17j`eyI mean, if youre about to reboot or powroff anyway...
09:18psykose has joined #asahi-dev
09:19jannau18k insertions is less than I would have guessed
09:19marcanwell, it'll leak every time you read that sysfs file :)
09:20j`eybad indentation
09:21j`eyseems to be spaces, not tabs
09:21marcanyeah, copypaste fail
09:26j`eymarcan: not sure for the reason of having an 'enum pm_setting'
09:26j`eyyou just use them as ints in ac_power_mode_map[]
09:26marcanno real reason, it could be #defines
09:27j`ey#defines seems to be the usual way, but maybe this subsystem does it like that? *shrug*
09:27marcanno idea tbh, I usually favor enums for this kind of thing but I haven't checked
09:41marcanthat supersedes bits/070-audio, right?
09:42marcanexcept the dt bits
09:42povikyes, also the dt bits
09:50marcansound/soc/apple/mca.c: In function ‘apple_mca_probe’:
09:50marcansound/soc/apple/mca.c:917:45: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long int’ [-Wformat=]
09:50marcansound/soc/apple/mca.c:951:47: warning: too many arguments for format [-Wformat-extra-args]
09:50marcansound/soc/apple/mca.c:951:47: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘struct device_node *’ [-Wformat=]
09:50marcanthat looks mildly broken :)
09:58marcanalso heh, panics early on t6000... I need to look at this
09:58marcan(not the audio)
10:00j`eymarcan: copy paste fail again in smc :P
10:00j`eykfree(buf); should be p_off
10:01marcanalready fixed :p
10:02j`eythanks to git push -f, it never happened!
10:03povikclang didn't seem to kick me for those
10:12marcanedecc06b4d34e9
10:12marcanrebuilding, but I'm pretty sure that's broken
10:14j`eyyou have CONFIG_SPARSEMEM_EXTREME?
10:14j`eyoh, I do too lol
10:14j`eysounds too EXTREME for regular use
10:15marcanI love people fixing compiler warnings without reading the code
10:17marcanyeah, reverting that (and the subsequent fixup) fixed it)
10:24j`eyat least you found it quickly
10:27marcanangry email sent :p
10:32j`eyhow can that not be breaking more things.
10:32marcanj`ey: very few machines don't have memory at 0
10:32marcanpushed asahi, barely smoke tested, have fun :-)
10:32j`eyI thought a decent amount of arm machines didnt
10:32marcant8103 does boot and doesn't; I think it needs to be significantly above 0 :)
10:33* marcanoff to shower and, er, lunch?
11:08svenmarcan: yeah, rtkit in there + axboe's patches are all fine
11:09sventhe flush thing is a bigger hack than it needs to be but it's good enough for now
11:09sven(and axboe wanted to clean that up anyway)
11:09mpspovik: I booted latest asahi, audio card is not detected on MBP
11:10mpsand I don't see any new option related to audio .config
11:10mpsmaybe DTS is changed
11:11marcanCONFIG_SND_SOC_APPLE_SILICON
11:12mpsmarcan: already had it set
11:14mpsGlanzmann: I didn't noticed this when compiling
11:14marcanare you missing ARCH_APPLE?
11:14mpsmarcan: :-)
11:15Glanzmannmarcan: Yes, I did. Forgot that my build box is now an amd64 ...
11:15GlanzmannYou found it faster than I, because that was the last thing that I checked.
11:15mpsmarcan: ah, you asked Glanzmann and not me, sorry
11:15marcanthe message literally told you...
11:16Glanzmannmarcan: Yes, it did, but I started testing kernel options from the bottom up, now top down.
11:17marcanbut that sounds like SND_SOC_APPLE_MCA needs a dep on ARCH_APPLE too to prevent that broken dep chain
11:17marcanGlanzmann: it's the only thing in the message that doesn't have a [y] next to it and isn't COMPILE_TEST
11:17marcanit was the only option
11:17mpsI have few aarch64 machines (some are powerfull) and I always build on them everything for aarch64
11:20Glanzmannmarcan: I see.
11:20marcanno, didn't realize that patch fixed a broken build
11:20marcanjust turn off that driver
11:21Glanzmannmps: Debian bootstrap.sh needs 8 minutes on the air, 4 on the ryzen ...
11:22povikshouldn't have touched the kconfigs
11:22poviklet's see what i did there
11:23Glanzmannpovik: I think it is unrelaed, maybe I had it just on in my usually broken config without any reason whatsoever.
11:35kettenismarcan: I just created an "asahi" u-boot branch with all the diffs that we still need on top of u-boot master
11:36kettenisbut maybe it makes sense to have that under github.com/AsahiLinux?
11:38j`eydid poweroff also rely on 12.x firmware, or just rtc?
11:39kettenisjust rtc I think
12:02poviksince the asahi branch now has NCO patches verbatim as they are on the list
12:02povikyou can try playback with couple of different samplerates, then post a tested-by here: https://lore.kernel.org/linux-clk/20220208183411.61090-1-povik+lin@cutebit.org
13:35___nick___ has joined #asahi-dev
13:37___nick___ has quit []
13:39___nick___ has joined #asahi-dev
13:40___nick___ has quit []
13:42___nick___ has joined #asahi-dev
14:35joerg has joined #asahi-dev
14:35joerg is now known as Guest293
14:36Guest293 has quit []
14:41joerg1 has joined #asahi-dev
14:43joerg1 has quit []
14:56povikno, that's for the cs42l83 codec on t8103 macs
14:57ah-[m]ah, t6000 is cs42l84
14:58povikbut the other day Dcow[m] suggested cs42l92 as possibly similar to cs42l83: https://statics.cirrus.com/pubs/proDatasheet/CS42L92_F2.pdf
14:58povikand the l92 even has a linux driver!
15:00poviker, similar to cs42l84, not cs42l83
15:02svenlooks like i just can't reproduce those missed nvme interrupts anymore (without the additional lock around command submission) no matter what i try :/
15:13jeffmiwj`ey: I'm with an old macOS 11.5.2 and neither rtc nor shutdown work with latest asahi branch, currently updating my system to latest macOS 12 to re-test
15:14j`eyjeffmiw: shutdown worked for me in the end, also 11.x. make sure you had all the SPMI/MFD/NVMEM options
15:14j`eyjeffmiw: but upgrading is needed anyway soo
15:14j`ey(for rtc I mean, and dcp)
15:18axboe has joined #asahi-dev
15:21jeffmiwI had all the SPMI/MFD/NVMEM options, I saw some errors on the spmi nodes in the dt, which model are you testing on ? I'm on mba
15:22j`eyjeffmiw: "bad cell count" errors are currently expected. MBA here too
15:23jeffmiwok so probably something else wrong in my setup then. I dig into it if I still see the issue after updating. For testing power off I tried halt or shutdown, how do you so it ?
15:24j`eyI did 'poweroff -f' but that was from an initramfs setup with busybox
15:25jeffmiwok, I'll check this. Thanks. I also have a minimal initramfs with busybox.
15:26mpspoweroff also works for me
15:38axboe has quit [Quit: leaving]
15:40axboe has joined #asahi-dev
16:02grgy has quit [Quit: ZNC 1.8.2 - https://znc.in]
16:03grgy has joined #asahi-dev
16:18kettenishmm, did I misunderstand that the CLUSTER_PSTATE register contains the actual power state of the cluster as well as the desired state?
18:52willemml has joined #asahi-dev
19:22willemml has quit [Quit: willemml]
19:59bps has quit [Ping timeout: 480 seconds]
20:01willemml has joined #asahi-dev
20:03willemml has quit []
20:07bps has joined #asahi-dev
20:10boardwalk has joined #asahi-dev
20:18Hiroshi has joined #asahi-dev
20:19Hiroshi is now known as Guest306
20:19axboe has quit [Quit: leaving]
20:20Guest306 has quit []
20:21axboe has joined #asahi-dev
20:54axboe has quit [Quit: reboot]
20:56axboe has joined #asahi-dev
21:07___nick___ has quit [Ping timeout: 480 seconds]
21:17bps has quit [Ping timeout: 480 seconds]
23:02alyssaj`ey: blasphemie
23:03j`eyalyssa: excusez-moi pour chaque faux pas que j'ai faire
23:25Gaspare has joined #asahi-dev
23:40willemml has joined #asahi-dev
23:41willemml has quit []
…