2022-02-15
00:41user982492 has joined #asahi-dev
01:33phire_ has joined #asahi-dev
01:33phire is now known as Guest407
01:33phire_ is now known as phire
01:36Guest407 has quit [Ping timeout: 480 seconds]
02:55yuyichao has quit [Ping timeout: 480 seconds]
03:00skipwich has quit [Quit: DISCONNECT]
03:01skipwich has joined #asahi-dev
03:31PhilippvK has joined #asahi-dev
03:34phiologe has quit [Ping timeout: 480 seconds]
03:43kov has quit [Quit: Coyote finally caught me]
03:48kov has joined #asahi-dev
05:00c10l3 has quit []
05:00c10l3 has joined #asahi-dev
05:49the_lanetly_052___ has joined #asahi-dev
06:42Bey0ndB1nary has joined #asahi-dev
07:45Bey0ndB1nary has quit []
08:00MajorBiscuit has joined #asahi-dev
08:18Bey0ndB1nary has joined #asahi-dev
08:18Bey0ndB1nary has quit []
08:47user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:55gladiac has quit [Quit: k thx bye]
08:56gladiac has joined #asahi-dev
09:24Major_Biscuit has joined #asahi-dev
09:26MajorBiscuit has quit [Ping timeout: 480 seconds]
09:32user982492 has joined #asahi-dev
09:32user982492 has quit []
10:27n1c has joined #asahi-dev
10:34n1c has quit [Quit: ZNC 1.8.2+deb1+focal2 - https://znc.in]
10:43n1c has joined #asahi-dev
11:34the_lanetly_052___ has quit [Remote host closed the connection]
11:34the_lanetly_052___ has joined #asahi-dev
11:48the_lanetly_052___ has quit [Ping timeout: 480 seconds]
12:20yuyichao has joined #asahi-dev
13:40Major_Biscuit has quit [Ping timeout: 480 seconds]
13:41Major_Biscuit has joined #asahi-dev
13:49refi64 has quit [Remote host closed the connection]
13:50alyssa has joined #asahi-dev
13:50refi64 has joined #asahi-dev
14:11riker77 has quit [Quit: Quitting IRC - gone for good...]
14:29riker77 has joined #asahi-dev
14:34riker77 has quit [Quit: Quitting IRC - gone for good...]
14:35MajorBiscuit has joined #asahi-dev
14:37yuyichao has quit [Ping timeout: 480 seconds]
14:37Major_Biscuit has quit [Ping timeout: 480 seconds]
15:01yuyichao has joined #asahi-dev
15:23riker77 has joined #asahi-dev
15:38marcanok, too tired to do more work today, I'm going to sleep early for once. pushed things as is to spmi/work.
15:40j`eymarcan: i guess the t8103 stuff is pretty simple, if copied mostly from the previous attempt..
16:14axboe has joined #asahi-dev
16:18j`eydoes it try to change it? ie does it even get to apple_soc_cpufreq_set_target for the 2nd cluster
16:21axboeI poked a bit yesterday, and seems like it was using the wrong clk base for pcluster2, it was the pcluster1 address
16:22axboeand the fact that capacity isn't set either just made me assume that something is wrong with the setup of that second pcluster
16:43axboenow it finds last cpu in p cluster 1 "not alive", and then hits a MPIDR mismatch on first cpu in cluster 2
17:11jannauaxboe: https://github.com/jannau/m1n1/commit/55b48fd6f266815ed0d31c82cd1bce3cf14dd433 works for me with a patch to skip cores
17:26user982492 has joined #asahi-dev
17:29jannauit does, it doesn't however remove disabled cores from the cpu-map added for cpufreq driver
17:32axboeif I just hack smp.c to keep a separate cpu index rather than use i it works for me, on top of plain m1n1
17:44MajorBiscuit has quit [Quit: WeeChat 3.4]
17:48jannauaxboe: we have to solve this in m1n1 as we haf to use a single dtb for M1 Pro machines with 8 and 10 cpu cores
17:56jannauI thought you tried with the unmodified dtb. I use https://paste.debian.net/1231019/ to simulate the sparseness and that works with my patch and the stock dtb
18:04user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:04Guest119 has left #asahi-dev [WeeChat 3.3]
18:28user982492 has joined #asahi-dev
18:29user982492 has quit []
18:33axboeI know you guys all know this, but I'm still blown away by the perf here. game changing imho
18:45axboewith a big backlog like that, useful to just try and flush out some of the independent ones. at least that makes you feel like you made progress ;)
18:50axboeI've only once seen higher AQ depth be useful, and that was under provisioning and with discard sizes being smaller where then having a higher admin queue depth made a difference
18:51axboesven: upstream would look kindly at the apple-nvme driver, as it can be combined with a "remove various weird apple workarounds or quirks" in the generic one
18:52svenoh, I agree. But nvme requires this rtkit protocol that’s also required for smc. I’m just waiting for marcan to finish that part
18:55svenI considered adding a pcie backend to apple nvme but that driver is imho already big enough for the initial submission
18:58axboej`ey: if we ever end up at the same conference, I'll tell you the story of the time hch took my kids to watch the lego movie
19:09svenyeah, it’s also been tested by a few people for at least weeks (and sometimes even months) now without any major issues
19:10jannaumarcan: spmi t8103 dts and a small fix for for the cpufreq driver https://github.com/jannau/linux/commits/spmi/work
19:12svenwe’ll have to figure out how to deal with the shared rtkit dependency but I guess in the worst case we just create an immutable branch somewhere so that both trees can merge it after review
19:12j`eyjannau: for the atomic thing did you actually get the sleep-during-atomic BUG, or just from manual inspection?
19:16kettenisI hope the bindings we came up with will be fairly uncontroversial since they largely just use generic stuff
19:34axboecompletioned polled for all 3, on last one it resets the controller, reset fails, IO errors ensue
19:57svenI don’t think I need to serialize writes there. it’s not really a queue pointer but just “please start command with tag x”
20:04axboecould just be timing and I'll still hit it, but seemed to be trivial to hit before and seems solid now
20:18timokrgr has quit [Quit: User left the chat]
20:23timokrgr has joined #asahi-dev
20:23axboesven: cuddle up with a cup of your favorite beverage and open Documentation/memory-barrier.txt ;)
20:24svenI assumed that writel to MMIO should be enough. It’s dma_wmb which should order it against the previous writes to normal memory and then just a single STR
20:27svenhmmm… I wonder if there’s anything in the irq handler that could mess something up in that case
20:34axboeyou have two issues going on, one is half way through memcpy of command, other happens faster and submits the tag
20:35axboebut only explanation I can find is that we trigger an interrupt for completion and don't find it, then it gets polled later
20:36sventhe hw first looks into the tcb at the specified tag, then reads the actual index into the “queue” (which is really more like an array here) and then reads the queue at that index
21:05axboesven: assuming you're keeping the ->enabled state for adding suspend, because I don't think it's needed right now
21:13sveni think the enabled originally comes from NVMEQ_ENABLED in pci.c. i convinced myself at some point that i didn't need it but then went back a few days later because i convinced myself that i do need it and then decided to keep it for now just-in-case IIRC
21:29axboeyeah I don't think you need it right now, but for suspend you probably will. so I left it alone
21:32axboeyou can just fold in or however you prefer, I don't need attribution since it's not in tree yet
21:46j`eythe code after /* last chance to complete any requests before nvme_cancel_request */ wont be useful if its removed
21:47c10l39 has joined #asahi-dev
21:54c10l3 has quit [Ping timeout: 480 seconds]
21:57jeffmiw has quit [Ping timeout: 480 seconds]
21:58jeffmiw has joined #asahi-dev
21:59axboe has quit [Ping timeout: 480 seconds]