#asahi-gpu · 2023-01-05 01:45
alyssaso if it's a "total bytes" thing we're missing a factor of 2 (12 instead of 24)#asahi-gpu · 2023-01-05 01:45
alyssathe sampler descriptor is either 8 bytes or 24 bytes depending if there are border colours or not#asahi-gpu · 2023-01-05 01:43
alyssastill ss0/ss1 in the shader#asahi-gpu · 2023-01-05 01:42
alyssathe relevant count goes from 4->24 when going from 2 compact samplers to effectively 2 extended ones#asahi-gpu · 2023-01-05 01:41
alyssaoh hmhmhm#asahi-gpu · 2023-01-05 01:39
alyssaand 4->24 in another case, uh#asahi-gpu · 2023-01-05 01:38
alyssa"Sampler state register count" goes 32 -> 24 with border colour on 1 of 2 samplers ?!#asahi-gpu · 2023-01-05 01:37
alyssaunclear what determines which#asahi-gpu · 2023-01-05 01:37
alyssathe "USC bind sampler" command binds either compact (no border colour) or extended (with border colour) samplers#asahi-gpu · 2023-01-05 01:37
alyssaooookay#asahi-gpu · 2023-01-05 01:02
alyssaHm#asahi-gpu · 2023-01-05 00:34
alyssawhy am I getting page faults with custom border colours.#asahi-gpu · 2023-01-05 00:00
alyssaannoying for Direct3D#asahi-gpu · 2023-01-05 00:00
alyssafor GL#asahi-gpu · 2023-01-05 00:00
alyssayeah ok I think this is reasonable#asahi-gpu · 2023-01-04 23:59
alyssathough it seems to still apply the API swizzle specified maybe#asahi-gpu · 2023-01-04 23:57
alyssawhat a delight#asahi-gpu · 2023-01-04 23:57
alyssaso the custom border colour is packed in the actual format#asahi-gpu · 2023-01-04 23:57
alyssargba16 unorm texture#asahi-gpu · 2023-01-04 23:57
alyssaah lol#asahi-gpu · 2023-01-04 23:56
alyssathose.. aren't floats are they..#asahi-gpu · 2023-01-04 23:56
alyssasampler, 7fff 3fff 1fff ffff#asahi-gpu · 2023-01-04 23:55
alyssaborder colour 3 is definitely for custom#asahi-gpu · 2023-01-04 23:50
alyssaGL_CLAMP in hardware on agx (wrap=4) wat?!#asahi-gpu · 2023-01-04 17:27
jannaunp, I think without it dcp/disp0 would crash instantly crash on fb unmap#asahi-gpu · 2023-01-04 17:25
marcanI should get some sleep :p#asahi-gpu · 2023-01-04 17:25
marcanjannau: you're right, sorry... misread the patch#asahi-gpu · 2023-01-04 17:22
jannaumarcan: I think it is there, each plane's update bit gets set if the plane was changed, see the for_each_oldnew_plane_in_state() loop in dcp_flush#asahi-gpu · 2023-01-04 17:16
marcannot that it really matters right now since we only support a single plane anyway...#asahi-gpu · 2023-01-04 17:16
marcanAIUI if a bit is set there and the surface is NULL, the plane is removed#asahi-gpu · 2023-01-04 17:16
marcanit's not really "enabled", more like "update/request"#asahi-gpu · 2023-01-04 17:16
marcanjannau: btw, now that I noticed, I think there's one missing thing still. when layers are removed, they should have their bits set in swap_enabled#asahi-gpu · 2023-01-04 16:58
marcansee https://gist.github.com/marcan/d93ebdffce5b36be9aaa06079a60503f for what I've been able to find about supported pixel formats#asahi-gpu · 2023-01-04 16:57
marcan(still feels really weird though)#asahi-gpu · 2023-01-04 16:57
marcan(also obviously the hardware supports it, it's just DCP firmware that doesn't because I guess Apple never needed it for macOS?)#asahi-gpu · 2023-01-04 16:57
marcan*bottommost plane#asahi-gpu · 2023-01-04 16:57
marcanwe can cheat that with premultiplication for the bottommost planes, but not any overlay planes#asahi-gpu · 2023-01-04 16:56
marcanI'm still quite annoyed that there isn't a "turn off alpha" bit anywhere as far as I can tell, and no XRGB8888 support at all#asahi-gpu · 2023-01-04 16:56
eric_engestromyup, just read the commit message and that's exactly what I'm experiencing :)#asahi-gpu · 2023-01-04 16:55
marcanit's all pretty cursed#asahi-gpu · 2023-01-04 16:55
marcanwhich is why the iBoot framebuffer works as intended, but then the apple comes back later when we enable another plane#asahi-gpu · 2023-01-04 16:55
marcanthe apple shape is the original iBoot alpha, which interestingly does not actually apply on boot because DCP does some optimization where fullscreen single planes end up ignoring alpha anyway#asahi-gpu · 2023-01-04 16:55
jannauscreenshot will not work since it's blended in the display controller#asahi-gpu · 2023-01-04 16:54
marcanand yes, that happened when we switched to plane 1 because plane 0 seems to be special on t600x, combined with the lack of alphaless formats (which we were unknowingly cheating by marking them as premultiplied)#asahi-gpu · 2023-01-04 16:54
eric_engestromthanks both :)#asahi-gpu · 2023-01-04 16:54
jannaueric_engestrom: fixed in 9e3157ab6af08531191f25709dc3494eb2c65f0a#asahi-gpu · 2023-01-04 16:54
eric_engestrommarcan: are you replying to me? awesome :)#asahi-gpu · 2023-01-04 16:54
eric_engestrom(using grim for the screenshot)#asahi-gpu · 2023-01-04 16:54
marcanthat's fixed in the 6.2-rc2 rebase I just pushed#asahi-gpu · 2023-01-04 16:53
eric_engestromalso, just tried to take a screenshot: the cursor is included, the apple logo isn't (not sure what info that really adds though)