#
…

2023-01-04

00:43hertz has joined #asahi-gpu
00:45amarioguy2 has joined #asahi-gpu
00:51amarioguy has quit [Ping timeout: 480 seconds]
00:59blazra2 has joined #asahi-gpu
01:06blazra has quit [Ping timeout: 480 seconds]
01:06blazra2 is now known as blazra
03:31karolherbst_ has joined #asahi-gpu
03:37karolherbst has quit [Ping timeout: 480 seconds]
03:53jackhill has quit [Remote host closed the connection]
06:14hertz has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:21cylm_ has joined #asahi-gpu
06:34possiblemeatball has quit [Quit: Leaving]
06:55karolherbst_ is now known as karolherbst
07:12SSJ_GZ has joined #asahi-gpu
08:16amarioguy has joined #asahi-gpu
08:19amarioguy2 has quit [Ping timeout: 480 seconds]
09:32bluetail1 has joined #asahi-gpu
09:39bluetail has quit [Ping timeout: 480 seconds]
09:39bluetail1 is now known as bluetail
10:43hertz has joined #asahi-gpu
12:47marcanalyssa, lina: BTW, does asahi handle multiplanar formats yet? DCP supports a bunch of those (and we're going to need them for some use cases), and Apple use multiplanar RGB10+A8 by default for UI stuff (compressed) so I assume it's supported by the hardware somehow (or is that just effectively "lol MRT"?)
12:49marcanin particular kwin seems to prefer alpha formats over alphaless, but right now we only *actually* support X2R10G10B10 as a 10-bit format (we claim A2 also but it's a lie). so right now kwin picks the A2 format even though it has no real alpha. we should offer it a proper 2-plane 10-bit alpha format as the best choice.
12:53jannaudid you test "w40a" 40-bit single plane ARGB10? I think I saw that as supported as well but it was missing from dcp_surfaces.txt
13:33karolherbst_ has joined #asahi-gpu
13:38karolherbst has quit [Ping timeout: 480 seconds]
13:43karolherbst_ is now known as karolherbst
14:10jannauw40a works for dcp but is despite its name 64 bit per pixel
14:13dottedmagIs it 10-bit with 6-bit unused per channel?
14:18dottedmagAlso Wayland implicitly implies that all the buffers are single-planar in wl_shm constructor. Nobody uses this constructor for anything useful, but well.
14:22jannauyes, 6 bit padding per component. I guess handling 40 bit per pixels is annoying on HW side as well. the kwin code in question uses zlinux_dmabuf
14:25possiblemeatball has joined #asahi-gpu
14:28dottedmagdmabuf _seems_ not to hardcode assumptions: width/height/format plus a number of weird flags (y invert, interlaced, bottom-first-interlaced), so it might work with multiplanar if they are advertised.
14:36jannaumulti-planar YUV works with dmabuf without issues
14:48amarioguy has quit [Remote host closed the connection]
15:15amarioguy has joined #asahi-gpu
15:35bcrumb has joined #asahi-gpu
15:35bcrumb has quit []
16:05danielssingle-planar also works fine with wl_shm, you just don’t get to choose your chroma offset or stride
16:45marcanjannau: w40a is in there (#4), and I would expect it works but it's such a massive waste of memory bandwidth... not a good idea for the main framebuffer
16:45marcanbi-planar formats are much nicer because the alpha is going to be all 0xff 99% of the time, which should compress down to ~nothing with framebuffer compression
16:47marcanso in practice w40a is going to be close to ~2x the memory bandwidth of w18p or b3a8
16:53eric_engestromlina: any chance that "apple logo" at boot is its own hardware plane and it's missing a clear in your driver's init?
16:53eric_engestromI'm getting leftover text from the linux console in the shape of an apple in the middle of my screen, and it's above everything else (including the cursor), but it's like it's rendered with a single value used for all channels (only grey, and the opacity seems to match the luminosity, black being fully transparent), so I'm guessing it might have been missed because if there's no text that happens to be right there, it will
16:53eric_engestromappear fully transparent
16:53eric_engestromalso, just tried to take a screenshot: the cursor is included, the apple logo isn't (not sure what info that really adds though)
16:54marcanthat's fixed in the 6.2-rc2 rebase I just pushed
16:54eric_engestrom(using grim for the screenshot)
16:54eric_engestrommarcan: are you replying to me? awesome :)
16:54jannaueric_engestrom: fixed in 9e3157ab6af08531191f25709dc3494eb2c65f0a
16:54eric_engestromthanks both :)
16:54marcanand yes, that happened when we switched to plane 1 because plane 0 seems to be special on t600x, combined with the lack of alphaless formats (which we were unknowingly cheating by marking them as premultiplied)
16:55jannauscreenshot will not work since it's blended in the display controller
16:55marcanthe apple shape is the original iBoot alpha, which interestingly does not actually apply on boot because DCP does some optimization where fullscreen single planes end up ignoring alpha anyway
16:55marcanwhich is why the iBoot framebuffer works as intended, but then the apple comes back later when we enable another plane
16:55marcanit's all pretty cursed
16:56eric_engestromyup, just read the commit message and that's exactly what I'm experiencing :)
16:56marcanI'm still quite annoyed that there isn't a "turn off alpha" bit anywhere as far as I can tell, and no XRGB8888 support at all
16:57marcanwe can cheat that with premultiplication for the bottommost planes, but not any overlay planes
16:57marcan*bottommost plane
16:57marcan(also obviously the hardware supports it, it's just DCP firmware that doesn't because I guess Apple never needed it for macOS?)
16:57marcan(still feels really weird though)
16:58marcansee https://gist.github.com/marcan/d93ebdffce5b36be9aaa06079a60503f for what I've been able to find about supported pixel formats
17:01hightower2 has quit [Ping timeout: 480 seconds]
17:16marcanjannau: btw, now that I noticed, I think there's one missing thing still. when layers are removed, they should have their bits set in swap_enabled
17:16marcanit's not really "enabled", more like "update/request"
17:16marcanAIUI if a bit is set there and the surface is NULL, the plane is removed
17:16marcannot that it really matters right now since we only support a single plane anyway...
17:22jannaumarcan: I think it is there, each plane's update bit gets set if the plane was changed, see the for_each_oldnew_plane_in_state() loop in dcp_flush
17:23hightower2 has joined #asahi-gpu
17:25marcanjannau: you're right, sorry... misread the patch
17:25marcanI should get some sleep :p
17:27jannaunp, I think without it dcp/disp0 would crash instantly crash on fb unmap
17:41systwi_ has joined #asahi-gpu
17:47systwi has quit [Ping timeout: 480 seconds]
17:57Telessia_ has joined #asahi-gpu
17:59Telessia_ has quit []
18:01lawrence has quit [Quit: The Lounge - https://thelounge.chat]
18:14bcrumb has joined #asahi-gpu
18:15bcrumb has quit []
18:21bcrumb has joined #asahi-gpu
18:28djorz has joined #asahi-gpu
18:33lawrence has joined #asahi-gpu
18:34bcrumb has quit [Quit: WeeChat 3.7.1]
19:04cylm_ has quit [Ping timeout: 480 seconds]
19:30WindowPa- has joined #asahi-gpu
19:35WindowPain has quit [Ping timeout: 480 seconds]
19:51amarioguy has quit [Remote host closed the connection]
20:01alyssa has quit [Quit: leaving]
20:38LinuxM1 has joined #asahi-gpu
20:46possiblemeatball has quit [Quit: Leaving]
20:46cr1901 has quit [Remote host closed the connection]
20:46cr1901 has joined #asahi-gpu
20:47LinuxM1 has quit [Quit: Leaving]
21:56hightower2 has quit [Ping timeout: 480 seconds]
22:05hightower2 has joined #asahi-gpu
22:11SSJ_GZ has quit [Ping timeout: 480 seconds]
22:15mkurz has joined #asahi-gpu
23:03mkurz has quit [Quit: Leaving]
23:50alyssa has joined #asahi-gpu
23:50alyssaGL_CLAMP in hardware on agx (wrap=4) wat?!
23:55alyssaborder colour 3 is definitely for custom
23:56alyssasampler, 7fff 3fff 1fff ffff
23:56alyssathose.. aren't floats are they..
23:57alyssargba16 unorm texture
23:57alyssaso the custom border colour is packed in the actual format
23:57alyssawhat a delight
23:59alyssathough it seems to still apply the API swizzle specified maybe
…