#
#asahi-gpu · 2023-08-30 19:20
i509vcbDoes gallium use any negative Scale Y?
#asahi-gpu · 2023-08-30 19:19
alyssaViewport::Scale Y is a float and should be possible to be negative
#asahi-gpu · 2023-08-30 19:18
alyssa(is there one?)
#asahi-gpu · 2023-08-30 19:18
alyssai509vcb: what's the question?
#asahi-gpu · 2023-08-30 18:17
i509vcbviewport does have float
#asahi-gpu · 2023-08-30 18:16
i509vcbno ignore that
#asahi-gpu · 2023-08-30 18:16
i509vcbbut X and Y are uint16
#asahi-gpu · 2023-08-30 18:16
i509vcbAlthough why are Min Z and Max Z floats?
#asahi-gpu · 2023-08-30 18:16
i509vcbscissor is uint...
#asahi-gpu · 2023-08-30 18:14
i509vcb(needed for KHR_maintenance1 which is one last mandatory extension wgpu needs)
#asahi-gpu · 2023-08-30 18:11
i509vcbhttps://usercontent.irccloud-cdn.com/file/JIO20R85/Screenshot_20230830_131110.png
#asahi-gpu · 2023-08-30 18:11
i509vcbagx seems to not like negative height, hopefully I don't need to do lowering in shaders for this...
#asahi-gpu · 2023-08-30 17:20
i509vcbdEQP-VK.compute.basic.empty_workgroup_all seem to be fine with me just immediately returning, so I guess thats valid from the cts
#asahi-gpu · 2023-08-30 17:05
alyssano reason
#asahi-gpu · 2023-08-30 17:01
i509vcbValid usage doesn't forbid 0
#asahi-gpu · 2023-08-30 16:59
i509vcbIf vkCmdDispatch gets 0 in any groupCount dimension. is there really any reason to record the command in the first place?
#asahi-gpu · 2023-08-30 16:37
alyssasee the corresponding gallium driver implementation
#asahi-gpu · 2023-08-30 16:37
alyssai509vcb: yes
#asahi-gpu · 2023-08-30 16:36
i509vcbalyssa: For indirect compute, I probably use CDM_INDIRECT instead of CDM_GLOBAL_SIZE? (Since that needs the group count at recording time)
#asahi-gpu · 2023-08-30 11:24
alyssaalright
#asahi-gpu · 2023-08-30 09:18
linaalyssa: When you're around, there's a new Dolphin issue seemingly related to MSAA+Depth that goes away when I flush after every draw, so I think it's shader related ^^
#asahi-gpu · 2023-08-30 05:27
linaalyssa: New kernel debug_flags bit 0x2000 to verbosely explain UAPI usage errors (you probably want that on always by default)
#asahi-gpu · 2023-08-30 03:05
alyssaella-0: please review i509vcb's MR when you get a chance, thank you!
#asahi-gpu · 2023-08-30 03:05
i509vcbok
#asahi-gpu · 2023-08-30 03:04
alyssathx
#asahi-gpu · 2023-08-30 03:04
alyssai509vcb: split out the patch then :)
#asahi-gpu · 2023-08-30 02:42
i509vcbalyssa: my branch is up to date, I just ended up filling in a few missing meta_begins I guess while testing things
#asahi-gpu · 2023-08-30 01:14
alyssai509vcb: needs a rebase, the meta_begin stuff landed already (I merged ella's commit)
#asahi-gpu · 2023-08-30 01:13
alyssaWoohoo!
#asahi-gpu · 2023-08-30 01:03
i509vcbalyssa: lower sysvals is done. Everything lives in the sysvals buffer now
#asahi-gpu · 2023-08-30 00:13
alyssayour pass order might need some tweaks
#asahi-gpu · 2023-08-30 00:13
alyssaone of the lower_explicit_io's IIRC
#asahi-gpu · 2023-08-30 00:10
i509vcbHmm deref_var &pushConstants (push_const PushConstants) seems to be getting lowered after I do sysvals?
#asahi-gpu · 2023-08-30 00:07
i509vcbI'm not sure why push constants seem to not be lowered in one of the tests I am running
#asahi-gpu · 2023-08-29 19:52
alyssasince "buffers" is super ambiguous
#asahi-gpu · 2023-08-29 19:52
alyssawhat I mean is, what AGXV currently just calls "buffers" should be called "vertex buffers" or "VBOs" for short
#asahi-gpu · 2023-08-29 19:49
i509vcbUhh I guess I'll get that done later today
#asahi-gpu · 2023-08-29 19:49
i509vcbAll I see right now in agxv_pipeline is vbos
#asahi-gpu · 2023-08-29 19:48
alyssad
#asahi-gpu · 2023-08-29 19:48
alyssathe term "buffers" is... extremely overloade
#asahi-gpu · 2023-08-29 19:48
alyssas/buffers/vertex buffers or VBOs/
#asahi-gpu · 2023-08-29 19:47
alyssa:+1:
#asahi-gpu · 2023-08-29 19:47
i509vcbI'm guessing that's something you probably want done
#asahi-gpu · 2023-08-29 19:47
i509vcbOn the sysvals MR, I think buffers are all that I need to finish if we wanted to just move absolutely everything into sysvals
#asahi-gpu · 2023-08-29 19:46
alyssa;)
#asahi-gpu · 2023-08-29 19:45
alyssapikachu.jpg
#asahi-gpu · 2023-08-29 19:45
alyssaIt's almost like I build the common code with Vulkan in mind
#asahi-gpu · 2023-08-29 19:45
alyssaThat's the intention
#asahi-gpu · 2023-08-29 19:44
i509vcbalyssa: agx_nir_needs_texture_crawl appears to be all I need to know whether or not I lower something to bindless
#asahi-gpu · 2023-08-29 13:24
alyssathat way you have a fixed binding to get the pointer and then you can add your nir_def offset (which can be indirect)

plus ›