#
…

2023-08-30

00:07i509vcbI'm not sure why push constants seem to not be lowered in one of the tests I am running
00:08ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
00:10i509vcbHmm deref_var &pushConstants (push_const PushConstants) seems to be getting lowered after I do sysvals?
00:10ourdumbfuture has joined #asahi-gpu
00:13alyssaone of the lower_explicit_io's IIRC
00:13alyssayour pass order might need some tweaks
00:17cr1901_ is now known as cr1901
01:03i509vcbalyssa: lower sysvals is done. Everything lives in the sysvals buffer now
01:08kujeger has quit [Ping timeout: 480 seconds]
01:13ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
01:14alyssai509vcb: needs a rebase, the meta_begin stuff landed already (I merged ella's commit)
01:29aratuk has joined #asahi-gpu
01:33ourdumbfuture has joined #asahi-gpu
01:33aratuk has quit []
01:38novafacing9926 has joined #asahi-gpu
01:43ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
01:45novafacing992 has quit [Ping timeout: 480 seconds]
01:45novafacing9926 is now known as novafacing992
01:49aratuk has joined #asahi-gpu
01:54JTL has joined #asahi-gpu
01:54aratuk has quit []
01:56kujeger has joined #asahi-gpu
01:56ourdumbfuture has joined #asahi-gpu
02:12hightower4 has joined #asahi-gpu
02:19hightower3 has quit [Ping timeout: 480 seconds]
02:40ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
02:42i509vcbalyssa: my branch is up to date, I just ended up filling in a few missing meta_begins I guess while testing things
02:48jeisom has quit [Ping timeout: 480 seconds]
03:04alyssai509vcb: split out the patch then :)
03:05alyssaella-0: please review i509vcb's MR when you get a chance, thank you!
03:48possiblemeatball has quit [Quit: Quit]
04:14cylm has quit [Ping timeout: 480 seconds]
05:06tertu2 has quit [Quit: so long...]
05:08crabbedhaloablut has joined #asahi-gpu
05:27linaalyssa: New kernel debug_flags bit 0x2000 to verbosely explain UAPI usage errors (you probably want that on always by default)
05:39tertu has joined #asahi-gpu
05:47tertu has quit [Ping timeout: 480 seconds]
05:47tertu has joined #asahi-gpu
05:58zhdi has joined #asahi-gpu
06:05Major_Biscuit has joined #asahi-gpu
06:10Major_Biscuit has quit []
08:02MajorBiscuit has joined #asahi-gpu
08:07zhdi has quit [Quit: Connection closed for inactivity]
08:25chadmed has quit [Ping timeout: 480 seconds]
09:05bisko has joined #asahi-gpu
09:08kujeger has quit [Ping timeout: 480 seconds]
09:18linaalyssa: When you're around, there's a new Dolphin issue seemingly related to MSAA+Depth that goes away when I flush after every draw, so I think it's shader related ^^
09:22bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
09:51jeisom has joined #asahi-gpu
09:58chadmed has joined #asahi-gpu
09:58chadmed has quit [Remote host closed the connection]
09:59chadmed has joined #asahi-gpu
10:16cr1901_ has joined #asahi-gpu
10:23cr1901 has quit [Ping timeout: 480 seconds]
10:33ourdumbfuture has joined #asahi-gpu
10:49duckworld has quit [Ping timeout: 480 seconds]
11:01ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
11:13minecrell has quit [Quit: Ping timeout (120 seconds)]
11:14minecrell has joined #asahi-gpu
11:19ourdumbfuture has joined #asahi-gpu
11:26alyssa has quit [Quit: alyssa]
11:30alyssa has joined #asahi-gpu
11:30alyssa has quit []
11:36cr1901__ has joined #asahi-gpu
11:44cr1901_ has quit [Ping timeout: 480 seconds]
12:04alyssa has joined #asahi-gpu
12:06kujeger has joined #asahi-gpu
12:08nightquest has quit [Ping timeout: 480 seconds]
12:09nightquest has joined #asahi-gpu
12:30ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
12:41ourdumbfuture has joined #asahi-gpu
12:43bisko has joined #asahi-gpu
13:22alyssa has quit [Quit: alyssa]
13:57bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
13:57bisko has joined #asahi-gpu
13:59Major_Biscuit has joined #asahi-gpu
14:01MajorBiscuit has quit [Ping timeout: 480 seconds]
14:16cylm has joined #asahi-gpu
14:19cr1901_ has joined #asahi-gpu
14:27cr1901__ has quit [Ping timeout: 480 seconds]
14:35cr1901_ is now known as cr1901
14:54bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
15:03ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
15:44Major_Biscuit has quit [Ping timeout: 480 seconds]
16:03alyssa has joined #asahi-gpu
16:20iaguis has joined #asahi-gpu
16:22ourdumbfuture has joined #asahi-gpu
16:36i509vcbalyssa: For indirect compute, I probably use CDM_INDIRECT instead of CDM_GLOBAL_SIZE? (Since that needs the group count at recording time)
16:37alyssai509vcb: yes
16:37duckworld has joined #asahi-gpu
16:37alyssasee the corresponding gallium driver implementation
16:42rhysmdnz has quit [Quit: Bridge terminating on SIGTERM]
16:42Guest942 has quit [Quit: Bridge terminating on SIGTERM]
16:45rhysmdnz has joined #asahi-gpu
16:46Guest1229 has joined #asahi-gpu
16:56Major_Biscuit has joined #asahi-gpu
16:57Major_Biscuit has quit []
16:58iaguis has quit [Quit: leaving]
16:59i509vcbIf vkCmdDispatch gets 0 in any groupCount dimension. is there really any reason to record the command in the first place?
16:59ave36309 has quit [Ping timeout: 480 seconds]
16:59iaguis has joined #asahi-gpu
17:01i509vcbValid usage doesn't forbid 0
17:05alyssano reason
17:20i509vcbdEQP-VK.compute.basic.empty_workgroup_all seem to be fine with me just immediately returning, so I guess thats valid from the cts
17:25jeisom has quit [Ping timeout: 480 seconds]
17:59ave36309 has joined #asahi-gpu
18:11i509vcbagx seems to not like negative height, hopefully I don't need to do lowering in shaders for this...
18:14i509vcb(needed for KHR_maintenance1 which is one last mandatory extension wgpu needs)
18:16i509vcbscissor is uint...
18:16i509vcbAlthough why are Min Z and Max Z floats?
18:16i509vcbbut X and Y are uint16
18:16i509vcbno ignore that
18:17i509vcbviewport does have float
19:08flom84 has joined #asahi-gpu
19:08crabbedhaloablut has quit []
19:18alyssai509vcb: what's the question?
19:18alyssa(is there one?)
19:19alyssaViewport::Scale Y is a float and should be possible to be negative
19:20i509vcbDoes gallium use any negative Scale Y?
19:21alyssaI don't remember
19:21flom84 has quit [Quit: Leaving]
19:21alyssaI thought so
19:21alyssalook at agx_get_scissor_extents
19:22flom84 has joined #asahi-gpu
19:25flom84 has quit [Remote host closed the connection]
19:25i509vcbScale gets passed through fabsf
19:34alyssafor the SCISSOR yes
19:34alyssafor the VIEWPORT no
19:40flom84 has joined #asahi-gpu
19:47ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
19:58flom84 has quit [Ping timeout: 480 seconds]
20:00nightquest has left #asahi-gpu [#asahi-gpu]
20:28alyssawith my wip branch, dolphin ubers @ 4k is up to 7.5fps
20:28alyssawas like 4.5fps, so this is great progress
20:29i509vcbViewport
20:29i509vcb Translate X: 640.000000
20:29i509vcb Scale X: 640.000000
20:29i509vcb Translate Y: 360.000000
20:29i509vcb Scale Y: -360.000000
20:29i509vcb Translate Z: 0.000000
20:29i509vcb Scale Z: 1.000000
20:29i509vcbthis looks fine?
20:29i509vcbVulkan doesn't set enable on REGION_CLIP, though that doesn't seem to be the issue
20:29alyssaTarget is 11.5fps (what I measured on macOS)
20:29alyssaSo... 65% of the way there are something? :p
20:30alyssa53% slower frametime than macOS, yeet
20:31alyssaa bit more usefully, getting 54fps for 2x
20:35alyssa(that's almost playable)
20:37i509vcbhmm common code gives me this:
20:37i509vcbScissor: min x: 0 min y: 720 max x: 1280 max y: 0
20:38i509vcbYou have an assert in gallium which forbids min_x > min_y, is that a hardware limitation?
20:43i509vcbyes that was the issue
20:46alyssaooh, and with break_if predicated properly, up to 64fps
20:48alyssaor 9.1fps at 4K
20:48alyssa79% of the way there, lol
20:54alyssawith the heuristic tuned a bit, 67fps
20:56alyssa(9.5fps)
20:56alyssa83%, i'll take it!
21:07i509vcbFixing the negative viewport thing apparently was enough to run an iced app (although a simple one)
21:25ourdumbfuture has joined #asahi-gpu
21:49i509vcbvkCmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports) returns void:
21:49i509vcbLooking at the API dump we get this:
21:49i509vcb commandBuffer: VkCommandBuffer = 0xaaab67735310
21:49i509vcb firstViewport: uint32_t = 0
21:49i509vcb viewportCount: uint32_t = 1
21:49i509vcb pViewports: const VkViewport* = 0xfffff8571848
21:49i509vcb pViewports[0]: const VkViewport = 0xfffff8571848:
21:49i509vcb x: float = 0
21:49i509vcb y: float = 720
21:49i509vcb width: float = 1280
21:49i509vcb height: float = -720
21:49i509vcb minDepth: float = 0
21:49i509vcb maxDepth: float = 1
22:00alyssaAdded some more patches.. some of them are hacks in their current form (just trying to scope out what we're missing) but around now ~9.8fps
22:11Bey0ndB1nary has joined #asahi-gpu
22:18darkapex has quit [Remote host closed the connection]
22:19darkapex has joined #asahi-gpu
22:19jeisom has joined #asahi-gpu
22:22Bey0ndB1nary has quit []
22:46ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
22:53i509vcbalyssa: oops in patch, here's another
22:53ourdumbfuture has joined #asahi-gpu
23:40ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
23:41ourdumbfuture has joined #asahi-gpu
…