#
✕ nick:alyssa
#asahi-gpu · 2023-09-26 12:03
alyssaaustriancoder: little surprised it was necessary
#asahi-gpu · 2023-09-25 21:59
alyssawhat a mood
#asahi-gpu · 2023-09-25 18:40
alyssadefinitely works on asahi/mesa
#asahi-gpu · 2023-09-25 18:40
alyssaprobably not
#asahi-gpu · 2023-09-25 18:40
alyssadon't remember
#asahi-gpu · 2023-09-20 15:38
alyssaand then no special handling will be needed in agxv, i think
#asahi-gpu · 2023-09-20 15:38
alyssashouldn't be too hard to generalize/fix vk_meta to do the right thing
#asahi-gpu · 2023-09-20 15:37
alyssaNotably, spirv_to_nir does not generate these sysvals for layers, neither does the glsl compiler. this is just a case of the vk_meta abstraction being a bit leaky and inadvertently hardcoding NVK specific details in common code
#asahi-gpu · 2023-09-20 15:36
alyssaI think you want to take the helper in that pass, move it to nir_builder with the appropriate rename, and then convert vk_meta to use it to ensure agxv never sees load_layer_id intrinsics
#asahi-gpu · 2023-09-20 15:35
alyssasee for contrast nir_lower_input_attachments which has a load_layer_id helper that takes driver nir options to generate a varying LAYER load instead of a sysval load if applicable
#asahi-gpu · 2023-09-20 15:34
alyssarather than conditionally doing so only if the driver wants layer IDs as sysvals
#asahi-gpu · 2023-09-20 15:34
alyssavk_meta is hardcoding a load_layer_id intrinsic inappropriately
#asahi-gpu · 2023-09-20 15:32
alyssaI see the problem now
#asahi-gpu · 2023-09-20 15:32
alyssai509vcb: ahhh
#asahi-gpu · 2023-09-20 15:31
alyssahmm
#asahi-gpu · 2023-09-20 15:31
alyssaa
#asahi-gpu · 2023-09-20 14:07
alyssa:\
#asahi-gpu · 2023-09-19 23:45
alyssafor us LAYER is a varying, not a sysval
#asahi-gpu · 2023-09-19 23:45
alyssabefore the predication pass etc
#asahi-gpu · 2023-09-19 23:45
alyssai509vcb: run nir_lower_sysvals_to_varyings with the appropriate modification to support layer
#asahi-gpu · 2023-09-19 23:41
alyssa:+1:
#asahi-gpu · 2023-09-19 23:22
alyssa5
#asahi-gpu · 2023-09-19 23:21
alyssakapeesh? :)
#asahi-gpu · 2023-09-19 23:21
alyssaI should probably simplify this in the gl driver but whatever, it's not really hurting anything there..
#asahi-gpu · 2023-09-19 23:20
alyssathe layered bool matters a lot more for the background and EOT programs, but those are independent of pipeline and you should have that information available for them just fine, I think
#asahi-gpu · 2023-09-19 23:19
alyssabut if you're spilling attachments you're already screwed so that seems like a reasonable tradeoff to me lol
#asahi-gpu · 2023-09-19 23:18
alyssabut if you just always use a 2D Array PBE descriptor for that (with layers=1 if necessary) that should still work out fine, at a slight cost to instruction count in the spilled path
#asahi-gpu · 2023-09-19 23:17
alyssathe only case where it would matter is for spilled render targets
#asahi-gpu · 2023-09-19 23:16
alyssawhen compiling frag shaders, just asssume the framebuffer is always layered
#asahi-gpu · 2023-09-19 23:14
alyssai509vcb: it doesn't look like you necesarily have that information but you dont really need it
#asahi-gpu · 2023-09-19 15:41
alyssai509vcb: keep in mind i didn't do agxv integration, I just mean that the core compiler/common support is merged in by virtue of the rebase :)
#asahi-gpu · 2023-09-19 15:02
alyssagood luck / have fun :)
#asahi-gpu · 2023-09-19 15:01
alyssasmoke tested with vkcube but did not CTS
#asahi-gpu · 2023-09-19 15:01
alyssai509vcb: rebased agxv/main, that branch has layered rendering now
#asahi-gpu · 2023-09-16 12:35
alyssai509vcb: lmk if you still need help with the rebase next week and hopefully I'll be well enough to take care of it then :-)
#asahi-gpu · 2023-09-15 21:29
alyssaI don't think i'll get to the rebase this weekend, though maybe you'd like to give it a try?
#asahi-gpu · 2023-09-15 21:29
alyssai509vcb: addressed your comments and merged
#asahi-gpu · 2023-09-15 20:19
alyssametals "tile shaders" make the correspondence fairly explicit
#asahi-gpu · 2023-09-15 20:18
alyssatile memory is the same physically as workgroup shared/local memoty
#asahi-gpu · 2023-09-15 20:18
alyssai509vcb: tiles are morally workgroups yeah
#asahi-gpu · 2023-09-13 19:13
alyssathanks :-)
#asahi-gpu · 2023-09-13 19:05
alyssasorry :(
#asahi-gpu · 2023-09-13 19:04
alyssaill right now so not soon unfortunately
#asahi-gpu · 2023-09-13 19:03
alyssai'm
#asahi-gpu · 2023-09-12 22:57
alyssanot 100% sure why the macs lag behind the iphones for a year
#asahi-gpu · 2023-09-12 22:57
alyssa(and dropping in a few months?)
#asahi-gpu · 2023-09-12 22:57
alyssaG15 (== Apple M3) should be hideously boring, I think
#asahi-gpu · 2023-09-12 22:55
alyssaI am more concerned about the alleged new ISA
#asahi-gpu · 2023-09-12 22:55
alyssaso we have time
#asahi-gpu · 2023-09-12 22:55
alyssawhich won't drop for another year+

plus ›