#
…

2023-09-20

00:01i509vcbI don't see any layer id enum variant in gl_system_value
00:19cr1901 has quit [Remote host closed the connection]
00:19cr1901 has joined #asahi-gpu
00:20cr1901 has quit [Read error: Connection reset by peer]
00:20eldriitch has quit [Quit: Leaving...]
00:25cr1901 has joined #asahi-gpu
00:56ourdumbfuture has joined #asahi-gpu
01:01i509vcbSomething about LAYER not having a sysval value feels weird
01:35ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
01:35ourdumbfuture has joined #asahi-gpu
02:42chadmed has quit [Quit: Konversation terminated!]
02:42chadmed has joined #asahi-gpu
02:44ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
03:36cylm has quit [Ping timeout: 480 seconds]
04:04novafacing9926 has quit [Read error: Connection reset by peer]
04:26possiblemeatball has quit [Quit: Quit]
04:59jeisom has quit [Ping timeout: 480 seconds]
06:14crabbedhaloablut has joined #asahi-gpu
07:11nst has quit [Quit: WeeChat 3.8]
07:53nst has joined #asahi-gpu
07:54nst has quit []
07:55nst has joined #asahi-gpu
08:28crabbedhaloablut has quit [Read error: Connection reset by peer]
08:29crabbedhaloablut has joined #asahi-gpu
08:37MajorBiscuit has joined #asahi-gpu
08:51crabbedhaloablut has quit [Read error: Connection reset by peer]
08:52crabbedhaloablut has joined #asahi-gpu
08:57chadmed has quit [Remote host closed the connection]
08:58chadmed has joined #asahi-gpu
09:12nimprod3l has joined #asahi-gpu
09:14eldriitch has joined #asahi-gpu
09:20eldriitch has quit [Quit: Leaving...]
09:22nimprod3l has quit [Quit: Leaving]
09:41le0n has quit [Ping timeout: 480 seconds]
10:30le0n has joined #asahi-gpu
10:43le0n has quit [Ping timeout: 480 seconds]
10:45ourdumbfuture has joined #asahi-gpu
10:47ourdumbfuture has quit []
11:02le0n has joined #asahi-gpu
11:54chadmed has quit [Quit: Konversation terminated!]
11:54chadmed has joined #asahi-gpu
11:55jeisom has joined #asahi-gpu
12:13ourdumbfuture has joined #asahi-gpu
12:14ourdumbfuture has quit []
12:15ourdumbfuture has joined #asahi-gpu
12:42cylm has joined #asahi-gpu
13:04nyx_o_ has joined #asahi-gpu
13:04nyx_o has quit [Ping timeout: 480 seconds]
14:05ourdumbfuture has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
14:12pg12 has quit [Ping timeout: 480 seconds]
14:13pg12 has joined #asahi-gpu
14:22i509vcbone thing I did notice is that layer has a gl_varying_slot, wouldn't that imply it's already a varying or is the common infrastructure not capable of expressing layer as a sysval currently
14:23i509vcbI guess I could do tree wide changes but then I have to figure out what other drivers expect...
15:23crabbedhaloablut has quit [Read error: Connection reset by peer]
15:24crabbedhaloablut has joined #asahi-gpu
15:32alyssai509vcb: ahhh
15:32alyssaI see the problem now
15:34alyssavk_meta is hardcoding a load_layer_id intrinsic inappropriately
15:34alyssarather than conditionally doing so only if the driver wants layer IDs as sysvals
15:35alyssasee for contrast nir_lower_input_attachments which has a load_layer_id helper that takes driver nir options to generate a varying LAYER load instead of a sysval load if applicable
15:36alyssaI think you want to take the helper in that pass, move it to nir_builder with the appropriate rename, and then convert vk_meta to use it to ensure agxv never sees load_layer_id intrinsics
15:37alyssaNotably, spirv_to_nir does not generate these sysvals for layers, neither does the glsl compiler. this is just a case of the vk_meta abstraction being a bit leaky and inadvertently hardcoding NVK specific details in common code
15:38alyssashouldn't be too hard to generalize/fix vk_meta to do the right thing
15:38alyssaand then no special handling will be needed in agxv, i think
15:40i509vcbFixing vk_meta there sounds reasonable, I imagine a few nvk specific details will be there anyways
15:44possiblemeatball has joined #asahi-gpu
15:48ourdumbfuture has joined #asahi-gpu
16:02tertl8 has joined #asahi-gpu
16:44MajorBiscuit has quit [Ping timeout: 480 seconds]
17:18flom84 has joined #asahi-gpu
17:27jeisom has quit [Read error: No route to host]
17:27jeisom has joined #asahi-gpu
17:47jeisom has quit [Ping timeout: 480 seconds]
18:00flom_84 has joined #asahi-gpu
18:06flom84 has quit [Ping timeout: 480 seconds]
18:07chadmed has quit [Ping timeout: 480 seconds]
18:07flom_84 has quit []
19:09billak has joined #asahi-gpu
19:10chadmed has joined #asahi-gpu
19:22billak has quit [Quit: Konversation terminated!]
19:23crabbedhaloablut has quit []
19:27hxliew has joined #asahi-gpu
20:03hightower2 has quit [Ping timeout: 480 seconds]
20:07jeisom has joined #asahi-gpu
20:10cylm has quit [Ping timeout: 480 seconds]
20:10dylanchapell has quit [Read error: Connection reset by peer]
20:21hightower2 has joined #asahi-gpu
20:43possiblemeatball has quit [Quit: Quit]
20:47possiblemeatball has joined #asahi-gpu
21:17dylanchapell has joined #asahi-gpu
22:00nyx_o_ has quit [Ping timeout: 480 seconds]
22:22tertl8 has quit [Quit: Connection closed for inactivity]
23:09c10l has quit [Quit: Bye o/]
23:14c10l has joined #asahi-gpu
23:43NateWeav has joined #asahi-gpu
23:57NateWeav has quit [Quit: The Lounge - https://thelounge.chat]
…