#asahi-dev · 2025-06-29 16:02
chaos_princessand you may or may not want to add a goto entry_disconnect after dev_err(tps->dev, "Couldn't register sysfs group for CD321x VDMs\n");#asahi-dev · 2025-06-29 16:02
martinrok, thanks#asahi-dev · 2025-06-29 16:01
chaos_princessno, just drop entry cleanup at all. the fact that you moved the creation to the end is enough#asahi-dev · 2025-06-29 16:00
martinrso entry creation should be near start of probe, right?#asahi-dev · 2025-06-29 15:59
chaos_princessyou got the order wrong, now all other errors will cause a non-existent sysfs groups to be removed#asahi-dev · 2025-06-29 15:55
martinrchaos_princess: sysfs entries should now be removed on all errors during probe, I don't see any dmesg messages when building as a built-in, feel free to verify if you'd like#asahi-dev · 2025-06-29 14:34
martinrok i think i see the fix#asahi-dev · 2025-06-29 14:11
chaos_princessyes, but it is more that you are not cleaning up everything that you should if something errors out#asahi-dev · 2025-06-29 14:10
martinrah you mean it is loading in too soon as a built-in?#asahi-dev · 2025-06-29 14:06
chaos_princessbuilt-in here, and it seems like your thing probes before the supplier devices do. so something returns EPROBE_DEFER after you created the sysfs entries, and you never clean up those on error#asahi-dev · 2025-06-29 14:06
martinrloading in with insmod#asahi-dev · 2025-06-29 14:05
martinrmodule#asahi-dev · 2025-06-29 14:05
chaos_princessare you building as module or built-in?#asahi-dev · 2025-06-29 14:05
chaos_princessi think i maybe see the issue #asahi-dev · 2025-06-29 14:05
martinr...unless i dont understand when tps6598x_probe is called#asahi-dev · 2025-06-29 14:04
chaos_princesshttps://pastebin.com/ymNM30Xu - that should be all the relevant bits#asahi-dev · 2025-06-29 14:01
martinrit should only try to create the sysfs object when the module is loaded#asahi-dev · 2025-06-29 14:01
martinryeah I'm not sure what's going on there, can I get a full dmesg?#asahi-dev · 2025-06-29 14:00
chaos_princesssysfs spam is still a thing though#asahi-dev · 2025-06-29 13:59
martinrthanks#asahi-dev · 2025-06-29 13:59
martinrnice#asahi-dev · 2025-06-29 13:59
chaos_princessi could talk between machines over serial with picocom#asahi-dev · 2025-06-29 13:59
martinrare you getting anything on the serial console?#asahi-dev · 2025-06-29 13:59
chaos_princessdfu port is port1 on j314#asahi-dev · 2025-06-29 13:57
chaos_princessok, nvm, i am stupid, it works#asahi-dev · 2025-06-29 13:54
chaos_princessactually, wait#asahi-dev · 2025-06-29 13:54
chaos_princessyep, still not working#asahi-dev · 2025-06-29 13:30
martinri couldn't recreate the sysfs issue but we'll leave that for later#asahi-dev · 2025-06-29 13:28
martinrno rush#asahi-dev · 2025-06-29 13:28
chaos_princesssure, give me a few mins#asahi-dev · 2025-06-29 13:27
martinrhttps://github.com/martinyrm/apple-cd321x-driver/blob/main/tipd/core.patch#asahi-dev · 2025-06-29 13:27
martinrchaos_princess: ok I don't think it's key related - I managed to reproduce the -1 error codes on my M1 MBA, and bumping up the VDM command timeout seems to help, would you mind trying again?#asahi-dev · 2025-06-29 12:42
jannauI think there are people using macvdmtool on all devices#asahi-dev · 2025-06-29 12:31
chaos_princesssure#asahi-dev · 2025-06-29 12:30
martinrchaos_princess: thanks for the help anyways - i'll see if I can find anything more on the keys#asahi-dev · 2025-06-29 12:15
chadmedunclear from the commit history but perhaps not#asahi-dev · 2025-06-29 12:12
martinrhas macvdmtool been tested on t600x?#asahi-dev · 2025-06-29 12:11
chadmeddifferent vdm key for t600x perhaps?#asahi-dev · 2025-06-29 12:10
martinrwhich is a bug I had encountered but is fixed on my end#asahi-dev · 2025-06-29 12:10
martinras for the spam, that is the sysfs object not being removed on device/module reload#asahi-dev · 2025-06-29 12:09
martinri expected the patching out the strlen check to work#asahi-dev · 2025-06-29 12:09
martinrchaos_princes: ok there is something quite different about the m1 pro then #asahi-dev · 2025-06-29 12:09
chaos_princessi also get a bunch of this dmesg spam https://pastebin.com/PdvmgHBi#asahi-dev · 2025-06-29 12:08
chaos_princesspatching out the check does not help btw#asahi-dev · 2025-06-29 12:07
chadmed?? #asahi-dev · 2025-06-29 12:07
chadmedhttps://github.com/martinyrm/apple-cd321x-driver/blob/main/tipd/core.patch#L67#asahi-dev · 2025-06-29 12:02
chaos_princesshttps://pastebin.com/7wczp2rF#asahi-dev · 2025-06-29 11:49
martinr*/dev/ttySAC0 for the back port i think#asahi-dev · 2025-06-29 11:41
martinrso I think we need to apply that patch to the tipd module on one device, connect the two M1 devices together with a USB3 cable (w/ SBU wires), then 'echo 1' to /sys/class/typec/port0/device/cd321x_vdm/serial - and then hopefully they should be able to talk to each other on /dev/ttySAC0 or /dev/ttySAC2#asahi-dev · 2025-06-29 11:36
chaos_princesssure, how do i test it?