#
…

2025-06-29

00:47allmazz_ has quit [Quit: leaving]
00:47allmazz has joined #asahi-dev
01:33allmazz_ has joined #asahi-dev
01:35allmazz has quit [Ping timeout: 480 seconds]
02:06tobhe_ has joined #asahi-dev
02:12hexdump01 has joined #asahi-dev
02:13tobhe has quit [Ping timeout: 480 seconds]
02:14hexdump0815 has quit [Ping timeout: 480 seconds]
02:38allmazz_ has quit [Quit: leaving]
02:38allmazz has joined #asahi-dev
03:12cylm_ has quit [Ping timeout: 480 seconds]
03:36WindowPain has quit [Quit: Ping timeout (120 seconds)]
03:37WindowPain has joined #asahi-dev
03:50nora_ has joined #asahi-dev
03:52nora has quit [Ping timeout: 480 seconds]
05:03the_sea_peoples has quit []
05:34the_sea_peoples has joined #asahi-dev
05:34mattia013 has quit [Remote host closed the connection]
05:36mattia013 has joined #asahi-dev
05:39the_sea_peoples has quit []
05:45the_sea_peoples has joined #asahi-dev
06:00ddxtanx has quit [Read error: Connection reset by peer]
06:02ddxtanx has joined #asahi-dev
06:05the_sea_peoples has quit []
06:13bacarrdy has quit [Ping timeout: 480 seconds]
06:15bacarrdy has joined #asahi-dev
06:32bacarrdy has quit [Ping timeout: 480 seconds]
06:52chadmed has quit [Quit: Konversation terminated!]
06:52chadmed has joined #asahi-dev
07:26chadmed has quit [Quit: Konversation terminated!]
07:26chadmed has joined #asahi-dev
07:27chadmed has quit []
07:28chadmed has joined #asahi-dev
07:40glem8100548899 has joined #asahi-dev
07:44bacarrdy has joined #asahi-dev
08:08bacarrdy has quit [Ping timeout: 480 seconds]
08:18bacarrdy has joined #asahi-dev
08:36bacarrdy has quit [Ping timeout: 480 seconds]
09:12okb has joined #asahi-dev
09:16bacarrdy has joined #asahi-dev
09:30bacarrdy has quit [Ping timeout: 480 seconds]
09:42bacarrdy has joined #asahi-dev
11:31martinr has joined #asahi-dev
11:34martinrso I finally got around to finishing up VDM support for tipd - is anyone with a second M1 device interested in helping me test serial mode? my M1 iPad Pro does respond to VDMs, but doesn't appear to output anything over serial at boot-time unfortunately
11:36chaos_princesssure, how do i test it?
11:41martinrso I think we need to apply that patch to the tipd module on one device, connect the two M1 devices together with a USB3 cable (w/ SBU wires), then 'echo 1' to /sys/class/typec/port0/device/cd321x_vdm/serial - and then hopefully they should be able to talk to each other on /dev/ttySAC0 or /dev/ttySAC2
11:48okb_ has joined #asahi-dev
11:49martinr*/dev/ttySAC0 for the back port i think
11:51okb has quit [Ping timeout: 480 seconds]
12:08chaos_princesspatching out the check does not help btw
12:09chaos_princessi also get a bunch of this dmesg spam https://pastebin.com/PdvmgHBi
12:09martinrchaos_princes: ok there is something quite different about the m1 pro then
12:09martinri expected the patching out the strlen check to work
12:10martinras for the spam, that is the sysfs object not being removed on device/module reload
12:10martinrwhich is a bug I had encountered but is fixed on my end
12:11chadmeddifferent vdm key for t600x perhaps?
12:12martinrhas macvdmtool been tested on t600x?
12:15chadmedunclear from the commit history but perhaps not
12:17Calandracas__ has joined #asahi-dev
12:23Calandracas_ has quit [Ping timeout: 480 seconds]
12:25Calandracas_ has joined #asahi-dev
12:30martinrchaos_princess: thanks for the help anyways - i'll see if I can find anything more on the keys
12:31Calandracas__ has quit [Ping timeout: 480 seconds]
12:42jannauI think there are people using macvdmtool on all devices
12:59martinr has quit [Ping timeout: 480 seconds]
13:11martinr has joined #asahi-dev
13:19cylm has joined #asahi-dev
13:27martinrchaos_princess: ok I don't think it's key related - I managed to reproduce the -1 error codes on my M1 MBA, and bumping up the VDM command timeout seems to help, would you mind trying again?
13:28chaos_princesssure, give me a few mins
13:30martinri couldn't recreate the sysfs issue but we'll leave that for later
13:54chaos_princessyep, still not working
13:54chaos_princessactually, wait
13:57chaos_princessok, nvm, i am stupid, it works
13:59chaos_princessdfu port is port1 on j314
13:59martinrare you getting anything on the serial console?
13:59chaos_princessi could talk between machines over serial with picocom
14:00chaos_princesssysfs spam is still a thing though
14:01martinryeah I'm not sure what's going on there, can I get a full dmesg?
14:01martinrit should only try to create the sysfs object when the module is loaded
14:04chaos_princesshttps://pastebin.com/ymNM30Xu - that should be all the relevant bits
14:05chadmed has quit [Quit: Konversation terminated!]
14:05martinr...unless i dont understand when tps6598x_probe is called
14:05chaos_princessi think i maybe see the issue
14:05chaos_princessare you building as module or built-in?
14:05chadmed has joined #asahi-dev
14:06martinrloading in with insmod
14:06chadmed has quit []
14:06chadmed has joined #asahi-dev
14:06chaos_princessbuilt-in here, and it seems like your thing probes before the supplier devices do. so something returns EPROBE_DEFER after you created the sysfs entries, and you never clean up those on error
14:10martinrah you mean it is loading in too soon as a built-in?
14:11chaos_princessyes, but it is more that you are not cleaning up everything that you should if something errors out
14:34martinrok i think i see the fix
14:57martinr has quit [Quit: WeeChat 4.3.4]
15:33pb17 has quit [Ping timeout: 480 seconds]
15:36pb17 has joined #asahi-dev
15:54martinr has joined #asahi-dev
15:55martinrchaos_princess: sysfs entries should now be removed on all errors during probe, I don't see any dmesg messages when building as a built-in, feel free to verify if you'd like
15:59chaos_princessyou got the order wrong, now all other errors will cause a non-existent sysfs groups to be removed
16:00martinrso entry creation should be near start of probe, right?
16:01chaos_princessno, just drop entry cleanup at all. the fact that you moved the creation to the end is enough
16:02martinrok, thanks
16:02chaos_princessand you may or may not want to add a goto entry_disconnect after dev_err(tps->dev, "Couldn't register sysfs group for CD321x VDMs\n");
16:02chaos_princessdepending on if it is ok to operate in this "degraded" state
16:03martinrthat makes sense
16:03chaos_princess*err_disconnect
16:03martinrfirst kernel driver attempt so I appreciate the hints
16:07martinri think it makes sense to keep the rest of tipd working if there's an issue with the VDM feature, especially because a device reset won't help with the sysfs creation error
16:08martinrnone of the added code will be used without a write to sysfs
16:15martinr has quit [Quit: WeeChat 4.3.4]
16:23martinr has joined #asahi-dev
16:26martinrok I think that looks pretty good, I went back and fixed the strlen check too
16:43amarioguy2quick question - if we want to redirect the timer IRQ to the guest (as an vIRQ, not enabling the FIQ in EL1 or injecting a virtual FIQ) where would it be best to inject a virtual IRQ in the HV exception handler?
16:44amarioguy2my first guess would be the start exception lower proxy call?
16:45rhysmdnz has quit [Quit: Bridge terminating on SIGTERM]
16:45Guest18690 has quit [Quit: Bridge terminating on SIGTERM]
16:47rhysmdnz has joined #asahi-dev
16:48Guest20458 has joined #asahi-dev
16:48amarioguy2(in case it helps - i'm envisioning the flow here as: timer FIQ fires, traps to EL2, masks the FIQ for a bit to handle it, then HV kicks it to the guest as a virtual IRQ where it proceeds from there)
16:58yuka has quit [Remote host closed the connection]
17:05yuka has joined #asahi-dev
17:28allmazz_ has joined #asahi-dev
17:30allmazz has quit [Ping timeout: 480 seconds]
17:36cylm_ has joined #asahi-dev
17:38cylm has quit [Ping timeout: 480 seconds]
17:50martinr has quit [Quit: WeeChat 4.3.4]
19:18fugi has quit [Quit: bye]
19:19fugi has joined #asahi-dev
19:23WindowPain4 has joined #asahi-dev
19:29WindowPain has quit [Ping timeout: 480 seconds]
19:29WindowPain4 is now known as WindowPain
20:23hspak4405343 has quit []
20:25pb17 has quit [Ping timeout: 480 seconds]
20:25hspak4405343 has joined #asahi-dev
20:38pb17 has joined #asahi-dev
20:48alexaltea has quit [Ping timeout: 480 seconds]
21:10alexaltea has joined #asahi-dev
21:29alexaltea has quit [Ping timeout: 480 seconds]
21:37xdbob has quit [Remote host closed the connection]
21:39xdbob has joined #asahi-dev
21:53okb_ has quit [Read error: Connection reset by peer]
21:53opticron has quit [Read error: Connection reset by peer]
21:54opticron has joined #asahi-dev
22:12allmazz has joined #asahi-dev
22:14allmazz_ has quit [Ping timeout: 480 seconds]
23:04SaltySimon has joined #asahi-dev
23:04SaltySimon has quit [Quit: Leaving]
23:44cylm_ has quit [Ping timeout: 480 seconds]
23:49dax has quit [Quit: dax]
…