#
#asahi-dev · 2025-08-27 15:14
nickchanit'd just be apple,s5l8960x-spi most likely
#asahi-dev · 2025-08-27 15:14
nickchanthe new one is still based on the old one
#asahi-dev · 2025-08-27 15:13
jannauthe samsung one wouldn't use "apple,spi" though
#asahi-dev · 2025-08-27 15:13
kettenisbut that's a samsung hardware block, not an apple one
#asahi-dev · 2025-08-27 15:12
nickchanone found on Samsung S5L8700 all the way to T8030 and another one found since T8101
#asahi-dev · 2025-08-27 15:11
nickchanthere's at least two incompatible variants for the spi
#asahi-dev · 2025-08-27 15:03
jannau"apple,spi" wasn't a good idea and in our case having just the unrelieable information from the ADT is an argument for only using SoC specific ones
#asahi-dev · 2025-08-27 15:02
jannauI'm actually not quite about what exactly Krzysztof complains. I don't think generic implementation / version compatibles like "nvme-ans2", "asc-mailbox-v4", "aic2" are uncommon nor did we start with that.
#asahi-dev · 2025-08-27 14:44
nickchanhttps://github.com/HoolockLinux/linux/commit/64621018c7ce68487e2bca7f0985eff15ab0b9a6
#asahi-dev · 2025-08-27 14:39
sven"Add bindings for SARTv0 as found on Apple A11 SoC." -> "dd bindings for SARTv0 as found on Apple A11 SoC, which is incompatible with the previously described versions since it uses a different MMIO layout"
#asahi-dev · 2025-08-27 14:38
nickchanwell the whole knowledge of sart0 comes from me trying to set the registers in all to 0xffffffffffffffff and see what actually gets set
#asahi-dev · 2025-08-27 14:34
nickchanthis is also a draft of a possible replacement commit
#asahi-dev · 2025-08-27 14:34
nickchansven: in case if you want a more rigorous description of what I just said see here: https://github.com/HoolockLinux/linux/commit/eeebce3a2bafc707ea67c1db85ba8028ef345092
#asahi-dev · 2025-08-27 14:32
nickchanthe config size bits is the range of low bits the hw allowed me to set the bits to 1
#asahi-dev · 2025-08-27 14:31
nickchanAPPLE_SART0_CONFIG_SIZE shifted by APPLE_SART0_CONFIG_SIZE_SHIFT
#asahi-dev · 2025-08-27 14:31
nickchanalso looking at the sart0 code that I did submit it looks like the filter entry size is up to... 31-bit?
#asahi-dev · 2025-08-27 14:29
nickchansome of the olders socs does use maxed frequency in m1n1
#asahi-dev · 2025-08-27 14:29
nickchanwell not any apple silicon mac socs anyways
#asahi-dev · 2025-08-27 14:28
nickchanno
#asahi-dev · 2025-08-27 14:27
svendo we already increase the cpu frequency to maximum inside m1n1? :>
#asahi-dev · 2025-08-27 14:09
jannaulet's see if there's a significant runtime impact of patching the whole DT. that might remind us of removing it
#asahi-dev · 2025-08-27 14:05
svenlet me reply to him on the weekend, then we can figure out what we'll do
#asahi-dev · 2025-08-27 14:04
svennickchan: some part of me just wants to be like "oh well, the commit is already upstream, too late" tbh :D
#asahi-dev · 2025-08-27 14:03
svenjannau: ack
#asahi-dev · 2025-08-27 14:03
jannauI'll use M1 as base compatible (if applicable) as that's what the driver was written for
#asahi-dev · 2025-08-27 14:02
nickchani am thinking about replacing the entire commit as well
#asahi-dev · 2025-08-27 14:02
svenlet me think about it, but i could also just replace the entire commit
#asahi-dev · 2025-08-27 14:02
svenhrm
#asahi-dev · 2025-08-27 14:01
nickchannot v2
#asahi-dev · 2025-08-27 14:01
nickchansven: right and a14 has sartv1
#asahi-dev · 2025-08-27 14:01
svenoh, it doesn't already mention SARTv0 but only 1,2 and 3?
#asahi-dev · 2025-08-27 14:00
nickchanThe binding description
#asahi-dev · 2025-08-27 13:59
svenwhat content needs to change? i can always back up the full commit and replace it with another one
#asahi-dev · 2025-08-27 13:59
nickchansven: how about the content of the sart binding commit? I can send a fixed version.
#asahi-dev · 2025-08-27 13:59
svenwe'd probably forgot to remove it even if we planned to do it 2 years from now tbh
#asahi-dev · 2025-08-27 13:57
jannauI'll re-add the missing generic compatibles for t6020 in m1n1. for all I care we can leave the code in m1n1 forever
#asahi-dev · 2025-08-27 13:57
kettenisjust keep shipping the device trees I have now and see what needs to be done in a year when they've finally decided what shade to paint their bikeshed in
#asahi-dev · 2025-08-27 13:57
svenlet's add least add back the generic compatible inside m1n1
#asahi-dev · 2025-08-27 13:55
svenmood
#asahi-dev · 2025-08-27 13:55
kettenissigh, oh well, I guess I just give up
#asahi-dev · 2025-08-27 13:55
svenhe might've only read the patch. i can still adjust the commit description since i haven't send out the pull request yet
#asahi-dev · 2025-08-27 13:55
nickchan(the only? difference between sart v0 and v1 is differences in the config flags)
#asahi-dev · 2025-08-27 13:54
nickchanthe existing binding description does say it is incompatible though so I don't get where the "unusual" thing come from
#asahi-dev · 2025-08-27 13:53
svenit's about the commit description
#asahi-dev · 2025-08-27 13:53
svennah
#asahi-dev · 2025-08-27 13:53
nickchanill post a patch that fixes the sart binding description I guess
#asahi-dev · 2025-08-27 13:52
jannaukettenis: https://lore.kernel.org/asahi/6365acb0-6e4c-4561-bc0f-d34637e8308e@kernel.org/
#asahi-dev · 2025-08-27 13:51
jannauapparently not for new submissions even if they are compatible with generic one
#asahi-dev · 2025-08-27 13:50
jannaumaybe we should ask for an exception for t6020 which already has downstream use outside of linux
#asahi-dev · 2025-08-27 13:49
kettenisI thought the plan was to keep adding the generic compatibles that are already upstream?

plus ›