#
…

2025-08-27

00:08ddxtanx has quit [Remote host closed the connection]
00:08john-cabaj has joined #asahi-dev
00:10ddxtanx has joined #asahi-dev
00:23hdbngr has joined #asahi-dev
00:31hdbngr has quit [Ping timeout: 480 seconds]
00:43DannyB has joined #asahi-dev
02:22hexdump02 has joined #asahi-dev
02:24hexdump01 has quit [Ping timeout: 480 seconds]
02:48tobhe has joined #asahi-dev
02:55tobhe_ has quit [Ping timeout: 480 seconds]
03:02skipwich has quit [Remote host closed the connection]
03:02skipwich has joined #asahi-dev
03:30john-cabaj has quit [Ping timeout: 480 seconds]
03:32hdbngr has joined #asahi-dev
03:41hdbngr has quit [Ping timeout: 480 seconds]
03:42ece314378925355451680698427415 has joined #asahi-dev
03:46cylm has quit [Ping timeout: 480 seconds]
03:48john-cabaj has joined #asahi-dev
03:58nora_ has joined #asahi-dev
04:00nora has quit [Ping timeout: 480 seconds]
04:07skipwich has quit [Ping timeout: 480 seconds]
04:22skipwich has joined #asahi-dev
04:30john-cabaj has quit [Ping timeout: 480 seconds]
05:00hdbngr has joined #asahi-dev
05:08hdbngr has quit [Ping timeout: 480 seconds]
05:12al3xtjames2 has joined #asahi-dev
05:28al3xtjames2 has quit [Quit: al3xtjames2]
05:29al3xtjames2 has joined #asahi-dev
05:42hdbngr has joined #asahi-dev
05:50hdbngr has quit [Ping timeout: 480 seconds]
05:52hdbngr has joined #asahi-dev
06:01hdbngr has quit [Ping timeout: 480 seconds]
06:15hdbngr has joined #asahi-dev
06:24hdbngr has quit [Ping timeout: 480 seconds]
06:26hdbngr has joined #asahi-dev
06:35hdbngr has quit [Ping timeout: 480 seconds]
07:05ravikant_ has joined #asahi-dev
07:44ece314378925355451680698427415 has quit [Ping timeout: 480 seconds]
08:01chaos_princessanyone knows how to tell the kernel to not light up a core cluster unless necessary?
08:06svenah well. i'm starting to remember the tbt mess now. acio depends on the iommu but the iommu only works once acio is at least partially up. this is going to be fun 🙃
08:07chaos_princesskinda like with aop and admac where aop wants to do admac power management itself
08:08svenit's gonna be rather annoying to represent this in the device tree
08:08svenhow did you solve aop and admac?
08:08chaos_princessremoving all register accesses from probe
08:09sventhis gets extra complicated because i have to shut down the iommu again before i shut down the PHY
08:09svenbut maybe i can do something similar. just have to check if there's a point in the iommu api where i can trigger that deferred probe and the shutdown again
08:14jannauchaos_princess: how is the kernel to decide necessary? Are you looking into some sort of CPU idle management which tries to keep an entire cluster idle? i.e. keeps one of the perf core cluster idle on t60x0 when only 4 perf cores are used
08:15chaos_princessi am not even fully sure what "necessary" means, kinda hoped android already has some solution, but probably to not light up the second p-cluster if utilization of the first one is below some threshold
08:18jannauI'd not be surprised if android has some out of band management for that otherwise I'd expect that's something the scheduler needs to handle
08:21chadmed has quit [Quit: Konversation terminated!]
08:21chadmed has joined #asahi-dev
08:22chaos_princesslol. thanks, looks helpful.
08:26jannaumaybe there is a sched_ext scheduler which does this (or it's easy to add this via sched_ext)
08:34jannauscx_nest seems match somewhat
08:41jannauotherwise I'd say that's something https://docs.kernel.org/scheduler/sched-energy.html should consider
08:45chadmedandroid has a litany of insane schedulers that all do weird shit incompatible with upstream
08:46chadmedi think what youre after is probably the job of EAS and a cpuidle driver working in concert
08:47jannauis it acceptable to add bcm4388 to brcmfmac's dt-bindings without driver support?
08:47chaos_princessiirc bindings need either a driver, or a tree that uses them
08:48chadmedunfortunately i dont think EAS has any smarts in it to deal with clusters sanely
08:48svenshould be fine, we also got those gpu bindings upstream and only chaos tree is using them so far
08:48svenafter all the bindings are supposed to just describe hardware...
08:49chadmedaccording to some theyre not even supposed to do that :P
08:53hdbngr has joined #asahi-dev
08:56jannauI have the wifi node in the t602x DT submission so the compatible is used (and causes dtbs_check complaints if it's omitted from the bindings)
08:56chaos_princessit should be ok then
09:59kettenisjannau: at some point we need to discuss the power control for the wifi chip with upstream
10:12hdbngr has quit [Ping timeout: 480 seconds]
11:14ravikant_ has quit [Ping timeout: 480 seconds]
11:21chadmedv2 of smc stuff sent
11:25jannauI plan to send it later today
11:31jannaukettenis: I've seen there is power handling in marcan's outstanding patches prior to bcm4388 support
11:33jannaushall I ask for acked-by to take the dt-bindings patches through the asahi tree?
11:34svenhttps://lore.kernel.org/asahi/12ab93b7-1fc2-4ce0-926e-c8141cfe81bf@kernel.org/ "You just need to remember not to grow the old items/pattern with generic compatible." i'm not sure if he also wants us to stop adding any compatible hardware to the generic fallback list
11:38jannauI missed that. That would require driver changes as we would have to add :apple,t8110-dart" to the driver to use compatible = "apple,t6020-dart", "apple,t8110-dart"; in new device trees
11:38jannauI'll ask for a clarification
11:40sveni think dart is actually fine because there's no "apple,dart" fallback
11:41svenbut he may want something like "apple,t6020-spi", "apple,t8103-spi" instead of "apple,t6020-spi", "apple,spi"
11:42chaos_princessdoes anyone know anything about "ioa-parent" (it is dart and maybe pmgr related)
11:48jannauno. looks like mmio addresses but the trailing 31 zeros are suspicios
11:48chaos_princessit is a mmio address, and it writes there
12:00ravikant_ has joined #asahi-dev
12:35john-cabaj has joined #asahi-dev
12:36nafod has quit [Ping timeout: 480 seconds]
12:49kettenisjannau: do you remember where? We have pwren-gpios in the PCIe port nodes, but that got NACKed IIRC
12:51jannauthe driver code is D3 handling. i.e. completely unrelated
12:54jannauwhy did I think we had the pwren-gpios in in the dt-bindings? I looked for mac pro support where it's more complicated due to the pcie switch
12:55jannaulinux has since a while a PCI slot power control driver.
12:56jannauthat alone is not enough since it needs to be synchronized with port probing
12:58jannauI want to look if https://lore.kernel.org/linux-pci/20250819-pci-pwrctrl-perst-v1-0-4b74978d2007@oss.qualcomm.com/ works for the mac pro. if it does it should work for all other devices
13:01jannauthe pci slot power control driver uses the pcie supplies from https://github.com/devicetree-org/dt-schema/blob/v2024.11/dtschema/schemas/pci/pci-bus-common.yaml#L153 which we could back by gpio driven dummy regulator
13:06kettenisI remember at some point during the discussion the point was raised that there is no "slot"
13:07kettenisI think a similar discussion eventually led to drivers/power/sequencing/pwrseq-qcom-wcn.c
13:08kettenisalthough that seems overkill for when there just is a single GPIO that needs to be toggled
13:11jannauthe "slot" controller matches "pciclass,0604" which we have
13:13jannauah, the supplies mention slot
13:14kettenisso yes, for the mac pro that is the answer
13:16jannauit uses of_regulator_bulk_get_all() so we could add our own -supplies
13:18jannauthe mac pro has this problem only for internal devices (which are still behind the pcie switch) so speaking about slots sounds equally wrong
13:23jannauKrzysztof replied. 15 or so more patches, redoing the dt-bindings and updating the device trees
13:24nafod has joined #asahi-dev
13:25jannauI'll add the generic compatibles for apple,t6020-* in m1n1
13:25svenyeah, i think it makes sense here to keep the generic ones around for a while
13:26svenmaybe drop them a year or two down the road
13:46jannaufeels silly to do with "apple,pmgr" which isn't even used in a driver. it's relying on "syscon", "simple-mfd"
13:47kettenisOpenBSD uses apple,pmgr
13:49kettenisI thought the plan was to keep adding the generic compatibles that are already upstream?
13:50cylm has joined #asahi-dev
13:50jannaumaybe we should ask for an exception for t6020 which already has downstream use outside of linux
13:51jannauapparently not for new submissions even if they are compatible with generic one
13:53nickchanill post a patch that fixes the sart binding description I guess
13:53svenit's about the commit description
13:54nickchanthe existing binding description does say it is incompatible though so I don't get where the "unusual" thing come from
13:55nickchan(the only? difference between sart v0 and v1 is differences in the config flags)
13:55svenhe might've only read the patch. i can still adjust the commit description since i haven't send out the pull request yet
13:55kettenissigh, oh well, I guess I just give up
13:57svenlet's add least add back the generic compatible inside m1n1
13:57kettenisjust keep shipping the device trees I have now and see what needs to be done in a year when they've finally decided what shade to paint their bikeshed in
13:57jannauI'll re-add the missing generic compatibles for t6020 in m1n1. for all I care we can leave the code in m1n1 forever
13:59svenwe'd probably forgot to remove it even if we planned to do it 2 years from now tbh
13:59nickchansven: how about the content of the sart binding commit? I can send a fixed version.
13:59svenwhat content needs to change? i can always back up the full commit and replace it with another one
14:00nickchanThe binding description
14:01svenoh, it doesn't already mention SARTv0 but only 1,2 and 3?
14:01nickchansven: right and a14 has sartv1
14:02svenlet me think about it, but i could also just replace the entire commit
14:02nickchani am thinking about replacing the entire commit as well
14:03jannauI'll use M1 as base compatible (if applicable) as that's what the driver was written for
14:03svenjannau: ack
14:04svennickchan: some part of me just wants to be like "oh well, the commit is already upstream, too late" tbh :D
14:05svenlet me reply to him on the weekend, then we can figure out what we'll do
14:09jannaulet's see if there's a significant runtime impact of patching the whole DT. that might remind us of removing it
14:23chadmed has quit [Quit: Konversation terminated!]
14:23chadmed has joined #asahi-dev
14:27svendo we already increase the cpu frequency to maximum inside m1n1? :>
14:29nickchanwell not any apple silicon mac socs anyways
14:29nickchansome of the olders socs does use maxed frequency in m1n1
14:31nickchanalso looking at the sart0 code that I did submit it looks like the filter entry size is up to... 31-bit?
14:31nickchanAPPLE_SART0_CONFIG_SIZE shifted by APPLE_SART0_CONFIG_SIZE_SHIFT
14:32nickchanthe config size bits is the range of low bits the hw allowed me to set the bits to 1
14:34nickchansven: in case if you want a more rigorous description of what I just said see here: https://github.com/HoolockLinux/linux/commit/eeebce3a2bafc707ea67c1db85ba8028ef345092
14:34nickchanthis is also a draft of a possible replacement commit
14:38nickchanwell the whole knowledge of sart0 comes from me trying to set the registers in all to 0xffffffffffffffff and see what actually gets set
14:39sven"Add bindings for SARTv0 as found on Apple A11 SoC." -> "dd bindings for SARTv0 as found on Apple A11 SoC, which is incompatible with the previously described versions since it uses a different MMIO layout"
15:02jannauI'm actually not quite about what exactly Krzysztof complains. I don't think generic implementation / version compatibles like "nvme-ans2", "asc-mailbox-v4", "aic2" are uncommon nor did we start with that.
15:03jannau"apple,spi" wasn't a good idea and in our case having just the unrelieable information from the ADT is an argument for only using SoC specific ones
15:11nickchanthere's at least two incompatible variants for the spi
15:12nickchanone found on Samsung S5L8700 all the way to T8030 and another one found since T8101
15:13kettenisbut that's a samsung hardware block, not an apple one
15:13jannauthe samsung one wouldn't use "apple,spi" though
15:14nickchanthe new one is still based on the old one
15:14nickchanit'd just be apple,s5l8960x-spi most likely
15:16nickchanmaybe I should look at whatever the ipod linux people are doing
15:29svenjannau: yeah, i dunno, but not a fight i'm willing to fight. i think with nvme the mistake was just nvme-ans2 while the controller is actually nvme-ans3 on the M!
15:40chaos_princessjust to be thorough, i assume we don't care about fabric and ecc errors, right?
15:56svenwhat did you run into? :D
15:57chaos_princesspmgr turns on error reporting on a bunch of fabric bits, and then... idk, i have no idea how to decode fabric errors as i can't observe them :P
15:57opticron has quit [Read error: Connection reset by peer]
15:57opticron has joined #asahi-dev
16:09svenah, in that case it sounds like a curiosity but nothing i'd spend time on right now
16:16ravikant_ has quit []
16:56jannauI'm troubled by writing a justification beyond "we agreed to not use them" for the commit messages
16:57jannauI'm annoyed but not annoyed enought to fight it either
16:59svenyeah :/
17:00svenmaybe put a link to the thread in there?
17:00sven"After discussion with the devicetree maintainers we agreed to not extend the list with the generic compatible anymore [1]"
17:05myrrhk has joined #asahi-dev
17:14myrrhk has quit [Remote host closed the connection]
17:15___nick___ has joined #asahi-dev
17:18svenhttps://git.kernel.org/pub/scm/linux/kernel/git/sven/linux.git/log/?h=wip/atcphy pretty happy with this now, will wait for feedback from heikki for tipd and then submit that afterwards
17:23___nick___ has quit []
17:26___nick___ has joined #asahi-dev
17:26___nick___ has quit []
17:28svenhttps://github.com/AsahiLinux/m1n1/pull/489/files fully untested fuses for !t8103 converted with a hacky python script
17:29___nick___ has joined #asahi-dev
17:33chaos_princesscommit message says 6002, but i don't see any of those
17:34svenuh.. let me double check what happened there
17:35svenah, they are the same as for 6000 and I deleted too much :D
17:36svendo you have a t6002 adt and can check the atcphy compatible?
17:37svenmight just be atc-phy,t6000 there as well, then I'll just adjust the commit message
17:37chaos_princessatc-phy,t6000
17:38sveni'll add a comment
17:39svenpushed
17:42chaos_princessok, i might be reading it wrong but the offsets don't really make sense
17:43chaos_princessevery single mmio under atc-phy5 starts with the second die offset
17:43chaos_princessand in the tunables, those seem to be on first
17:44svenhrm.. did i mess something up in the python script then
17:44svenor did we mess up the fdt?
17:45chaos_princessContainer: addr = 0x00000020922BC000 size = 0x0000000000002000 - this seems to be the tunable mmio from atcphy 5
17:45jannauthe fdt doesn't have the real mmio offsets
17:45chaos_princess(add 2000000000 for io offset)
17:45jannauthe addresses are translated via ranges in soc
17:46sventhe script uses libfdt via python bindings on the .dtb file fwiw
17:48svenoh, but i'm using it wrong i think
17:49jannaulibfdt doesn't do the translation, see dt_get_address() in m1n1's src/devicetree.c
17:49sventhat's the issue
17:49svengood catch
18:10svenupdated
18:10hdbngr has joined #asahi-dev
18:10svenshould've just adjusted the address manually instead of trying to fix that script :D
18:16john-cabaj has quit [Ping timeout: 480 seconds]
18:19hdbngr has quit [Ping timeout: 480 seconds]
18:31jkangas has joined #asahi-dev
18:48Mary has quit [Quit: .]
18:49Mary has joined #asahi-dev
19:00rivendell has joined #asahi-dev
19:01hdbngr has joined #asahi-dev
19:08rivendell has quit [Ping timeout: 480 seconds]
19:09rivendell has joined #asahi-dev
19:10hdbngr has quit [Ping timeout: 480 seconds]
19:11hdbngr has joined #asahi-dev
19:20hdbngr has quit [Ping timeout: 480 seconds]
19:29hdbngr has joined #asahi-dev
19:31bgb_ has quit [Remote host closed the connection]
19:31bgb has joined #asahi-dev
19:42i509vcb has joined #asahi-dev
20:05___nick___ has quit [Remote host closed the connection]
20:08DarkShadow4444 has joined #asahi-dev
20:08DarkShadow44 has quit [Read error: Connection reset by peer]
20:13bgb has quit [Remote host closed the connection]
20:13bgb has joined #asahi-dev
20:15Mary has quit [Quit: .]
20:16Mary has joined #asahi-dev
20:46john-cabaj has joined #asahi-dev
21:43john-cabaj has quit [Ping timeout: 480 seconds]
22:07hdbngr has quit [Ping timeout: 480 seconds]
22:56linuxgemini has quit [Quit: Ping timeout (120 seconds)]
22:56linuxgemini has joined #asahi-dev
22:59rivendell has quit [Remote host closed the connection]
23:50hdbngr has joined #asahi-dev
23:53john-cabaj has joined #asahi-dev
…