#
✕ nick:sven
#asahi-dev · 2022-11-15 10:39
svenI never though if z as a modifier which is why I could never remember the correct thing for size_t. that makes a lot of sense, thanks!
#asahi-dev · 2022-11-15 10:26
svenI’ll just drop the warn_on for now
#asahi-dev · 2022-11-15 10:26
svenbecause I changed the format again and never tested it :D
#asahi-dev · 2022-11-15 10:23
svenoh, and I still need to update the tunables format in m1n1. the current atcphy code supports both but I want to move the new format I have to be consistent with the thunderbolt/acio tunables
#asahi-dev · 2022-11-15 10:21
svenah, let me fetch again then
#asahi-dev · 2022-11-15 10:21
svenugh
#asahi-dev · 2022-11-15 10:21
svendrivers/gpio/gpio-macsmc.c:220:6: error: void value not ignored as it ought to be
#asahi-dev · 2022-11-15 10:21
svendrivers/gpio/gpio-macsmc.c: In function 'macsmc_gpio_event':
#asahi-dev · 2022-11-15 10:21
svenand you may need to do that if you're faster than the tps6598x thingy can negotiate the altmode
#asahi-dev · 2022-11-15 10:20
sveni think you can get away with just switching the phy mode from usb3-only to usb3/dp without shutting down dwc though
#asahi-dev · 2022-11-15 10:19
svenit's very subtle unfortunately and that's the only order that works reliably so far
#asahi-dev · 2022-11-15 10:19
svenotherwise it only works sometimes
#asahi-dev · 2022-11-15 10:18
svenand when shutting down first undo the pipehandler dance and then shut down the PHY
#asahi-dev · 2022-11-15 10:18
svenyou first need to bring up the PHY, then dwc3, then do the pipehandler dance when initializing
#asahi-dev · 2022-11-15 10:18
svenkettenis_: once you implement it make sure you get the order of what happens in usb3_mux_set and phy_power_on correct
#asahi-dev · 2022-11-15 10:16
sveni'll fix the license headers as well
#asahi-dev · 2022-11-15 10:15
svenjust copy/paste fail
#asahi-dev · 2022-11-15 10:15
svennope
#asahi-dev · 2022-11-15 10:13
svenbut I can just skip all that for now
#asahi-dev · 2022-11-15 10:13
svenhttps://lore.kernel.org/linux-usb/20221114174449.34634-1-sven@svenpeter.dev/ irq+fix + those are essentially only required if I want to apply my current altmode mess
#asahi-dev · 2022-11-15 10:12
svenwe don't need that altmode mess yet
#asahi-dev · 2022-11-15 10:12
svenbut i've just dropped my tipd fix commits for now and will just do a quick change that only does typec_set_mode
#asahi-dev · 2022-11-15 10:12
svendon't think greg sent the pull request yet
#asahi-dev · 2022-11-15 10:09
svenor I guess I just skip the additional tipd fixes and just do that 2 line mux commit
#asahi-dev · 2022-11-15 10:09
svenoh.. you have that other weird tipd irq fix in asahi-wip. let's see, i think jannau had a conflict resolution for that somewhere
#asahi-dev · 2022-11-15 09:56
svenlet me fix that statement above then: the way to get them right for local hacks is to compile and then just use whatever it tells you :P
#asahi-dev · 2022-11-15 09:55
svenpaddr_t and friends as well
#asahi-dev · 2022-11-15 09:55
svenfair enough
#asahi-dev · 2022-11-15 09:49
svenit's just about printf format specifiers. the way to get them right is to first just use %d, then compile and let the warning tell you what you should've used
#asahi-dev · 2022-11-15 09:48
svenalso very harmless
#asahi-dev · 2022-11-15 09:48
sveni think that one's marcan's fault :D
#asahi-dev · 2022-11-15 09:46
sventhat one should hopefully stick around this time and not get reverted by accident again
#asahi-dev · 2022-11-15 09:46
svenoh, right!
#asahi-dev · 2022-11-15 09:46
svenok, let me prepare something during this very important meeting :>
#asahi-dev · 2022-11-15 09:43
svenmarcan: so I guess the easiest way to prepare usb3 for you to merge is to just base it on the current asahi-dev? it's just a few commits so it shouldn't conflict with anything (revert the old role switch quirk, add the new role switch quirk, add atcphy, add two lines to tipd, device tree updates)
#asahi-dev · 2022-11-15 08:55
svenmost important new features: lights!
#asahi-dev · 2022-11-15 07:44
svenunfortunately It’s not a table so it’s a bit anoying
#asahi-dev · 2022-11-15 07:43
svensomeone needs to throw a t8112 kext into ghidra and extract like 10 bit locations for fuses
#asahi-dev · 2022-11-15 07:43
svensee #asahi-re
#asahi-dev · 2022-11-15 07:42
svenlet me prepare something later then
#asahi-dev · 2022-11-15 07:42
svenive been playing around with it the past days and can’t break it anymore
#asahi-dev · 2022-11-15 07:42
svenyeah, and that’s pretty damn stable
#asahi-dev · 2022-11-15 07:41
svenDP/dcpext is still much too unstable imho
#asahi-dev · 2022-11-15 07:40
svenI’ll prepare something for usb3/atc. No m2 support unless someone gets the fuses though
#asahi-dev · 2022-11-13 20:22
svenoh, that's fine. I was more thinking about understanding that typec subsystem a bit better and cleaning up my tipd hacks!
#asahi-dev · 2022-11-13 20:21
sven:<
#asahi-dev · 2022-11-13 20:13
svenalyssa: don't you want to get back into kernel stuff? I hear USB and type-c would be a good new project!
#asahi-dev · 2022-11-13 19:04
sventhat UCSI code is much more complex. guess i'll send a mail to heikki to ask if my code that bypasses all of the typec bus stuff like drivers/platform/chrome/cros_ec_typec.c does is acceptable to him as well
#asahi-dev · 2022-11-13 19:03
svenhttps://lore.kernel.org/all/20201126121713.GO1008337@kuha.fi.intel.com/ uh oh. so maybe my current typec/tipd code isn't quite what will be acceptable upstream :/
#asahi-dev · 2022-11-13 18:41
svenbut if anyone wants to give it a go i'll be happy to give some pointers in #asahi-re where to find them

plus ›