#
✕ nick:sven
#asahi-dev · 2022-02-15 20:17
svenstrange, I can reproduce it with the cpufreq driver as well
#asahi-dev · 2022-02-15 20:04
svenweird
#asahi-dev · 2022-02-15 19:59
svenyeah. nvmmu_inval might need a lock though to serialize the write/read sequence
#asahi-dev · 2022-02-15 19:57
svenI don’t think I need to serialize writes there. it’s not really a queue pointer but just “please start command with tag x”
#asahi-dev · 2022-02-15 19:46
svenlooks like I can’t reproduce it on the M1. Let me try with the cpufreq driver
#asahi-dev · 2022-02-15 19:39
sven-62 is timeout… so I guess the controller firmware doesn’t come up anymore? Weird
#asahi-dev · 2022-02-15 19:38
svenlooks like the reset even fails
#asahi-dev · 2022-02-15 19:36
svenit should only reset when completion polling didn’t find that command
#asahi-dev · 2022-02-15 19:36
svensure
#asahi-dev · 2022-02-15 19:33
svenso it doesn’t even completion poll the commands but they actually time out?
#asahi-dev · 2022-02-15 19:32
svenguess I jinxed it by claiming no one had any major issues ;)
#asahi-dev · 2022-02-15 19:29
svenhuh, don’t think I ever saw that one either
#asahi-dev · 2022-02-15 19:12
svenwe’ll have to figure out how to deal with the shared rtkit dependency but I guess in the worst case we just create an immutable branch somewhere so that both trees can merge it after review
#asahi-dev · 2022-02-15 19:10
svenjust waiting for marcan and smc
#asahi-dev · 2022-02-15 19:09
svenyeah, it’s also been tested by a few people for at least weeks (and sometimes even months) now without any major issues
#asahi-dev · 2022-02-15 18:55
svenI considered adding a pcie backend to apple nvme but that driver is imho already big enough for the initial submission
#asahi-dev · 2022-02-15 18:54
sven:-)
#asahi-dev · 2022-02-15 18:52
svenapple-nvme right now only works for platform devices fwiw
#asahi-dev · 2022-02-15 18:52
svenoh, I agree. But nvme requires this rtkit protocol that’s also required for smc. I’m just waiting for marcan to finish that part
#asahi-dev · 2022-02-15 18:48
svenI guess I could also re-submit that ugly usb hack
#asahi-dev · 2022-02-15 18:47
svenI already pinged him off-list last week or so
#asahi-dev · 2022-02-15 18:40
svenAt least I’m only responsible for maybe 10
#asahi-dev · 2022-02-15 18:40
sven:(
#asahi-dev · 2022-02-15 18:37
svenyeah… we’re carrying way too many patches right now.
#asahi-dev · 2022-02-15 18:22
svennice :)
#asahi-dev · 2022-02-15 18:20
svenyup
#asahi-dev · 2022-02-15 18:19
svenuh, sure
#asahi-dev · 2022-02-15 18:19
sven:D
#asahi-dev · 2022-02-15 18:16
svenif you already have a patch that’s working it’s probably the easiest to just submit it
#asahi-dev · 2022-02-15 18:07
svenaxboe: do you want to submit that tipd interrupt mask fix or should I do it?
#asahi-dev · 2022-02-15 17:32
svenjannau: it should’ve been clairvoyant and done that already ;)
#asahi-dev · 2022-02-12 22:30
sveneither way, axboe's interrupt mask fix is a good idea anyway
#asahi-dev · 2022-02-12 22:29
sventhat's fine the first time if it probed dwc3 before the cd321x
#asahi-dev · 2022-02-12 22:29
svenhrm, but that would always fail then
#asahi-dev · 2022-02-12 22:28
svenjannau: actually, usb/role.h has a stub for that function when !IS_ENABLED(CONFIG_USB_ROLE_SWITCH)
#asahi-dev · 2022-02-12 22:25
svenjannau: probably because the dwc3 controller was forced to host mode which will also break usb hot plug with the current workaround
#asahi-dev · 2022-02-12 22:23
svennice :)
#asahi-dev · 2022-02-12 22:12
sventhe probe function writes the irq mask pretty early and has lots of failure paths that don’t clean it up afterwards
#asahi-dev · 2022-02-12 22:11
svenI wonder why they are disabled though
#asahi-dev · 2022-02-12 22:10
sventhe other tps gets that “plug event” and pulls the irq line low but the kernel only checks the MagSafe tps one and doesn’t see any interrupts there
#asahi-dev · 2022-02-12 22:10
sventhat explains the “empty” irq status
#asahi-dev · 2022-02-12 22:07
svenokay, I wonder if the cd321x chips probe correctly if the dwc3 is in host mode only
#asahi-dev · 2022-02-12 22:05
svenokay, shot in the dark: do your USB ports work more than once? is the dwc3 controller running dual mode?
#asahi-dev · 2022-02-12 21:41
sven*on
#asahi-dev · 2022-02-12 21:40
sventhere should be a few that all trigger in the same interrupt
#asahi-dev · 2022-02-12 21:39
svenwait… why does only one interrupt thread do that?
#asahi-dev · 2022-02-12 21:39
sventhe interrupts are changed in the apple-variant but many other things are the same
#asahi-dev · 2022-02-12 21:38
svenhttps://www.ti.com/lit/ug/slvuan1a/slvuan1a.pdf
#asahi-dev · 2022-02-12 21:32
svenyeah, it can’t hurt to try..
#asahi-dev · 2022-02-12 21:32
sventhis irq is also shared across all tps chips. But I think we have them all declared in the device tree

plus ›