#asahi-dev · 2022-03-05 13:55
sventhanks, fixed!#asahi-dev · 2022-03-05 13:49
svenj`ey: added everything now hopefully https://github.com/AsahiLinux/linux/commit/dce2da78500b50ed35511fd0fc5a3f84732ad047#diff-cf630c5ac133b89cb3f8430da9f0e91ddd58685cee59406d9770572d5493b873R68#asahi-dev · 2022-03-05 13:45
svenusb 3-1: new high-speed USB device number 2 using xhci-hcd <-- why doesn't atcphy like me :-(#asahi-dev · 2022-03-05 13:42
svenalyssa: didn't we already volunteer jannau for this? :>#asahi-dev · 2022-03-05 13:42
svencan't hurt to add it i guess#asahi-dev · 2022-03-05 13:41
svenoh, it needs be there as well?#asahi-dev · 2022-03-05 13:40
svenhrm, though i guess i might need that module_device_table as well#asahi-dev · 2022-03-05 13:39
svenoh, you mean https://github.com/AsahiLinux/linux/commit/b703677f341fa6eec75aea96c0847257cd21217c#diff-cf630c5ac133b89cb3f8430da9f0e91ddd58685cee59406d9770572d5493b873R45? :P#asahi-dev · 2022-03-05 13:39
svenj`ey: what's 4ae85b2ba1debea2ce828ca24de73ce49e41e516?#asahi-dev · 2022-03-05 13:11
svenalyssa: uh.. and now i'm confused :D#asahi-dev · 2022-03-05 13:09
sventhe actual display-controller doing the scan out, not necessarily the DCP co-processor#asahi-dev · 2022-03-05 12:48
svenat least for the lane ones there isn't afaict. still need to check if the "always apply these after a reset" ones are applied in a different order for thunderbolt#asahi-dev · 2022-03-05 12:45
svenany opinion?#asahi-dev · 2022-03-05 12:45
svenbtw. regarding those tunables, I could either pass them through as apple,tunable-<apple-names> or merge some of those together. e.g. apple,tunable-ln1-usb which would contain USB_LN1_AUSPMA_TX_TOP, USB_LN1_AUSPMA_RX_TOP, USB_LN1_AUSPMA_RX_SHM and USB_LN1_AUSPMA_RX_EQ which are always applied in that order#asahi-dev · 2022-03-05 12:42
sventhat might just break horribly if you don't do a full reset anyway#asahi-dev · 2022-03-05 12:41
svenyeah, I'm mostly concerned about usb3 <-> thunderbolt transitions and stuff like that#asahi-dev · 2022-03-05 12:41
svenyeah... exactly#asahi-dev · 2022-03-05 12:41
svenbut we'll always need those mode-specific tunables anyway#asahi-dev · 2022-03-05 12:40
svenI could *probably* get away without the fuses and some tunables but I feel like there's a reason why macOS also tears down the entire atcphy when a cable is unplugged just like usb#asahi-dev · 2022-03-05 12:40
sventhough I think the main reason we wanted to avoid pulling all that crap into linux where tunables and fuses and well... we'll likely need those two for atcphy anyway#asahi-dev · 2022-03-05 12:38
svenyeah, that sounds reasonable#asahi-dev · 2022-03-05 12:35
svenhrm, i hope the pcie thing doesn't need the PHY init from m1n1 again#asahi-dev · 2022-03-05 12:21
svenlooks good then!#asahi-dev · 2022-03-05 12:19
svenoh wait.. reset does that, doesn't it?#asahi-dev · 2022-03-05 12:19
svenyou probably also need to restore that streams enable thing#asahi-dev · 2022-03-05 12:19
svennice!#asahi-dev · 2022-03-05 12:09
sveni guess it's time to yak shave instead of hacking on the kernel for now then :D#asahi-dev · 2022-03-05 12:08
svenhrm, yeah, that would work actually#asahi-dev · 2022-03-05 12:07
svenj`ey: yeah, it's just going to be annoying because i develop on macOs running on my macbook air and my target machine is the mini. so i'd have to reboot to the mini, sync files, compile there, sync files back, reboot again#asahi-dev · 2022-03-05 11:57
sven*header#asahi-dev · 2022-03-05 11:57
svenaaaand time to recompile the entire kernel again because I changed a head file. I really need to move to compiling on the M1 :D#asahi-dev · 2022-03-05 11:48
svenreconfig or however it's called#asahi-dev · 2022-03-05 11:48
svenbut i'd expect them to add the dart lock sequence to this hardware engine they have to restore some state like the boot vector at least#asahi-dev · 2022-03-05 11:47
svennow I wonder what state is kept if you go through this real deep sleep thing (the one that's worse than non-retention wfi)#asahi-dev · 2022-03-05 11:46
sventhey probably use that for SEP as well#asahi-dev · 2022-03-05 11:45
svenyeah, that would make sense#asahi-dev · 2022-03-05 11:45
sventhough I never tried what happens if I do this to another dart that i lock manually#asahi-dev · 2022-03-05 11:44
svenyou can still transition it to state 0x0 but it just keeps its state#asahi-dev · 2022-03-05 11:44
svenit was one of the things I tried to unlock the DCP dart :D#asahi-dev · 2022-03-05 11:43
svenyup, unless it's locked apparently#asahi-dev · 2022-03-05 11:36
svenbut even if you issue that identify ns list with nsid = 1 it replies different than what it's supposed to reply if it followed the nvme spec#asahi-dev · 2022-03-05 11:36
sven0xb is "invalid namespace" IIRC#asahi-dev · 2022-03-05 11:35
sventhe nvme core will fall back to just enumerating the namespaces#asahi-dev · 2022-03-05 11:35
sveni need to add a quirk for that I guess but it doesn't hurt#asahi-dev · 2022-03-05 11:35
sventhat message is normal though iirc#asahi-dev · 2022-03-05 11:35
svenhm....#asahi-dev · 2022-03-04 18:05
svennow I just wonder why I added it there in the first place#asahi-dev · 2022-03-04 18:01
svenI think it’ll just work if you just remove that call in apple_nvme_disable#asahi-dev · 2022-03-04 17:56
svenmarcan: I think the admin queue is marked as dying with blk_cleanup_queue and then it won’t allow allocating new requests there#asahi-dev · 2022-03-04 17:29
svenGoodnight!