#
…

2022-03-05

00:24loki_val has joined #asahi-dev
00:27crabbedhaloablut has quit [Ping timeout: 480 seconds]
00:30phire has quit [Remote host closed the connection]
00:31phire has joined #asahi-dev
00:37gruetzkopf has quit [Server closed connection]
00:37gruetzkopf has joined #asahi-dev
01:13yuyichao_ has quit [Ping timeout: 480 seconds]
02:17user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:20Emantor has quit [Quit: ZNC - http://znc.in]
02:20Emantor has joined #asahi-dev
03:31phiologe has joined #asahi-dev
03:34PhilippvK has quit [Ping timeout: 480 seconds]
03:59user982492 has joined #asahi-dev
05:06_alice is now known as arisu
05:11_alice has joined #asahi-dev
05:13ManuelQuinones[m] has joined #asahi-dev
06:29Gaelan_ has joined #asahi-dev
06:32Gaelan has quit [Ping timeout: 480 seconds]
06:50the_lanetly_052___ has joined #asahi-dev
06:59yuyichao_ has joined #asahi-dev
08:00j`eymaz: in the PCIe driver is this timeout a spec value, or just a reasonable timeout you chose https://github.com/torvalds/linux/blob/master/drivers/pci/controller/pcie-apple.c#L593 ?
08:25marcanrepro'd the wifi fail on j293 fwiw
08:25j`eyaccidentally?
08:26marcanjust immediately (hadn't been testing on that machine)
08:26marcanfwiw, the power gpio stuff is using spec values, but yeah, I don't know about the link timeout
08:26marcanOTOH, ideally we would just support hotplug and avoid having a timeout altogether
08:34___nick___ has joined #asahi-dev
08:34___nick___ has quit []
08:36___nick___ has joined #asahi-dev
08:53bisko has quit [Read error: Connection reset by peer]
08:55bisko has joined #asahi-dev
08:55user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:32the_lanetly_052___ has quit [Ping timeout: 480 seconds]
09:32gladiac has joined #asahi-dev
09:45jannaufinally a sio tracer without RegMonitor
09:46jannauthe keyboard controller get's at least told when the back light is switched on and off (binary)
09:47jannaunot with a HID message though but with one of the strange 4 byte long messages
09:53bisko has quit [Ping timeout: 480 seconds]
10:17kov has joined #asahi-dev
10:33trouter has quit [Quit: ZNC 1.8.2 - https://znc.in]
10:34trouter has joined #asahi-dev
10:52j`eybtw initcall_blacklist looks useful, for example: initcall_bla
10:52j`eycklist=apple_nvme_driver_init
10:55trouter has quit [Quit: ZNC 1.8.2 - https://znc.in]
10:56trouter has joined #asahi-dev
11:11j`eymarcan: disabling pcie and nvme, I get a resume from s2idle.. but then it appears unresponsive
11:12j`eythis is using the vuart with hv, so maybe there's an issue there, can try with the keyboard/fb in a bit
11:12marcanj`ey: vuart definitely shouldn't break... unresponsive as in no console?
11:13marcanbreakpoint it in the HV and see what it's doing? you might have to go through all CPUs
11:13marcan(there's no nice way to automate that right now due to the cpu switch command being a console exit behind the scenes... I just paste a pile of cpu(0)\nbt\ncpu(1)\n... )
11:13marcans/breakpoint/break/
11:13j`eyunresponsive in that when Im trying to type into picocom, no characters get written, which I think means the other end isnt accepting any?
11:14marcanprobably
11:14marcancheck the backtrace
11:14marcanmight just be deadlocked somewhere
11:14marcandoes the power button printk?
11:15j`eyno pressing the power button doesn't printk either currently
11:15j`ey - 0xffff800008761c4c (cpu_do_idle+0x8) is where it's currently at
11:15j`ey(I have smp=False, so only 1 CPU)
11:15marcanthat's weird
11:15gtk2 has joined #asahi-dev
11:15j`eyhm I also just noticed that the screen didn't turn back on
11:16marcanI wouldn't be surprised if various things break, but the vuart is, well, virtual
11:16j`eymacsmc-rtkit 23e400000.smc: RTKit: Message (id=1): ASSERTION FAILED: smc/apComms.cpp:219
11:17marcanis that after pressing the button a bunch of times?
11:17j`ey(im dumb, you dont get printks if.. your broken in the debugger and didn't 'cont')
11:17marcanlol yeah
11:17j`eypasting full output
11:17marcanit'll reboot soon :)
11:18j`eyand yes, just rebooted
11:19marcanI think you probably just overflowed the queue
11:19marcanif you pressed it enough times
11:19marcanso that's normal
11:20marcanbut anyway, that means it's alive
11:20marcantry trace_device("/arm-io/aic", True) and see if you get activity when you send the first UART character after resume
11:20marcanif you only get one burst of activity and no more, then that means suspend/resume in the samsung uart driver is likely broken
11:21marcanwhich wouldn't be entirely surprising, especially since I mucked with that for the runtime-pm stuff and never tested it
11:21marcanif you get nothing that could still be the UART driver is broken :)
11:21marcan(or the vuart emulation!)
11:23marcanif you want to trace vuart you have to do it in the C, since there's no way to trace it in python and still have the underlying emulation
11:24j`eyIm trying the trace_device now
11:24j`eybtw I think the screen does turn back on, but just doesn't redraw the logo maybe
11:25j`ey(the only thing that is on the fb is Tux, since I only have conosle=ttySAC0)
11:25j`ey(and I will put some prints in the vuart after this test)
11:26j`eyno output from trace when pressing a key
11:27j`eyIm tempted to revert 0a11aa08f94fdb2b21429c7a5c5c83124b85250a tty: serial: samsung_tty: Support runtime PM
11:28j`ey(although it's clearly working in some form since I get output, just not input)
11:28marcanoutput is easier than input :)
11:30j`eythat didn't help either
11:34marcan[ 15.689164] nvme-apple 393cc0000.nvme: ANS boot and NVMe init completed.
11:34marcan[ 15.689325] nvme nvme0: Identify NS List failed (status=0xb)
11:34marcansven: well it got further :-)
11:35j`eyis that with the blk_queue_disable thing removed?
11:35svenhm....
11:35sventhat message is normal though iirc
11:35sveni need to add a quirk for that I guess but it doesn't hurt
11:35sventhe nvme core will fall back to just enumerating the namespaces
11:36marcanah, then maybe it works
11:36marcanand indeed no serial
11:36sven0xb is "invalid namespace" IIRC
11:36svenbut even if you issue that identify ns list with nsid = 1 it replies different than what it's supposed to reply if it followed the nvme spec
11:37LuigyLeon[m] has joined #asahi-dev
11:38j`eymarcan: I tried with using console=tty0 and I resume works, so it's really a serial issue
11:38j`ey(so using the fb/keyboard of the mac)
11:40marcanj`ey: I think there's something wrong about resume
11:40marcan->complete isn't getting called in the smc driver
11:41j`eymarcan: macsmc_hid_pm_complete this one?
11:42null has quit [Server closed connection]
11:42null has joined #asahi-dev
11:42marcan[ 5.110194] apple-dart b02f80000.iommu: translation fault: status:0x81000001 stream:1 code:0x1 (NO TTBR FOR IOVA) at 0xfffec000
11:43marcansven: good chance that one is DART state getting lost across powergate, right?
11:43svenyup, unless it's locked apparently
11:44svenit was one of the things I tried to unlock the DCP dart :D
11:44marcanguessing the lock bit also makes it not powergate at all?
11:44marcanor maybe the powergating gets disabled elsewhere
11:44marcanas part of general iBoot stuff
11:44marcanpmgr definitely needs to have a pile of config settings somewhere
11:44marcanthere's no way all that power domain stuff is hardcoded in silicon
11:44marcanwe know e.g. ANE1 refuses to power on
11:44svenyou can still transition it to state 0x0 but it just keeps its state
11:45marcanyeah, and I bet the powergated bit never turns on
11:45marcanand it does for the other darts
11:45sventhough I never tried what happens if I do this to another dart that i lock manually
11:45marcanprobably still unlocks, I imagine it's a separate "never gate" bit in pmgr somewhere
11:45svenyeah, that would make sense
11:46sventhey probably use that for SEP as well
11:47svennow I wonder what state is kept if you go through this real deep sleep thing (the one that's worse than non-retention wfi)
11:48svenbut i'd expect them to add the dart lock sequence to this hardware engine they have to restore some state like the boot vector at least
11:48svenreconfig or however it's called
11:52j`eymarcan: that callback is called for me
11:53j`ey(that = macsmc_hid_pm_complete, put some printks to verify)
11:57svenaaaand time to recompile the entire kernel again because I changed a head file. I really need to move to compiling on the M1 :D
11:57sven*header
11:57mps has quit [Server closed connection]
11:58mps has joined #asahi-dev
12:05j`eyI get serial again with this + the revert
12:06j`eysven: you will cut your compile times down a lot, worth it!
12:07svenj`ey: yeah, it's just going to be annoying because i develop on macOs running on my macbook air and my target machine is the mini. so i'd have to reboot to the mini, sync files, compile there, sync files back, reboot again
12:07j`eyI was thinking a linux vm on the mba
12:08svenhrm, yeah, that would work actually
12:09sveni guess it's time to yak shave instead of hacking on the kernel for now then :D
12:17skrzyp has quit [Server closed connection]
12:17skrzyp has joined #asahi-dev
12:18marcanthat makes USB survive suspend/resume :-)
12:18marcansven: also you should use ccache
12:19svenyou probably also need to restore that streams enable thing
12:19svenoh wait.. reset does that, doesn't it?
12:21svenlooks good then!
12:24Ziemas has quit [Server closed connection]
12:24Ziemas has joined #asahi-dev
12:31marcanproper fix :)
12:32j`eymarcan: nice, how did you figure that out?
12:32marcanI looked at what resume was doing and noticed it was first restoring the IRQ flags in resume_noirq, then calling reset in resume which masked with ucon_mask
12:32marcanand was obviously undoing that
12:33marcanthose flags are apple-specific so it doesn't apply to other chips (though one other variant uses ucon_mask for something else)
12:33marcan(I actually introduced ucon_mask myself in the S5L patchset...)
12:34j`eyah nice, cool
12:34j`eyso just pcie left?
12:34marcanwhich might be more painful, but maybe not *that* bad since all the scaffolding for suspend/resume should already be there?
12:34marcanprobably apple-pcie just needs a huge pile of re-init ports en masse on resume?
12:35marcanand also figure out why brcmfmac outright blocks it
12:35svenhrm, i hope the pcie thing doesn't need the PHY init from m1n1 again
12:37j`eymarcan: pull & rebuilt & works, nice
12:38marcansven: if it does we can just stop powergating it for now, which we probably want to anyway for "normal" s2idle since people probably want wake-on-wlan?
12:38marcanand then punt it to full system sleep which will happen via m1n1 anyway
12:38svenyeah, that sounds reasonable
12:39marcanhonestly I'm surprised s2idle even tries to full sleep all devices like this
12:39marcanbut I guess it makes sense
12:39marcanbut there's probably some way to just mark pcie as "don't do that"
12:40sventhough I think the main reason we wanted to avoid pulling all that crap into linux where tunables and fuses and well... we'll likely need those two for atcphy anyway
12:40marcanso maybe it's time to bite that bullet
12:40svenI could *probably* get away without the fuses and some tunables but I feel like there's a reason why macOS also tears down the entire atcphy when a cable is unplugged just like usb
12:41svenbut we'll always need those mode-specific tunables anyway
12:41marcanwell... remember the usb2 nonsense...
12:41svenyeah... exactly
12:41marcanthe SS lanes do have redrivers
12:41marcanthough I want to say *that* doesn't have magic protocols
12:41marcanand is just straight through redriving
12:41marcanbut who knows...
12:41svenyeah, I'm mostly concerned about usb3 <-> thunderbolt transitions and stuff like that
12:41marcanmaybe there's some idle state signaling that confuses things
12:42sventhat might just break horribly if you don't do a full reset anyway
12:45svenbtw. regarding those tunables, I could either pass them through as apple,tunable-<apple-names> or merge some of those together. e.g. apple,tunable-ln1-usb which would contain USB_LN1_AUSPMA_TX_TOP, USB_LN1_AUSPMA_RX_TOP, USB_LN1_AUSPMA_RX_SHM and USB_LN1_AUSPMA_RX_EQ which are always applied in that order
12:45svenany opinion?
12:45marcanalso we have that power domain flag that says "never go below clkgate"
12:45marcanwe could use *that* for pcie and I'd hope that doesn't lose PHY state
12:46marcanthough that would introduce a DT compat break if we ever remove it, for older kernels
12:46marcanbut we might just never want to do that, and leave full PCIe powergate for deep sleep
12:47marcansven: I would merge
12:47marcanif there's nothing special to it other than them being applied in order
12:48svenat least for the lane ones there isn't afaict. still need to check if the "always apply these after a reset" ones are applied in a different order for thunderbolt
12:53kaprests has quit [Server closed connection]
12:53kaprests has joined #asahi-dev
12:58marcanso I'm getting about 5W power draw in suspend, which is not great. I wonder how much of that is the CPUs...
12:58marcanlet's see
12:59marcanso smp_start_secondaries makes *no* difference to power usage, which is using deep sleep, so at least now we know that's pretty good
12:59marcannow let me switch to light sleep
13:00lewurm has quit [Server closed connection]
13:00lewurm has joined #asahi-dev
13:02marcanok, that's about 100mA = 2W gone there
13:03marcanthat might make the case for doing an ugly hack in linux to support deep sleep for the time being, that's a significant win and should be trivial to just do as a throwaway patch
13:03_jannau_ has quit [Server closed connection]
13:03_jannau_ has joined #asahi-dev
13:04marcanletting the e-cluster go to sleep too saves us a bit more too
13:05marcanand then of course there's the screen, can't do much about that until the DCP driver is in place, but I bet that'll save a bunch of power too
13:05marcansince putting 3K onto the screen all the time can't be cheap, and in FB mode it has to keep refreshing from RAM, it can't know you didn't touch it
13:06j`eyeven with s2idle?
13:06marcanDCP doesn't know about s2idle
13:07marcanit's purely an OS-level thing
13:07marcananyway, with the deep sleep hack I would expect at least 24h of sleep battery life, which is enough to get you through randomly putting the laptop away for a day
13:07marcanmaybe more since these are USB-C level measurements, there's going to be some loss and some power spent on trickle charging the battery
13:07j`eyin this sentence, 'it' refers to DCP? "and in FB mode it has to keep refreshing from RAM"
13:09sventhe actual display-controller doing the scan out, not necessarily the DCP co-processor
13:09Glanzmannmarcan: kettenis meassured the screen power to be aroung ~ 1 Watts. (that is by toggling the backlight gpio).
13:10marcan>backlight
13:10marcanthese are two different things
13:10alyssasven: misread those registers as USB_L1NA_USPMA_TX_TOP and got very confused
13:10marcanI can tell you right now how much power the screen draws, actually
13:11svenalyssa: uh.. and now i'm confused :D
13:12j`eysven: right, makes sense
13:13jato has quit [Server closed connection]
13:13jato has joined #asahi-dev
13:25arctan95 has quit [Quit: Connection closed for inactivity]
13:32alyssamarcan: re backlight, it's my understanding brightness is controlled by the DCP?
13:37vitorbarth has joined #asahi-dev
13:38j`eysven: you might need something like 4ae85b2ba1debea2ce828ca24de73ce49e41e516 in the efuses driver
13:38marcanalyssa: yes
13:39svenj`ey: what's 4ae85b2ba1debea2ce828ca24de73ce49e41e516?
13:40alyssamarcan: brightness->DCP, blanking->GPIO? that's not annoying or anything ;-p
13:40marcanalyssa: no, everything DCP
13:40svenhrm, though i guess i might need that module_device_table as well
13:40marcanthe GPIO is a gross hack we use for now
13:40marcanwhich I'm pretty sure DCP controls itself
13:41j`eysven: and owner in the platform driver?
13:41alyssamarcan: what has to happen for DCP to show up in asahi/linux
13:41svenoh, it needs be there as well?
13:41marcanalyssa: it has to work on all the machines, and have notch aversion
13:42alyssai don't have anything but the mini, so -ENOTMYPROBLEM ;-p
13:42j`eysven: not sure, but I guess so *shrug*
13:42svencan't hurt to add it i guess
13:42marcananyway, turning stuff off I can get it down to 3.5W in m1n1, which is still kinda high but that's 21h battery runtime
13:42svenalyssa: didn't we already volunteer jannau for this? :>
13:42marcanlooking through SMC power counters now to see if I can spot some power hog
13:42alyssasven: right yes of course
13:45svenusb 3-1: new high-speed USB device number 2 using xhci-hcd <-- why doesn't atcphy like me :-(
13:45marcan#863: PRab = (flt , 0x85) 0.3517 <- that's 0.3W still going to the display somehow
13:45alyssasven: don't feel special atcphy doesn't like anyone
13:45marcanactually, not even, to disp0
13:46alyssamarcan: might still be scanout..?
13:46alyssalet me ballpark that
13:46alyssawhat's the screen resolution?
13:47marcan#863: PRab = (flt , 0x85) 0.0
13:47marcanit was DISPEXT still on
13:49* alyssawonders why she can't find data on memory bandwidth / power consumption anymore grumble
13:50j`eysven: looks like it!
13:54j`eysven: "Say y here to enabled suppor", enable not enabled
13:55sventhanks, fixed!
14:07Shiz has quit [Server closed connection]
14:07Shiz has joined #asahi-dev
14:11vitorbarth has quit [Read error: Connection reset by peer]
14:16marcanok, so the lowest I can get things is 3.3W, but there's like a whole 1W unaccounted for in the SPMU for some reason, so I don't know what that's about (assuming I guessed the SMC keys right, of course)
14:17marcanthat's 22h runtime
14:17marcanthen again, the way I brute force powered things down via PMGR and the PMU GPIOs may not be correct :p
14:21jannauthis sounds like I should make sure that the current dcp driver and m1n1 dcp changes are always on github
14:24marcanthere's about 1W going to the SoC CLVRs, which also doesn't sound right for mostly being idle
14:24marcanwell, could be pcie? let me nuke that
14:33marcananyway, dunno, will have to cross check this with osx and see if there's some magic that makes it use less power
14:34marcanmaybe PMP manages some of that, who knows
14:34marcanor maybe the RAM isn't configured to go into lower power states right now
14:35the_lanetly_052___ has joined #asahi-dev
14:42alyssajannau: yass
14:42alyssafeed me, DCP, feed me! :-p
14:46jix has quit [Server closed connection]
14:46jix has joined #asahi-dev
14:55psykose has quit [Remote host closed the connection]
14:55psykose has joined #asahi-dev
14:57psykose has quit [Remote host closed the connection]
14:57psykose has joined #asahi-dev
15:29akemin_dayo has quit [Remote host closed the connection]
15:30akemin_dayo has joined #asahi-dev
15:44XeR has quit [Server closed connection]
15:44XeR has joined #asahi-dev
16:11jannauminor merge conflicts in dart/dts, merged into AsahiLinux/asahi in https://github.com/jannau/linux/tree/asahi-dcp
16:12jannaunot much changed besides replacing the locked dart hacks with "/reserved-memory"
16:13jannauI squashed the macos 12 dcp ABI changes so you need to update
16:20maz has quit [Server closed connection]
16:23maz has joined #asahi-dev
16:31bisko has joined #asahi-dev
16:34the_lanetly_052__ has joined #asahi-dev
16:35jannauHV dcp tracing doesn't blow up on t600x. anyone willing to bet if the linux dcp driver will just work after adding the missing nodes to the device
16:37alyssathat seems like it would be too easy
16:39bisko has quit [Ping timeout: 480 seconds]
16:40the_lanetly_052___ has quit [Ping timeout: 480 seconds]
16:44j`ey has quit [Server closed connection]
16:44j`ey has joined #asahi-dev
17:06marcanjannau: at the very least the DVA offset is different, if that isn't a DT prop yet
17:09vup has quit [Server closed connection]
17:14jannaumarcan: not sure what you mean
17:15marcanthe offset that is added/ORed to DART IOVAs to yield RTKit DVAs
17:15marcanwhich is configured in the DAPF, but we don't inspect that
17:19jannauit's currently hard-coded in the driver but it fails already to power on dcp/rtkit
17:21jannaualso disp0 has only 5 instead of 7 registers
17:22bisko has joined #asahi-dev
17:22jannauat least the dart preserved memory setup works
17:24VinDuv has quit [Server closed connection]
17:25VinDuv has joined #asahi-dev
17:25marcando we even need to touch disp0?
17:30jannaudcpep_cb_rt_bandwidth asks for the two missing registers and we map the disp0 mmio regs for dcp
17:32marcanthe map is by index though, isn't it? IIRC
17:32marcananyway, I need to get some sleep, and I think I'll disconnect for tomorrow... it's apartment cleanup day ;)
17:34jannaugood night
17:34vup has joined #asahi-dev
17:38Nspace has quit [Server closed connection]
17:38Nspace has joined #asahi-dev
17:39tanty has quit [Server closed connection]
17:40tanty has joined #asahi-dev
17:52os has quit [Server closed connection]
17:53os has joined #asahi-dev
17:56sandyriver[m] has joined #asahi-dev
18:04agraf has quit [Server closed connection]
18:04agraf has joined #asahi-dev
18:07_andy_t_ has quit [Server closed connection]
18:08_andy_t_ has joined #asahi-dev
18:18ar has quit [Server closed connection]
18:19ar has joined #asahi-dev
18:28user982492 has joined #asahi-dev
18:34bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:35bisko has joined #asahi-dev
18:41chengsun has quit [Quit: Quit]
18:42chengsun has joined #asahi-dev
19:01jvsg[m] has joined #asahi-dev
19:01user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:02sandyriver[m] is now known as peer[m]
19:07alyssajannau: disp0 changing is an easy enough DT change, no?
19:09xerpi[m] has quit [Server closed connection]
19:09xerpi[m] has joined #asahi-dev
19:12bisko has quit [Remote host closed the connection]
19:13M1bn3mar[m] has quit [Server closed connection]
19:13M1bn3mar[m] has joined #asahi-dev
19:14bisko has joined #asahi-dev
19:18ella-0[m] has quit [Server closed connection]
19:18ella-0[m] has joined #asahi-dev
19:19jannaualyssa: still struggling with waking dcp up. even gone back to walking tables for dcp-dart
19:24alyssagood luck.
19:30bisko has quit [Ping timeout: 480 seconds]
19:41emilazy has quit [Server closed connection]
19:41emilazy has joined #asahi-dev
19:43HayashiEsme[m] has quit [Server closed connection]
19:43HayashiEsme[m] has joined #asahi-dev
19:48jevinskie[m] has quit [Server closed connection]
19:48jevinskie[m] has joined #asahi-dev
19:52kovmarcan, looks like defconfig is missing CONFIG_BACKLIGHT_GPIO and that breaks DRM now
19:54j`eybreaks it how?
19:56j`eyfrom the commit it looks like it should gracefully handle not having a driver for it
19:57Glanzmannj`ey: Maybe the same error CONFIG_BACKLIGHT_CLASS_DEVICE=y (fails if it is =m)
19:58kovj`ey, no DRM node in /dev, no messages in dmesg
19:59j`eyhm odd
19:59kovX failed to come up, tried weston, then I noticed the device nodes were missing, after a bit of banging my head against menuconfig I realized the new dt had the backlight stuff and could it be gpio_backlight missing? that made it work
20:01j`eylooking at 46ff9b5bb0a48baba8bd69db3b53a6604fcae160 makes it looks like that case should be handled
20:16user982492 has joined #asahi-dev
20:26dhewg has quit [Server closed connection]
20:26dhewg has joined #asahi-dev
20:26bisko has joined #asahi-dev
20:40fridtjof[m] has quit [Server closed connection]
20:40fridtjof[m] has joined #asahi-dev
21:07___nick___ has quit [Ping timeout: 480 seconds]
21:19jannausigh, it was the "apple,min-state = <4>;"
21:23jannausome power management magic, it was missing from the t6001 ps_disp0_cpu0 power state
21:23gladiac has quit [Quit: k thx bye]
21:32cde[m] has quit [Server closed connection]
21:32cde[m] has joined #asahi-dev
21:41svenouch. that essentially means “don’t powergate DCP” which is probably require because DCP isn’t completely shut down
22:59psykose has quit [Remote host closed the connection]
23:00psykose has joined #asahi-dev
23:01yuyichao has joined #asahi-dev
23:03yuyichao_ has quit [Ping timeout: 480 seconds]
…