#
✕ nick:sven
#asahi-dev · 2022-03-21 10:13
svenjust disable the watchdog? :D
#asahi-dev · 2022-03-21 10:04
svenyes, i'll also put something in the commit message.
#asahi-dev · 2022-03-21 09:14
svenall other coprocs I could probably exploit and take over in a weekend
#asahi-dev · 2022-03-21 09:12
svenwe can't patch the firmware. ANS specifically is locked away the same way SEP is
#asahi-dev · 2022-03-21 09:10
svenstill disappointing because i don't get the satisfaction of fixing some obscure race condition in the driver ;)
#asahi-dev · 2022-03-21 09:09
sventrue
#asahi-dev · 2022-03-21 08:47
svenmaybe it’s just that, but that would be disappointing :(
#asahi-dev · 2022-03-21 08:46
svenyeah, the interrupt only cares about the CQ
#asahi-dev · 2022-03-21 08:28
svenso it seems that if a new command is submitted while the interrupt is processed something strange happens sometimes. But I’ve been over that handler dozens of time and can’t find anything
#asahi-dev · 2022-03-21 08:28
sventhat lock is also taken in the interrupt handler fwiw
#asahi-dev · 2022-03-21 08:27
sven*I’d
#asahi-dev · 2022-03-21 08:27
svenif I can trust debug strings from the controller firmware it would panic if the fifo ever overflows. What is give to have documentation right now :(
#asahi-dev · 2022-03-21 08:26
sventhough iirc it was lost occasionally
#asahi-dev · 2022-03-21 08:25
sventhe weird part is that the write isn’t lost most of the time. it still reaches the controller and eventually the command results appears on the completion queue. It just doesn’t trigger an interrupt.
#asahi-dev · 2022-03-21 08:19
svenPart of me still thinks that ordering shouldn’t matter at all here since I shouldn’t even care if the write only becomes visible seconds later
#asahi-dev · 2022-03-21 08:18
svensure, worth a try to see what happens
#asahi-dev · 2022-03-21 08:07
svenand I still can’t reproduce it on my machine at all
#asahi-dev · 2022-03-21 08:05
svenwe thought it did at first but then Glanzmann managed to reproduce it again
#asahi-dev · 2022-03-21 08:05
svenadding a readl afterward the writel instead of the lock didn’t fix it
#asahi-dev · 2022-03-21 07:59
svengood thing I didn’t submit nvme yesterday, ofc the bot found yet another warning :D
#asahi-dev · 2022-03-20 20:09
sveni'll take a closer look tomorrow but it sounds like something with the usb role switch hack goes wrong
#asahi-dev · 2022-03-20 20:06
svenit's still weird that it even tries to do that though
#asahi-dev · 2022-03-20 20:06
svenoh, maybe that's why I don't see it
#asahi-dev · 2022-03-20 20:01
svenmaybe some of those missing pokes are required to make that part faster. i don't think there's any sleep(4.8s) anywhere in the code
#asahi-dev · 2022-03-20 20:00
svenyeah, that sounds wrong
#asahi-dev · 2022-03-20 19:59
svenhuh, it's actually ~5 seconds before it even says "new superspeed device". that seems wrong.
#asahi-dev · 2022-03-20 19:58
sven~5-6 seconds for me as well, but this is a slow HDD that actually has to spin up
#asahi-dev · 2022-03-20 19:57
sveni noticed it took a while but i assumed that was mostly because dwc3 has to recreate everything
#asahi-dev · 2022-03-20 19:57
svenhrm, i never checked how long it took for me
#asahi-dev · 2022-03-20 19:54
sveni don't see any unplug event there so it shouldn't even go down that path
#asahi-dev · 2022-03-20 19:54
svenor even more importantly, why does it even try to do that in early boot?
#asahi-dev · 2022-03-20 19:54
svenso why does dwc3 fail to reinit the core :/
#asahi-dev · 2022-03-20 19:52
sveni was a bit concerned that gen 2 needs some of the magic pokes I've just skipped
#asahi-dev · 2022-03-20 19:52
svenso that works as well, nice.
#asahi-dev · 2022-03-20 19:52
svenohh.... i also just realized that jannau's device is gen 2!
#asahi-dev · 2022-03-20 19:51
sveni've been doing this long enough, i know at this point that my code cannot be trusted :-P
#asahi-dev · 2022-03-20 19:51
sven;)
#asahi-dev · 2022-03-20 19:51
sven<sven> that's what I get for assuming my code just works there as well I guess
#asahi-dev · 2022-03-20 19:50
svenyeah, that one
#asahi-dev · 2022-03-20 19:50
svenoh
#asahi-dev · 2022-03-20 19:49
svenso that's why it doesn't want to do usb2 for atcphy0
#asahi-dev · 2022-03-20 19:49
svenhttps://github.com/AsahiLinux/linux/commit/edd8b87e1973b03d2a8ae654018e6a01cd1cc03e#diff-4ec98212264a78f99613cc50412966b95ae4f37367bcc01ce9d14fdfec19573fR1072 that should be -ENOENT
#asahi-dev · 2022-03-20 19:46
svenhrm, I wonder why it tries to shut down dwc3 so early
#asahi-dev · 2022-03-20 19:44
sventhat's what I get for assuming my code just works there as well I guess
#asahi-dev · 2022-03-20 19:44
svenah, probably that one fuse that atcphy0 doesn't need
#asahi-dev · 2022-03-20 19:43
svenhow did i break that
#asahi-dev · 2022-03-20 19:43
svenhuh
#asahi-dev · 2022-03-20 19:43
svenphy-apple-atc 383000000.phy: tunables and/or fuses not available; only USB2 will be supported
#asahi-dev · 2022-03-20 19:36
sven\o/
#asahi-dev · 2022-03-20 19:36
svenand I guess I should also clean up and push my m1n1 atc tracer

plus ›