#
…

2022-03-21

00:22kameks has joined #asahi-dev
01:26kameks has quit [Ping timeout: 480 seconds]
01:40kylealanhale has joined #asahi-dev
01:41kameks has joined #asahi-dev
01:53nico_32 has quit [Remote host closed the connection]
01:55nico_32 has joined #asahi-dev
01:59Zianther has joined #asahi-dev
02:02Zianther has left #asahi-dev [Leaving]
02:28phiologe has joined #asahi-dev
02:31PhilippvK has quit [Ping timeout: 480 seconds]
02:42roxfan has quit [Ping timeout: 480 seconds]
02:52riker77_ has joined #asahi-dev
02:57riker77 has quit [Ping timeout: 480 seconds]
02:57riker77_ is now known as riker77
02:58rikkaa has joined #asahi-dev
03:13RevHelix has quit [Quit: No Ping reply in 180 seconds.]
03:15RevHelix has joined #asahi-dev
03:22chadmed has joined #asahi-dev
03:27kov has quit [Quit: Coyote finally caught me]
03:27PhilippvK has joined #asahi-dev
03:27kov has joined #asahi-dev
03:30phiologe has quit [Ping timeout: 480 seconds]
03:42dougall has quit [Server closed connection]
03:42dougall has joined #asahi-dev
03:44lethalbit has quit [Server closed connection]
03:44lethalbit has joined #asahi-dev
03:49duckworld has quit [Server closed connection]
04:02riatre has quit [Server closed connection]
04:03riatre has joined #asahi-dev
04:04kameks has quit [Ping timeout: 480 seconds]
04:09pphilipss has quit [Quit: Deuces!]
04:09pphilipss has joined #asahi-dev
04:23ChaosPrincess has quit [Server closed connection]
04:23ChaosPrincess has joined #asahi-dev
04:29amw has quit [Server closed connection]
04:29amw has joined #asahi-dev
04:30_whitelogger has joined #asahi-dev
04:34zyroklarryfish[m] has joined #asahi-dev
04:35roxfan has joined #asahi-dev
04:36robinp has quit [Server closed connection]
04:36robinp has joined #asahi-dev
04:38kylealanhale has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:38kylealanhale has joined #asahi-dev
04:47kylealanhale has quit [Ping timeout: 480 seconds]
05:07Dcow[m]1guys, society pushed on me enough to decide use PyQt for installer GUI, instead of Flutter
05:07Dcow[m]1if marcan ok with that choice I am gonna start working today
05:08Dcow[m]1the second question, qml or widgets?
05:08rikkaa has quit [Quit: Connection closed for inactivity]
05:08Dcow[m]1s/qml/qtquick/
05:09Dcow[m]1sorry, forget about irc spam stuff. muscle memory to edit :(
05:21pphilipss has quit [Ping timeout: 480 seconds]
05:22tpw_rulesthat sounds kind of heavyweight
05:24Dcow[m]1the GUI itself or usage qt?
05:26tpw_rulesusing Qt for it
05:29Dcow[m]1well, installer downloads few gigs minimum, no? not a big deal to bundle qt
05:29PaterTemporalis has quit [Ping timeout: 480 seconds]
05:41chadmedid probably just use the python bindings for cocoa if i were you
05:41chadmedmeans all you have to bundle is pycocoa
05:41chadmedand retains a native as possible look in macos
05:42chadmedthe only other native gui toolkit they have over there is tcl/tk and i would not wish that on my worst enemy
05:42Dcow[m]1that's the option, yeah.
05:42kameks has joined #asahi-dev
05:42Dcow[m]1never used cocoa before
05:43Dcow[m]1empty window with pyqt - looks native enough for me
05:43chadmedoh qt picks up dark mode stuff now
05:44chadmedthats the thing i was most concerned about actually wrt "native" look
05:44chadmedlast time i played with it on macos it didnt pick up the system wide dark mode
05:46chadmedhm pyqt5 is only 40mb or so too anyway
05:46chadmedi thought it was larger than that
05:46Dcow[m]1that's from Figma - I was going to make it looks ~ like that
05:47chadmedfor a second there i thought you meant the japanese figurines
05:47nicolas17isn't the installer shipping its own Python? I doubt pyqt5 is larger than python itself and the stdlib...
05:47nicolas17so it should be fine
05:47Dcow[m]1yes, it's shipping python
05:47chadmedthat concept looks pretty nice, i like it
05:49nicolas17it's not universal binary, is it? :P
05:49Dcow[m]1do we really need to make in universal?)
05:49Dcow[m]1it's always gonna be arm64
05:50Dcow[m]1but I think it's universal now
05:50Dcow[m]1since there was bugreports about running it under Rosetta
05:50nicolas17no, on the contrary, I was asking if it was unnecessarily universal :P
06:19Dcow[m]1well, pyqt6 is about 150Mb
06:19Dcow[m]1if I install it to the package
06:20Dcow[m]1can be slimmed though, I don't need a lot from Qt
06:33alexandruchi[m] has joined #asahi-dev
07:16Dcow[m]1slimmed to 77
07:17r0ni has joined #asahi-dev
07:26Dcow[m]1now it's up to marcan to decide =)
07:27nicolas17 has quit [Ping timeout: 480 seconds]
07:29marcan77MB for the installer per se is a bit heavy tbh
07:30r0ni has quit [Quit: Textual IRC Client: www.textualapp.com]
07:31marcanhow much is it compressed?
07:31marcanthe installer right now is a 15MB tarball
07:31r0ni has joined #asahi-dev
07:32Dcow[m]1the whole tarball
07:34Dcow[m]1might slimmdown a little bit more
07:34MajorBiscuit has joined #asahi-dev
07:36Dcow[m]1well, to 42 lol
07:36Major_Biscuit has joined #asahi-dev
07:39Dcow[m]1not sure if I need QtMultimedia and QtHelp, removing this will slim about 7 mb I think
07:39Dcow[m]1uncompressed
07:40Dcow[m]141.2 tarball
07:42roxfan has quit [Ping timeout: 480 seconds]
07:43MajorBiscuit has quit [Ping timeout: 480 seconds]
07:46marcanis that with python too, or just the Qt bits?
07:47Dcow[m]137.4 the whole installer tarball with Qt
07:47Dcow[m]1and python, yes
07:48Dcow[m]1personally I can live with 40 mb installer
07:49Dcow[m]1it's gonna download a lot more while installing
07:59svengood thing I didn’t submit nvme yesterday, ofc the bot found yet another warning :D
08:04mazsven: catching up: what's the latest on the nvme lock thingy?
08:05svenadding a readl afterward the writel instead of the lock didn’t fix it
08:05svenwe thought it did at first but then Glanzmann managed to reproduce it again
08:07svenand I still can’t reproduce it on my machine at all
08:09mazright, but the writel()/readl_relaxed() could still be reordered as a pair (they can't be reordered between themselves -- same address, but the pair could be reordered wrt the rest of the code).
08:09rqou_ has joined #asahi-dev
08:10mazit'd be worth trying a full fat dma_mb() (which translates into dmb osh), and see if that sticks. but without understanding how that can ionfluence the rest of the stack, it's hard to reason about it.
08:18svensure, worth a try to see what happens
08:19svenPart of me still thinks that ordering shouldn’t matter at all here since I shouldn’t even care if the write only becomes visible seconds later
08:21mazthen it would mean that this writes races against something else and is somehow lost?
08:22mazis there a FIFO status that tells you whether it is safe to queue something?
08:25sventhe weird part is that the write isn’t lost most of the time. it still reaches the controller and eventually the command results appears on the completion queue. It just doesn’t trigger an interrupt.
08:26sventhough iirc it was lost occasionally
08:27svenif I can trust debug strings from the controller firmware it would panic if the fifo ever overflows. What is give to have documentation right now :(
08:27sven*I’d
08:28sventhat lock is also taken in the interrupt handler fwiw
08:28svenso it seems that if a new command is submitted while the interrupt is processed something strange happens sometimes. But I’ve been over that handler dozens of time and can’t find anything
08:39mazbut the interrupt only cares about the completion queue, right? what this avoids is concurrent writes of the SQ and CQ. maybe this is just working around a HW/FQ bug...
08:46svenyeah, the interrupt only cares about the CQ
08:47svenmaybe it’s just that, but that would be disappointing :(
08:52f-fritz[m] has joined #asahi-dev
08:59mazTBH, I can perfectly see how such a bug would occur if I was to write the firmware side of this.
09:10svenstill disappointing because i don't get the satisfaction of fixing some obscure race condition in the driver ;)
09:12Jamie[m]1consider: the satisfaction of reverse-engineering and patching the firmware
09:12svenwe can't patch the firmware. ANS specifically is locked away the same way SEP is
09:14j`eybut it isn't encrypted at least
09:14svenall other coprocs I could probably exploit and take over in a weekend
10:01mazsven: if anything, please put a comment close to the lock being taken on submission. it really is the sort of thing someone eventually will eventually try and remove.
10:04svenyes, i'll also put something in the commit message.
10:12j`eyis there a way to know if a reboot was due to the watchdog? I guess I can look at 'macsmc-reboot macsmc-reboot: PMU logged 5 boot error(s)' in dmesg and see if its 6 on next boot
10:13svenjust disable the watchdog? :D
10:13svenif it still reboots it can't be because of that thing then!
10:14j`eyyes, that was my next thing to try :P
10:18Dcow[m]1marcan: so, shall I start it using qt?
10:19marcanDcow[m]1: 37MB sounds reasonable enough for me, go for it :)
10:20Dcow[m]1yey. what do you think about dedicated installer channel? a-la #asahi-installer
10:21marcandepends on whether we end up talking a lot about it, we can figure it out as we go
10:21marcanalso I'm going to try to take it easy this coming week so feel free to hack on it on your own :)
10:23Dcow[m]1a few word about how are YOU see it would be great. it's been a long time since last time I am using Qt or python, lol)
10:24marcanI mean I'm a fan of Qt and the only reason I didn't immediately jump for that is I thought it'd be larger
10:25marcanI think in the future we should think about packaging this as a proper macOS app users can download and run "normally", and also run from USB (since USB mode runs as an app too), and probably also converge stage2.sh into using the same codebase / app
10:25marcanthat would make the whole experience a lot more flexible and nicer
10:26marcanthe most important part is that whatever you do has to run from recovery mode too, including with FileVault enabled, which has a few gotchas regarding libraries/etc
10:26marcanso make sure you test that configuration
10:28Dcow[m]1>> I thought it'd be larger
10:28Dcow[m]1I have slimmed most of Qt. I think we need only QtCore/QtWidgets.
10:35Dcow[m]1how much of logged info you would to see in UI? what essential?
10:39chadmedyou could just pipe the stdout/stderr of the "real" installer into a text box in the root window
10:40chadmedthat would make it easy for troubleshooting. if you catch the installer exiting on an error code you just throw a message saying "make a paste of the text below" or something
10:41chadmedyou could even hide this from the user unless theyre in expert mode *until* you catch an error and only show it then
10:42kameks has quit [Ping timeout: 480 seconds]
10:50c10l has joined #asahi-dev
10:51nuh^ has joined #asahi-dev
10:56AdryzzOLEDEdition[m]yea, even stuff like the ubuntu installer has a hidden box that shows console output that you can show with a click
11:04Dcow[m]1yeah, probably I will end up with something like that.
11:04Dcow[m]1There is such thing as QWizard/QWizardPage, it's essentially what we need, but it's looks so ugly...ugh
11:05Dcow[m]1that's why I wanted use Flutter - I can UI so quick and so good with it(
11:07AdryzzOLEDEdition[m]isnt flutter for desktop still in alpha
11:11chadmedgui is kind of painful no matter the toolkit tbh
11:11Dcow[m]1stable for Windows, beta for others. But I been using it for yeah on desktop already. it's in beta because it's not finished a little OS integrations things, but almost all already. If you don't need anything special - it's very stable.
11:12Dcow[m]1I am really enjoy making Ui in Flutter
11:12AdryzzOLEDEdition[m]i only tried it months ago and it was nice but i hate Dart
11:12Dcow[m]1try it some time
11:12AdryzzOLEDEdition[m]i am a opening/closing curly bracket on their own line kind of programmer
11:13Dcow[m]1hate Dart...why?
11:14Dcow[m]1so, dart format is the thing. just set it up other way.
11:14Dcow[m]1I can say the only thing I hate in Dart is threading
11:14AdryzzOLEDEdition[m]it is very java-like and the linter doesnt have an option for opening curly brackets on their own line
11:16AdryzzOLEDEdition[m]i am probably just experiencing some kind of trauma i had when trying out android studio years ago and Dart reminded me of it
11:17Dcow[m]1use it with VS Code next time, lol
11:18AdryzzOLEDEdition[m]i am on vscode, didnt explain myself properly:
11:18AdryzzOLEDEdition[m]years ago when i was 14 i tried android studio and my poor laptop was dying with 4GB of ram, and also i still don't understand how it all works
11:18bit_shifts has joined #asahi-dev
11:19AdryzzOLEDEdition[m]eventually i ran away from java and the whole mobile world
11:19AdryzzOLEDEdition[m]also we are on the wrong channel
11:19mps(for me text mode basic software is better than guis)
11:20gladiac has quit [Quit: k thx bye]
11:21gladiac has joined #asahi-dev
11:23chadmedlikewise, especially for this sort of thing
11:23chadmedbut it will be nice and Mac-like to have a GUI and also far more end user friendly
11:24chadmedconsider the average person who associates TUIs with either "hacking" or Dwarf Fortress
11:24AdryzzOLEDEdition[m]can't wait to get my hands on a mac
11:27bit_shifts has quit []
11:29chadmedi need to get my hands on more machines
11:29chadmedhopefully i can swipe a friend's j316c for a bit after he upgrades and then give it back to him
11:30bit_shifts has joined #asahi-dev
11:31bit_shifts has quit []
11:47marcanDcow[m]1: as much as possible should be logged to the log file, even more than the current code. The user doesn't have to see any of that but it would be nice to show them ~the same info as the current installer, though some details can be behind "details" type buttons
11:47marcanlike the detailed partition info is useful to have because nothing else has that, it's hell to find the same info in diskutil
12:00Dcow[m]1I am definitely going to save log file as it now
12:42kameks has joined #asahi-dev
12:43Thib[m]12 has joined #asahi-dev
13:09break has joined #asahi-dev
13:10PaterTemporalis has joined #asahi-dev
13:14joske_ has joined #asahi-dev
13:17joske_ has quit []
13:17joske has joined #asahi-dev
13:23break has quit [Quit: Konversation terminated!]
13:26chadmed has quit [Remote host closed the connection]
13:39yuyichao_ has quit [Ping timeout: 480 seconds]
13:59yuyichao_ has joined #asahi-dev
14:31nuh^ has quit [Ping timeout: 480 seconds]
14:47timokrgr2 has joined #asahi-dev
14:49timokrgr has quit [Ping timeout: 480 seconds]
14:49timokrgr2 is now known as timokrgr
14:49Glanzmannsven / maz: Can you send me patch, than I run it on my desktop for a few days and see if I can reproduce it.
14:50Glanzmannsven: Yay on the NVMe submit. :-)
14:50svenwhat nvme submit? and what patch?
14:50Glanzmannsven: I thought you wrote earlier that you submitted nvme upstream.
14:50svennot yet, just preparing everything
14:51Glanzmannsven / maz: I was referring to 09:10 < maz> it'd be worth trying a full fat dma_mb() (which translates into dmb osh), and see if that sticks. but without understanding how that can ionfluence the rest of the stack, it's hard to reason about it.
14:51GlanzmannIf you send me a patch or explain me how to do that, I run it on my desktop for a few days and see if I see the issue again.
14:51GlanzmannBy desktop I mean air ...
14:51svenadd dma_mb(); just below the writel if you want to test that
14:52svenbut we currently assume that the issue is actually concurrent writes to the SQ and CQ which then trigger a bug in the firmware. for that the lock would actually be the best solution
14:53GlanzmannOh, I see. Should I try anyway or do you consider it resolved?
14:54svencan't hurt i guess
14:54Glanzmannsven: Should I remove the 'readl_relaxed' below the writel or leave it?
15:07alyssa has left #asahi-dev [#asahi-dev]
15:10kameks has quit [Ping timeout: 480 seconds]
15:11joske has quit [Quit: Leaving]
15:36nicolas17 has joined #asahi-dev
15:45sveneither leave it and put the dma_mb after it or replace it with the dma_mb
15:45svenbut i expect that in either case the bug will still happen, possibly less frequent because the timing changes
16:00svenalright, https://github.com/AsahiLinux/linux/commits/nvme-rfc should be good enough for the first submission
16:13mazsven: just don't post it as "RFC". that's an awesome incentive for people to ignore patches. also, the merge window isn't the best time to post these things...
16:14svenok, so I guess wait until the merge window closes and submit it then?
16:15mazit really depends on the maintainer, but some become pretty annoyed about large series during the merge window (yours is pretty small, to be honest).
16:15mazI'd tempt it, but really drop the RFC part.
16:30nicolas17sven: can you share a m1n1 trace file for ANS or some other rtkit thing? I wanted to look into the protocol but uh I don't own M1 hardware >.>
16:30sventhere's no trace file for ANS rtkit, it's just text output
16:34sveni thought I only did whitespace changes in that nvme thing, but now it doesn't seem to boot anymore *sigh*
16:34svenlet's see what i messed up
16:35j`eywhat nvme thing?
16:35svennvme-rfc (which is actually nvme-v1 now)
16:36svencheckpatch complained about some whitespace issues that clang-format didn't catch and I fixed them
16:36svenbut apparently I also broke something else
16:37svenoh, lol, i'm just dumb
16:38sveni forgot that that branch doesn't have the device tree changes itself :D
16:39Glanzmannsven: I was about to tell you it is a missing config option. :-)
16:40jmr2 has joined #asahi-dev
16:41jmr2sven: I guess I know the answer, but could KCSAN helps with the NVMe race, now that it's available on arm?
16:42svenif it's actually a race is in the controller firmware it won't help
16:43svenbut doesn't hurt to enable it on my builds anyway i guess
16:43j`eytell me if you enable get a hang at boot, I have some KCSAN fixes
16:44svenactually, let me send out nvme out first :D
16:44svenotherwise i'll run into something and keep procrastinating that for another few months!
16:48jmr2 has quit [Quit: Page closed]
16:52svenaaand sent.
16:53j`eysven: 🎉
16:54Glanzmannsven: well done. :-)
17:01Darkmatter66 has joined #asahi-dev
17:05axboesven: thanks for writing an actual commit message :)
17:31nicolas17sven: oh, you mean the stuff you use in m1n1 to intercept ANS comms outputs parsed text directly?
17:44klaus has joined #asahi-dev
17:46klaus has quit []
17:46klaus has joined #asahi-dev
17:47klaus has quit []
17:47klaus has joined #asahi-dev
17:47klaus has quit []
17:54kylealanhale has joined #asahi-dev
18:15skipwich has quit [Ping timeout: 480 seconds]
18:19skipwich has joined #asahi-dev
18:23___nick___ has joined #asahi-dev
18:23___nick___ has quit []
18:25___nick___ has joined #asahi-dev
18:28m6wiq has joined #asahi-dev
18:28m6wiq has quit [Remote host closed the connection]
18:28m6wiq has joined #asahi-dev
18:32roxfan has joined #asahi-dev
18:48skipwich_ has joined #asahi-dev
18:49skipwich has quit [Read error: Connection reset by peer]
18:49skipwich_ is now known as skipwich
18:57skipwich has quit [Ping timeout: 480 seconds]
19:00marcansven: nice :)
19:01marcannicolas17: it's python, there's no serialized binary stream
19:01marcanit's a bidirectional protocol
19:01marcantherefore there is no "trace" file to speak of
19:01marcanthere is a stream of MMIO events, but then there are callbacks and explicit memory reads and things like that
19:01marcanso just the events wouldn't do you any good
19:02nicolas17reading the code it seems DCP trace files aren't quite a "raw binary dump" either :P
19:02marcanthe DCP trace files are text dumps of raw hex messages, at the command/response buffer level
19:02marcanwhich is quite a few layers above the ring buffers/memory buffers
19:02Major_Biscuit has quit [Ping timeout: 480 seconds]
19:02marcanthose are constructed by python
19:03marcanI added that feature because there was a lot of iteration in the DCP protocol/marshaling parsing and I didn't want to have to reboot macOS under the HV every time I changed something
19:05marcannicolas17: FWIW the DCP traces are a protocol only used by DCP
19:05nicolas17so that way at least some of the parsing is done "offline" later from the trace file and not during "capturing", right?
19:05marcanso they would not help you for any other ASC
19:06marcanthey could be parsed live, but I never bothered integrating that
19:06marcaninstead trace_dcp.py has its own, dumber, parser that only looks at function names
19:06marcanso there is some duplication there
19:07nicolas17okay so this is not as low level of a trace as I thought but could still be interesting... could you send me such a trace file if you have one laying around...?
19:08marcanthis is from january, probably 12.0.1?
19:11jannauhttp://www.jannau.net/dcp_mbp14_12.2.1.log this is from march 6th and macos 12.2.1
19:13nicolas17cool thanks both
19:15nicolas17jannau: btw, your server seems to be misconfigured and http://www... redirects to https:/www... (single slash)
19:16nicolas17curl deals with it anyway, wget gives a bizarre error :D
19:21jannauindeed, fixed. thanks
19:23kylealanhale has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:42turo_ has left #asahi-dev [Textual IRC Client: www.textualapp.com]
19:43turo has joined #asahi-dev
19:50LuEvers[m] is now known as lkvrsfld[m]
19:54r0ni has quit [Quit: Textual IRC Client: www.textualapp.com]
19:55kylealanhale has joined #asahi-dev
20:04marcannicolas17: feel free to send a PR :)
20:06nicolas17well I don't know if the first msg being overwritten is a problem
20:06nicolas17clearly the second one is what's being passed to Call()
20:07marcanI honestly don't remember off the top of my head how this works, so... :-)
20:08kettenismarcan: do you want to send the u-boot nvme timeout fix to the u-boot mailing list?
20:08marcankettenis: you can send it for me if you like :)
20:09kettenisthe commit subject does need a small tweak I think ;)
20:09kettenisso I can take care of it
20:14kettenisI think I'll send out that one and my mem layout fix now to see if that can still make the 2022.04 release
20:15kettenisand direct the other diffs to the -next branch
20:48m6wiq has quit []
20:49Darkmatter66 has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
20:54Darkmatter66 has joined #asahi-dev
21:01nicolas17oh dcp/ipc.py has two things called Call, I was *so* confused
21:06FarukAydn[m]I've never done kernel development before but I want to get into it somehow. Would TRYING to contribute asahi be a good option to do that?
21:07___nick___ has quit [Ping timeout: 480 seconds]
21:08kylealanhale has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:04pphilipss has joined #asahi-dev
22:25pphilipss has quit [Remote host closed the connection]
22:30nicolas17D414 = Callback(bool_, "sr_setProperty_int", obj=FourCC, key=string(0x40), value=InPtr(uint64_t))
22:31nicolas17the data I'm seeing has "FMOI" (probably the fourcc "IOMF" in little endian) but then the following 0x40 bytes are "bics_mode" + a few nulls + more garbage, I expected it to be all null-padded...
22:32nicolas17is this actual leftover garbage in memory because the client only writes bics_mode\0 and leaves whatever was left in the remaining bytes untouched?
22:51lockejan[m] has joined #asahi-dev
23:06kloenk has quit [Remote host closed the connection]
23:07kloenk has joined #asahi-dev
23:15* kevans91contemplates the merits of gluing gdbstub or similar into m1n1
23:16kevans91hmm, not sure off-hand how communication to that would look
23:18kevans91oh, you can do gdb over uart
23:43nicolas17ok I did get it parsed into <d[0x0] D414 ServiceRelay::sr_setProperty_int(obj='IOMF', key='bics_mode', value=0) but it seems there's 4 more bytes at the end (00 ff ff ff) and I don't know what they are
23:51gladiac is now known as Guest2767
23:51gladiac has joined #asahi-dev
23:54minecrell has quit [Quit: Ping timeout (120 seconds)]
23:55minecrell has joined #asahi-dev
23:57Guest2767 has quit [Ping timeout: 480 seconds]
…