#
✕ nick:sven
#asahi-dev · 2022-05-04 16:33
svenohhhhh…. I also just realized that I never sent out that PR because I confused myself with the test mail I just sent to myself *sigh*
#asahi-dev · 2022-05-04 16:31
svenand nice that it works now :-)
#asahi-dev · 2022-05-04 16:31
svenI guess we can send that as a follow up patch anyway.
#asahi-dev · 2022-05-04 14:24
sven:D
#asahi-dev · 2022-05-04 14:09
svenhuh, aren't there irqchips that need to talke to some i2c device to mask/unask/etc?
#asahi-dev · 2022-05-03 07:46
svenI’d also watch (at least in the background)
#asahi-dev · 2022-05-02 16:55
svencpufreq looks good to me. And surprisingly simple!
#asahi-dev · 2022-05-02 16:46
sveni've kept the _gpl now because it doesn't matter fwiw
#asahi-dev · 2022-05-02 16:46
sventags/asahi-soc-rtkit-sart-nvme-for-5.19 should be ready as well (and just point to asahi-soc/rtkit-sart-nvme)
#asahi-dev · 2022-05-02 16:05
svenyup, seems to work
#asahi-dev · 2022-05-02 16:03
svenlet's see, i guess i can send it just to myself to test
#asahi-dev · 2022-05-02 16:03
svenand at least --dry-run looks like it does the correct thing
#asahi-dev · 2022-05-02 16:03
svenyeah, i put subject, to/cc and a small message at the top
#asahi-dev · 2022-05-02 16:02
svenso, uh, i guess i can just use git send-email to send out pull requests as well? or is there any reason why that wouldn't work?
#asahi-dev · 2022-05-02 15:48
svensounds good to me
#asahi-dev · 2022-05-02 15:41
svenmarcan: https://f.svpe.de/1dade0ebfd84b92c4bb3a333c68dc7d07fd6aed331876695e2ccf0a59a1e41e6_0001-PCI-apple-Add-hotplug-support.patch maybe works but likely the wrong approach to get the re-scan working
#asahi-dev · 2022-05-02 15:40
svenmaybe we really need some linux-asahi mailing list. i'm sure i've forgotten people every now and then as well :/
#asahi-dev · 2022-05-02 15:35
svenand for port_down remove the devices and enable the LTSS again
#asahi-dev · 2022-05-02 15:34
svenbut tl;dr: just wait for the port_up interrupt and re-scan it
#asahi-dev · 2022-05-02 15:33
sveni can push that somewhere, you can clean it up and then just let whatever else down the line enable that pwren gpio
#asahi-dev · 2022-05-02 15:33
svenfwiw, i have some rather hacky pcie hotplug code
#asahi-dev · 2022-05-02 11:23
svenand now you know _why_ I don't stream :D
#asahi-dev · 2022-05-02 11:22
svenat least with git itself no-one usually notices when I mess up!
#asahi-dev · 2022-05-02 11:19
sveni'm always a bit afraid every single time i use send-email that something will go wrong. hasn't happened in a while but i bet the moment i get confident that i know how to use it i'll mess up again :D
#asahi-dev · 2022-05-02 09:04
sven:/
#asahi-dev · 2022-05-02 09:02
sven:D
#asahi-dev · 2022-05-02 09:01
svenwe're gonna write ~all things inside linux that use rtkit and sart anyway *shrug*
#asahi-dev · 2022-05-02 09:00
sveni don't really care about the exports fwiw, i only want BSD etc. to be able to re-use code from the drivers itself if possible
#asahi-dev · 2022-05-02 09:00
svenheh, so either i realized that back then as well and made the exports non-GPL in SART but those in rtkit GPL or I just got it right by accident :D
#asahi-dev · 2022-05-02 07:51
svenalso spi :-P
#asahi-dev · 2022-05-02 07:37
svenarnd: regarding nvme, do I send a v4 with the minor changes from v3, wait a few more days, and then send the pull request or do I send the pull request directly and only mention the changes in the tag description?
#asahi-dev · 2022-05-02 07:30
svennice!
#asahi-dev · 2022-05-02 07:24
sven:D
#asahi-dev · 2022-05-02 07:14
svena function called poll that calls peek which actually polls was a bit too weird for me ;)
#asahi-dev · 2022-05-02 07:11
svenyes, that’s why I kept it out for now
#asahi-dev · 2022-05-02 07:07
svensure
#asahi-dev · 2022-05-02 06:54
svenhm, maybe _that_ was the reason why I originally had them inside the SART driver as EXPORT_SYMBOL
#asahi-dev · 2022-04-30 08:31
sven*aes
#asahi-dev · 2022-04-30 08:31
svenso I guess keygen=1 allows to derive chip-specific keys that never leave the aws engine
#asahi-dev · 2022-04-30 08:30
sventhanks!
#asahi-dev · 2022-04-30 06:50
svenI wonder what key 3 is used for
#asahi-dev · 2022-04-30 06:50
svenkey 2 is just a guess fwiw, but it seems to be disabled and I’d expect the iboot key to be disabled when we get control
#asahi-dev · 2022-04-29 20:49
svenhttps://f.svpe.de/2222bacbad4e7ca44043bc1cfaaefa940ac04aa56c984cc5a1874b25903295f4_aes_m1_mini_sven2_fixed.txt / https://f.svpe.de/19dc117acc2def2fd4dad1dd2aac877d94cd09f2d8b7eb65a4e4a3e1ef22e275_aes.py
#asahi-dev · 2022-04-29 20:48
sven... and ofc there's a off-by-one error, that thing actually has three separate key mangling functions
#asahi-dev · 2022-04-29 20:45
svenjannau: found a key mangling function, can you try https://f.svpe.de/fe9bcf76d99ae223291fed90ef989780f8cd996f230765dc17c916e797fbcd33_aes.py and compare that with https://f.svpe.de/77d516175c5d2344c3695ad04cf2bc00899599028460de068c73f6eacd43c1c9_aes_m1_mini_sven2.txt?
#asahi-dev · 2022-04-29 18:04
svenyou got quite a nice collection of m1s there :-)
#asahi-dev · 2022-04-29 18:01
svenor maybe I got the key mask wrong but it didn’t do anything when I set bits above 3 (which should be key = 0 if the field is only 2 bits) and tried to program a key afterwards
#asahi-dev · 2022-04-29 17:59
svenkey 2 is probably the one that encrypts iboot and disabled and >=4 probably unused
#asahi-dev · 2022-04-29 17:57
svenok, so i guess key 1 is different for each chip then and key 3 is global for a chip family
#asahi-dev · 2022-04-29 17:18
svenlooks like it can do ~100-140 MiB/s while the arm64 aes instructions are ~850 MiB/s without cpufreq so it's probably useless for us anyway

plus ›