#
…

2022-05-02

01:00mimou has joined #asahi-dev
01:24user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:31yrlf has joined #asahi-dev
01:45mimou has quit [autokilled: Spambot. Don't mail support@oftc.net if you think this is in error. (2022-05-02 01:45:34)]
02:29phiologe has joined #asahi-dev
02:33PhilippvK has quit [Ping timeout: 480 seconds]
02:39user982492 has joined #asahi-dev
02:44wren^ has quit [Ping timeout: 480 seconds]
02:44wren^ has joined #asahi-dev
03:37kov has quit [Quit: Coyote finally caught me]
03:37kov has joined #asahi-dev
03:47nicolas17 has quit [Quit: Konversation terminated!]
04:09nicolas17 has joined #asahi-dev
04:18user982492 has quit [Read error: Connection reset by peer]
04:18user982492_ has joined #asahi-dev
04:28nicolas17 has quit [Ping timeout: 480 seconds]
05:34tawhidsgames[m] has joined #asahi-dev
05:39tawhidsgames[m] is now known as Tawhid[m]
05:54kgarrington has joined #asahi-dev
05:55kgarrington has quit [Remote host closed the connection]
06:02marcansven: please split off the MAINTAINERS changes for v4 :)
06:13marcanactually, this time you can get away without the nvme one
06:13marcanit's dwc3 and spi that conflict
06:33user982492_ has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:48user982492 has joined #asahi-dev
06:51marcansven: also is there a reason why all the RTKit symbols are _GPL when the driver itself is MIT?
06:54svenhm, maybe _that_ was the reason why I originally had them inside the SART driver as EXPORT_SYMBOL
07:05jannausven: I intend to send https://github.com/jannau/linux/tree/dart-t6000 tonight. I kept you as commit author and added myself as "Co-Developed-by:" for the two commits I changed. Is that ok?
07:11marcansven: ported smc to the new rtkit stuff; you're missing the apple_rtkit_poll() thing (which calls the peek nonsense), I assume that's deliberate? I'll probably send the mailbox cleanup and tack on the apple changes as one series later today
07:11marcan(at which point it will be called poll instead of peek)
07:11svenyes, that’s why I kept it out for now
07:14svena function called poll that calls peek which actually polls was a bit too weird for me ;)
07:17marcan[ 15.568940] macsmc-reboot macsmc-reboot: Issuing power off (off1)
07:17marcan[ 15.578488] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000
07:18marcankernel panic but it shuts down anyway
07:22marcanah, I think it's just supposed to never return?
07:23marcanyeah, same as restart, nevermind then
07:28marcanpushed new asahi & bits based on v5.18-rc5, with nvme-v3 and fixed up smc and mailbox stuff
07:28marcansmoke tested the smc stuff only
07:37svenarnd: regarding nvme, do I send a v4 with the minor changes from v3, wait a few more days, and then send the pull request or do I send the pull request directly and only mention the changes in the tag description?
07:41j`eymarcan: yay for new branch
07:45arndsven: if the changes are very small, just reply that you've folded in the obvious fix, and then send the pull request when you feel it's ready
07:49marcanarnd: if smc makes it in we can just send you another pull with it on top, right?
07:50marcanwonder how that review will go. it's a pile of (individually quite trivial) drivers in various subsystems, on top of a core mfd device... not sure if I should send the whole thing as one series (to provide context) or what
07:50marcaneither way the mailbox stuff has to go in first so I'll send that today
07:51marcanand also the PCIe GPIO stuff... and I have some other random patches I should just get rid of too
07:51svenalso spi :-P
07:52marcanand I wonder about the PMU MFD+nvmem stuff... kernel-wise it's independent from SMC but SMC is its only user, and this is assuming people like that approach, so maybe it should go in the SMC series too
07:53marcanI guess I can always just send a big fat series for context, see what first impressions I get, then if it doesn't need a complete rethink split it off for further reviews
07:53marcanalso I really should fix up that SPMI driver too
07:53marcanguess I'll go do that once I send the stuff that's ready today
08:13jluthra has quit [Remote host closed the connection]
08:14jluthra has joined #asahi-dev
08:34user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:43Telvana has quit []
08:43Telvana has joined #asahi-dev
08:48___nick___ has joined #asahi-dev
08:57marcansven: re _GPL, just realized mailbox stuff is _GPL
08:57marcanso that might mean we should keep all the rtkit stuff _GPL
08:59marcanI guess it makes sense from a licensing point of view to have a chain of GPL -> MIT -> MIT -> MIT drivers that have their exports poisoned to _GPL by the first one... but I'm not happy about it.
09:00svenheh, so either i realized that back then as well and made the exports non-GPL in SART but those in rtkit GPL or I just got it right by accident :D
09:00marcanoh well, at least the drivers themselves are MIT so it won't stop the BSDs et al from using them as long as they roll their own mailbox
09:00sveni don't really care about the exports fwiw, i only want BSD etc. to be able to re-use code from the drivers itself if possible
09:00marcanyeah, whatever
09:01svenwe're gonna write ~all things inside linux that use rtkit and sart anyway *shrug*
09:02marcansending the mailbox mess
09:03marcanwhy do I always screw up git send emails
09:03marcanI said --to-cover and I had a to: line, why didn't that go through?
09:04marcan... because I had a spurious newline
09:04marcanalso of *course* the broadcom guy bounced
09:04marcanI think I'm going to stop ccing any broadcom people
09:04marcanthey must have some serious churn over there
09:25marcanokay, sent out a bunch of my misc fixes
09:26marcannext the pci stuff
09:42marcanI'll send cpufreq too, because why not. Needs a binding though, let me do that.
09:43MajorBiscuit has joined #asahi-dev
09:46marcanactually, let me figure out if I can find the "current pstate" field real quick
09:47bisko has joined #asahi-dev
09:51marcanfound it, offset 0x50 has [actual][requested] in the low 4+4 bits
09:55bisko has quit [Ping timeout: 480 seconds]
10:25marcanfound the PLL coefficients too, and a last change timestamp. I'll throw them in the driver for doc purposes.
11:03marcanj`ey: bet you weren't expecting that one
11:03marcanalso sigh, typoed the CC: to lkml
11:03marcanI think git send-email will curse me to the end
11:03marcanthis one brought to you by me trying to use a shiny USB-C ethernet adapter I got a while ago and getting a pretty fireworks show
11:05marcanactually sigh, I messed that up
11:05marcanreally not my day today eh
11:05j`eymarcan: what is this non-asahi related stuff??? :P
11:07marcanwhat do you mean non-asahi related stuff? I fixed anker USB-Ethernet adapters to work on M1 Macs!
11:08marcan(and also fixed them to work on every other machine, but that's just a nice side effect)
11:08dottedmagmarcan: Does this device expose two Ethernet interfaces, one CDC-Ethernet and another custom?!
11:08marcanit exposes multiple configurations, two of which are standard CDC-Ethernet
11:08marcanCDC uses two interfaces per config
11:09marcanthen this vendor specific driver indiscriminately binds to both CDC interfaces, and tries to drive them as two vendor specific devices
11:09marcan(since CDC is the default config)
11:11j`eytypo in the commit message, missing 'v', "and comes back as a endor specific only device".. unless you mean a device that only works on Endor https://starwars.fandom.com/wiki/Endor :D
11:12marcanj`ey: fixed in v2 already
11:12marcan(which also fixed the cc and an actual code problem which I just forgot to amend)
11:19sveni'm always a bit afraid every single time i use send-email that something will go wrong. hasn't happened in a while but i bet the moment i get confident that i know how to use it i'll mess up again :D
11:22j`eysven: that sounds like using git in general
11:22svenat least with git itself no-one usually notices when I mess up!
11:23j`eysven: that's because you dont stream :P
11:23svenand now you know _why_ I don't stream :D
12:18kettenisthe EXPORT_SYMBOL_GPL() thing in non-GPL licensed files is always a bit weird, but from a copyright perspective I'm confident I can just ignore it as long as we don't have any GPL-only code in our kernel (which we don't)
12:20nyx_o has joined #asahi-dev
13:39yuyichao has quit [Ping timeout: 480 seconds]
13:53hir0pro has joined #asahi-dev
13:54yuyichao has joined #asahi-dev
14:25hir0pro has quit [Ping timeout: 480 seconds]
14:39hir0pro has joined #asahi-dev
14:40hir0pro has quit []
15:32marcanso much for the "easy" pwner gpio series. now we get to make deep changes to how the PCI subsystem probes devices.
15:33svenfwiw, i have some rather hacky pcie hotplug code
15:33sveni can push that somewhere, you can clean it up and then just let whatever else down the line enable that pwren gpio
15:34svenbut tl;dr: just wait for the port_up interrupt and re-scan it
15:35svenand for port_down remove the devices and enable the LTSS again
15:39kettenismarcan, looks like you didn't cc me on that series
15:39kettenisbut changing this now is a pain
15:40svenmaybe we really need some linux-asahi mailing list. i'm sure i've forgotten people every now and then as well :/
15:40kettenisand the way pcie works it really doesn't matter whether it is on the device itself or on the port node
15:44kettenisand if this were an actual pcie slot and the gpio would control the slot power, the port would actually be the right place fir the pwern-gpio
15:46marcankettenis: that's true, but it's also true that future devices could have multiple gpios for power sequencing or similar nonsense :(
15:46marcanand yeah, I really should get a ML setup
15:48marcanany objections to requesting a list there?
15:48svensounds good to me
15:50kettenisI would subscribe to such a list
15:52marcankettenis: if rob does want the gpio under the device, I can just have it in both places in our devicetrees for the time being, to make it less painful for you?
15:56kettenisyes, keeping both for 6 month or a year would allow users to easily upgrade across such a change
15:58kettenisputting the property on the device node makes it a bit ambiguous whether it is the responsibility of the pci bus driver or the actual device driver to turn on the GPIO
16:01kettenisbut letting the device driver control the GPIO doesn't really scale
16:02kettenisit also makes it hard to have the schema do the appropriate checks
16:02svenso, uh, i guess i can just use git send-email to send out pull requests as well? or is there any reason why that wouldn't work?
16:02marcanI usually edit them to put something at the top, but I dunno
16:03svenyeah, i put subject, to/cc and a small message at the top
16:03svenand at least --dry-run looks like it does the correct thing
16:03svenlet's see, i guess i can send it just to myself to test
16:05svenyup, seems to work
16:31MajorBiscuit has quit [Quit: WeeChat 3.4]
16:36marcanok, merged and pushed everything again
16:36marcanI think bits/130-cpufreq is submittable, if anyone wants to take a look
16:36marcanI'm going to sleep :)
16:46sventags/asahi-soc-rtkit-sart-nvme-for-5.19 should be ready as well (and just point to asahi-soc/rtkit-sart-nvme)
16:46sveni've kept the _gpl now because it doesn't matter fwiw
16:55user982492 has joined #asahi-dev
16:55svencpufreq looks good to me. And surprisingly simple!
17:15jato has quit [Quit: ZNC - https://znc.in]
17:17jato has joined #asahi-dev
17:42hir0pro has joined #asahi-dev
18:11hir0pro has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:30hir0pro has joined #asahi-dev
19:05hir0pro has quit [Quit: Textual IRC Client: www.textualapp.com]
19:44rqou__ has joined #asahi-dev
19:51rqou_ has quit [Ping timeout: 480 seconds]
19:57arti1208[m] has joined #asahi-dev
20:03wren^ has quit [Ping timeout: 480 seconds]
20:08___nick___ has quit [Ping timeout: 480 seconds]
20:28wren^ has joined #asahi-dev
20:48wren^ has quit [Ping timeout: 480 seconds]
20:48wren^ has joined #asahi-dev
21:12ep0x has joined #asahi-dev
21:13ep0xhi guys, is there any new
21:13ep0xupdate? i saw today commits on linux main branch
21:14j`eyit was a rebase onto 5.18-rc4
21:14j`eyand marcan sent out a bunch of patches to the mailing list for review
21:15ep0xit means we will get something fixed in this patch? :D
21:15j`ey*5.18-rc5
21:15j`eyno new fixes, just upstreaming of current features
21:16ep0xok mate, thanks for this info.
21:17ep0xJust to ask, where i can track about new fixes or new features, in Linux or in M1n1. repo?
21:17ep0xlike speakers on M1 pro 14'
21:19ep0xbtw i am using Asahi as everyday linux on M1, and for me biggest problem is display brightness, everything else i can wait without problem, but damn to much light in my eyes everyday :)
21:21j`eyep0x: you can try rebooting into macOS and dim it, and then reboot into linux.. apparently that worked for some
21:21user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:22mpsyes, this works
21:24j`eynot ideal of course :P
21:24ep0xwell i knew here is a lot of smart people!
21:26ep0xI didn't want to annoy ppl here with questions, but after using Asahi as everyday especially with high brightness, i had to come and ask :)
21:27ep0xand sure THANKS for your help and work guys! I wish i can help somehow for this project
21:27j`eyj annau is working on DCP, which will eventually be used to control brightness, but it's WIP
21:28ep0xfor now no1 did manage speakers to work?
21:29Dcow[m]1it's not safe yet. povik is the who working on audio.
21:29j`eyspeakers work on some models, but it's disabled for now
21:30ep0xi go to dim display in mac and reboot ill come with results ;) Thanks once again <3
21:31ep0x has quit [Remote host closed the connection]
21:35ep0x has joined #asahi-dev
21:35ep0xha! perfect, working as you said guys! Awesome
21:35ep0xi am currently on Asahi mac m1 pro 14''
21:48ep0x has quit [Remote host closed the connection]
22:07qdot has joined #asahi-dev
22:17user982492 has joined #asahi-dev
22:48user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:20user982492 has joined #asahi-dev
23:58nicolas17 has joined #asahi-dev
…