#
✕ nick:robher
#asahi-dev · 2025-08-13 13:41
robherjannau: Yeah, checkpatch needs to be updated. It just greps the bindings tree for a match. So "the" would be a "documented" compatible. I have a patch to make it use schemas, but then it is dependent on build artifacts. Maybe we just drop it as we have other ways to check now.
#asahi-dev · 2025-04-04 13:01
robhermaz: there's also the linux,pci-probe-only flag if keeping the firmware configuration is needed.
#asahi-dev · 2025-04-04 12:57
robhermaz: There's also a switch example on hikey970 (or 960 maybe?).
#asahi-dev · 2025-04-04 12:56
robhermaz: Certainly possible. PPC boots with all the PCI hierarchy described. The kernel can in fact generate the DT PCI nodes for you. Boot with CONFIG_PCI_DYNAMIC_OF_NODES enabled. Add what you need from the DT to your dts. Then add the GPIOs you need to handle.
#asahi-dev · 2023-09-21 21:09
robherI thought Linus was testing this for us in the merge windows. ;)
#asahi-dev · 2023-04-17 14:16
robhermarcan: I should also put in some sort of check/dependency. That's been on my todon't list for some time now. BTW, runs with TOT dtschema with Linus/next branches can be found here: https://gitlab.com/robherring/linux-dt/-/jobs
#asahi-dev · 2023-04-17 14:05
robhermarcan: might have been a stale processed-schema.json. If dtschema changes, it doesn't get updated.
#asahi-dev · 2023-04-17 14:01
robhermarcan: Do you have ea87f1eb4fd8 ("dt-bindings: arm: Allow 32-bit 'cpu-release-addr' values")? It's in 6.3-rc
#asahi-dev · 2023-04-17 13:57
robheryou're on 2023.04?
#asahi-dev · 2023-04-17 13:57
robhermarcan: I don't see any new DT warnings on mainline. Is this on an asahi based DT?
#asahi-dev · 2023-04-17 12:45
robhermarcan: I'll look into it.
#asahi-dev · 2023-04-10 17:51
robhermarcan: Again, talk to Robin as he understands the IOMMU interaction much better than I do.
#asahi-dev · 2023-04-10 17:49
robhermarcan: I think for 32-bit sizes we handle that case (DT with ~0 size).
#asahi-dev · 2023-04-10 17:44
robherby default
#asahi-dev · 2023-04-10 17:44
robherWith an iommu in the middle, I don't know if you can get all 64-bits.
#asahi-dev · 2023-04-10 17:43
robherA device that supports >32bit should set their mask to what they support (at the device, ignoring bus level restrictions)
#asahi-dev · 2023-04-10 17:41
robherAs for the specifics in of_dma_configure_id(), that's a conversation to have with Robin who is not here.
#asahi-dev · 2023-04-10 17:40
robhermarcan: generally, if you want anything other than all 32bit or all 64bit, then you need to use dma-ranges.
#asahi-dev · 2023-04-10 17:37
robhermarcan: a default greater than 32-bit mask would break lots of things.
#asahi-dev · 2023-04-03 21:32
robherkettenis_: IIRC, they are just passed to userspace. 'mount-matrix' is the property.
#asahi-dev · 2023-04-03 21:19
robherkettenis_: We already have floats in DT in a few places. They are encoded as strings.
#asahi-dev · 2023-03-18 02:41
robhermarcan: Seems fine to me. I'd drop the 'apple' at least for hid-country-code.
#asahi-dev · 2023-03-17 15:02
robher"/chosen" doesn't seem right to me either.
#asahi-dev · 2023-03-17 15:01
robherEveryone says HID is discoverable until it is not...
#asahi-dev · 2023-03-16 17:33
robhermarcan: working a bit intermittently this week... I would think similar issues exist for pinebook, QCom based laptops, etc. and we need a common solution. I'd lean toward having just an identifier in firmware and then userspace knows the mapping. Then the mapping is independent of type of firmware and users can tweak it if desired.
#asahi-dev · 2023-03-11 14:25
robhermarcan: I suppose the PD driver could prevent that assuming it's all one driver and instance. Otherwise, if your refcounts and actual h/w state are mismatched, kind of hard for s/w to do the right thing,
#asahi-dev · 2023-03-11 14:15
robhermarcan: It might be better to have some hint in the DT as to what domains are critical. Maybe simple-framebuffer node needs a power-domains property (though the display phandle link could provide that).
#asahi-dev · 2023-03-11 14:11
robhermarcan: That could leave domains powered forever if there is not a driver. It's a common problem because we never know 'all drivers are loaded' except for !CONFIG_MODULES
#asahi-dev · 2023-03-11 14:07
robherI think there's been some binding proposal for 'boot clocks'. It's been a while back.
#asahi-dev · 2023-03-11 14:06
robherAnd if it was on already at boot.
#asahi-dev · 2023-03-11 14:05
robherA shared clock (or parent) would have the same issue.
#asahi-dev · 2023-03-11 14:03
robherThat's probably broken for any provider. Or if you defer for provider A, and then provider B is disabled.
#asahi-dev · 2023-03-11 14:02
robherah
#asahi-dev · 2023-03-11 14:01
robhermarcan: only parent-child dependencies. The device that defers should have a dependency on the PD provider and not attempt to probe. But how is the PD turned off if its driver hasn't probed yet?
#asahi-dev · 2023-02-14 15:53
robherThat script should be in the dt-review-ci. On my phone ATM...
#asahi-dev · 2023-02-14 15:51
robhermarcan: all in gitlab.com/robherring/
#asahi-dev · 2023-02-09 14:19
robhermarcan, jeffmiw: Doubtful it is related to DT refcounting. refcounts should have no effect on static nodes which are *all* of them unless you are modifying the DT in the kernel.
#asahi-dev · 2023-01-28 13:32
robhermarcan: merging thru separate trees for bindings and dts is fine. That's been the norm, but schema warnings changes that.
#asahi-dev · 2022-12-14 19:41
robherpovik: children of root, 'simple-bus' or 'simple-mfd' nodes are automagic
#asahi-dev · 2022-12-06 23:51
robherjannau: Yeah, I think we need to split some common things out of ethernet-controller.yaml for wifi.
#asahi-dev · 2022-12-04 15:49
robhergot to run.
#asahi-dev · 2022-12-04 15:49
robhermarcan: bootloader version makes sense for /chosen
#asahi-dev · 2022-12-04 15:46
robherkettenis: True. That's generally for defining firmware interfaces the OS uses. Things that could be h/w, but happen to be implemented by firmware.
#asahi-dev · 2022-12-04 13:40
robhermarcan: yes, it's documented in dtschema. /chosen is configuration for the OS, so informational firmware versions doesn't really really seem appropriate. Idealy, there'd be appropriate device nodes to put stuff in. There's also the /options node.
#asahi-dev · 2022-11-19 00:22
robheralyssa: Only a hunch that I will be at some point. Unless krzk steals it from me. My only interest is having an external display...
#asahi-dev · 2022-11-18 23:47
robheralyssa: I hope my only involvement is reviewing the binding for it.
#asahi-dev · 2022-11-18 23:39
robherFWIW, I can boot with DCP enabled now. Seems it was the same problem I hit a while back with DART driver needing to be built-in. There's some dependency there fw_devlink is missing I think.
#asahi-dev · 2022-11-18 15:25
robherDoes m1n1 stage1 need to be updated or is updating stage2 (ESP) enough (when there's some change in h/w init)?
#asahi-dev · 2022-11-17 23:26
robherjannau: Right. Without the edge config, now it is booting for me.
#asahi-dev · 2022-11-17 22:49
robherjannau: humm, I guess I need a USB C to A cable. asahi-wip (6.1-rc1 based) from about a month ago boots but USB is deferred (presumably a new dependency in the DT missing the driver). The current asahi-wip with edge config does not.

plus ›