2023-02-14
00:09mkurz has quit [Ping timeout: 480 seconds]
00:15mkurz has joined #asahi-dev
00:19___nick___ has joined #asahi-dev
00:19___nick___ has quit []
00:21___nick___ has joined #asahi-dev
01:01DarkShadow4444 has quit [Quit: ZNC - https://znc.in]
01:01DarkShadow44 has joined #asahi-dev
02:03hightower2 has quit [Remote host closed the connection]
02:03hightower2 has joined #asahi-dev
02:47zef has joined #asahi-dev
02:54zef_ has quit [Ping timeout: 480 seconds]
04:31pthariensflame has joined #asahi-dev
04:31pthariensflame has quit []
05:00c10l9 has quit []
05:01c10l9 has joined #asahi-dev
06:00skmp__ has quit []
06:02md_ has joined #asahi-dev
06:13md_ has quit [Quit: Konversation terminated!]
06:15md_ has joined #asahi-dev
06:17md_ has quit []
06:44bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
06:59gladiac has joined #asahi-dev
07:25darkapex has quit [Remote host closed the connection]
07:29marcanjannau_: re the M2 series, feel free to respin it and I can try to get it in this week. For anything that's going through our tree that I authored (like the pmgr thing) I think I just need an r-b.
07:31marcanmaz_: assuming krzysztof doesn't insist on splitting the whole series into 15 subsystems (sigh... robher?) are you okay with me pulling in that aic2 change via soc? I think that patch is the only one that has any binding changes beyond strictly the compatible.
07:32jannau_marcan: I'll respin it today. I reviewed the pwr-states bindings patch. we need to find someone to review the devicetree patch
07:42bisko has joined #asahi-dev
08:01gladiac has quit [Quit: k thx bye]
08:11robinp has quit [Remote host closed the connection]
08:12robinp has joined #asahi-dev
08:17uartman_ has joined #asahi-dev
08:29seeeath has joined #asahi-dev
08:37seeeath has quit [Ping timeout: 480 seconds]
08:37MajorBiscuit has joined #asahi-dev
08:44bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
08:47maz_marcan: absolutely. binding changes that are backward compatible and that do not change driver code or existing behaviours are fine by me. just merge the damn sucker.
09:13stickytoffee has quit [Quit: brb]
09:30uartman_ has quit [Ping timeout: 480 seconds]
09:33seeeath has joined #asahi-dev
09:34bisko has joined #asahi-dev
09:37leitao has joined #asahi-dev
09:41seeeath has quit [Ping timeout: 480 seconds]
09:51uartman_ has joined #asahi-dev
09:52leitao has quit [Ping timeout: 480 seconds]
10:08leitao has joined #asahi-dev
10:31chadmedhttps://github.com/chadmed/speakersafetyd very very basic proof of concept for the model
10:51chadmed has quit [Remote host closed the connection]
10:53stickytoffee has joined #asahi-dev
11:00chadmed has joined #asahi-dev
11:21darkapex has joined #asahi-dev
11:21uartman_ has quit [Ping timeout: 480 seconds]
11:29ChaosPrincessadded support for compressing the recovery disk image to asahi-installer: https://github.com/AsahiLinux/asahi-installer/pull/178
11:31marcanI was going to ask whether you can unify it a bit with asahi_firmware/img4.py but... probably not worth it here.
11:31ChaosPrincessalso, i wouldnt mind someone looking at the rest of the z2 series :P
11:32marcanChaosPrincess: can you add a sanity check at the end? read the whole file through the transparent decompression, crc32 it and check against the zip metadata.
11:33ChaosPrincessi installed an os via it already and did a sha comparison for compressed vs uncompressed.
11:33ChaosPrincessbut can do that too
11:33marcanChaosPrincess: yeah, it's more like in case we run into corner cases on block boundaries and weirdness like that. always nice to have sanity checks when "interesting" processing is involved.
11:37jannau_ChaosPrincess: any preference on warning/clippy fixes and rustfmt for asahi-nvram? I'd like to package it and add it to asahi-meta to sync the bt pairing keys on first boot
11:38marcanmore than first boot even, should probably sync on every boot + shutdown in the other direction? otherwise if you add a device you end up with split brain again.
11:41ChaosPrincessjannau_: sure, sounds like a good idea.
11:42jannau_I wanted to start with the simple case of first-boot as syncing is obviously correct there
11:50marcanPSA: I'm going to try out $stuff with the DRM folks on the freedesktop.org gitlab. if it goes well we might move asahi-soc there.
11:51marcanarnd: I'll let you know if we do move and CC you on the MAINTAINERS update & notify linux-next (I think that's about it for things to do?)
11:53arndmarcan: yes, that should be fine. I tend to fast-track MAINTAINERS file updates through the fixes branch, so if you do the move now and I end up sending another fixes PR, it would be reflected in 6.2
11:54marcanack. I suspect it might take a bit longer, since we'll be playing games with CI and clang-format and such, but we'll see :)
11:55arndI don't have any other fixes queued at the moment though, and it's probably not urgent enough to send it to linus if it's the only other thing
11:55marcanI do have the M2 DTs pending for the regular process, can you get those in if I send you the pull on Thursday?
12:05poviksurprisingly it's not described here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html
12:05marcan`make dt_binding_check dtbs_check DT_SCHEMA_FILES=Documentation/..../foo.yaml` is what I use
12:06chadmedwe will need a way to know what sample rate the main pcm has been opened by $audio_server at since the visense pcm will refuse to be opened at any other rate
12:07jannau_'Documentation/..../' is not necessary, 'DT_SCHEMA_FILES=apple,sart.yaml' for example works as well
12:08marcanideally visense should be openable even without the main PCM open (and just stay idle), and ignore the samplerate
12:08marcanand then either we report the sample rate some other way (control?), or just don't and the daemon can guess from the timing of samples arriving
12:09povikalso i think there should be a way to figure out the rate the pcm will let you be opened in without brute force
12:09povikmarcan: you can open the visense pcm without main pcm running but i think alsa timeouts will shut you down
12:09marcanyeah, I plan to look into all this next time I do a stream about it (was going to be today but...)
12:09chadmedalsa-lib will let you query the pcm for supported rates (and by extension the rust bindings)
12:10marcanchadmed: I don't think trying to interlock the sample rates is a viable solution long term, it's inherently racy
12:10marcanwe want the safety daemon to just always be there, idling (and not keeping hardware awake) when nothing is using the playback pcm, and just be woken up with samples when there are some
12:10marcantrying to play PCM open/close games to match sample rates is a losing game for this use case
12:12marcanI mean we'll still need "a" sample rate for opening it, but it can just be fake or allow any of the valid ones or whatever
12:13marcanit'll be tricky getting all the flows right and making sure it acts as a subordinate and doesn't spuriously keep power domains on and things like that
12:13arndmarcan: it's really late for new content for 6.3, I would much prefer to have an intitial to merge by -rc4 rather than -rc8, with follow-up patches and fixes on top up to the merge window. I have a few other things going on this week, so it's possible that this will have to wait for 6.4, but I'll have a look when you send it
12:13povik13:13 <@marcan> it'll be tricky getting all the flows right and making sure it acts as a subordinate and doesn't spuriously keep power domains on and things like that
12:15chadmedyeah the only issue i see is the rate. re idleness we can just stop talking to visense when the speakers up indicator goes dark, and we can also block program flow on an empty sample buffer
12:16povikthe only issue are the alsa timeouts AFAIK, opening/closing the PCM but not having the sample rate race might be OK
12:16marcanmain thing is not closing the PCM because then you end up with corner cases around reopening it / add safety corner cases if something goes wrong when reopening it / etc
12:16marcanmuch better to leave it open and just deal with disabling whatever timeouts might get in the way
12:17marcanconsider a loaded system, the safety daemon gets the notification a bit late / runs late, then you get a weird "speakers are quiet for a split second" effect
12:18marcanincidentally, we probably want to make the safety daemon RT, and we need to make sure that doesn't trigger any overeager scheduling when the PCM is dark or demote it during that time
12:19chadmedit can definitely cut audio levels which is good but its erm.... very crude so needs refining
12:19povik13:17 <@marcan> consider a loaded system, the safety daemon gets the notification a bit late / runs late, then you get a weird "speakers are quiet for a split second" effect
12:19povikon second thought it's better if you get a weird effect rather than compromise safety on unresponsive daemon
12:20marcanfor the interlock, I was thinking of a raw control we write with the current CLOCK_MONOTONIC_RAW timestamp or something, periodically. if the kernel sees an out of whack update or no updates for 1 second, it goes into safety mode.
12:20marcanand then the kernel would keep track of PCM downtime and only require those updates within 1 second of the re-start
12:21marcanmain thing here is there's a window between the "unmute ramp-up/sound start" time and the "safety timeout" time
12:21marcanfor unmute you really don't want to spend ages on it, it kind of sucks when new sounds get cut off at the beginning (very persistent problem on some platforms)
12:23chadmedapple actually have a slight buffer and quick signal decay in userspace because these amps pop when you cut off their singnal too quick lmfao
12:24jnhmm, if there's a 1 sec grace period after sound output starts, it should probably be designed in such a way that a cycle of on for 995ms, off for 5ms (for example) doesn't bypass the safety requirement (you probably thought of that problem already)
12:25marcanjn: yes, my idea was that there's a 1 sec cumulative interval grace, and the daemon should itself have a timeout where after it stops getting samples it does one final update at the very least
12:41marcansven, jannau_, povik: can you tell me which branches from github are still relevant? I could transfer them all, but I think we have a lot of junk in there anyway so we might as well do some spring cleaning
12:45svenohhh. I remember now. I tried to create one and it didn’t get approved (or maybe I just didn’t get the email?)
12:48jannau_marcan: isn't it just lina sven and you with write access? dcp/sleep and dcp/wtf can be deleted as bits/200-dcp has the same functionality
12:49cylm has joined #asahi-dev
12:52sven“Not all browsers support WebAuthn. Therefore, we require that you set up a two-factor authentication app first. That way you'll always be able to sign in - even from an unsupported browser.” *sigh*
12:52jannau_is it intended that CI runs on ancient tags (4.13) Linus? https://gitlab.freedesktop.org/asahi/linux/-/pipelines
13:04marcanwill probably wait a bit and play around with CI and come up with a finished plan before pulling the trigger
13:06jannau_out-of-tree CI config is probably required for supporting a large number of linux subtree with CI
13:08jannau_the asahi tree cares about different things than the rest of trees and it would be hard to provide the CI infrastructure for that
13:08marcanI'm debating whether I want to split off asahi-soc into its own CI thing, since we probably want significantly different configs for that vs. the full downstream tree
13:09marcanjannau_: yes, but we can have something like drivers/soc/apple/.gitlab-ci.yml and throw our stuff then, and only our repo (which is configured to point there) would use it
13:26beeblebrox has joined #asahi-dev
13:38marcanfor now, let's start by trying out clang-format. I added an override file with some minor things.
13:38marcanhttps://gitlab.freedesktop.org/asahi/linux/-/commit/b86d4b879cd9d5d85955618f3c2002905cb031f4 (parent commit has the overrides)
13:39chadmed has quit [Remote host closed the connection]
13:40chadmed has joined #asahi-dev
13:41Cyrinux9 has quit []
13:44Cyrinux9 has joined #asahi-dev
13:52jannau_ has quit []
13:52jannau has joined #asahi-dev
13:54seeeath has joined #asahi-dev
14:09leitao has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
14:10leitao has joined #asahi-dev
14:21leitao has quit [Ping timeout: 480 seconds]
14:26leitao has joined #asahi-dev
14:41seeeath has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
14:42seeeath has joined #asahi-dev
15:37chadmed has quit [Remote host closed the connection]
15:38chadmed has joined #asahi-dev
15:48marcanrobher: is your DT checker bot script public somewhere? I'm thinking of setting up something similar as a GitLab CI
15:49marcanin particular whatever logic it uses to diff results to find new warnings/errors and such
16:15leitao has quit [Ping timeout: 480 seconds]
16:45ChaosPrincessi kinda partially locked myself out of that gmail account by losing my old sim card, and tried to use this newfangled b4 thingy :P
16:47ChaosPrincessneither did i
17:09stickytoffee has quit [Ping timeout: 480 seconds]
17:30winter has joined #asahi-dev
17:39stickytoffee has joined #asahi-dev
17:39stickytoffee has quit []
17:51MajorBiscuit has quit [Ping timeout: 480 seconds]
17:55rkjnsn_ has joined #asahi-dev
18:04seeeath has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:05seeeath has joined #asahi-dev
18:37neutrino2211 has joined #asahi-dev
18:45linuxgemini1 has quit []
19:32leitao has joined #asahi-dev
19:33leitao has quit []
19:38kesslerd has joined #asahi-dev
19:58mkurz_ has joined #asahi-dev
19:58kesslerd has quit [Ping timeout: 480 seconds]
20:01mkurz__ has joined #asahi-dev
20:04mkurz has quit [Ping timeout: 480 seconds]
20:07mkurz_ has quit [Ping timeout: 480 seconds]
20:22mkurz__ has quit [Read error: No route to host]
20:22mkurz__ has joined #asahi-dev
20:24mkurz__ has quit []
20:45zalyx has quit [Ping timeout: 480 seconds]
20:57chadmedpovik: the buffer which the samples are read into is an array of i16s. I convert them to 32-bit floats after the samples are in.
20:58chadmedmore accurately, i take the slice of samples relating to each speaker and convert the elements of that slice
21:02axboe has quit [Ping timeout: 480 seconds]
21:08___nick___ has quit [Ping timeout: 480 seconds]
21:10axboe has joined #asahi-dev
21:11poviksure, but there are no 16-bit floats nor 32-bit TDM slots in the picture, so that comment was just misleading
21:36mkurz has joined #asahi-dev
21:38mkurz has quit []
21:41kesslerd has joined #asahi-dev
21:45seeeath has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:46seeeath has joined #asahi-dev
21:46zalyx has joined #asahi-dev
22:07neutrino2211 has quit [Read error: Connection reset by peer]
22:23kesslerd has quit [Ping timeout: 480 seconds]
22:33seeeath has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:34seeeath has joined #asahi-dev
22:42hightower3 has joined #asahi-dev
22:44hightower4 has joined #asahi-dev
22:49hightower2 has quit [Ping timeout: 480 seconds]
22:52hightower3 has quit [Ping timeout: 480 seconds]
23:22darkapex_ has joined #asahi-dev
23:23darkapex has quit [Ping timeout: 480 seconds]
23:26seeeath has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:27seeeath has joined #asahi-dev
23:39seeeath has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:40seeeath has joined #asahi-dev
23:56axboemarcan: cc me on these things, I'm quite serious when I say I think this is a big deal and if my voice can add a bit of push back to the BS, then I'm more than happy to do so. I absolutely hate for this to be an unnecessary burden, seems like such a waste of time when that energy could be spent so much better on solving actual issues