#asahi-dev · 2025-06-29 16:26
martinrok I think that looks pretty good, I went back and fixed the strlen check too#asahi-dev · 2025-06-29 16:08
martinrnone of the added code will be used without a write to sysfs#asahi-dev · 2025-06-29 16:07
martinri think it makes sense to keep the rest of tipd working if there's an issue with the VDM feature, especially because a device reset won't help with the sysfs creation error#asahi-dev · 2025-06-29 16:03
martinrfirst kernel driver attempt so I appreciate the hints#asahi-dev · 2025-06-29 16:03
martinrthat makes sense #asahi-dev · 2025-06-29 16:02
martinrok, thanks#asahi-dev · 2025-06-29 16:00
martinrso entry creation should be near start of probe, right?#asahi-dev · 2025-06-29 15:55
martinrchaos_princess: sysfs entries should now be removed on all errors during probe, I don't see any dmesg messages when building as a built-in, feel free to verify if you'd like#asahi-dev · 2025-06-29 14:34
martinrok i think i see the fix#asahi-dev · 2025-06-29 14:10
martinrah you mean it is loading in too soon as a built-in?#asahi-dev · 2025-06-29 14:06
martinrloading in with insmod#asahi-dev · 2025-06-29 14:05
martinrmodule#asahi-dev · 2025-06-29 14:05
martinr...unless i dont understand when tps6598x_probe is called#asahi-dev · 2025-06-29 14:01
martinrit should only try to create the sysfs object when the module is loaded#asahi-dev · 2025-06-29 14:01
martinryeah I'm not sure what's going on there, can I get a full dmesg?#asahi-dev · 2025-06-29 13:59
martinrthanks#asahi-dev · 2025-06-29 13:59
martinrnice#asahi-dev · 2025-06-29 13:59
martinrare you getting anything on the serial console?#asahi-dev · 2025-06-29 13:30
martinri couldn't recreate the sysfs issue but we'll leave that for later#asahi-dev · 2025-06-29 13:28
martinrno rush#asahi-dev · 2025-06-29 13:27
martinrhttps://github.com/martinyrm/apple-cd321x-driver/blob/main/tipd/core.patch#asahi-dev · 2025-06-29 13:27
martinrchaos_princess: ok I don't think it's key related - I managed to reproduce the -1 error codes on my M1 MBA, and bumping up the VDM command timeout seems to help, would you mind trying again?#asahi-dev · 2025-06-29 12:30
martinrchaos_princess: thanks for the help anyways - i'll see if I can find anything more on the keys#asahi-dev · 2025-06-29 12:12
martinrhas macvdmtool been tested on t600x?#asahi-dev · 2025-06-29 12:10
martinrwhich is a bug I had encountered but is fixed on my end#asahi-dev · 2025-06-29 12:10
martinras for the spam, that is the sysfs object not being removed on device/module reload#asahi-dev · 2025-06-29 12:09
martinri expected the patching out the strlen check to work#asahi-dev · 2025-06-29 12:09
martinrchaos_princes: ok there is something quite different about the m1 pro then #asahi-dev · 2025-06-29 11:49
martinr*/dev/ttySAC0 for the back port i think#asahi-dev · 2025-06-29 11:41
martinrso I think we need to apply that patch to the tipd module on one device, connect the two M1 devices together with a USB3 cable (w/ SBU wires), then 'echo 1' to /sys/class/typec/port0/device/cd321x_vdm/serial - and then hopefully they should be able to talk to each other on /dev/ttySAC0 or /dev/ttySAC2#asahi-dev · 2025-06-29 11:34
martinrhttps://github.com/martinyrm/apple-cd321x-driver/tree/main#asahi-dev · 2025-06-29 11:34
martinrso I finally got around to finishing up VDM support for tipd - is anyone with a second M1 device interested in helping me test serial mode? my M1 iPad Pro does respond to VDMs, but doesn't appear to output anything over serial at boot-time unfortunately #asahi-dev · 2025-04-10 16:58
martinryeah that's the first place i looked #asahi-dev · 2025-04-10 16:47
martinrsven: great thanks :)#asahi-dev · 2025-04-10 13:53
martinr(i.e. J313AP for the M1 MBA)#asahi-dev · 2025-04-10 13:51
martinrjannau: ok great, currently i've got the unlock key hard-coded for my device (obviously undesirable) - is there a mechanism for accessing the mac device name from the kernel? (which is where the key is derived from)#asahi-dev · 2025-04-10 13:23
martinrsven: i've got an initial PoC of a tipd driver that can unlock the ACE chip and send VDMs (just tested remote device reboot so far). is this still needed/or is there interest in this feature? if so, I can spend some time extending it to the other VDM commands#asahi-dev · 2024-07-14 15:31
martinrjannau: great thanks, tidying up now#asahi-dev · 2024-07-14 12:24
martinrthere are other minutiae: currently tipd does not support resetting the cd321x. do we now send the unlock command on initialization and enable this functionality?#asahi-dev · 2024-07-14 12:05
martinrOk, I just managed to get initial VDM support added to tipd (i.e. just the reboot command working for now). I might need some input from somone on best practices re. interfaces (currently exposed via sysfs), as this is my first attempt at driver code.#asahi-dev · 2024-07-11 19:47
martinrhi - I'd like to work on extending tipd to add VDM/serial support. has anyone else already picked this up? just in the interest of avoiding duplicate work#asahi-dev · 2024-02-17 16:57
martinrunderstood, thanks#asahi-dev · 2024-02-17 16:52
martinrdoes anyone have a copy of the CD321x firmware? or a known ROM dumping method