#
✕ nick:marcan
#asahi-dev · 2022-11-03 02:09
marcanjust to appease him
#asahi-dev · 2022-11-03 02:09
marcanand I'm not going to make a mess of the code (putting the core into header files, what? that's supposed to be for inlining for performance, not because someone doesn't like the code in their tree)
#asahi-dev · 2022-11-03 02:08
marcanhe clearly has his own ideas about what being an mfd means, and they do not fit this particular combination of hardware platforms
#asahi-dev · 2022-11-03 02:05
marcanand I have no confidence left that we will find a solution that he finds acceptable that doesn't annoy *me* as the author and maintainer of this particular driver
#asahi-dev · 2022-11-03 02:01
marcanbut I think we're well past the point where it's worth arguing with lee just for the sake of replacing a for loop calling platform_device_register
#asahi-dev · 2022-11-03 01:59
marcanrmk: no, I was hoping to get this sorted out before trying to figure out how to do a T2 one (or for someone else to work on that from t2linux)
#asahi-dev · 2022-11-02 19:05
marcanI also have a dock-like thing that definitely does 3+DP
#asahi-dev · 2022-11-02 19:04
marcan(as well as the usual assortment of HDMI adapters of course)
#asahi-dev · 2022-11-02 19:04
marcanfwiw I just picked up a USBC 4K monitor that I *think* does USB3+DP, so I can test with that
#asahi-dev · 2022-11-01 17:58
marcan(please test etc)
#asahi-dev · 2022-11-01 17:57
marcanI should sleep :)
#asahi-dev · 2022-11-01 17:57
marcanpushed to asahi-dev
#asahi-dev · 2022-11-01 17:53
marcancherry picked anyway, but I'll push this build for now
#asahi-dev · 2022-11-01 17:52
marcanI just finished making a kernel build lol
#asahi-dev · 2022-11-01 17:45
marcanno
#asahi-dev · 2022-11-01 17:40
marcanI should probably also kick off some OS builds soon...
#asahi-dev · 2022-11-01 17:39
marcan*asahi-dev
#asahi-dev · 2022-11-01 17:39
marcanI also removed the mkinitcpio package override there
#asahi-dev · 2022-11-01 17:38
marcanI'm going to tag and release to asahi-wip, let's see how that goes.
#asahi-dev · 2022-11-01 17:38
marcandone.
#asahi-dev · 2022-11-01 17:37
marcanI need to draw the line somewhere
#asahi-dev · 2022-11-01 17:37
marcanyes, I know, but it's always "one more tiny thing" :)
#asahi-dev · 2022-11-01 17:36
marcandon't want to add any more variables
#asahi-dev · 2022-11-01 17:36
marcanChaosPrincess: I would but I'm kind of running behind on progress report / kernel update so I'm going to punt that one to next time, sorry. hopefully it won't be as long as this one though.
#asahi-dev · 2022-11-01 17:35
marcaneither way, I think that's *finally* release material soon
#asahi-dev · 2022-11-01 17:34
marcanI tested it setting the timeout to 2ms, it fails as you would expect but doesn't go into a spiral of doom
#asahi-dev · 2022-11-01 17:34
marcanin the meantime, it's pushed to asahi-wip with improved pasemi-i2c error recovery
#asahi-dev · 2022-11-01 17:33
marcanjannau: going to do a kernel build, do you have any DCP updates?
#asahi-dev · 2022-11-01 16:12
marcanunless Apple extended it or made it configurable (they probably did?)
#asahi-dev · 2022-11-01 16:12
marcanso that's... borderline for us, lol
#asahi-dev · 2022-11-01 16:12
marcanalso, the datasheet says the *hardware* timeout is 25ms (!)
#asahi-dev · 2022-11-01 16:12
marcanno, it doesn't reset
#asahi-dev · 2022-11-01 16:03
marcanand then the next problem is that when i2c *does* time out, it breaks forever and cannot recover
#asahi-dev · 2022-11-01 16:01
marcanah, because I'm dumb
#asahi-dev · 2022-11-01 15:59
marcan... why is cpufreq crashing on me now?
#asahi-dev · 2022-11-01 15:52
marcanah, easier then
#asahi-dev · 2022-11-01 15:51
marcanI'll send a fix
#asahi-dev · 2022-11-01 15:51
marcanit instead checks the timeout counter which is not touched
#asahi-dev · 2022-11-01 15:51
marcanyeah
#asahi-dev · 2022-11-01 15:47
marcanvery very broken
#asahi-dev · 2022-11-01 15:46
marcanthis is broken
#asahi-dev · 2022-11-01 15:46
marcanand the irq path does *not* actually check whether the timeout expired
#asahi-dev · 2022-11-01 15:44
marcan10ms is ridiculous
#asahi-dev · 2022-11-01 15:44
marcananyway, looking at other drivers, 100ms-1s seems to be common
#asahi-dev · 2022-11-01 15:44
marcanah, but that's for arbitration loss
#asahi-dev · 2022-11-01 15:43
marcanbut the i2c core has an actual timeout field too
#asahi-dev · 2022-11-01 15:43
marcanlol, like every driver has a random hardcoded timeout
#asahi-dev · 2022-11-01 15:42
marcanthis ought to be platform-specific
#asahi-dev · 2022-11-01 15:42
marcanI wonder if it's configurable somewhere
#asahi-dev · 2022-11-01 15:41
marcanyeah but we kept it with the irq support :p

plus ›