#asahi-dev · 2022-11-04 01:09
marcanrmk: re the last patch, I think the main Kconfig should also be moved under mfd, not just left as a dummy option#asahi-dev · 2022-11-04 01:08
marcani.e. having a cell does not imply having required DT documentation. that documentation should come with the driver itself, if that subdevice needs DT info.#asahi-dev · 2022-11-04 01:07
marcan(except rtc, rtc will need the nvram nonsense)#asahi-dev · 2022-11-04 01:07
marcanrmk: the other mfd cells are not expressed in the DT at all right now, and don't need to be. also I thought we agreed to drop the compatible for gpio?#asahi-dev · 2022-11-03 14:55
marcanChaosPrincess: no#asahi-dev · 2022-11-03 14:45
marcanjannau: in particular fan control is what I meant for the older machines, I don't see that there (and also all those keys need to be in the DT for DT platforms, or we need to just autodiscover somehow and shrug for non-DT platforms)#asahi-dev · 2022-11-03 14:07
marcanbut the only T2 I have semi-access to is a friend's main machine, so I can only borrow it for this stuff sporadically (and in particular right now probably not until next year)#asahi-dev · 2022-11-03 14:06
marcanthe T2 Macs with the ACPI backend are the bridge between both worlds, I think they can use more of the M1 subdevice work#asahi-dev · 2022-11-03 14:06
marcanfor the legacy backend I *could* pull out a positively ancient and slow as molasses Mac Mini I have lying around, or borrow a friend's old MBP. but it's entirely possible none of the current subdevice drivers will actually be useful on those platforms as-is (the big one that should work for all 3 is hwmon, not written yet, and maybe some hid/input stuff could be shared too?)#asahi-dev · 2022-11-03 14:04
marcan(I was hoping for someone to have some opinion on this; the original naming was inconsistent and I wasn't sure what to do about it, so thank you :p)#asahi-dev · 2022-11-03 14:03
marcanmacsmc_ all the way#asahi-dev · 2022-11-03 14:03
marcanyeah, I think its location in the tree implies that but the module wouldn't, so that's fair#asahi-dev · 2022-11-03 14:02
marcansmc_rtkit I think can stay named like that in platform/apple, though macsmc_rtkit would work too if you think it's better#asahi-dev · 2022-11-03 14:02
marcanthe mfd driver should be called macsmc (no core at that point)#asahi-dev · 2022-11-03 14:02
marcanand yes, he also agreed with that#asahi-dev · 2022-11-03 14:02
marcanhe also mentioned the smc cells stuff should be one line per cell#asahi-dev · 2022-11-03 14:01
marcananyway, glad we could get it resolved in the end#asahi-dev · 2022-11-03 14:01
marcan:)#asahi-dev · 2022-11-03 14:01
marcanhe picked it as the "least bad" solution :)#asahi-dev · 2022-11-03 14:00
marcanso no real changes vs. what we have now other than renaming/moving some bits#asahi-dev · 2022-11-03 14:00
marcanhe agreed to my proposal of moving smc_core into mfd/ and keeping smc_rtkit in platform/#asahi-dev · 2022-11-03 13:59
marcanwe had an IRC chat#asahi-dev · 2022-11-03 13:59
marcanrmk: I think you missed that I just talked with Lee, we're going with mfd#asahi-dev · 2022-11-03 13:12
marcanno rush, I should spend what's left of today drafting a progress report (finally)#asahi-dev · 2022-11-03 13:12
marcangot it#asahi-dev · 2022-11-03 13:09
marcan(I think you've done enough to help with this one, but I won't stop you if you want to see it through the end ;))#asahi-dev · 2022-11-03 13:09
marcanif you have a most recent tree with review comments, I can take care of merging it with whatever and resubmitting#asahi-dev · 2022-11-03 13:08
marcanrmk: do you want to work this out or should I take over and let you rest a bit from this one? :)#asahi-dev · 2022-11-03 13:08
marcansmc_core is going into mfd/ (named macsmc at that point)#asahi-dev · 2022-11-03 13:08
marcanin other news, I just had an IRC chat with Lee, looks like we resolved the MFD issue (cc rmk)#asahi-dev · 2022-11-03 13:07
marcanit doesn't make sense he'd name the series like that and then not do it#asahi-dev · 2022-11-03 13:07
marcanchadmed: let's see what he replies, might just be confusion#asahi-dev · 2022-11-03 13:06
marcanah, that didn't go out to asahi@ or me#asahi-dev · 2022-11-03 13:04
marcanI just see a single standalone patch v2#asahi-dev · 2022-11-03 13:04
marcanwait which series?#asahi-dev · 2022-11-03 13:01
marcan5/5?#asahi-dev · 2022-11-03 13:01
marcanok#asahi-dev · 2022-11-03 13:01
marcanahh#asahi-dev · 2022-11-03 13:01
marcanso wait, the patch description says it does allow opp-microwatt alone?#asahi-dev · 2022-11-03 13:00
marcanoh, fair#asahi-dev · 2022-11-03 12:58
marcanbut yeah, mailbox is... special :(#asahi-dev · 2022-11-03 12:58
marcanespecially once things get more than 1 consumer#asahi-dev · 2022-11-03 12:58
marcanthat happens all over the place#asahi-dev · 2022-11-03 12:58
marcansven: there's quite a bit of "this one thing was done in a dumb way recently without thinking about it, and needs to be redone"#asahi-dev · 2022-11-03 12:56
marcanchadmed: "I have included your patch in my series now, cc'd you." did he change his mind?#asahi-dev · 2022-11-03 12:55
marcangood thing is we can fix it#asahi-dev · 2022-11-03 12:55
marcanchadmed: bad engineering in kernel land is not uncommon :p#asahi-dev · 2022-11-03 12:55
marcanyeah... heh#asahi-dev · 2022-11-03 02:10
marcanso let's just drop the mfd dependency and stay in platform#asahi-dev · 2022-11-03 02:10
marcanin the end if we end up with everything split up weirdly, that will just mean more reviews and more acks to coordinate and honestly I don't really want to deal with him any more