#asahi-dev · 2023-02-14 12:21
marcanmain thing here is there's a window between the "unmute ramp-up/sound start" time and the "safety timeout" time#asahi-dev · 2023-02-14 12:20
marcanand then the kernel would keep track of PCM downtime and only require those updates within 1 second of the re-start#asahi-dev · 2023-02-14 12:20
marcanpovik: ^#asahi-dev · 2023-02-14 12:20
marcanfor the interlock, I was thinking of a raw control we write with the current CLOCK_MONOTONIC_RAW timestamp or something, periodically. if the kernel sees an out of whack update or no updates for 1 second, it goes into safety mode.#asahi-dev · 2023-02-14 12:18
marcanincidentally, we probably want to make the safety daemon RT, and we need to make sure that doesn't trigger any overeager scheduling when the PCM is dark or demote it during that time#asahi-dev · 2023-02-14 12:17
marcanconsider a loaded system, the safety daemon gets the notification a bit late / runs late, then you get a weird "speakers are quiet for a split second" effect#asahi-dev · 2023-02-14 12:17
marcanit can, but then you introduce a weird timing dependency there#asahi-dev · 2023-02-14 12:16
marcanmuch better to leave it open and just deal with disabling whatever timeouts might get in the way#asahi-dev · 2023-02-14 12:16
marcanmain thing is not closing the PCM because then you end up with corner cases around reopening it / add safety corner cases if something goes wrong when reopening it / etc#asahi-dev · 2023-02-14 12:15
marcan:)#asahi-dev · 2023-02-14 12:14
marcan(I honestly don't know how ASoC works)#asahi-dev · 2023-02-14 12:14
marcaneven better then :)#asahi-dev · 2023-02-14 12:13
marcanarnd: it can wait then (it's a pile of DT compatible additions + t8112 device trees)#asahi-dev · 2023-02-14 12:13
marcanit'll be tricky getting all the flows right and making sure it acts as a subordinate and doesn't spuriously keep power domains on and things like that#asahi-dev · 2023-02-14 12:12
marcanit'll probably need some ASoC changes or core ALSA changes to make this possible but eh#asahi-dev · 2023-02-14 12:12
marcanand the samples actually arrive at the rate determined by the playback sample rate#asahi-dev · 2023-02-14 12:12
marcanI mean we'll still need "a" sample rate for opening it, but it can just be fake or allow any of the valid ones or whatever#asahi-dev · 2023-02-14 12:11
marcanwe're just going to run into rare races that break audio for people#asahi-dev · 2023-02-14 12:10
marcantrying to play PCM open/close games to match sample rates is a losing game for this use case#asahi-dev · 2023-02-14 12:10
marcanwe want the safety daemon to just always be there, idling (and not keeping hardware awake) when nothing is using the playback pcm, and just be woken up with samples when there are some#asahi-dev · 2023-02-14 12:10
marcanchadmed: I don't think trying to interlock the sample rates is a viable solution long term, it's inherently racy#asahi-dev · 2023-02-14 12:09
marcanwe also need the safety interlocks etc#asahi-dev · 2023-02-14 12:09
marcanyeah, I plan to look into all this next time I do a stream about it (was going to be today but...)#asahi-dev · 2023-02-14 12:08
marcanand then either we report the sample rate some other way (control?), or just don't and the daemon can guess from the timing of samples arriving#asahi-dev · 2023-02-14 12:08
marcanideally visense should be openable even without the main PCM open (and just stay idle), and ignore the samplerate#asahi-dev · 2023-02-14 12:08
marcanchadmed: we need to rethink the whole samplerate thing anyway#asahi-dev · 2023-02-14 12:05
marcan`make dt_binding_check dtbs_check DT_SCHEMA_FILES=Documentation/..../foo.yaml` is what I use#asahi-dev · 2023-02-14 11:56
marcanif it's too late it's not a big deal anyway#asahi-dev · 2023-02-14 11:55
marcan(cutoff is this weekend right?)#asahi-dev · 2023-02-14 11:55
marcanI do have the M2 DTs pending for the regular process, can you get those in if I send you the pull on Thursday?#asahi-dev · 2023-02-14 11:54
marcanack. I suspect it might take a bit longer, since we'll be playing games with CI and clang-format and such, but we'll see :)#asahi-dev · 2023-02-14 11:51
marcanarnd: I'll let you know if we do move and CC you on the MAINTAINERS update & notify linux-next (I think that's about it for things to do?)#asahi-dev · 2023-02-14 11:50
marcanPSA: I'm going to try out $stuff with the DRM folks on the freedesktop.org gitlab. if it goes well we might move asahi-soc there.#asahi-dev · 2023-02-14 11:38
marcanmore than first boot even, should probably sync on every boot + shutdown in the other direction? otherwise if you add a device you end up with split brain again.#asahi-dev · 2023-02-14 11:33
marcanChaosPrincess: yeah, it's more like in case we run into corner cases on block boundaries and weirdness like that. always nice to have sanity checks when "interesting" processing is involved.#asahi-dev · 2023-02-14 11:33
marcanand yes, I know... too many things in my head atm, I really need a TODO list#asahi-dev · 2023-02-14 11:32
marcan(I think it has uncompressed crc32 in there)#asahi-dev · 2023-02-14 11:32
marcanChaosPrincess: can you add a sanity check at the end? read the whole file through the transparent decompression, crc32 it and check against the zip metadata.#asahi-dev · 2023-02-14 11:31
marcanI'll give it a spin next time I do installer tests#asahi-dev · 2023-02-14 11:31
marcanI was going to ask whether you can unify it a bit with asahi_firmware/img4.py but... probably not worth it here.#asahi-dev · 2023-02-14 11:30
marcanoooh nice!#asahi-dev · 2023-02-14 11:29
marcan(I'd say I can fix it myself but we do want his ack for that one on paper)#asahi-dev · 2023-02-14 11:28
marcanwhoops :/#asahi-dev · 2023-02-14 10:42
marcanno rush, ideally I get this applied on thursday or so#asahi-dev · 2023-02-14 10:40
marcanyeah, the big DT one#asahi-dev · 2023-02-14 09:25
marcanit's pushed to povik's repo#asahi-dev · 2023-02-14 08:47
marcan<3#asahi-dev · 2023-02-14 07:32
marcansven? :>#asahi-dev · 2023-02-14 07:31
marcanmaz_: assuming krzysztof doesn't insist on splitting the whole series into 15 subsystems (sigh... robher?) are you okay with me pulling in that aic2 change via soc? I think that patch is the only one that has any binding changes beyond strictly the compatible.#asahi-dev · 2023-02-14 07:29
marcanjannau_: re the M2 series, feel free to respin it and I can try to get it in this week. For anything that's going through our tree that I authored (like the pmgr thing) I think I just need an r-b.