#asahi-dev · 2023-05-09 14:38
marcan(also the daemon is missing idle catch-up but that just means it's too conservative)#asahi-dev · 2023-05-09 14:38
marcanin principle in the state it's in now, it can be tested end-to-end with pipewire and such, it's just that there is nothing keeping the speakers safe if the safety daemon dies#asahi-dev · 2023-05-09 14:37
marcanthat's the interlock thing#asahi-dev · 2023-05-09 14:37
marcannext time I will do the "make it fail safe" part#asahi-dev · 2023-05-09 14:37
marcantoday I did the "make it work" part of the kernel side#asahi-dev · 2023-05-09 14:36
marcanafter that it should be shippable in principle, except we still need to make and validate profiles for all the other machines and do a bunch of integration work before it really ships#asahi-dev · 2023-05-09 14:35
marcan:p#asahi-dev · 2023-05-09 14:35
marcanjust implementing an interlock mechanism for the mixer controls#asahi-dev · 2023-05-09 14:35
marcanhey next one will be more boring#asahi-dev · 2023-05-09 14:35
marcanaw#asahi-dev · 2023-05-09 14:33
marcanI left the speakers thing unstarted yesterday and felt bad about it :p#asahi-dev · 2023-05-09 14:33
marcanI did toot it!#asahi-dev · 2023-05-09 14:32
marcan(I still only somewhat get it, but hey, I made it work :p)#asahi-dev · 2023-05-09 14:32
marcan(today I spent most of the 5 hour stream trying to understand how all those pieces tie together...)#asahi-dev · 2023-05-09 14:31
marcan< povik> so we are probably not clearing the cpu_dai->rate of frontend <- that's fine because there are two frontends#asahi-dev · 2023-05-09 14:30
marcanwhy do I always have to fix USB problems everywhere? it's not like I wrote the virtual xHCI support in qemu, I absolutely did not...#asahi-dev · 2023-05-09 14:29
marcanalyssa, kettenis, jannau: I'm going to have to fix that u-boot splat myself aren't I#asahi-dev · 2023-05-09 11:09
marcanfeel free to hack on the code as much as you like#asahi-dev · 2023-05-09 11:09
marcananyway, going to get some dinner#asahi-dev · 2023-05-09 11:09
marcan:)#asahi-dev · 2023-05-09 11:09
marcanah ok#asahi-dev · 2023-05-09 11:08
marcanseems redundant but I dind't try removing it#asahi-dev · 2023-05-09 11:08
marcanbut that confused me, I don't get why that calls it#asahi-dev · 2023-05-09 11:08
marcanvia macaudio_fe_hw_params#asahi-dev · 2023-05-09 11:07
marcanit can#asahi-dev · 2023-05-09 11:07
marcanwhich is kind of overkill here#asahi-dev · 2023-05-09 11:07
marcanit's all kind of hacky but at least it fits into the existing framework without major changes, like new UAPI for rate change signaling#asahi-dev · 2023-05-09 11:06
marcanso it all works out#asahi-dev · 2023-05-09 11:06
marcanbut the macaudio driver nukes the rate set on the capture path, and if the DAI rate is 0 then the rate equality checks don't apply#asahi-dev · 2023-05-09 11:06
marcanon the core code (which I ended up not touching)#asahi-dev · 2023-05-09 11:06
marcanthe only reason it has to get the rate right if the other side is open is because there's a check in that path#asahi-dev · 2023-05-09 11:06
marcanyeah we just don't care basically#asahi-dev · 2023-05-09 11:05
marcanI did check that we drop the clocks and stuff even if the sense PCM is open#asahi-dev · 2023-05-09 11:05
marcanthere shouldn't be any downside to keeping the PCM open in theory#asahi-dev · 2023-05-09 11:05
marcanchadmed: that is possible but it introduces a race#asahi-dev · 2023-05-09 11:04
marcanbut eh#asahi-dev · 2023-05-09 11:04
marcanunfortunately there's no reasonable way to do driver-initiated hw_params feedback as far as I know, hence the mixer control feedback instead#asahi-dev · 2023-05-09 11:04
marcanI mean it could hardcode one and then that would fail#asahi-dev · 2023-05-09 11:04
marcanonce the PCM is running it doesn't matter any more#asahi-dev · 2023-05-09 11:03
marcanas long as it does that it works#asahi-dev · 2023-05-09 11:03
marcanrequired safetyd behavior is that it looks up the available rates then picks one (it will either get a range if the playback PCM is closed, or the playback PCM rate as a single supported rate if it's open)#asahi-dev · 2023-05-09 11:03
marcanthe dance with the sample rate is a bit awkward, but it does work in practice#asahi-dev · 2023-05-09 10:59
marcanit was a bit rough, but eh#asahi-dev · 2023-05-09 10:49
marcanthe pd stuff I got some nasty fault at some point, I suspect some path is trying to remove the device link twice so I just hardened all of those, but you may want to go over it#asahi-dev · 2023-05-09 10:48
marcanyeah#asahi-dev · 2023-05-09 10:48
marcanit's ASoC stuff#asahi-dev · 2023-05-09 10:48
marcanbackend#asahi-dev · 2023-05-09 10:47
marcannext the watchdog/lockout stuff. I think for that I'm going to use the existing kctl lock mechanism, I just need a new callback for lock/unlock so the controls can use that to take actions#asahi-dev · 2023-05-09 10:46
marcanand fixed the sample rate mismatch / read timeout issue (managed to do it entirely in macaudio, though perhaps in a hacky way)#asahi-dev · 2023-05-09 10:46
marcanI rebased your old series on the current kernel, fixed some stuff