2023-05-09
00:14Poplar has quit [Quit: leaving]
00:20sarucchi has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
00:30dax has joined #asahi-dev
00:31marcanwhat I meant is that ASoC at least seems to have a reasonable model to cover the combinations, while so many other niche SoC subsystems in the kernel kind of utterly fail at abstracting things out usefully
00:36zjstraus has quit [Ping timeout: 480 seconds]
00:39zjstraus has joined #asahi-dev
00:47zjstraus2 has joined #asahi-dev
00:51zjstraus has quit [Ping timeout: 480 seconds]
00:51zjstraus2 is now known as zjstraus
02:26psykose has joined #asahi-dev
02:32dax has quit [Quit: dax]
02:32dax has joined #asahi-dev
02:34psykose has quit [Remote host closed the connection]
03:02cylm has quit [Quit: WeeChat 3.6]
03:04cylm has joined #asahi-dev
03:21brolin has joined #asahi-dev
03:29brolin has quit [Ping timeout: 480 seconds]
03:47eiln has quit [Quit: WeeChat 3.8]
03:51cylm_ has joined #asahi-dev
03:54cylm has quit [Ping timeout: 480 seconds]
04:00cylm_ has quit [Ping timeout: 480 seconds]
04:01cylm_ has joined #asahi-dev
04:13sarucchi has joined #asahi-dev
04:20mlp has joined #asahi-dev
04:37mlp has quit [Ping timeout: 480 seconds]
04:39marcankettenis: is there some way we can skip u-boot USB init on laptops by default on internal installs? that will both speed up boot time and insulate us from USB stack brokenness a bit (which people keep running into...)
04:41marcan(or maybe once we get that Rust USB stack into m1n1 we should replace u-boot's stack with that too :p)
04:45mlp has joined #asahi-dev
05:08mlp has quit [Ping timeout: 480 seconds]
05:17mlp has joined #asahi-dev
05:25mlp has quit [Ping timeout: 480 seconds]
06:03psykose has joined #asahi-dev
06:17gabuscus has quit []
06:31cylm has joined #asahi-dev
06:33cylm_ has quit [Ping timeout: 480 seconds]
06:34gabuscus has joined #asahi-dev
06:35systwi has quit [Read error: Connection reset by peer]
06:36systwi has joined #asahi-dev
06:49cylm has quit [Read error: Connection reset by peer]
06:51bisko has joined #asahi-dev
06:52cylm has joined #asahi-dev
07:30wonjongbot has joined #asahi-dev
07:38wonjongbot has quit [Ping timeout: 480 seconds]
08:08Ziemas has joined #asahi-dev
08:09MajorBiscuit has joined #asahi-dev
08:14MajorBiscuit has quit []
08:14bps2 has joined #asahi-dev
08:15MajorBiscuit has joined #asahi-dev
08:15povikerr, s/the day of light/the light of day/, not sure why i keep writing this idiom the wrong way...
08:16povikanyway what i was getting at is that the lack of docs (in places) might be related to the usefulness of the abstraction
08:16povikso some of the details are made up on spot, and only in combinations of components that see actual use the details are worked out to compatibility
08:17povikthat's not to say ASoC isn't lacking in high-level docs, the lack of which isn't contributing to anything
08:19MajorBiscuit has quit []
08:20MajorBiscuit has joined #asahi-dev
08:31Ziemas has quit [Read error: Connection reset by peer]
08:33chadmed has quit [Remote host closed the connection]
08:47nsklaus has joined #asahi-dev
09:02c10l has quit [Quit: Bye o/]
09:03c10l has joined #asahi-dev
09:09chadmed has joined #asahi-dev
09:11chadmedbut i havent looked into it deeper than glancing over the commit that added the feature last night
09:17_jannau_I don't see how kwin should make a difference then unless you have additional color management
09:21chadmeditd be nice to eliminate the screen/a colour space mismatch and check on a known-good monitor but obv cant without dcpext
09:28kettenisunfortunately your last attempt to get marex to look into the usb induced crashes doesn't seem to have worked
09:29kettenismaybe time for me to finally come up with a diff to address at least the obvious problems with aborted usb transfers in the xhci host code
09:32hightower2 has quit [Ping timeout: 480 seconds]
09:35sarucchi has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
09:36kettenisI suppose we could call usb_init() from the board code based on whether we already have a keyboard or not
09:37chadmedjannau: true, and its not like i dont know what its meant to look like on this screen either. macos behaves properly
10:06psykose has quit [Remote host closed the connection]
10:12pjakobsson has joined #asahi-dev
10:13chadmed has quit [Remote host closed the connection]
10:16chadmed has joined #asahi-dev
10:35bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
10:46marcanpovik: ivsense fun stuff in https://github.com/AsahiLinux/linux/tree/sound/ivsense-improvements
10:46marcanand fixed the sample rate mismatch / read timeout issue (managed to do it entirely in macaudio, though perhaps in a hacky way)
10:47marcannext the watchdog/lockout stuff. I think for that I'm going to use the existing kctl lock mechanism, I just need a new callback for lock/unlock so the controls can use that to take actions
10:49marcanthe pd stuff I got some nasty fault at some point, I suspect some path is trying to remove the device link twice so I just hardened all of those, but you may want to go over it
10:49eiln has joined #asahi-dev
10:52povikfrom the looks of it there's at least the double free of apple_mca_release/mca_fe_disable_clocks
10:55poviki wanted to suggest we flip on ignore_pmdown time flag on all the PCM links from macaudio instead
10:58povikthat should be another way of fixing the shutdown ordering, but i have yet to try it and confirm that
11:00sarucchi has joined #asahi-dev
11:03marcanrequired safetyd behavior is that it looks up the available rates then picks one (it will either get a range if the playback PCM is closed, or the playback PCM rate as a single supported rate if it's open)
11:04chadmedis it not possible to have it only try opening the secondary pcm when the primary one is running with the speaker active kctl?
11:04marcanunfortunately there's no reasonable way to do driver-initiated hw_params feedback as far as I know, hence the mixer control feedback instead
11:06marcanthe only reason it has to get the rate right if the other side is open is because there's a check in that path
11:06marcanbut the macaudio driver nukes the rate set on the capture path, and if the DAI rate is 0 then the rate equality checks don't apply
11:07marcanit's all kind of hacky but at least it fits into the existing framework without major changes, like new UAPI for rate change signaling
11:08sarucchi has quit [Ping timeout: 480 seconds]
11:50chadmed_ has joined #asahi-dev
11:54chadmed has quit [Ping timeout: 480 seconds]
11:54alyssa has joined #asahi-dev
11:55stipa is now known as Guest931
11:55stipa has joined #asahi-dev
11:55alyssakettenis: With the build of U-Boot that Fedora Asahi is shipping, booting an M1 MacBook Air with certain type-C USB devices plugged in reliably causes a boot loop (requiring me to unplug the devices while booting and then plug back in once booted)
11:56alyssaSpecifically, if I have plugged in the "Apple USB-C Digital AV Multiport Adapter" ( https://m.media-amazon.com/images/I/31DDmAfrcvL._AC_SL1024_.jpg ), with power plugged connected, a USB Razer mouse plugged in to the type-A port, and no HDMI connection
11:58alyssa(There's nothing funny about the USB devices, it's a U-Boot bug, so it's unsurprising other devices are affected.)
11:58povikmarcan: fixup for build failures due to missing thread.atclr: https://github.com/povik/linux/commit/0edfac62e6ee7096aed06869387c28852364de96
11:58alyssaDifficult to get good debug output from this since it reboots as soon as it spits out a stack trace, but the problem starts at:
11:59cylm_ has joined #asahi-dev
11:59_jannau_most recent attempt to get this fixed: https://lore.kernel.org/u-boot/322414817369964463b2ffd89ff1989f@posteo.net/
12:00cylm has quit [Ping timeout: 480 seconds]
12:01Guest931 has quit [Ping timeout: 480 seconds]
12:03alyssaWondering if u-boot's approach of "be our own kernel and support everyone's hardware" is not great, actually >_>
12:05alyssa(my desktop is tethered boot... m1n1 is excellent and I had no idea how many issues that shielded me from until I got a macbook and installed what we ship and hit boot loops on my first day.)
12:12chadmed_alyssa: if you dont need any of what u-boot provides you can cat your kernel and initramfs directly to m1n1 stage 2
12:12chadmed_ is now known as chadmed
12:13_jannau_doesn't solve the problem of shipping the same problem to users and breaks on the next update
12:15alyssaI had no idea we were shipping "known to boot loop, end users hitting it in the wild, can't be fixed, good luck"
12:15kettenisultimately those that have the hardware that triggers the issue need to invest time, either by continuing nagging about this on the u-boot lists or fix the issue
12:15chadmedin the same way i have speakers enabled daily and the max volume bumped up in macaudio.c but wouldnt ship this to users in a billion years
12:16Shizalyssa: i've noticed a *bunch* of issues when configuring and compiling our own u-boot for $dayjob
12:18chadmedafaict the m1 air shares hardware with my 13" x86 macbook, but with a different chassis shape
12:18Shiz14:03:40 @alyssa : Wondering if u-boot's approach of "be our own kernel and support everyone's hardware" is not great, actually >_>
12:20chadmedassuming you have an m1 air leave it with me and ill see what i can do. i tried to get a start on those machines a while ago but the linux sound driver for the x86 macbook pro is out of tree and mega jank
12:25chadmedanyway with the mini unfortunately theres probably not a lot else i can do beyond whats there... the speaker is exceedingly crap
12:27chadmedthese new ones sound materially worse than a 2011 sandy bridge one i have in a cupboard somewhere
12:28chadmedi think the trick will be to have the psychoacoustic bass plugin so i can relax the cone a bit
12:30chadmedi suspect psychoacoustic bass will be a hard necessity on those machines for shipping to users just going by how much this 14" jiggled around before i brought up the opposed woofers
12:30chadmedthen again if they are indeed similar/identical hardware to the 13" i have then the woofers are pathetic enough that it doesnt matter
12:43reece has joined #asahi-dev
12:47yrlf has quit [Quit: The Lounge - https://thelounge.chat]
12:48yrlf has joined #asahi-dev
13:00reece has quit [Quit: Leaving]
13:23brolin has joined #asahi-dev
13:24hightower2 has joined #asahi-dev
13:28darkapex has quit [Remote host closed the connection]
13:37brolin has quit [Ping timeout: 480 seconds]
13:41brolin has joined #asahi-dev
13:46crabbedhaloablut has quit [Read error: Connection reset by peer]
13:47crabbedhaloablut has joined #asahi-dev
13:49bisko has joined #asahi-dev
13:52povikhttps://patchwork.kernel.org/project/linux-wireless/patch/1471360704-10507-2-git-send-email-jakub.kicinski@netronome.com/
14:13bcrumb has joined #asahi-dev
14:30marcanwhy do I always have to fix USB problems everywhere? it's not like I wrote the virtual xHCI support in qemu, I absolutely did not...
14:31marcan< povik> so we are probably not clearing the cpu_dai->rate of frontend <- that's fine because there are two frontends
14:32marcan(today I spent most of the 5 hour stream trying to understand how all those pieces tie together...)
14:33fredmb has joined #asahi-dev
14:36marcanafter that it should be shippable in principle, except we still need to make and validate profiles for all the other machines and do a bunch of integration work before it really ships
14:37kettenisone issue is that some of the callers expect that it always returns a valid pointer, whereas there is a "return NULL" in that function
14:38marcanin principle in the state it's in now, it can be tested end-to-end with pipewire and such, it's just that there is nothing keeping the speakers safe if the safety daemon dies
14:40kettenisthe issue has been on my radar since forever but 1) it never makes it to the top of the list of things for me to work on and 2) I don't seem to have USB devices that hit the issue
14:41marcanchadmed: practical issue: do you think we should have the kernel safe fallback volume cap global, or per-speaker?
14:41povikisn't there some quick workaround we can do, returning some scratch structure from that function?
14:45povikmarcan: i don't get in what sense keeping the speakers in balance is of advantage with the fallback cap
15:17mlp has joined #asahi-dev
15:24marcansven: this is worse, this is USB core stuff. you're lucky you just have to sequence PHYs :p
15:25marcanyeah but xHCI takes the standard level of USB insanity and wraps it in a mixed register/ring buffer/DMA interface ;)
15:26svennhi/thunderbolt does that dma ring buffer thing as well but it doesn’t seem to be as bad xhci
15:26bps2 has quit [Ping timeout: 480 seconds]
15:26svenat least it’s mostly ring buffers there and not much mixing between registers and ring buffers
15:27sventhough you ofc access registers of all the crap on the path to the device via those ringer buffer commands
15:27svenif you really want some pain you can always pick up fixing the pcie hotplug mess as well :>
15:28mlp has quit [Read error: Connection reset by peer]
15:29j`eyxhci in m1n1 means that the only thing we'll need on the nvme is the m1n1 stage1/stub? (compared to usb booting now which needs stage2 and uboot on the nvme)
15:30marcanit basically does the actual bootability provisioning in iSCPreboot instead of the Preboot partition itself
15:30marcanso you end up with source files in Preboot (on USB) and the actual boot/ folder on iSCPreboot
15:31marcanthe funny thing is once it's all set up and the default boot partition, you can unplug the disk and it still boots into m1n1
15:51roxfan2 has joined #asahi-dev
15:57roxfan has quit [Ping timeout: 480 seconds]
16:15amarioguy has quit [Remote host closed the connection]
16:15amarioguy has joined #asahi-dev
16:25brolin has quit [Ping timeout: 480 seconds]
16:25mlp has joined #asahi-dev
16:25mazmarcan: not sure you're already aware, but the apple cpuidle driver screams like mad when used with lockdep.
16:28j`eyit was brought up, and he linked https://lore.kernel.org/linux-arm-kernel/20220726145430.bfwidmw6xmeppbfb@bogus/
16:30brolin has joined #asahi-dev
16:30amarioguy has quit [Remote host closed the connection]
16:31amarioguy has joined #asahi-dev
16:40bcrumb has quit [Quit: WeeChat 3.8]
16:49derzahl has joined #asahi-dev
16:50amarioguy has quit [Ping timeout: 480 seconds]
16:51mlp has quit [Ping timeout: 480 seconds]
16:53mlp has joined #asahi-dev
17:07mlp has quit [Ping timeout: 480 seconds]
17:16mlp has joined #asahi-dev
17:25MajorBiscuit has quit [Quit: WeeChat 3.6]
17:25dh-- has quit [Read error: Connection reset by peer]
17:34StupidYui has quit [Remote host closed the connection]
17:35StupidYui has joined #asahi-dev
17:39cylm has joined #asahi-dev
17:45cylm_ has quit [Ping timeout: 480 seconds]
17:50hightower2 has quit [Ping timeout: 480 seconds]
17:53Oro_ has joined #asahi-dev
17:54Oro_ has quit []
17:54orowith2os has joined #asahi-dev
18:09brolin has quit [Ping timeout: 480 seconds]
18:16yrlf has quit [Quit: The Lounge - https://thelounge.chat]
18:17yrlf has joined #asahi-dev
18:19brolin has joined #asahi-dev
18:28brolin has quit [Ping timeout: 480 seconds]
18:35brolin has joined #asahi-dev
18:42hightower2 has joined #asahi-dev
18:44brolin has quit [Ping timeout: 480 seconds]
18:47j`eyI usually delete stuff, git add, then undo the deletion in my editor and other silly things
18:49mlp has quit [Ping timeout: 480 seconds]
18:50bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
18:51brolin has joined #asahi-dev
19:00brolin has quit [Ping timeout: 480 seconds]
19:01mlp has joined #asahi-dev
19:08brolin has joined #asahi-dev
19:16alyssa has left #asahi-dev [#asahi-dev]
19:16brolin has quit [Ping timeout: 480 seconds]
19:25brolin has joined #asahi-dev
19:34brolin has quit [Ping timeout: 480 seconds]
19:38yrlf has quit [Quit: The Lounge - https://thelounge.chat]
19:42brolin has joined #asahi-dev
19:46darkapex has joined #asahi-dev
19:46povikif only git blame had stream timestamps, that would then truly be suited to on-demand watching
19:51brolin has quit [Ping timeout: 480 seconds]
19:58brolin has joined #asahi-dev
19:59mlp has quit [Ping timeout: 480 seconds]
19:59yrlf has joined #asahi-dev
20:00brolin has quit []
20:08orowith2os has quit [Quit: Connection closed for inactivity]
20:24chadmedmacan: i think the global limit as we do it now is fine. bumping up the amp limit to 18.5 dBmV gives enough volume to be ~the same as macos with dsp all applied
20:26chadmedin terms of safety when the daemon goes down then id suggest using the codec's hardware volume cut. setting the fallback volume limit at the kctl level will screw with peoples alsamixer settings
20:29chadmedthat can be fixed by having the daemon pull everything up to 100 when it starts but that makes it very desktop-centric and break UX for folks without sound servers which kinda defeats the purpse
20:30chadmedhalves the output without changing values in the DVC register which means its totally transparent to userspace
20:32povikit shouldn't poke the registers directly, but what's required can be exposed as a control from the codec which is toggled by the machine driver and can't be written from userspace
20:36povikmaybe it can even be hidden, but that's another point to potentially have to argue out on the mailing list so why bother :-p
21:28darkapex has quit [Remote host closed the connection]
23:15chadmed_ has joined #asahi-dev
23:16chadmed_povik: having the control visible to userspace will be useful for diagnostic purposes imo
23:18orowith2os has joined #asahi-dev
23:47nsklaus has quit [Ping timeout: 480 seconds]
23:58lewurm- has joined #asahi-dev
23:58lewurm`` has quit [Read error: Connection reset by peer]