#asahi-dev · 2021-12-10 06:41
marcanworked with gpm though#asahi-dev · 2021-12-10 06:41
marcan[ 14.089493] applespi spi1.0: Received corrupted packet (invalid message length 8 - num-fingers 0, tp-len 48)#asahi-dev · 2021-12-10 06:41
marcan[ 14.081273] applespi spi1.0: Received corrupted packet (invalid message length 8 - num-fingers 0, tp-len 48)#asahi-dev · 2021-12-10 06:41
marcanahh xorg broke it#asahi-dev · 2021-12-10 06:40
marcanseems to work for me#asahi-dev · 2021-12-10 06:37
marcanhow does it break for you?#asahi-dev · 2021-12-10 06:37
marcanlet me actually try the touchpad (I was just catting the device)#asahi-dev · 2021-12-10 06:34
marcankeyboard too#asahi-dev · 2021-12-10 06:34
marcanHV, no tracing#asahi-dev · 2021-12-10 06:34
marcanon the M1 Pro#asahi-dev · 2021-12-10 06:33
marcanI seem to have working touchpad with that branch as-is#asahi-dev · 2021-12-10 06:33
marcanthat sounds like there's more than one problem#asahi-dev · 2021-12-10 06:27
marcanthat, right?#asahi-dev · 2021-12-10 06:27
marcan[ 0.716454] applespi spi1.0: Unknown touchpad model 0 - falling back to MB8 touchpad#asahi-dev · 2021-12-10 06:27
marcan[ 0.709687] applespi spi1.0: Received corrupted packet (crc mismatch)#asahi-dev · 2021-12-10 06:22
marcanbut for now let's see if it breaks because of a driver problem or a SPI problem...#asahi-dev · 2021-12-10 06:21
marcanwe definitely want to rewrite that as a HID transport properly (and someone else can add the bits to make it work with ACPI laptops too and then we can deprecate applespi in the future)#asahi-dev · 2021-12-10 06:21
marcansuch a mess of ACPI stuff mixed in there#asahi-dev · 2021-12-10 06:21
marcanalso oh god just looking at the diff context for that applespi.c makes me cringe#asahi-dev · 2021-12-10 06:18
marcanjust plain HV should have relatively little performance impact, mostly the timer IRQ spam#asahi-dev · 2021-12-10 06:18
marcandoes it not need those delays with the HV *even without* SPI tracing?#asahi-dev · 2021-12-10 06:14
marcanlet's see#asahi-dev · 2021-12-10 06:14
marcanah, saw the link#asahi-dev · 2021-12-10 06:10
marcanin principle we can run the HV in UP mode (or just filter out one CPU, might add an option for that) and then throw the gpiola on that one and see what linux does#asahi-dev · 2021-12-10 06:10
marcanj`ey: can you push that branch somewhere?#asahi-dev · 2021-12-10 00:12
marcanit might be it was never making it out of the transfer loop #asahi-dev · 2021-12-10 00:11
marcaneither that or it would get stuck#asahi-dev · 2021-12-10 00:09
marcandid you not hit the WARN_ON(fifo_flags & APPLE_SPI_FIFO_TXOVERFLOW); ? I would expect that to fire with the bad code#asahi-dev · 2021-12-10 00:08
marcanyup, that was a dumb typo#asahi-dev · 2021-12-10 00:08
marcanjannau/j`ey: thanks for catching that!#asahi-dev · 2021-12-09 16:22
marcanlol#asahi-dev · 2021-12-09 16:21
marcansven: yeah, someone emailed (!) me about retries++, lol#asahi-dev · 2021-12-09 15:08
marcanI can test on an M1Pro if you have some baseline#asahi-dev · 2021-12-09 15:08
marcanpovik: awesome!#asahi-dev · 2021-12-09 13:38
marcankettenis: ahaha, thanks for catching that :)#asahi-dev · 2021-12-09 13:36
marcanalright, time for dinner :)#asahi-dev · 2021-12-09 13:36
marcanthanks!#asahi-dev · 2021-12-09 13:36
marcan:)#asahi-dev · 2021-12-09 13:35
marcanwell, it was easy to implement that stuff :p#asahi-dev · 2021-12-09 13:33
marcan:-)#asahi-dev · 2021-12-09 13:30
marcandid you find the FIFO reset bits?#asahi-dev · 2021-12-09 13:29
marcanI assume you don't have the 1~32 bit per word, cpha/cpol/bitreverse features though#asahi-dev · 2021-12-09 13:29
marcanah, I see#asahi-dev · 2021-12-09 13:26
marcan(CS stuff aside)#asahi-dev · 2021-12-09 13:25
marcankettenis: btw, since I ended up not looking at the openbsd driver... how does it compare with what you had? :)#asahi-dev · 2021-12-09 13:25
marcanyou need to pick one since you need to do pinctrl anyway; either internal CS or gpio CS#asahi-dev · 2021-12-09 13:25
marcansince the spi core definitely has gpio CS handling code already#asahi-dev · 2021-12-09 13:25
marcanbut I imagine it's just a change to the probe function if so#asahi-dev · 2021-12-09 13:25
marcanI'm not sure how the spi core handles that; I need to check to see if that needs to be explicitly implemented#asahi-dev · 2021-12-09 13:17
marcanboth work