2021-12-09
00:27yuyichao_ has quit [Ping timeout: 480 seconds]
02:54yuyichao_ has joined #asahi-dev
03:13PhilippvK has joined #asahi-dev
03:16phiologe has quit [Ping timeout: 480 seconds]
05:19squags has joined #asahi-dev
05:30yrlf5 has quit []
05:30yrlf has joined #asahi-dev
05:55Dcow_ has joined #asahi-dev
06:00Dcow has quit [Ping timeout: 480 seconds]
08:05aleasto has joined #asahi-dev
08:13aleasto has quit [Remote host closed the connection]
09:45aleasto has joined #asahi-dev
09:58kettenis_ is now known as kettenis
10:16gruetzkopf has joined #asahi-dev
10:19gruetze_ has quit [Ping timeout: 480 seconds]
10:35kettenis_ has joined #asahi-dev
10:35kettenis has quit [Read error: Connection reset by peer]
10:49kettenis_ is now known as kettenis
11:00Dcow has joined #asahi-dev
11:05Dcow_ has quit [Ping timeout: 480 seconds]
11:07Dcow_ has joined #asahi-dev
11:10Dcow has quit [Ping timeout: 480 seconds]
11:55minecrell has quit [Read error: Connection reset by peer]
11:57minecrell has joined #asahi-dev
12:19N3ros[m] has joined #asahi-dev
13:03marcanHope it works with the keyboard. We aren't implementing any of the delays yet, but the spi core might take care of that? Turns out we can't use hardware CS anyway so...
13:08marcanoh, I didn't even notice, but the genpd stuff works fine too, it's clockgating it properly
13:14kettenisso one interesting thing is that all previous drivers explicitly control CS# through pinctrl
13:15FireFox317marcan, apparantly the flash@0 node also dont need the #address-cells and #size-cells properties, but i guess we would also find that when we would upstream these bindings
13:19aleasto has quit [Remote host closed the connection]
13:20kettenisso we could explicitly list the gpio in the DT and your driver would simply ignore that?
13:25marcanI'm not sure how the spi core handles that; I need to check to see if that needs to be explicitly implemented
13:25FireFox317marcan, ah yep, you are correct. Indeed that can be used for defining partitions
13:25marcankettenis: btw, since I ended up not looking at the openbsd driver... how does it compare with what you had? :)
13:26kettenisI can probably switch the OpenBSD driver to use the internal CS# control pretty quickly
13:29kettenismarcan: I think the fundamentals are quite close, but I don't bother with interrupts yet in the openbsd driver
13:37conected has joined #asahi-dev
13:41kettenisletting the controller control CS# is nicer, but if Apple ever decides to use an arbitrary GPIO to control CS# we'll have to use a gpio descriptor
13:57povikand the speakers there may need some code changes also in addition to DT nodes, don't know
14:00FireFox317povik, I can test it on a M1 air
14:28FireFox317povik, added some general comments. Feel free to ignore them :)
14:37kgarrington has joined #asahi-dev
14:37kgarrington has quit [Remote host closed the connection]
14:47kgarrington has joined #asahi-dev
14:48kgarrington has quit [Remote host closed the connection]
14:48akemin_dayo has quit [Ping timeout: 480 seconds]
14:56akemin_dayo has joined #asahi-dev
14:58yuyichao_ has quit [Ping timeout: 480 seconds]
15:33conected has quit []
15:48yuyichao_ has joined #asahi-dev
15:59sirn has quit [Quit: ZNC 1.8.2 - https://znc.in]
16:00sirn has joined #asahi-dev
16:19j_ey_also you might want a timeout. in the transfer_one. sifive didnt, but I saw some other drivers that did. and the core will set one up for you (if you structure the code differently)
16:19j_ey_ is now known as j`ey
16:20svenand this doesn't matter here because the refclock is constant but i think you should use devm_add_action_or_reset to clk_disable_unprepare the clock.
16:21bps has quit [Ping timeout: 480 seconds]
16:53yuyichao has joined #asahi-dev
16:54akemin_dayo has quit [Ping timeout: 480 seconds]
16:57yuyichao_ has quit [Ping timeout: 480 seconds]
17:19svenpovik: i briefly looked at it and left some general comments. i don't know anything about those subsystems but it mostly already looks good to me
17:44akemin_dayo has joined #asahi-dev
17:44bps has joined #asahi-dev
18:00_jannau_j`ey: see https://github.com/AsahiLinux/m1n1/commit/e8b30c93257b4d9d882463b573815f5c4d89681d line 173 for reference of the pin layout for m1 pro/max spi3
18:16_jannau_j`ey: try to comment the delay hacks in applespi. I think those are only comaptible with the corellium spi driver
18:22Gaspare has joined #asahi-dev
18:29Glanzmann has joined #asahi-dev
18:30Glanzmannj`ey: Do you use the macbook air as workstation under Linux? If so, how long does the battery last?
19:09roxfan has joined #asahi-dev
19:10roxfan2 has quit [Ping timeout: 480 seconds]
19:48Gaspare has quit [Ping timeout: 480 seconds]
19:54mipmeb has joined #asahi-dev
19:59mipmeb???? c / e r t a i n l y , z a m e r i c a n s n e e d e d s o m e t h i n g l i k e 9 / 11 t o J u s t i f y i n v a d i n g - i r - a q w h i c h h a s b e e n a l r e a d y p la n n e d a s a p a r t o f c r e a t i v e c -h a o s D i d u s a t r a i n & s u p p l y i s i s w i t h
19:59mipmeb w e a p o n s l i k e i t d i d w i t h a l - q a- e d a t o j u s t i f y c r e a t i n g w a r .s C R E - A T - I V E C H A - O S d i d c i a - d i d 9 / 11 o r i t j u s t l e t i t h a p p e n p l a n f o r m i d d l e -e a s t i f a l q a e d a d i d i t
19:59mipmeb W H Y t o k - i - l - l 9 m i l l i o n i r -a q i - s a b o u t 9 m i l l i o n i r a q i - d i -e d E i t h e r - b e c a u s e - o f d i r e c t a m e r ic a n v i o l e n c e a n d b e c a u s e o f s i e g e u s a m a d e a g a i n s t i r - a q t h a t p r e v e n t e d i -r a -q i f r o m e s s e n
19:59mipmebt i a l l i v i n g m a t e r i a l s , f o o d , m e d i c i n e a n d e v e n p e n c i l s f o r z c h i l d e r n - i s i s a n d a l q- a e d a - o n l y a p p e a r e d i n i r - a q a f t e r u s a i n v a s i o n , D i d u s a p a v e t h e w a y for i s- i s t o i r a -q ? s a d -d -a m
20:00mipmeb h u s- s i n who l o s t m o s t of his p o -w e r in 1 st , 2 nd g u l f w a r s a n d d u r i n g 1 0 y e a r s of s i e g e , d i d n o t a l l o w i s ` i s or a l , q a , e d e a t o e n t e r i r -a q , e v e n t o ` h e l p h i m a g a i n s t u s a
20:03Ganneff has joined #asahi-dev
20:03mipmeb has quit [Remote host closed the connection]
20:07___nick___ has joined #asahi-dev
20:07___nick___ has quit []
20:09___nick___ has joined #asahi-dev
20:31os has quit [Ping timeout: 480 seconds]
20:36os has joined #asahi-dev
20:43DarkShadow44 has quit [Quit: ZNC - https://znc.in]
20:43DarkShadow44 has joined #asahi-dev
20:44TheLink has quit [Quit: ZNC 1.8.2 - https://znc.in]
20:44TheLink has joined #asahi-dev
20:51ar has quit [Ping timeout: 480 seconds]
20:52ar has joined #asahi-dev
21:08___nick___ has quit [Ping timeout: 480 seconds]
21:29Ganneff has left #asahi-dev [#asahi-dev]
22:16j`eyit seems like thats a property of the device connected via SPI then, and not the controller itself
22:24j`eyI dont see a cs_delay, but theres a bunch of other ones here https://www.kernel.org/doc/html/latest/driver-api/spi.html
22:26jannauthis seems to be sufficient: https://gist.github.com/jannau/b36b8c6b91f94bfdbc2f04298118a333
23:11Dcow_ has quit [Read error: Connection reset by peer]
23:11Dcow has joined #asahi-dev
23:31StupidYui has joined #asahi-dev
23:57jannauj`ey: https://github.com/jannau/linux/tree/exp/spi-keyboard is my current state, the touchpad still can be wedged easily