#
✕ nick:marcan
#asahi-dev · 2022-03-05 12:33
marcan(I actually introduced ucon_mask myself in the S5L patchset...)
#asahi-dev · 2022-03-05 12:33
marcanthose flags are apple-specific so it doesn't apply to other chips (though one other variant uses ucon_mask for something else)
#asahi-dev · 2022-03-05 12:32
marcanand was obviously undoing that
#asahi-dev · 2022-03-05 12:32
marcanI looked at what resume was doing and noticed it was first restoring the IRQ flags in resume_noirq, then calling reset in resume which masked with ucon_mask
#asahi-dev · 2022-03-05 12:31
marcanproper fix :)
#asahi-dev · 2022-03-05 12:31
marcanj`ey: https://github.com/AsahiLinux/linux/commit/ea0cfdc040fec6f9100b0ee8d589364c330f2134
#asahi-dev · 2022-03-05 12:19
marcanyup
#asahi-dev · 2022-03-05 12:18
marcansven: also you should use ccache
#asahi-dev · 2022-03-05 12:18
marcanthat makes USB survive suspend/resume :-)
#asahi-dev · 2022-03-05 12:18
marcansven: https://github.com/AsahiLinux/linux/commit/37da9b0065cb2cd40a1ddaaa7c27121db612a855
#asahi-dev · 2022-03-05 11:47
marcanyeah
#asahi-dev · 2022-03-05 11:45
marcanprobably still unlocks, I imagine it's a separate "never gate" bit in pmgr somewhere
#asahi-dev · 2022-03-05 11:45
marcanheh
#asahi-dev · 2022-03-05 11:45
marcanand it does for the other darts
#asahi-dev · 2022-03-05 11:45
marcanyeah, and I bet the powergated bit never turns on
#asahi-dev · 2022-03-05 11:44
marcanwe know e.g. ANE1 refuses to power on
#asahi-dev · 2022-03-05 11:44
marcanthere's no way all that power domain stuff is hardcoded in silicon
#asahi-dev · 2022-03-05 11:44
marcanpmgr definitely needs to have a pile of config settings somewhere
#asahi-dev · 2022-03-05 11:44
marcanas part of general iBoot stuff
#asahi-dev · 2022-03-05 11:44
marcanor maybe the powergating gets disabled elsewhere
#asahi-dev · 2022-03-05 11:44
marcanlol
#asahi-dev · 2022-03-05 11:44
marcanguessing the lock bit also makes it not powergate at all?
#asahi-dev · 2022-03-05 11:43
marcanheh
#asahi-dev · 2022-03-05 11:43
marcansven: good chance that one is DART state getting lost across powergate, right?
#asahi-dev · 2022-03-05 11:42
marcan[ 5.110194] apple-dart b02f80000.iommu: translation fault: status:0x81000001 stream:1 code:0x1 (NO TTBR FOR IOVA) at 0xfffec000
#asahi-dev · 2022-03-05 11:41
marcanyeah
#asahi-dev · 2022-03-05 11:40
marcan->complete isn't getting called in the smc driver
#asahi-dev · 2022-03-05 11:40
marcanj`ey: I think there's something wrong about resume
#asahi-dev · 2022-03-05 11:36
marcanand indeed no serial
#asahi-dev · 2022-03-05 11:36
marcanah, then maybe it works
#asahi-dev · 2022-03-05 11:35
marcanyeah
#asahi-dev · 2022-03-05 11:34
marcansven: well it got further :-)
#asahi-dev · 2022-03-05 11:34
marcan[ 15.689325] nvme nvme0: Identify NS List failed (status=0xb)
#asahi-dev · 2022-03-05 11:34
marcan[ 15.689164] nvme-apple 393cc0000.nvme: ANS boot and NVMe init completed.
#asahi-dev · 2022-03-05 11:28
marcanoutput is easier than input :)
#asahi-dev · 2022-03-05 11:27
marcantry it
#asahi-dev · 2022-03-05 11:23
marcanif you want to trace vuart you have to do it in the C, since there's no way to trace it in python and still have the underlying emulation
#asahi-dev · 2022-03-05 11:21
marcan(or the vuart emulation!)
#asahi-dev · 2022-03-05 11:21
marcanif you get nothing that could still be the UART driver is broken :)
#asahi-dev · 2022-03-05 11:21
marcanwhich wouldn't be entirely surprising, especially since I mucked with that for the runtime-pm stuff and never tested it
#asahi-dev · 2022-03-05 11:20
marcanif you only get one burst of activity and no more, then that means suspend/resume in the samsung uart driver is likely broken
#asahi-dev · 2022-03-05 11:20
marcantry trace_device("/arm-io/aic", True) and see if you get activity when you send the first UART character after resume
#asahi-dev · 2022-03-05 11:20
marcanbut anyway, that means it's alive
#asahi-dev · 2022-03-05 11:19
marcanso that's normal
#asahi-dev · 2022-03-05 11:19
marcanif you pressed it enough times
#asahi-dev · 2022-03-05 11:19
marcanI think you probably just overflowed the queue
#asahi-dev · 2022-03-05 11:17
marcanit'll reboot soon :)
#asahi-dev · 2022-03-05 11:17
marcanlol yeah
#asahi-dev · 2022-03-05 11:17
marcanis that after pressing the button a bunch of times?
#asahi-dev · 2022-03-05 11:16
marcanHA

plus ›