#asahi-dev · 2024-05-09 10:06
leiono idea then, but here that curl command has been trying for 1m30 now#asahi-dev · 2024-05-09 10:03
leioI'm not sure I can trust this online ipv6 traceroute (didn't have anything installed here yet locally), but it shows it's stuck after 2403:5800:1701:3::2#asahi-dev · 2024-05-09 10:00
leioit does not ACK pings, 2403:580a:80ed:0:cb9d:978f:8d50:57fe#asahi-dev · 2024-05-09 09:56
leiochadmed: that link connects forever over IPv6 but works over IPv4 btw#asahi-dev · 2024-04-28 11:19
leiostopped making what? (commit log)#asahi-dev · 2024-04-26 06:43
leioline number is like 20 off as well#asahi-dev · 2024-04-26 06:42
leiocase _SMC_KEY("flt "): {#asahi-dev · 2024-04-26 06:41
leiowhere there is a block after case label#asahi-dev · 2024-04-26 06:41
leiothat diff doesn't match the code I'm looking at from jannau's branch#asahi-dev · 2024-04-26 06:27
leioAdding -Wc2x-extensions only adds a warning from include/linux/path.h code, nothing for macsmc-hwmon.c#asahi-dev · 2024-04-26 06:24
leio-Wall is there though#asahi-dev · 2024-04-26 06:24
leiono -Wc2x-extensions passed though#asahi-dev · 2024-04-26 06:23
leiono warnings here from touch drivers/hwmon/macsmc-hwmon.c && make LLVM=1 LLVM_IAS=1 -j25 #asahi-dev · 2024-04-26 06:19
leioyou run your kernel from clang builds?#asahi-dev · 2024-04-26 06:19
leioooh, LTOing options#asahi-dev · 2024-04-26 06:19
leiomeh, why not CC=clang, too obvious? :D#asahi-dev · 2024-04-26 06:17
leiohow did I change kernel compile to clang? :D#asahi-dev · 2024-04-26 06:14
leiothat feels false positive warning if triggered for new variable decls after a block start#asahi-dev · 2024-04-26 06:10
leioand the warning?#asahi-dev · 2024-04-26 06:07
leiowhere can I see the code itself as opposed to a diff?#asahi-dev · 2024-04-26 06:06
leio(those that do these early testing with newer versions and warning options)#asahi-dev · 2024-04-26 06:05
leioI have fixed upstream clang compilation warnings in the same way successfully and without any further problems by gentoo clang users#asahi-dev · 2024-04-26 05:57
leioand that's what I see in the linked patch to be done before and after?#asahi-dev · 2024-04-26 05:57
leioshould be fine if it's at start of a block and you can start a block after case label#asahi-dev · 2024-04-05 19:11
leioThis still remains off-topic here, and any other asahi channels except for #asahi-offtopic.#asahi-dev · 2024-03-30 11:27
leio(as long as the documentation matches what the library C function actually does :D )#asahi-dev · 2024-03-30 11:27
leiosad thing that "(transfer full)", "(transfer none)" and so on doc markup doesn't really help with anything much in C side beyond being able to see it as a documentation to know what to do with it in C, but they are used to make bindings memory safe at least#asahi-dev · 2024-03-30 11:25
leiobut I can't find the old revisions anymore (and it doesn't matter)#asahi-dev · 2024-03-30 11:25
leioand I assume it crashed before because you g_autoptr as_section while wp_properties_get doesn't hand a string that you own#asahi-dev · 2024-03-30 11:17
leiotl;dr: I think you need `section.name = as_section ? g_strdup (as_section) : wp_spa_json_parse_string (tmp);`#asahi-dev · 2024-03-30 11:17
leiootherwise you'll have a UAF (use after free) down the line when the section you made gets deleted and the wp_properties stuff accesses it, or e.g. properties get reloaded and the section is accessed#asahi-dev · 2024-03-30 11:16
leioso I THINK you need to g_strdup it instead of casting away the const#asahi-dev · 2024-03-30 11:16
leiochadmed: the thing is that wpa_spa_json_parse_string gives you a char* that the caller will own (transfer full), while wp_properties_get gives you a string that you do not own (transfer none)#asahi-dev · 2024-03-30 10:58
leiocasting away the const is sort of a give-away of problem, I think?#asahi-dev · 2024-03-30 10:57
leiowp_spa_json_parse_string is (transfer full), so that path does own it; so if section gets deallocated, it frees the strict that the underlying hashmap in wp_properties stuff owns#asahi-dev · 2024-03-30 10:56
leionot sure it's OK to assign a string to section.name without owning it, though#asahi-dev · 2024-03-30 10:54
leiowp_properties_get is (transfer none), so, uh, nevermind :)#asahi-dev · 2024-03-30 10:53
leiothough some no_frags case in the same file that's used the same doesn't concern itself about it either, so I guess it might be fine in your case too?#asahi-dev · 2024-03-30 10:50
leiochadmed_#asahi-dev · 2024-03-30 10:49
leioif that is true, you could make it a g_autoptr and then go through g_steal_pointer when passing it on to section.name#asahi-dev · 2024-03-30 10:47
leiothough not the case if any of the error early returns happen#asahi-dev · 2024-03-30 10:47
leioah, no, if it's set, it gets passed on to section.name, so that's intended presumably, nvm#asahi-dev · 2024-03-30 10:46
leiodoesn't as_section leak now in some cases? Though only if wp_properties_get returns something that needs freeing and I don't know which it is#asahi-dev · 2024-03-27 21:08
leioyeah, I meant before realizing 6.8 itself works for what you were testing, but you were just checking if it'd be easy to figure out if it is indeed broken; seeing #-alt now#asahi-dev · 2024-03-27 21:00
leioyou reverted half of 6.8 without it being broken? :)#asahi-dev · 2024-03-27 18:04
leiook, thanks#asahi-dev · 2024-03-27 17:41
leioI'd actually prefer not being stuck in 6.6 :)#asahi-dev · 2024-03-27 17:41
leiofor the HDMI stuff#asahi-dev · 2024-03-27 17:41
leiojanneg: which branch I should just grab? I don't mind 6.8 if only bluetooth and/or wifi is broken, don't use them#asahi-dev · 2024-03-26 21:17
leioI think 6K would not work well for DPMS, so I stopped using it and turned monitor off for the night instead; that one needed the HDMI replugging gymnastics