#
…

2024-04-26

00:23pb17 has quit [Ping timeout: 480 seconds]
00:31pb17 has joined #asahi-dev
00:45mushisaaa has quit [Quit: mushisaaa]
01:00KxCORP589 has quit [Quit: Bye!]
01:00KxCORP589 has joined #asahi-dev
01:02john-cabaj has quit [Ping timeout: 480 seconds]
01:04xal has quit []
01:05xal has joined #asahi-dev
01:05mushisaaa has joined #asahi-dev
01:13mushisaaa has quit [Quit: mushisaaa]
01:19mushisaaa has joined #asahi-dev
01:52jeisom has quit [Ping timeout: 480 seconds]
02:04DarkShadow44 has joined #asahi-dev
02:06DarkShadow4444 has quit [Ping timeout: 480 seconds]
02:25ddxtanx has quit [Quit: Konversation terminated!]
02:35mushisaaa has quit [Quit: mushisaaa]
02:37chadmedjannau: macsmc_hwmon_read_key is not valid c11, so idk if we can keep it
02:37chadmedgcc doesnt complain but clang emits a warning
02:40chadmedeasiest way to make it shut up would be to go back to declaring all the key types we support at the top of the function, as annoying as that is
02:40mushisaaa has joined #asahi-dev
02:41chadmedif we're only needing to support 'flt ' and 'ioft' then its fine imo
03:26mushisaaa has quit [Quit: mushisaaa]
03:28mushisaaa has joined #asahi-dev
03:30tristan2 has joined #asahi-dev
03:32tristan2_ has quit [Ping timeout: 480 seconds]
03:36mushisaaa has quit [Ping timeout: 480 seconds]
03:38pb17 has quit [Ping timeout: 480 seconds]
03:46pb17 has joined #asahi-dev
03:54baozich has joined #asahi-dev
03:57ghishadow has joined #asahi-dev
04:28ghishadow has quit [Ping timeout: 480 seconds]
04:45nicolas17 has quit [Ping timeout: 480 seconds]
04:50milky has quit [Quit: Lost terminal]
05:24systwi has quit [Ping timeout: 480 seconds]
05:24systwi has joined #asahi-dev
05:31chadmednah its the fact that there is a declaration after a label (the label being the case statement)
05:31chadmedthats only officially adopted for C23
05:36pb17 has quit [Ping timeout: 480 seconds]
05:44jannauah, that should be fine. a way out of it would be to move the parsing to functions
05:53chadmedyeah not a big deal just unsure how upstream will feel about it when we get to that stage
05:57leioshould be fine if it's at start of a block and you can start a block after case label
05:57leioand that's what I see in the linked patch to be done before and after?
06:04jannauI thought so too, that's why I wrote the misguided patch, but I guess goto and switch labels are special
06:05leioI have fixed upstream clang compilation warnings in the same way successfully and without any further problems by gentoo clang users
06:06leio(those that do these early testing with newer versions and warning options)
06:07leiowhere can I see the code itself as opposed to a diff?
06:10jannaugcc was erroring out about the not being able to reduce the case statements to integer constants after rebasing onto 6.8.6-3
06:10leioand the warning?
06:11jannauI haven't compiled with clang
06:14chadmedthe warning is just "you cant have a declaration after a label" and is turned on by -Wc2x-extensions
06:14chadmedhold on let me clean up, commit and push
06:14leiothat feels false positive warning if triggered for new variable decls after a block start
06:16chadmedcould be but i dont think if (x) { int y; } was ever defined behaviour right
06:17leiohow did I change kernel compile to clang? :D
06:17chadmedmake LLVM=1 LLVM_IAS=1
06:18chadmednote that youll probably get asked about some config items
06:19leiomeh, why not CC=clang, too obvious? :D
06:19leioooh, LTOing options
06:19leioyou run your kernel from clang builds?
06:19chadmedyup, have for years even on amd64
06:23leiono warnings here from touch drivers/hwmon/macsmc-hwmon.c && make LLVM=1 LLVM_IAS=1 -j25
06:24leiono -Wc2x-extensions passed though
06:24leio-Wall is there though
06:26pb17 has joined #asahi-dev
06:27leioAdding -Wc2x-extensions only adds a warning from include/linux/path.h code, nothing for macsmc-hwmon.c
06:40chadmeddrivers/hwmon/macsmc-hwmon.c:103:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
06:41chadmedclang 18 btw
06:41leiothat diff doesn't match the code I'm looking at from jannau's branch
06:41leiowhere there is a block after case label
06:42leiocase _SMC_KEY("flt "): {
06:42chadmedoh duh put it in a block
06:43leioline number is like 20 off as well
06:43chadmedyeah of course it is i rewrote parts of the driver and this version has no fan support because im not up to that yet
06:46chadmedi still dont think we should allow the setting of fan speeds even behind a parameter btw
06:46chadmedlook at how many people ignored the repeated warnings about prematurely enabling their speakers
06:46chadmedwe cannot guarantee that messing with the fan settings is safe yet so we should not allow it to be done in production systems at all until we can
07:01jannauI'm not proposing to merge that version. there is a legitimate development use for fan speed control. It makes CPU core temp key mapping easier
08:31pb17 has quit [Ping timeout: 480 seconds]
09:02pb17 has joined #asahi-dev
09:46ddxtanx has joined #asahi-dev
09:51jeisom has joined #asahi-dev
10:02kaazoo has joined #asahi-dev
10:06buroa2 has quit [Quit: The Lounge - https://thelounge.chat]
10:07buroa2 has joined #asahi-dev
10:08MrKai774 has joined #asahi-dev
10:10kaazoo has quit [Quit: Leaving.]
10:12MrKai77 has quit [Ping timeout: 480 seconds]
10:12MrKai774 is now known as MrKai77
10:46kaazoo has joined #asahi-dev
11:05pb17 has quit [Ping timeout: 480 seconds]
11:13baozich1 has joined #asahi-dev
11:18baozich has quit [Ping timeout: 480 seconds]
11:18baozich1 is now known as baozich
11:22chadmed_ has joined #asahi-dev
11:32pb17 has joined #asahi-dev
11:49kaazoo has quit [Ping timeout: 480 seconds]
11:53baozich1 has joined #asahi-dev
11:54baozich has quit [Remote host closed the connection]
11:54baozich1 is now known as baozich
11:55kaazoo has joined #asahi-dev
12:05baozich has quit [Ping timeout: 480 seconds]
12:12kaazoo has quit [Quit: Leaving.]
12:15linxz_ has joined #asahi-dev
12:19linxz has quit [Ping timeout: 480 seconds]
12:19linxz_ is now known as linxz
12:30ghishadow has joined #asahi-dev
12:31jeisom has quit [Remote host closed the connection]
12:32jeisom has joined #asahi-dev
12:38systwi has quit [Ping timeout: 480 seconds]
12:39xcpy00 has quit [Quit: The Lounge - https://thelounge.chat]
12:40systwi has joined #asahi-dev
12:44wille-io has joined #asahi-dev
12:48nicolas17 has joined #asahi-dev
12:55glem3 has joined #asahi-dev
13:00glem has quit [Ping timeout: 480 seconds]
13:00glem3 is now known as glem
13:21pb17 has quit [Ping timeout: 480 seconds]
13:23pb17 has joined #asahi-dev
14:11pbsds is now known as Guest2304
14:11pbsds has joined #asahi-dev
14:15Guest2304 has quit [Ping timeout: 480 seconds]
14:50checkfoc_us has quit []
14:52checkfoc_us has joined #asahi-dev
15:09pb17 has quit [Ping timeout: 480 seconds]
15:17pb17 has joined #asahi-dev
16:46pb17 has quit [Ping timeout: 480 seconds]
17:03nela has quit [Quit: bye!]
17:04nela has joined #asahi-dev
17:05pb17 has joined #asahi-dev
17:09hightower4 has joined #asahi-dev
17:16hightower3 has quit [Ping timeout: 480 seconds]
17:16mkurz has joined #asahi-dev
17:19JayBeeFOSS has quit [Ping timeout: 480 seconds]
17:20JayBeeFOSS has joined #asahi-dev
17:38mkurz has quit [Quit: Konversation terminated!]
18:20prime has quit [Ping timeout: 480 seconds]
18:23prime has joined #asahi-dev
18:23prime is now known as Guest2324
18:41john-cabaj has joined #asahi-dev
19:02pb17 has quit [Ping timeout: 480 seconds]
19:13roxfan2 has joined #asahi-dev
19:15jeisom has quit [Remote host closed the connection]
19:15pb17 has joined #asahi-dev
19:17jeisom has joined #asahi-dev
19:19roxfan has quit [Ping timeout: 480 seconds]
19:19jeisom has quit [Read error: Connection reset by peer]
19:19jeisom has joined #asahi-dev
19:50WindowPain has joined #asahi-dev
19:55WindowPa- has quit [Ping timeout: 480 seconds]
19:58chadmed has quit [Quit: Konversation terminated!]
19:58chadmed has joined #asahi-dev
19:58chadmed has quit []
19:58chadmed has joined #asahi-dev
19:59chadmed has quit []
19:59chadmed has joined #asahi-dev
19:59Simonx22 has quit [Remote host closed the connection]
19:59chadmed has quit [Read error: Connection reset by peer]
19:59chadmed has joined #asahi-dev
19:59chadmed has quit []
20:00chadmed has joined #asahi-dev
20:01chadmed has quit []
20:01chadmed has joined #asahi-dev
20:02chadmed has quit []
20:02chadmed has joined #asahi-dev
20:03chadmed has quit []
20:03chadmed has joined #asahi-dev
20:04chadmed has quit []
20:05chadmed has joined #asahi-dev
20:07chadmed has quit []
20:07chadmed has joined #asahi-dev
20:07maximbaz has quit [Quit: bye]
20:07maximbaz has joined #asahi-dev
20:07jeisom has quit [Remote host closed the connection]
20:09jeisom has joined #asahi-dev
20:09SalimTerryLi has quit [Ping timeout: 480 seconds]
20:10Simonx22 has joined #asahi-dev
20:15jeisom_ has joined #asahi-dev
20:15jeisom has quit [Read error: Connection reset by peer]
20:18SalimTerryLi has joined #asahi-dev
20:25Simonx22 has quit []
20:27Simonx22 has joined #asahi-dev
20:28Simonx22 has quit []
20:28Simonx22 has joined #asahi-dev
20:36Simonx22 has quit []
20:36Simonx22 has joined #asahi-dev
20:38Simonx22 has quit []
20:40Simonx22 has joined #asahi-dev
20:56pb17 has quit [Ping timeout: 480 seconds]
21:18pb17 has joined #asahi-dev
22:10john-cabaj has quit [Ping timeout: 480 seconds]
22:29schroes has quit [Read error: No route to host]
23:07pb17 has quit [Ping timeout: 480 seconds]
23:15pb17 has joined #asahi-dev
23:19crabbedhaloablut has quit []
23:21crabbedhaloablut has joined #asahi-dev
23:34tobhe_ has quit [Remote host closed the connection]
…