#
✕ nick:kettenis
#asahi-dev · 2021-12-09 13:41
kettenisletting the controller control CS# is nicer, but if Apple ever decides to use an arbitrary GPIO to control CS# we'll have to use a gpio descriptor
#asahi-dev · 2021-12-09 13:39
kettenisj_ey_ but you have to pick one or the other
#asahi-dev · 2021-12-09 13:37
kettenisshould have skipped that on the global search and replace ;)
#asahi-dev · 2021-12-09 13:37
kettenis* Based on spi-apple.c, Copyright 2018 SiFive, Inc.
#asahi-dev · 2021-12-09 13:36
kettenisgreat work!
#asahi-dev · 2021-12-09 13:36
kettenisyup, yours is nice and concise as well
#asahi-dev · 2021-12-09 13:34
kettenisI like keeping my drivers minimal ;)
#asahi-dev · 2021-12-09 13:33
kettenisI'll probably only implement the features that are really needed
#asahi-dev · 2021-12-09 13:32
kettenisI obviously need to go in and replace some of the magic numbers now ;)
#asahi-dev · 2021-12-09 13:32
kettenisdidn't find the FIFO reset bits (but didn't really need them)
#asahi-dev · 2021-12-09 13:31
kettenisindeed, I don't have any of those features
#asahi-dev · 2021-12-09 13:29
kettenismarcan: I think the fundamentals are quite close, but I don't bother with interrupts yet in the openbsd driver
#asahi-dev · 2021-12-09 13:26
kettenisI can probably switch the OpenBSD driver to use the internal CS# control pretty quickly
#asahi-dev · 2021-12-09 13:20
kettenisso we could explicitly list the gpio in the DT and your driver would simply ignore that?
#asahi-dev · 2021-12-09 13:17
kettenismarcan: does that mean that pinctrl should configure the pin appropriately?
#asahi-dev · 2021-12-09 13:14
ketteniswhereas your driver controls it through the SPI controller itself isn't it?
#asahi-dev · 2021-12-09 13:14
kettenisso one interesting thing is that all previous drivers explicitly control CS# through pinctrl
#asahi-dev · 2021-12-07 16:15
kettenismaz: now that it has spread to x86, you can share te pain with lots more people ;)
#asahi-dev · 2021-12-06 20:24
kettenisdefenitely something worth fixing in m1n1
#asahi-dev · 2021-12-06 20:24
kettenisI use "FULL_PAGE" in the OpenBSD driver
#asahi-dev · 2021-12-06 20:21
kettenisso if that is set, the whole 16k page is mapped
#asahi-dev · 2021-12-06 20:20
kettenisBIT(1)
#asahi-dev · 2021-12-03 18:24
kettenisdoes it renegotiate the syslog/crashlog memory addresses in that case?
#asahi-dev · 2021-12-03 18:21
kettenisso that means I wouldn't be able to do so from u-boot either isn't it?
#asahi-dev · 2021-12-03 17:05
kettenisso RUN is really RESET?
#asahi-dev · 2021-12-02 16:39
kettenisthat is the keyboard interrupt
#asahi-dev · 2021-12-02 16:39
kettenishttps://github.com/kettenis/u-boot/blob/708c71df69d31421a92e7b7577f4c7ac1ed8f659/arch/arm/dts/t8103-j293.dts#L50
#asahi-dev · 2021-12-02 16:35
kettenisit combines the parent and the actual (gpio) interrupt specification
#asahi-dev · 2021-12-02 16:35
kettenisI'd use interrupts-extended in this context though
#asahi-dev · 2021-12-02 16:34
kettenispovik: I think it should
#asahi-dev · 2021-12-02 15:41
kettenisah, so adding support for the role-switch-default-mode property is what I need then
#asahi-dev · 2021-12-02 15:35
kettenisI suppose I'd need to implement support for the hpm chip in u-boot to get role switching to work properly?
#asahi-dev · 2021-12-02 15:32
kettenisanyway, it would be great you and/or jannau could remove that dr_mode property such that we don't run into this issue again later
#asahi-dev · 2021-12-02 15:27
kettenisI think so; the ports are usable as-is
#asahi-dev · 2021-12-02 15:26
kettenisthose dwc3 nodes have not yet been sumitted upstream isn't it?
#asahi-dev · 2021-12-02 15:15
kettenisthat seems to work
#asahi-dev · 2021-12-02 15:13
kettenisbut u-boot defenitely doesn't look at that
#asahi-dev · 2021-12-02 15:12
kettenisrole-switch-default-mode = "host";
#asahi-dev · 2021-12-02 15:09
kettenissven: having those ports default to otg instead of host doesn't make sense to me on these machines
#asahi-dev · 2021-12-02 14:54
kettenismarcan, sven: dr_mode changed from "host" to "otg" on the asahi branch and that makes u-boot unhappy
#asahi-dev · 2021-12-02 11:28
kettenisworks for me ;)
#asahi-dev · 2021-12-02 11:17
kettenis"integration"
#asahi-dev · 2021-12-02 11:14
ketteniss/sande/sane/
#asahi-dev · 2021-12-02 11:14
ketteniswith some extras thrown in for bits where I have (somewhat) sande openbsd drivers ;)
#asahi-dev · 2021-12-02 11:13
kettenisthe current u-boot device trees are based on that branch
#asahi-dev · 2021-12-01 14:37
kettenisin a roundabout way...
#asahi-dev · 2021-12-01 14:27
kettenisthe pcie PERST# polarity fix falls into that category I think
#asahi-dev · 2021-11-29 18:15
ketteniswith the power domans I need to add a "u-boot,dm-pre-reloc" property to the power-controller nodes that correspond to the power domains used by the serial console
#asahi-dev · 2021-11-28 23:19
kettenisand the corellium applespi diff is full of hacks to achieve that
#asahi-dev · 2021-11-28 23:18
kettenisthe chip needs a delay after asserting cs

plus ›