#asahi-dev · 2021-12-12 19:14
jannauit does#asahi-dev · 2021-12-12 19:11
jannaulinux has 3 distinct drivers for the touchpad events. applespi (used by corellium), kettenis found bcm5974 (input device), hid-magicmouse is convenient since it is already hid#asahi-dev · 2021-12-12 19:08
jannauin other news touchpad is working with spi hid as well#asahi-dev · 2021-12-12 19:08
jannauI found the 3rd driver for the raw events from the touchpad: drivers/hid/hid-magicmouse.c #asahi-dev · 2021-12-12 15:32
jannaukeyboard works with spi-hid-apple#asahi-dev · 2021-12-12 15:30
jannauit's just applespi patches on top of asahi (potentially rebased onto 5.16-rc4)#asahi-dev · 2021-12-12 14:44
jannauj`ey: dart-t6000 and apple-dwc3 reset quirk. the latter semi-hard requirement for adding the usb-c ports to the dts#asahi-dev · 2021-12-12 08:19
jannau20us seems to work fine, I'll use 20us and leave a comment that those might be 45 us#asahi-dev · 2021-12-12 08:06
jannauthe 245 are an error. the 45 come from the plist: CS to Clock Us and Clock to CS Us#asahi-dev · 2021-12-12 07:18
jannaumarcan: yes, I tried using cs_inactive yesterday and https://github.com/jannau/linux/commit/f3e786d16121516 works well with the SPI core DT change#asahi-dev · 2021-12-11 12:40
jannaukettenis: "apple,spi-hid-transport" sounds good to me#asahi-dev · 2021-12-11 11:34
jannauand now to spi-hid-apple#asahi-dev · 2021-12-11 11:29
jannaucs setup/hold/inactive added to the DT and parsed by spi core: https://github.com/jannau/linux/tree/exp/spi-keyboard#asahi-dev · 2021-12-11 10:14
jannauit would make sense to add properties for cs_setup/cs_hold/cs_inactive to spi-peripheral-props.yaml now that they are available in spi core#asahi-dev · 2021-12-11 10:09
jannauspi-peripheral-props.yaml has spi-rx-delay-us / spi-tx-delay-us which would best map onto 'Inter Stage Us'#asahi-dev · 2021-12-11 07:49
jannaumarcan: yes, https://github.com/jannau/linux/commit/6701d2c38df72ea0693c49afd93555c366ffa90b fixes it as well. not sure my interpretation of 'Inter Transaction' and 'Inter Stage' delays are accurate though#asahi-dev · 2021-12-10 08:06
jannauI doubt kettenis uses my linux tree#asahi-dev · 2021-12-10 08:06
jannauI'm not sure how much time we should spend on applespi. I'll work on the spi hid transport this weekend#asahi-dev · 2021-12-10 08:02
jannauI'm testing on t6000-j314c, I have no t8103 laptop#asahi-dev · 2021-12-10 07:58
jannauthanks, fix pushed#asahi-dev · 2021-12-10 07:48
jannauprobably my tree, I think I updated just the compatible for t8103#asahi-dev · 2021-12-10 06:51
jannauthe spi device might be a multiplexer with distinct keyboard and touchpad sub devices#asahi-dev · 2021-12-10 06:36
jannaukeyboard seems to be more reliable#asahi-dev · 2021-12-10 06:35
jannaucaps lock led still breaks it but that ought to be an applespi problem#asahi-dev · 2021-12-10 06:34
jannauincreasing SPI_END_CS_DELAY_US in applespi to 100 fixes the touchpad on baremetal#asahi-dev · 2021-12-10 06:29
jannaunot sure but I see those two messages with spi tracing and working touchpad#asahi-dev · 2021-12-10 06:28
jannauon applespi side it presents received spi data as 0x00#asahi-dev · 2021-12-10 06:26
jannautouchpad seems to need more delay than I currently have. broken both with bare metal and hv without tracing#asahi-dev · 2021-12-10 06:20
jannauit's broken without spi tracing#asahi-dev · 2021-12-10 06:19
jannaulet me test that#asahi-dev · 2021-12-10 06:18
jannauI suppose j`ey was using something very similar to https://github.com/jannau/linux/tree/exp/spi-keyboard except for the random delays which fix it somewhat on bare metal#asahi-dev · 2021-12-10 00:11
jannauI saw tx_overflow set in the spi trace I did not notice it in the kernel log but I was not really looking at it#asahi-dev · 2021-12-10 00:02
jannauno, also if the controller has no method to set the cs timing: !spi->controller->set_cs_timing#asahi-dev · 2021-12-10 00:01
jannauif cs is already configured as periph it should work#asahi-dev · 2021-12-10 00:00
jannauI haven't added the pins for t8103 but fixed the compatible string#asahi-dev · 2021-12-09 23:58
jannausetting cs_setup from the applespi probe function doesn't seem to have an effect#asahi-dev · 2021-12-09 23:57
jannauj`ey: https://github.com/jannau/linux/tree/exp/spi-keyboard is my current state, the touchpad still can be wedged easily#asahi-dev · 2021-12-09 22:52
jannaudelays are still too short or missing. it is still broken on baremetal#asahi-dev · 2021-12-09 22:45
jannauit's not smooth when tracing spi in the hypervisor#asahi-dev · 2021-12-09 22:36
jannauI suppose discarding input data on a write broke it with the corellium driver#asahi-dev · 2021-12-09 22:34
jannaucaps lock led toggling works now and doesn't break the touchpad#asahi-dev · 2021-12-09 22:33
jannauyes#asahi-dev · 2021-12-09 22:29
jannauAPPLE_SPI_FIFO_DEPTH#asahi-dev · 2021-12-09 22:26
jannaualso not just priming but maximal write size#asahi-dev · 2021-12-09 22:26
jannauthis seems to be sufficient: https://gist.github.com/jannau/b36b8c6b91f94bfdbc2f04298118a333#asahi-dev · 2021-12-09 22:24
jannauno, existing delays are fine, I should not have increased the amount of fifo priming#asahi-dev · 2021-12-09 22:12
jannauincreased delays in applespi were required#asahi-dev · 2021-12-09 22:10
jannauwill do, currently reverting hopefully unrelated changes to have a minimal diff#asahi-dev · 2021-12-09 22:07
jannauj`ey: works now with printks and not fully priming the tx fifo#asahi-dev · 2021-12-09 19:45
jannauj`ey: both, haven't looked into it beyond that