#asahi-dev · 2021-12-10 15:01
j`eybroonie seemed to think it was important for some reason..#asahi-dev · 2021-12-10 15:00
j`eyits not used#asahi-dev · 2021-12-10 14:57
j`eyno its' not here https://github.com/jannau/linux/commits/exp/spi-keyboard#asahi-dev · 2021-12-10 14:56
j`eyoh, he must have missed it, it was in previous branches of his#asahi-dev · 2021-12-10 14:54
j`eyhttps://gitlab.arm.com/linux-arm/jg-open/-/commit/9d18ad40628a31790af3f713c3037d43dcbbc6f6#asahi-dev · 2021-12-10 14:54
j`eylooks like youre missing a patch#asahi-dev · 2021-12-10 14:08
j`eymarcan: because I misunderstood what you said before#asahi-dev · 2021-12-10 13:35
j`eynevermind, I forgot to chainload#asahi-dev · 2021-12-10 13:31
j`eyIm getting what seems to be recursive exceptions when trying to use linux.py, anyone else seeing this?#asahi-dev · 2021-12-10 12:45
j`eymarcan: https://paste.gg/p/anonymous/a4350b45ace148b5b81e5f8cc298271b works #asahi-dev · 2021-12-10 10:32
j`eyyes it was the clock (obviously!)#asahi-dev · 2021-12-10 10:30
j`eymarcan: either that 120MHZ clock fixed it.. or the change I made to use gpio instead of hw-cs /me reverts back to hw-cs and checks#asahi-dev · 2021-12-10 10:15
j`eyit certainly looks outside of physical memory space :P#asahi-dev · 2021-12-10 08:58
j`eyyeah but it was always the mini you worked on, then the t6000 :P#asahi-dev · 2021-12-10 08:57
j`eymarcan: im happy the air is getting some attention ^_^#asahi-dev · 2021-12-10 08:49
j`ey(any linkin park fans?)#asahi-dev · 2021-12-10 08:48
j`eyin the end it doesnt even matter#asahi-dev · 2021-12-10 08:47
j`eyand divides too much or something#asahi-dev · 2021-12-10 08:46
j`eyI see, I wonder then how corelliums code worked, maybe its buggy#asahi-dev · 2021-12-10 08:46
j`eymarcan: I dont want to distract, but I'm confused now if m1air uses a 24mhz or 120mhz clock? #asahi-dev · 2021-12-10 08:44
j`eyholds#asahi-dev · 2021-12-10 08:37
j`eymarcan: fwiw I always get one corrupted packet on boot#asahi-dev · 2021-12-10 00:27
j`eymarcan: I managed to see one packet from the keyboard at least, but then it gets stuck#asahi-dev · 2021-12-10 00:04
j`ey(I probably need to do more testing with linux.py, I always used hv)#asahi-dev · 2021-12-10 00:03
j`eyyeah I missed that when i first read it, thought it was inside the if () {..#asahi-dev · 2021-12-10 00:02
j`eyoh hm, !spi->controller->set_cs_timing should be true actually?#asahi-dev · 2021-12-10 00:01
j`eyhttps://github.com/jannau/linux/blob/exp/spi-keyboard/drivers/spi/spi.c#L947#asahi-dev · 2021-12-10 00:01
j`eycs_setup is only used if the spi core is in charge of the cs gpio#asahi-dev · 2021-12-09 22:46
j`eyjannau: :D#asahi-dev · 2021-12-09 22:43
j`eyI got very frustrated with my thinkpad's one#asahi-dev · 2021-12-09 22:42
j`eynice nice#asahi-dev · 2021-12-09 22:40
j`eymarcan: pinging marcan on the FIFO_DEPTH to make surehe sees it#asahi-dev · 2021-12-09 22:37
j`eyjannau: how is the trackpad in general?#asahi-dev · 2021-12-09 22:34
j`eyjannau: woot#asahi-dev · 2021-12-09 22:30
j`eyjannau: so does that fix it too? min_t(u32, *left, APPLE_SPI_FIFO_DEPTH - inuse);#asahi-dev · 2021-12-09 22:29
j`eyyeah#asahi-dev · 2021-12-09 22:29
j`eyAPPLE_SPI_FIFOSTAT_LEVEL_TX GENMASK(15, 8)#asahi-dev · 2021-12-09 22:28
j`eywas thta meant to be FIFOSIZE - inuse?#asahi-dev · 2021-12-09 22:27
j`eywait.. im confused by APPLE_SPI_FIFOSTAT_LEVEL_TX - inuse#asahi-dev · 2021-12-09 22:24
j`eyI dont see a cs_delay, but theres a bunch of other ones here https://www.kernel.org/doc/html/latest/driver-api/spi.html#asahi-dev · 2021-12-09 22:16
j`ey(delays after CS assertion)#asahi-dev · 2021-12-09 22:16
j`eyit seems like thats a property of the device connected via SPI then, and not the controller itself#asahi-dev · 2021-12-09 22:12
j`eyseems like we had different issues anyway, but worth trying#asahi-dev · 2021-12-09 22:09
j`eyjannau: put the diff somewhere i can try the air tomorrow#asahi-dev · 2021-12-09 22:09
j`eygreat!#asahi-dev · 2021-12-09 21:55
j`eyjannau: oh, if you want to try again, theres that retries++ line you could try delete#asahi-dev · 2021-12-09 19:46
j`eyjannau: ok, I'm not going to look tonight e9ther#asahi-dev · 2021-12-09 19:06
j`eyor just as-is#asahi-dev · 2021-12-09 19:05
j`eyjannau: after removing the delays?#asahi-dev · 2021-12-09 18:31
j`eyjust for testing patches