#
✕ nick:chadmed
#asahi-dev · 2024-05-07 11:48
chadmedoh well there goes that idea
#asahi-dev · 2024-05-07 11:48
chadmedtvos uses dolby mat and macos doesnt even pretend to support bitstream formats at all
#asahi-dev · 2024-05-07 11:48
chadmedoh ffs
#asahi-dev · 2024-05-06 06:34
chadmedor is it more that we feed DCP PCM and it handles the actual bitstream format in firmware?
#asahi-dev · 2024-05-06 06:34
chadmedright okay, didnt realise we _only_ support PCM. thought that was just the driver
#asahi-dev · 2024-05-06 05:50
chadmedcurrently its being enumerated as a bare AVOUT jack which is why it gets picked up as built-in analog audio
#asahi-dev · 2024-05-06 05:43
chadmedjannau: there is an asoc codec that is essentially just an hdmi helper. should we rewrite the dcp audio stuff as an asoc driver to make use of that? it seems to be mostly what we're looking for, we could even attach each dcp instance to macaudio and just leave it inactive if theres no display attached to it?
#asahi-dev · 2024-04-30 06:53
chadmedjannau: done, sorry dont have my keys at work for obvious reasons
#asahi-dev · 2024-04-28 09:46
chadmednot the other thing ;)
#asahi-dev · 2024-04-28 09:46
chadmedsigned-off-by
#asahi-dev · 2024-04-28 09:44
chadmedjannau: could i have your s-o-b for the hwmon driver?
#asahi-dev · 2024-04-27 12:20
chadmedand all we have to do in probe is collect whichever ones were created into the array of pointers
#asahi-dev · 2024-04-27 12:20
chadmedyeah that's what i was thinking of trying tomorrow, then we can just roll creating it into populate_sensors
#asahi-dev · 2024-04-27 12:09
chadmedj475
#asahi-dev · 2024-04-27 11:48
chadmedthere _has_ to be a better way to do that hwmon_channel_info stuff... surely...
#asahi-dev · 2024-04-27 11:47
chadmedalso picked jannau's commits refactoring the devicetree stuff but that's broken and needs work (TW0P doesn't exist on every machine for example)
#asahi-dev · 2024-04-27 11:47
chadmedtook some time to refactor various parts of the hwmon driver and rebase it atop 6.8-3: https://github.com/chadmed/linux/tree/hwmon-rebase
#asahi-dev · 2024-04-27 10:02
chadmeddoesnt look like anything related to asahi-audio. those speaker routing props logs are from the volume limiter and are expected to be there
#asahi-dev · 2024-04-26 07:02
chadmed+1
#asahi-dev · 2024-04-26 06:46
chadmedwe cannot guarantee that messing with the fan settings is safe yet so we should not allow it to be done in production systems at all until we can
#asahi-dev · 2024-04-26 06:46
chadmedlook at how many people ignored the repeated warnings about prematurely enabling their speakers
#asahi-dev · 2024-04-26 06:46
chadmedi still dont think we should allow the setting of fan speeds even behind a parameter btw
#asahi-dev · 2024-04-26 06:43
chadmedyeah of course it is i rewrote parts of the driver and this version has no fan support because im not up to that yet
#asahi-dev · 2024-04-26 06:42
chadmedoh duh put it in a block
#asahi-dev · 2024-04-26 06:41
chadmedclang 18 btw
#asahi-dev · 2024-04-26 06:40
chadmedhttps://github.com/chadmed/linux/commit/306ee43fdb600acf45f73e257096afaa07335f9b
#asahi-dev · 2024-04-26 06:40
chadmeddrivers/hwmon/macsmc-hwmon.c:103:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
#asahi-dev · 2024-04-26 06:19
chadmedyup, have for years even on amd64
#asahi-dev · 2024-04-26 06:18
chadmednote that youll probably get asked about some config items
#asahi-dev · 2024-04-26 06:17
chadmedmake LLVM=1 LLVM_IAS=1
#asahi-dev · 2024-04-26 06:16
chadmedcould be but i dont think if (x) { int y; } was ever defined behaviour right
#asahi-dev · 2024-04-26 06:14
chadmedhold on let me clean up, commit and push
#asahi-dev · 2024-04-26 06:14
chadmedthe warning is just "you cant have a declaration after a label" and is turned on by -Wc2x-extensions
#asahi-dev · 2024-04-26 05:53
chadmedyeah not a big deal just unsure how upstream will feel about it when we get to that stage
#asahi-dev · 2024-04-26 05:31
chadmedthats only officially adopted for C23
#asahi-dev · 2024-04-26 05:31
chadmednah its the fact that there is a declaration after a label (the label being the case statement)
#asahi-dev · 2024-04-26 02:41
chadmedif we're only needing to support 'flt ' and 'ioft' then its fine imo
#asahi-dev · 2024-04-26 02:40
chadmedeasiest way to make it shut up would be to go back to declaring all the key types we support at the top of the function, as annoying as that is
#asahi-dev · 2024-04-26 02:37
chadmedgcc doesnt complain but clang emits a warning
#asahi-dev · 2024-04-26 02:37
chadmedjannau: macsmc_hwmon_read_key is not valid c11, so idk if we can keep it
#asahi-dev · 2024-04-25 06:15
chadmedoh you added to the devices and the socs. i thought the soc ones were duplicates
#asahi-dev · 2024-04-25 05:40
chadmedjannau: hdmi audio was already a line item on the device specific feature tables :)
#asahi-dev · 2024-04-23 07:24
chadmedSND_USE_CASE_DEV_HDMI
#asahi-dev · 2024-04-23 07:24
chadmedthere are SectionDevice identifiers for HDMI so perhaps we start with the low-hanging fruit and implement a UCM file for it then work from there
#asahi-dev · 2024-04-23 07:20
chadmedlooks like it's going to be mostly UCM looking at what HDA does but looking at the driver it does seem a bit incomplete. perhaps because we are not advertising IEC958 modes it's mucking with what userspace thinks we can do idk
#asahi-dev · 2024-04-23 06:57
chadmedjannau: i believe it is a combination of the two. i assume you made snd_soc_macaudio changes for dcp audio?
#asahi-dev · 2024-04-20 09:34
chadmedi was inclined to believe there was an issue given how loose upstream seem to be with these things. the reason i had to change what we match on in the first place is because the naming convention for nodes just... changed one day
#asahi-dev · 2024-04-20 09:33
chadmedah ok phew
#asahi-dev · 2024-04-20 09:30
chadmedim updating my system now and will check what's going on with pw 1.0.5
#asahi-dev · 2024-04-20 09:17
chadmedthey will be hidden in pw-dump if the dsp rule matched

plus ›