#
✕ nick:marcan
#asahi · 2021-03-26 18:32
marcanprobably one of the adjacent chips
#asahi · 2021-03-26 18:32
marcanhttps://d3nevzfk7ii3be.cloudfront.net/igi/WgkFM4qTwDa42kDf.full that CD3215 should have one
#asahi · 2021-03-26 18:31
marcanthe ipads in particular use similar PD chips I believe
#asahi · 2021-03-26 18:31
marcanthey definitely have eeproms
#asahi · 2021-03-26 18:28
marcanI don't think DFU would erase that firmware, I would expect it to upgrade it to the latest version though
#asahi · 2021-03-26 18:27
marcanso if those are too broken to make DFU work, then it won't
#asahi · 2021-03-26 18:27
marcanbut it's USB, it has to go through the PD/mux chips
#asahi · 2021-03-26 18:27
marcanit does
#asahi · 2021-03-26 18:26
marcanit's entirely possible it can't
#asahi · 2021-03-26 18:26
marcanit is, but the firmware is just patches for the internal ROM; I don't know what happens if you wipe it, I don't know if DFU itself can work off of the internal ROM only
#asahi · 2021-03-26 18:24
marcanthere is definitely *some* flash used for that
#asahi · 2021-03-26 18:23
marcanit should be the smaller one, that's not 64MB
#asahi · 2021-03-26 18:23
marcanyeah there would be the two I mentioned at least
#asahi · 2021-03-26 18:22
marcanthere's a spinor but I don't want to go near that unless we have to, because it's a brick risk. there's also the PD controller flash which is similarly fairly critical
#asahi · 2021-03-26 18:22
marcanchatcat: which ones?
#asahi · 2021-03-26 18:22
marcanI need to fix that for EL1 mode (I will a bit later, don't want that to block this series)
#asahi · 2021-03-26 18:21
marcanmaz: does the kernel run at EL1 in CONFIG_VHE=n mode? if so, it won't work with the current AIC anyway
#asahi · 2021-03-26 18:03
marcanthey don't, but if they're level-triggered the logic still works
#asahi · 2021-03-26 18:03
marcanI mean for non-MSI stuff
#asahi · 2021-03-26 18:03
marcanwell, we don't get to allocate
#asahi · 2021-03-26 18:02
marcannothing beautiful but possible on paper if needed
#asahi · 2021-03-26 18:02
marcancould also be done by playing with masks I guess
#asahi · 2021-03-26 18:01
marcanthis is useful because it means we can still do software IRQ priorities on edge-triggered IRQs (e.g. poll all or a subset of IRQ states in a different order, bypassing the internal logic; this might make sense if we want to desperately prioritize, say, a couple IRQs for some reason)
#asahi · 2021-03-26 18:00
marcanso basically they have some flops to latch the edge that get cleared on ack, and its output is presented as the level state
#asahi · 2021-03-26 18:00
marcanyeah
#asahi · 2021-03-26 17:58
marcanbasically they behave as level IRQs that go high on the event, and low after the AIC event register is read
#asahi · 2021-03-26 17:58
marcanlikely
#asahi · 2021-03-26 17:57
marcanthough it's all automagic, so it just allows either mode
#asahi · 2021-03-26 17:57
marcanI also threw in allowing edge-triggering for IRQs, since it seems MSIs work like that after all
#asahi · 2021-03-26 17:56
marcanAIC ended up getting another pile of cleanup, mostly unifying irq_data accesses
#asahi · 2021-03-26 17:56
marcanarnd: feel free to take a look too, maybe this is the good one :)
#asahi · 2021-03-26 17:55
marcanhttps://github.com/AsahiLinux/linux/commits/upstream-bringup-v4 has the latest cleanup, and should fix that bug (though I don't have a good way to test it)
#asahi · 2021-03-26 17:55
marcanheh
#asahi · 2021-03-26 10:34
marcanI forgot to subtract out the AIC IRQ offset from the hwirq number, so nothing ever gets masked/unmasked
#asahi · 2021-03-26 10:34
marcanmaz: wait, how did the guest masking ever work? AFAICT the aic FIQ mask code in v3 is completely broken :D
#asahi · 2021-03-26 10:02
marcanyeah, that worked
#asahi · 2021-03-26 09:36
marcansounds reasonable
#asahi · 2021-03-26 09:35
marcanthe conflict is in an unrelated driver
#asahi · 2021-03-26 09:34
marcanI thought git would just skip identical patches like that
#asahi · 2021-03-26 09:33
marcanarnd: maybe I should just cherry-pick the relevant patches?
#asahi · 2021-03-26 09:32
marcanbleh, 71b25f4df984 does not merge cleanly into -rc3
#asahi · 2021-03-26 09:30
marcanthe serial ones I mean
#asahi · 2021-03-26 09:30
marcanI just broke out the v4 changes into a separate branch, so that can go in later, nothing critical there
#asahi · 2021-03-26 09:30
marcanworks for me
#asahi · 2021-03-26 09:26
marcanoh, --no-ff, sure
#asahi · 2021-03-26 09:26
marcanarm64-fiq-20210315 is already that, so I can start with it
#asahi · 2021-03-26 09:20
marcanthe GENERIC_IRQ_MULTI_HANDLER is in -rc3, that tag contains the rest of the fiq support series, tty-next pulls in the samsung changes that gregkh already merged, and then everything else goes on top
#asahi · 2021-03-26 09:20
marcanso the base should just be arm64-fiq-20210315 (which is based off of v5.12-rc3), with tty-next merged on top
#asahi · 2021-03-26 09:15
marcan(I mean the originals)
#asahi · 2021-03-26 09:15
marcanshould I just drop them from the series then, as they already got independently merged?

plus ›