2021-03-26
00:02brandas has joined #asahi
00:04troseman has joined #asahi
00:06Bublik_ has joined #asahi
00:06crabbedhaloablut has quit [Ping timeout: 245 seconds]
00:07crabbedhaloablut has joined #asahi
00:08Bublik has quit [Ping timeout: 250 seconds]
00:35marcankettenis: cute, so either it's latched by AIC itself, or by the PCIe core with some kind of feedback of when it is acknowledged
00:55JusticeEX has quit [Ping timeout: 260 seconds]
01:04raster has quit [Quit: Gettin' stinky!]
01:06choozy has quit [Remote host closed the connection]
01:30roxfan2 has joined #asahi
01:31bdju has quit [Quit: Reconnecting]
01:31bdju has joined #asahi
01:31roxfan has quit [Ping timeout: 240 seconds]
01:31amwI'm thinking it would be nice to consolidate Sven's normal USB serial code support on m1n1 as it worked
01:32Eighth_Doctor is now known as Conan_Kudo
01:34Conan_Kudo is now known as Eighth_Doctor
01:37ifthenelse6 has joined #asahi
01:37stemnic1 has joined #asahi
01:39ifthenelse has quit [Quit: Ping timeout (120 seconds)]
01:39stemnic has quit [Quit: Ping timeout (120 seconds)]
01:39stemnic1 is now known as stemnic
01:39ifthenelse6 is now known as ifthenelse
02:02arcsor5 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:06arcsor5 has joined #asahi
02:16ifthenelse has quit [Quit: Ping timeout (120 seconds)]
02:16ifthenelse has joined #asahi
02:26riker77_ has joined #asahi
02:26riker77 has quit [Ping timeout: 248 seconds]
02:26riker77_ is now known as riker77
02:48marcanthat's because most of the past month on the Linux branch has been review feedback, not new code :)
03:09amwgit log --format=fuller marcan/upstream-bringup-v4 : shows commitdate Mar 6th vs Feb 4th for authordate
03:11Necrosporus has quit [Ping timeout: 252 seconds]
03:13amwI'm just thinking this week end might be nice to have official branch that you can boot with a normal USB cable serial as per Sven's usb-uartproxy-console-wip for m1n1
03:14amwBut I that the m1n1 main is a fairly similar date - but not sure if it has usb serial support yet?
03:26phiologe has quit [Ping timeout: 252 seconds]
03:27phiologe has joined #asahi
03:33JusticeEX has joined #asahi
03:39amwBut I that the m1n1 main is a fairly similar date - but not sure if it has usb serial support yet?~.
03:40troseman has quit [Ping timeout: 240 seconds]
03:52arcsor5 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:55arcsor5 has joined #asahi
04:07marvin24 has quit [Ping timeout: 252 seconds]
04:07marvin24 has joined #asahi
04:09marcanthe kernel release schedule has hard deadlines and missing them means months of wait until the next version, so I really want to make sure we make 5.13
04:27prabinspkt has joined #asahi
04:35arcsor5 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:44mxw39 has quit [Remote host closed the connection]
04:44mxw39 has joined #asahi
04:44mxw39 has quit [Remote host closed the connection]
04:45mxw39 has joined #asahi
05:08mxw39 has quit [Quit: Konversation terminated!]
05:09mxw39 has joined #asahi
05:23bbolli has quit [Ping timeout: 265 seconds]
05:32Necrosporus has joined #asahi
05:36mxw39 has quit [Read error: Connection reset by peer]
05:37mxw39 has joined #asahi
05:38mxw39 has quit [Client Quit]
05:40mxw39 has joined #asahi
05:44amwmarcan: Ok - great. Happy to wait, good to get a status update, I can work from Sven's branch
06:07Graypup_ has quit [Quit: ZNC 1.6.1 - http://znc.in]
06:08Graypup_ has joined #asahi
06:19VinDuv has joined #asahi
06:36prabinspkt has quit [Quit: Connection closed for inactivity]
06:48marcan has quit [Quit: Now where's my screwdriver...]
06:49marcan has joined #asahi
07:05eichin has quit [Read error: Connection reset by peer]
07:05eric_engestrom has quit [Ping timeout: 240 seconds]
07:05HeN has quit [Ping timeout: 248 seconds]
07:06jkkm has quit [Read error: Connection reset by peer]
07:06eric_engestrom has joined #asahi
07:06eichin has joined #asahi
07:06jkkm has joined #asahi
07:07HeN has joined #asahi
07:26VinDuv has quit [Quit: Leaving.]
07:33jeffmiw has joined #asahi
07:37jeffmiw has quit [Ping timeout: 252 seconds]
07:58svenyeah, there's no rush. people who can make good use of the usb serial code right now can just use my wip branches
08:04JusticeEX has quit [Ping timeout: 252 seconds]
08:09alvaro_fe has quit [Ping timeout: 245 seconds]
08:15goldenkrew3000 has joined #asahi
08:16Namidairo_ has quit [Read error: Connection reset by peer]
08:16Namidairo has joined #asahi
08:17shenki has quit [Ping timeout: 258 seconds]
08:17shenki has joined #asahi
08:19vimal has quit [Ping timeout: 276 seconds]
08:31furkan has quit [Ping timeout: 260 seconds]
08:31raster has joined #asahi
08:32klaus has joined #asahi
08:38vimal has joined #asahi
08:48ephe_meral2 has joined #asahi
08:50jaXvi has joined #asahi
08:56goldenkrew3000 has quit [Ping timeout: 252 seconds]
08:58arndmarcan: do you think there are any show-stoppers left? Final consensus on the "non-posted" property is the only thing I still see as necessary, not sure where we actually are on that, or if there are any other issues. Once there are only minor style issues left, I would like to just merge a branch in to my for-next tree and let you follow up with patches on top of that
08:59roxfan2 is now known as roxfan
08:59arndI think gregkh already merged the serial driver patches into his tree, not sure if that is a problem for having everything in one branch
08:59marcanI think the nonposted stuff is also pretty much OK, robher just needs to review my final, simpler version
09:00marcanyeah, I noticed that... before they were finally reviewed too, not sure if that will be a problem now since those changed
09:01arndnote that gregkh doesn't remove stuff from his branch, so it's now part of the git history, though he could revert the patches if necessary
09:03marcanI'm honestly a bit confused as to how the pipeline with gregkh and krzysztof works here :)
09:04arndwhat we could do in theory is to have your branch based on the serial git, or a merge of that into another branch. I'd probably reserve a top-level branch in the soc tree for m1, so that this time we have "arm/dt", "arm/defconfig", "arm/drivers", "arm/soc" and "arm/m1" branches, and after 5.13 you split the patches into dt, defconfig, drivers, etc as everyone else
09:06arndthe usual procedure for the serial drivers is that gregkh would wait for an Acked-by or Reviewed-by tag from krzk and then apply the patches directly. There is rarely the need for gregkh to require a pull request from a driver maintainer
09:08arndmarcan: cmarinas mentioned that he also has picked up maz' patches for GENERIC_IRQ_MULTI_HANDLER into the arm64 tree (I don't know what patches those are, but I assume you do), so you'll want to merge that branch and the serial driver on top of -rc3, and then rebased the rest on top of that
09:08marcankrzysztof reviewed everything but had a couple caveats, but I think they only related to a spurious whitespace change and commit messages; nothing is actionable there any more if they already got merged
09:12marcanI'm guessing this was largely automated then, after he sent those tags even though there were a couple nits left
09:14arndmarcan: if nothing of the additional feedback is required for correct operation of the driver, I'd suggest you keep those fixups separate from the rest of the series and just send them to gregkh as cleanups
09:20marcanso the base should just be arm64-fiq-20210315 (which is based off of v5.12-rc3), with tty-next merged on top
09:20marcanthe GENERIC_IRQ_MULTI_HANDLER is in -rc3, that tag contains the rest of the fiq support series, tty-next pulls in the samsung changes that gregkh already merged, and then everything else goes on top
09:22vijfhoek has quit [Quit: Quit Message]
09:22furkan has joined #asahi
09:24arndmarcan: I would start out with -rc3, and then "git pull --no-ff" the other branches into that one at a time, with a merge changeset describing why you need then.
09:26vijfhoek has joined #asahi
09:27vijfhoek has quit [Client Quit]
09:28arndmarcan: tty-next seems to have a backmerge of -rc3 into that, with the previous patches based on -rc2
09:29arndI'd prefer not to have the same backmerge of in my tree (it messes up the history), so maybe either merge in 71b25f4df984 (the last commit for the samsung serial driver) or 3d82be8be6fd (the last commit before the backmerge) instead of the entire tty-next
09:30marcanI just broke out the v4 changes into a separate branch, so that can go in later, nothing critical there
09:35arndit doesn't consider them identical if they have different commit IDs and there was a merge conflict in the old version
09:36arndwhat I'd suggest is to merge 71b25f4df984 into your branch and resolve the conflict the same way that gregkh did in his tree. Then try to merge tty-next on top of that. If that is a clean merge, it should be fine, otherwise I can see if I have a better idea
09:36ephe_meral2 has quit [Ping timeout: 240 seconds]
09:39vijfhoek has joined #asahi
09:45goldenkrew3000 has joined #asahi
09:51ephe_meral2 has joined #asahi
10:17goldenkrew3000 has quit [Remote host closed the connection]
10:19chatcat has joined #asahi
10:23furkan has quit [Ping timeout: 246 seconds]
10:34marcanmaz: wait, how did the guest masking ever work? AFAICT the aic FIQ mask code in v3 is completely broken :D
10:34marcanI forgot to subtract out the AIC IRQ offset from the hwirq number, so nothing ever gets masked/unmasked
10:40ephe_meral2 has quit [Remote host closed the connection]
11:08ephe_meral2 has joined #asahi
11:22j`ey has joined #asahi
11:22j`ey has quit [Changing host]
11:40furkan has joined #asahi
11:42brandas has quit [Ping timeout: 240 seconds]
11:42brandas has joined #asahi
12:20jeffmiw has joined #asahi
12:24jeffmiw has quit [Ping timeout: 240 seconds]
12:25jato has quit [Quit: ZNC - https://znc.in]
12:27jato has joined #asahi
12:32rjeffman has joined #asahi
12:42korzq has quit [Quit: The Lounge - https://thelounge.chat]
12:42korzq has joined #asahi
12:42korzq has quit [Changing host]
12:42korzq has joined #asahi
13:09JusticeEX has joined #asahi
13:32ephe_meral has joined #asahi
13:33ephe_meral2 has quit [Ping timeout: 252 seconds]
14:10JusticeEX has quit [Ping timeout: 265 seconds]
14:32karlyeurl has quit [Ping timeout: 252 seconds]
14:37ephe_meral1 has joined #asahi
14:37ephe_meral has quit [Ping timeout: 252 seconds]
14:48klaus has quit [Quit: Textual IRC Client: www.textualapp.com]
15:03snalty_ has quit [Quit: ZNC 1.8.2 - https://znc.in]
15:20karlyeurl has joined #asahi
15:22snalty has joined #asahi
15:33manawyrm has quit [Ping timeout: 258 seconds]
15:33Guest89357 has quit [Ping timeout: 258 seconds]
15:34Guest89357 has joined #asahi
15:46awordnot has quit [Ping timeout: 248 seconds]
15:50manawyrm has joined #asahi
16:31hir0 has joined #asahi
16:37bisko has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:13VinDuv has joined #asahi
17:17arcsor5 has joined #asahi
17:32ephe_meral1 has quit [Ping timeout: 252 seconds]
17:55mazmarcan: interesting. it just means that the timers are always disabled, and that we are just opportunistically injecting virtual interrupts into the guest as a best effort measure. given what little guest code gets run at the moment, it isn't surprising we didn't notice that.
17:55marcanhttps://github.com/AsahiLinux/linux/commits/upstream-bringup-v4 has the latest cleanup, and should fix that bug (though I don't have a good way to test it)
17:57marcanI also threw in allowing edge-triggering for IRQs, since it seems MSIs work like that after all
17:58marcanbasically they behave as level IRQs that go high on the event, and low after the AIC event register is read
18:00marcanso basically they have some flops to latch the edge that get cleared on ack, and its output is presented as the level state
18:01marcanthis is useful because it means we can still do software IRQ priorities on edge-triggered IRQs (e.g. poll all or a subset of IRQ states in a different order, bypassing the internal logic; this might make sense if we want to desperately prioritize, say, a couple IRQs for some reason)
18:21marcanmaz: does the kernel run at EL1 in CONFIG_VHE=n mode? if so, it won't work with the current AIC anyway
18:22marcanI need to fix that for EL1 mode (I will a bit later, don't want that to block this series)
18:22marcanthere's a spinor but I don't want to go near that unless we have to, because it's a brick risk. there's also the PD controller flash which is similarly fairly critical
18:23chatcatmarcan: there is usually some 64 MB winbond and apparently another macronix (not sure about this) on the macbook air m1 and the mini
18:25chatcatis the firmware for those eeproms actually part of upgrades, i.e. can you get it from somewhere else?
18:26marcanit is, but the firmware is just patches for the internal ROM; I don't know what happens if you wipe it, I don't know if DFU itself can work off of the internal ROM only
18:28marcanI don't think DFU would erase that firmware, I would expect it to upgrade it to the latest version though
18:30chatcati did not yet take a close look at all other similar devices like ipad, iphone which are kinda similar to the ARM Macs but iirc there were not eeproms
18:32marcanhttps://d3nevzfk7ii3be.cloudfront.net/igi/WgkFM4qTwDa42kDf.full that CD3215 should have one
18:37chatcatthx what board is this? some way to physically dump the chips would also be nice (though not related to asahi directly) , you could restore it and take a closer look what is in there, there are some testpoints on the board but the air m1 is a bit ... crowded, not sure about some useful testpoints for the mini
18:39marcanyou used to be able to read/write the flash directly from the host, but I got the impression that now they're doing some unlock/signing stuff
18:40marcaneither way we pretty much know what's there, for the PD controller it's tricky to make sense of since it's just function hooks, not the entire firmware
18:40marcanthe big 64M flash should be easily dumpable once we have spi working, but I'm not going to be instantiating that driver in default device trees for safety
19:12arnd- for the merge commits, please add a little more detail on why it gets merged in the changelog. I would also add a Signed-off-by for the merge, though that is not strictly required
19:13arnd- When you add Reviewed-by or similar tags, please keep your own Signed-off-by as the last tag in the list
19:13arnde.g. on https://github.com/AsahiLinux/linux/commit/07f6504a82ffe78aba8fd78618444a1b8895f3ee
19:13odmir has joined #asahi
19:16hir0 has quit [Ping timeout: 240 seconds]
19:19arnd- finally, I see the irqchip driver is still missing an Ack from the irqchip maintainers. I don't know if you already point this out in the cover letter, otherwise please add it
19:20arndI'd hope to get a Reviewed-by from maz, plus an Acked-by from tglx for merging it through the soc tree instead of the tip/irqchip tree
19:21arndOnce you have those, I can pull it into the soc tree for linux-next, and whatever comes up later can be add-on patches
19:24arndI can also give some Reviewed-by replies for the patches I have looked at in detail, though they are not that meaningful if I'm also the one to merge the patches
19:32awordnot has joined #asahi
19:54choozy has joined #asahi
20:19odmir has quit []
20:28Izumoo has joined #asahi
20:30Izumoo_ has quit [Ping timeout: 258 seconds]
20:35odmir has joined #asahi
20:38odmir has quit [Remote host closed the connection]
20:39odmir has joined #asahi
20:39raster has quit [Quit: Gettin' stinky!]
20:43odmir has quit [Ping timeout: 240 seconds]
20:46devinvs[m] has joined #asahi
21:01arcsor5 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:06raster has joined #asahi
21:10odmir has joined #asahi
21:12arcsor5 has joined #asahi
21:29JusticeEX has joined #asahi
21:52Izumoo has quit [Quit: Konversation terminated!]
21:53odmir has quit [Ping timeout: 260 seconds]
22:01VinDuv has quit [Quit: Leaving.]
22:08zkrx has quit [Ping timeout: 240 seconds]
22:19odmir has joined #asahi
22:21macc24 has quit [Ping timeout: 252 seconds]
22:25raster has quit [Quit: Gettin' stinky!]
22:27macc24 has joined #asahi
22:30zkrx has joined #asahi
22:36chatcat has quit [Ping timeout: 240 seconds]
22:58odmir has quit [Remote host closed the connection]
22:58odmir has joined #asahi
23:19arcsor5 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:46arcsor5 has joined #asahi
23:52JusticeEX has quit [Ping timeout: 240 seconds]