#
#asahi-re · 2021-08-30 03:23
marcanwhich is looking up disp0, yes
#asahi-re · 2021-08-30 03:23
marcanit only call it right after sr_mapDeviceMemoryWithIndex(PROV, 4, 256, 0x23b3d0000, 0x4000)
#asahi-re · 2021-08-30 03:23
alyssa(Obviously letting a copro map whatever memory it wants defeats the purpose of having an IOMMU)
#asahi-re · 2021-08-30 03:22
alyssamap_physical, the DCP only calls it with disp0 regs, yeah?
#asahi-re · 2021-08-30 03:22
marcanfor mappings?
#asahi-re · 2021-08-30 03:22
alyssaoh meant to ask about this
#asahi-re · 2021-08-30 03:22
alyssa+ /* XXX: need to validate the DCP is allowed to access */
#asahi-re · 2021-08-30 03:22
alyssaSnrkt
#asahi-re · 2021-08-30 03:21
marcan(just they make a mess of it)
#asahi-re · 2021-08-30 03:21
marcanthere's prior art there too :p
#asahi-re · 2021-08-30 03:21
marcanthis is how apple does it anyway so...
#asahi-re · 2021-08-30 03:21
alyssaalright, won't worry so much then
#asahi-re · 2021-08-30 03:20
marcanyeah I think this is all kosher
#asahi-re · 2021-08-30 03:20
alyssaalthough then I needed deferred probe nonsense --- yeah
#asahi-re · 2021-08-30 03:20
marcanso pick one that will be the "parent" driver that kicks everything off, then that defers probing until everything else is probed
#asahi-re · 2021-08-30 03:20
alyssaOkay, that's what I have now
#asahi-re · 2021-08-30 03:20
marcansibling nodes with a reference, like interrupt-parent and such
#asahi-re · 2021-08-30 03:20
alyssain the DT is that modeled as sibling nodes or as parent/child?
#asahi-re · 2021-08-30 03:19
alyssaHum, alright. That seems sane
#asahi-re · 2021-08-30 03:19
alyssaon the other hand, the DCP module needs to "own" the DCP dart so the rtkit crap can just do dma_alloc_coherent properly
#asahi-re · 2021-08-30 03:19
marcanbut I mean, you can have different drivers in one module that just happen to know about each other and share all kinds of private data
#asahi-re · 2021-08-30 03:18
alyssathe KMS driver needs to "own" disp0 stream 0, so that way framebuffer memory can be allocated by the DRM core and be automatically mapped with no driver twiddling
#asahi-re · 2021-08-30 03:18
marcanthat's kind of different, that's multiple devices sharing one register mapping
#asahi-re · 2021-08-30 03:18
alyssasven linked me to your clock gate thing as an example..?
#asahi-re · 2021-08-30 03:18
marcanwell, you can still have different devices from Linux's point of view, managed by one driver
#asahi-re · 2021-08-30 03:17
alyssabecause why would a single device need multiple independent IOMMUs? :v
#asahi-re · 2021-08-30 03:17
alyssathis is a kludge to workaround linux only allowing a device to have a single IOMMU
#asahi-re · 2021-08-30 03:17
marcanthey should probably be a single driver tbh :p
#asahi-re · 2021-08-30 03:17
marcanheh
#asahi-re · 2021-08-30 03:17
alyssahave a DCP driver and a KMS driver and they are independent modules with mutual references in their private structs it's not good
#asahi-re · 2021-08-30 03:16
alyssaI uhhh
#asahi-re · 2021-08-30 03:16
marcanha
#asahi-re · 2021-08-30 03:16
alyssaforefront on the pile of hacks is the mess of a DT i've made
#asahi-re · 2021-08-30 03:16
marcan:p
#asahi-re · 2021-08-30 03:16
alyssaso no I am not putting up with 1080 on a 27" monitor
#asahi-re · 2021-08-30 03:15
alyssaLook my chromebook is 2400x1600 on a laptop screen
#asahi-re · 2021-08-30 03:15
marcanyou really care about your 4K don't you :p
#asahi-re · 2021-08-30 03:15
alyssaTomorrow will be ~~cleaning up the pile of hacks~~ adding more hacks so I get 4k@60 on linux
#asahi-re · 2021-08-30 03:14
marcannice!
#asahi-re · 2021-08-30 03:14
marcan:D
#asahi-re · 2021-08-30 03:14
alyssa^ that gets us to "hello KMS" on the DCP
#asahi-re · 2021-08-30 03:14
alyssa 14 files changed, 1684 insertions(+), 18 deletions(-)
#asahi-re · 2021-08-30 03:13
alyssathen again i can only imagine what dcp.kext looks like 😋
#asahi-re · 2021-08-30 03:13
marcanit's okay, review will take care of that :D
#asahi-re · 2021-08-30 03:12
alyssaI want to say the mess I've produced is not that
#asahi-re · 2021-08-30 03:12
marcanit's our job to stick it to apple and make the linux version orders of magnitude more beautiful ;)
#asahi-re · 2021-08-30 03:12
alyssajinx
#asahi-re · 2021-08-30 03:12
marcanwe know it's a mess :p
#asahi-re · 2021-08-30 03:12
alyssaactually you know what i'm done trying to apply logic to this pile of hacks
#asahi-re · 2021-08-30 03:12
marcanlook, don't try to make sense of this

plus ›