#
#asahi-re · 2021-09-13 08:10
sventhat requires a real phy driver
#asahi-re · 2021-09-13 08:09
marcanright
#asahi-re · 2021-09-13 08:09
svennot really
#asahi-re · 2021-09-13 08:09
marcanright now we don't do USB3 at all, right?
#asahi-re · 2021-09-13 08:09
svenah, nice
#asahi-re · 2021-09-13 08:09
marcanwe're just going to have another one for TB
#asahi-re · 2021-09-13 08:09
marcanthe dp/usb/phy/tcpm model is the same as what we have
#asahi-re · 2021-09-13 08:09
marcansven: fwiw, rk3399 is a good model for this
#asahi-re · 2021-09-13 08:05
marcanlol
#asahi-re · 2021-09-13 08:04
svenso i guess a week or so for you then? :P
#asahi-re · 2021-09-13 08:04
marcanno promises on how long power/clocks will take though... that could be a rabbit hole
#asahi-re · 2021-09-13 08:04
marcansure :p
#asahi-re · 2021-09-13 08:03
svenso you'll upstream power/clocks first and then fix the core code? :>
#asahi-re · 2021-09-13 08:03
marcansven: current conclusion: this is all made of fail for altmodes and we need to fix core code :p
#asahi-re · 2021-09-13 08:03
marcansigh
#asahi-re · 2021-09-13 08:03
marcanwho made this binding
#asahi-re · 2021-09-13 08:03
marcanthere can be multiple of these
#asahi-re · 2021-09-13 08:03
marcanno
#asahi-re · 2021-09-13 08:03
marcanwhat
#asahi-re · 2021-09-13 08:03
marcan alternate mode connection of which SBU is a part.
#asahi-re · 2021-09-13 08:03
marcan description: Sideband Use (SBU), present in USB-C. This describes the
#asahi-re · 2021-09-13 08:03
marcan $ref: /schemas/graph.yaml#/properties/port
#asahi-re · 2021-09-13 08:03
marcan port@2:
#asahi-re · 2021-09-13 08:01
marcanheh yeah
#asahi-re · 2021-09-13 07:59
svennot a big deal and a quick fix, but i guess apple is the first one to use two of these chips on the same irq line
#asahi-re · 2021-09-13 07:59
sventhe interrupt handling is also broken. it requests a shared interrupt but always returns IRQ_HANDLED
#asahi-re · 2021-09-13 07:59
sventhe ti driver is pretty minimal
#asahi-re · 2021-09-13 07:59
marcanwhere are altmodes in this thing...
#asahi-re · 2021-09-13 07:58
marcanthough those are just audio/debug
#asahi-re · 2021-09-13 07:58
marcanlol the ti driver
#asahi-re · 2021-09-13 07:58
marcan desc.accessory = TYPEC_ACCESSORY_NONE; /* XXX: handle accessories */
#asahi-re · 2021-09-13 07:58
marcanI'm volunteering for displayport *if* I get power to work :p
#asahi-re · 2021-09-13 07:58
svenso it sounds like you're volunteering for thunderbolt to me? :>
#asahi-re · 2021-09-13 07:57
marcanand on paper should be handled the same way
#asahi-re · 2021-09-13 07:57
j_eytps6598x_interrupt -> tps6598x_disconnect -> tps6598x_set_data_role
#asahi-re · 2021-09-13 07:57
marcanbut displayport alt mode should already be a thing
#asahi-re · 2021-09-13 07:57
marcanI'm guessing there are no devicetrees with thunderbolt, seeing as, well, intel monopolized that and it's ACPI-mediated...
#asahi-re · 2021-09-13 07:57
sventrue
#asahi-re · 2021-09-13 07:57
marcanand displayport
#asahi-re · 2021-09-13 07:57
marcanyeah
#asahi-re · 2021-09-13 07:56
sveneventually we may or may not need to do more thanks to thunderbolt (ugh) but this might work for now
#asahi-re · 2021-09-13 07:56
marcanmight as well use it with a smallish patch and move on :p
#asahi-re · 2021-09-13 07:56
marcanit's there
#asahi-re · 2021-09-13 07:56
marcanwhy not
#asahi-re · 2021-09-13 07:56
marcanI don't know if anyone else actually relies on the roleswitch for hotplugs within a mode, but well
#asahi-re · 2021-09-13 07:56
marcanthis is probably the least friction way, since it's an existing subsystem
#asahi-re · 2021-09-13 07:56
marcanyeah
#asahi-re · 2021-09-13 07:56
svenyeah, that could work once the interrupt stuff in the TI code is adapted
#asahi-re · 2021-09-13 07:55
marcanand it should just be a matter of making sure it actually works as intended, and that dwc3 can use the HOST -> NONE -> HOST transition to reset itself
#asahi-re · 2021-09-13 07:55
marcanso if all the right configs and DT links are set up, that should all already work

plus ›