#asahi-gpu · 2023-03-07 03:03
alyssai think yes#asahi-gpu · 2023-03-07 03:03
i509vcb /s/believe/does#asahi-gpu · 2023-03-07 03:02
i509vcbNot sure if it is implemented right now, but I believe the hardware supports enough to implement timeline support for DRM sync objects?#asahi-gpu · 2023-03-07 02:10
alyssa40 commits now#asahi-gpu · 2023-03-07 02:10
alyssastill big, but#asahi-gpu · 2023-03-07 01:47
alyssa-next is looking quite a bit less scary#asahi-gpu · 2023-03-06 12:43
linaalyssa: Also this is now rebased on 6.2 with DCP changes, so you might need a m1n1 update too (I did)#asahi-gpu · 2023-03-06 12:28
linaalyssa: Please uprev your kernel, I think I fixed both issues ^^#asahi-gpu · 2023-03-06 12:26
linaI think it's fixed! ^^#asahi-gpu · 2023-03-06 12:22
lina*Wild guess* those fields might have something to do with preemption, that sounds like the kind of thing piglit would end up triggering...#asahi-gpu · 2023-03-06 12:21
linaLet me run with a fix for that corruption warning and see how that goes...#asahi-gpu · 2023-03-06 12:21
linaStill works ^^#asahi-gpu · 2023-03-06 12:18
linaTrying again with higher GL...#asahi-gpu · 2023-03-06 12:17
linaExcluding that though, I got through a piglit run ^^#asahi-gpu · 2023-03-06 12:15
linastreaming-texture (or something) is OOMing for me...#asahi-gpu · 2023-03-06 11:55
linaOoooo that's a new one#asahi-gpu · 2023-03-06 11:55
lina[ 83.025087] asahi 206400000.gpu: Allocator: Corruption after object of type asahi::fw::fragment::RunFragmentG13V12_3 at 0xffffffa00009be00:0x928 + 0x0..0x5#asahi-gpu · 2023-03-06 11:53
linaReproduced the RTKit crash... now did my GpuContext thing fix it?#asahi-gpu · 2023-03-06 11:09
linaNow the piglig thing...#asahi-gpu · 2023-03-06 11:09
linaOK, I think I finally fixed this one ^^#asahi-gpu · 2023-03-06 10:38
linaI think I need to modify the C side for this, this is just broken, I have no idea how to safely wrap this API without duplicating job tracking...#asahi-gpu · 2023-03-06 10:35
linaNo, but that only cleans up completed jobs and detaches the callbacks, it doesn't actually free pending jobs because it assumes you want to restart the queue later...#asahi-gpu · 2023-03-06 10:28
linaMaybe drm_sched_stop() before killing the scheduler will do what I want...?#asahi-gpu · 2023-03-06 10:14
linaOkay, I can't put a reference to the scheduler in the job, because if it is the last reference dropping the scheduler from the job cleanup callback deadlocks ;;#asahi-gpu · 2023-03-06 10:13
linaYeeeah...#asahi-gpu · 2023-03-06 10:11
linaOhh... am I deadlocking by any chance?#asahi-gpu · 2023-03-06 10:03
linaThis is weeeird... the job cleanup callback gets called but the job doesn't get dropped sometimes?#asahi-gpu · 2023-03-06 09:55
linaThat could just be the context issue I mentioned though... but first I want to find out why I'm leaking jobs...#asahi-gpu · 2023-03-06 09:54
linaAnd this time I crashed RTKit ^^;;#asahi-gpu · 2023-03-06 09:35
linaNope, this is getting signaled... so why is the scheduler not cleaning this up?#asahi-gpu · 2023-03-06 09:24
linaAh, this could be a bad firmware interaction... I do know I invalidate context before waiting for jobs to complete, which is probably a bad idea. Maybe that just kills things and leaves the jobs dangling, never to complete.#asahi-gpu · 2023-03-06 09:03
linaWait no I do#asahi-gpu · 2023-03-06 09:03
linaOhhh wait, I think I'm never calling the entity cleanup function. Okay, that one's on me then...#asahi-gpu · 2023-03-06 09:01
linaWhy do I get the feeling this is drm_sched again... something like killing the entity stops jobs from being run, but doesn't cancel/free pending jobs...#asahi-gpu · 2023-03-06 08:52
lina... and I can't reproduce it now? ;;#asahi-gpu · 2023-03-06 08:46
linaOkay, I fixed the splat but I have another issue... I'm leaking slots somewhere with this workload, it runs out#asahi-gpu · 2023-03-06 08:24
linaLet's see if my fix worked...#asahi-gpu · 2023-03-06 08:24
linaOkay, reproduced the sched thing with something deliberate (8Kx8K glmarks getting killed in a loop) ^^#asahi-gpu · 2023-03-06 08:17
linaAnd GPU crashes are better behaved now, at least it doesn't just hang your system#asahi-gpu · 2023-03-06 08:17
linaI'll look at the piglit stuff next though I'm less worried about that since I think we've always had corner case GPU crash bugs (as much as I've tried to eliminate them...)#asahi-gpu · 2023-03-06 08:15
linaThis ownership/lifetime stuff is so subtle and completely undocumented in C APIs, it's such a mess T_T#asahi-gpu · 2023-03-06 08:15
linaI've added a reference from the job to the scheduler and I think that will fix it... since the job should never get destroyed until the scheduler cleans it up from its main loop, which can only happen when the fence gets signaled or fails, so that should mean the scheduler always outlives the job outlives the fence...#asahi-gpu · 2023-03-06 08:14
linaTo make things even more confusing, the job completion isn't via a job reference, it's via a fence...#asahi-gpu · 2023-03-06 08:13
linawas gone.#asahi-gpu · 2023-03-06 08:13
linaalyssa: I can't reproduce your splat but I think I know what happened. I thought there would be something in drm_sched to wait for in-progress jobs when a scheduler/entity gets destroyed, but it doesn't look like it... so you probably had a GPU job submitted, then the userspace process aborted, then the kernel freed all the scheduler stuff and when the GPU job completed it crashed because the scheduler #asahi-gpu · 2023-03-05 16:32
alyssaadvertising dual source blending + GL 2.1 was an oversight when dropping the "add all the CAPs!!!!" commits from next#asahi-gpu · 2023-03-05 16:31
marcanfair :p#asahi-gpu · 2023-03-05 16:31
alyssasure. I'm not interested in changing that :)#asahi-gpu · 2023-03-05 16:31
marcanI grepped a bit and there's at least some conditional that implies it *should* work but I bet nobody ever tests that codepath...#asahi-gpu · 2023-03-05 16:30
alyssa This extension is written against the OpenGL 3.2 Specification (Compatibility Profile)