#
#asahi-gpu · 2023-06-14 19:45
alyssa* special register 32 giving a sort of tile ID
#asahi-gpu · 2023-06-14 19:45
alyssa(and documented it)
#asahi-gpu · 2023-06-14 19:45
alyssalina already found that one
#asahi-gpu · 2023-06-14 19:45
alyssa* special register 20 given the core (or cluster? what's the difference?) index
#asahi-gpu · 2023-06-14 19:44
alyssait relies on a few hardware features to work:
#asahi-gpu · 2023-06-14 19:44
alyssaIDK if we'll do the same thing. But understanding first.
#asahi-gpu · 2023-06-14 19:44
alyssaI have a good handle on the transform they're doing for the fragment shaders
#asahi-gpu · 2023-06-14 19:44
alyssaI'm combing through a trace of emrt this afternoon
#asahi-gpu · 2023-06-14 17:01
linaTested all the discard cases, works ^^
#asahi-gpu · 2023-06-14 16:52
alyssabut first, lunch
#asahi-gpu · 2023-06-14 16:52
alyssaso eMRT is up next
#asahi-gpu · 2023-06-14 16:47
alyssabut CTS seems happy with this if you are
#asahi-gpu · 2023-06-14 16:45
alyssaI'll revisit this post-CTS to deal with the performance hit
#asahi-gpu · 2023-06-14 16:45
linaStill works!
#asahi-gpu · 2023-06-14 16:44
alyssacheers
#asahi-gpu · 2023-06-14 16:44
steventhanks alyssa!
#asahi-gpu · 2023-06-14 16:44
alyssa(I repushed)
#asahi-gpu · 2023-06-14 16:44
alyssatry again with the fix :-D
#asahi-gpu · 2023-06-14 16:44
alyssalina: hold on i fixed the thing steven pointed out
#asahi-gpu · 2023-06-14 16:44
linaalyssa: Confirmed it fixes Darwinia ^^
#asahi-gpu · 2023-06-14 16:43
alyssayep definitely not
#asahi-gpu · 2023-06-14 16:43
alyssaprobably not
#asahi-gpu · 2023-06-14 16:42
stevenfirst line of lower_sample_mask_write is "return false" but there's a bunch of changes after it -- was that return intentional?
#asahi-gpu · 2023-06-14 16:41
lina^^
#asahi-gpu · 2023-06-14 16:40
alyssawe make a good team, you and me :~)
#asahi-gpu · 2023-06-14 16:40
alyssalina: i must say i would not have had the persistence to work through the Darwinia side of this
#asahi-gpu · 2023-06-14 16:39
alyssawe can recover that later. correctness first.
#asahi-gpu · 2023-06-14 16:39
alyssaand I expect that code to regress performance somewhat
#asahi-gpu · 2023-06-14 16:39
alyssaas predicted, it's not a quickfix
#asahi-gpu · 2023-06-14 16:39
stevenalyssa: thank you! looking now
#asahi-gpu · 2023-06-14 16:39
alyssarunning through CTS now
#asahi-gpu · 2023-06-14 16:38
linaI just finished the kernel fix! Reviewing now ^^
#asahi-gpu · 2023-06-14 16:38
alyssabut yknow. should work. probably
#asahi-gpu · 2023-06-14 16:38
alyssaI have not really tested this
#asahi-gpu · 2023-06-14 16:38
alyssalina: steven: https://gitlab.freedesktop.org/asahi/mesa/-/merge_requests/86
#asahi-gpu · 2023-06-14 16:21
stevenIs it functionally possible to specify a multisampled texture with a sample count of 1 (i.e. effectively making it single-sampled despite being GL_TEXTURE_2D_MULTISAMPLE)? If so I kind of wonder if it's as simple the sample count not propagating all the way through
#asahi-gpu · 2023-06-14 16:19
linaThere is exactly one number calculated based on FB tile dimensions that is only relevant for clustering and it needed to be *samples
#asahi-gpu · 2023-06-14 16:18
alyssaif you don't/can't fix it, i'll merge your disable patch
#asahi-gpu · 2023-06-14 16:18
alyssaregardless I can't help with msrtt
#asahi-gpu · 2023-06-14 16:18
lina(Kernel side)
#asahi-gpu · 2023-06-14 16:18
alyssafun
#asahi-gpu · 2023-06-14 16:18
linaBTW, the Ultra thing was an MSAA interaction, there may be more lurking... but I think this is the only one relevant for clustering. So if there's anything else with tiling and MSAA, you'll see it on M1.
#asahi-gpu · 2023-06-14 16:18
alyssaif you could do that I'd appreciate it!
#asahi-gpu · 2023-06-14 16:18
stevenYeah, Lina was noticing that the MSRTT path for MSAA in Darwinia didn't have a visual difference (and I saw that locally too). Using the traditional blit-to-resolve path instead works fine of course
#asahi-gpu · 2023-06-14 16:18
alyssashould be easy to fix hopefully if it's broken
#asahi-gpu · 2023-06-14 16:17
alyssaI would believe it
#asahi-gpu · 2023-06-14 16:17
linaI can try turning it off and see if it fixes it...
#asahi-gpu · 2023-06-14 16:17
linaSteven says it's broken and that's why MSAA didn't work when I tested it earlier
#asahi-gpu · 2023-06-14 16:17
alyssathere's an unmerged piglit that has problems on other drivers
#asahi-gpu · 2023-06-14 16:17
alyssathere are like, no tests for this ...

plus ›