#asahi-gpu · 2023-06-15 13:10
linaThat's the macO-yes#asahi-gpu · 2023-06-15 13:10
alyssa("macOS uses it")#asahi-gpu · 2023-06-15 13:10
alyssaHow'd you find that 0xb value?#asahi-gpu · 2023-06-15 13:10
alyssaInteresting#asahi-gpu · 2023-06-15 13:10
linaI'm not sure if we should just pass that to userspace as-is as an integer without understanding it though, it is parsed by the firmware as far as I know, not straight a hardware register.#asahi-gpu · 2023-06-15 13:09
linaI think there's probably one global enable and then specific feature bits or something...#asahi-gpu · 2023-06-15 13:09
linaI think different bits in fault_control might enable different things, but I don't know what's what yet...#asahi-gpu · 2023-06-15 13:09
linaIf you want to test, just flip the kernel arg and plumb it into a new feature you fake on or something, I can put it into the kernel next time I sit down to hack on it ^^#asahi-gpu · 2023-06-15 13:07
alyssaOK#asahi-gpu · 2023-06-15 13:06
linaIt should just be a compatible feature flag#asahi-gpu · 2023-06-15 13:06
linaYeah ^^#asahi-gpu · 2023-06-15 13:05
alyssaso just need a bit of uapi to tell userspace whether it's on or not?#asahi-gpu · 2023-06-15 13:05
linaIt's a kernel parameter, asahi.fault_control=0xb#asahi-gpu · 2023-06-15 13:04
alyssa[Although probably I should figure out how to fix that properly since Adreno doesn't have soft fault and it also uses the same broken pass..]#asahi-gpu · 2023-06-15 13:04
alyssalina: what's the story with soft fault?#asahi-gpu · 2023-06-15 13:03
alyssaAfter this, the only fail left will be due to nir_opt_preamble speculating loads#asahi-gpu · 2023-06-15 13:03
alyssa(I've been up for a few hours I don't know my sleep schedule these days)#asahi-gpu · 2023-06-15 13:03
alyssaHopefully I can finish that off today, it's only 9am lol#asahi-gpu · 2023-06-15 13:03
linaNice! ^^#asahi-gpu · 2023-06-15 13:03
alyssa(-:#asahi-gpu · 2023-06-15 13:03
alyssaI'm glad I took the easy way out because I'm getting close to something workable#asahi-gpu · 2023-06-15 11:42
linaAlso on M2 Pro/Max machines, all GPUs have "missing" cores due to the way they designed the chips... (clusters have uneven numbers of cores and they implemented it by just having phantom cores logically which are always marked disabled)...#asahi-gpu · 2023-06-15 11:41
linaalyssa: For compute context switching, they have a table as part of their data structure that maps core numbers, and my understanding is that is used for GPUs with disabled cores to avoid allocating memory that will never be used, since I'm guessing the core ID has gaps on those. So I'm surprised they don't use it for eMRT?#asahi-gpu · 2023-06-15 11:35
linaAs far as I'm concerned it's just core -> mGPU/cluster#asahi-gpu · 2023-06-15 11:34
linaWhat is a cluster according to apple? I thought I made that one up#asahi-gpu · 2023-06-15 11:34
linaalyssa: Frags is Apple terminology and I don't actually know what it means#asahi-gpu · 2023-06-15 10:26
alyssaas for the shadertoy, yes if you run shadertoys you get to pick up the pieces#asahi-gpu · 2023-06-15 10:22
alyssamaybe?#asahi-gpu · 2023-06-15 10:22
alyssa"frags -> core -> cluster"?#asahi-gpu · 2023-06-15 10:22
alyssawhereas you call those#asahi-gpu · 2023-06-15 10:22
alyssa"core -> cluster -> mGPU"?#asahi-gpu · 2023-06-15 10:22
alyssaOhh.. I guess the hierarchy in Apple terms is like#asahi-gpu · 2023-06-15 10:21
alyssa(just needing the driver to use the right constants for the implementation)#asahi-gpu · 2023-06-15 10:21
alyssameaning, the shaders they produce are portable across GPUs regardless of configuration#asahi-gpu · 2023-06-15 10:21
alyssalina: right, ok. Interestingly Apple gets the "# of concurrent tiles per core" parameter from a uniform, and doesn't ever explicitly use "# of cores" in the shader#asahi-gpu · 2023-06-15 04:36
linaalyssa: BTW, the firefox register spilling thing was some crazy shadertoy, not webrender, so don't worry about that ^^#asahi-gpu · 2023-06-15 02:30
linaalyssa: What I call clusters is what Apple calls "mGPU"s. M1 has just one. We need to test whatever you end up with on t600x and check whether the core ID register is globally unique or we need to get the mGPU ID somewhere else and add it in... hopefully it's unique.#asahi-gpu · 2023-06-14 22:04
alyssait just needs to work#asahi-gpu · 2023-06-14 22:04
alyssait doesn't need to be fast#asahi-gpu · 2023-06-14 22:01
alyssa("Slow?" "Shhh")#asahi-gpu · 2023-06-14 22:01
alyssawhy not use em#asahi-gpu · 2023-06-14 22:01
alyssabindless images, sure why not, I already implement those#asahi-gpu · 2023-06-14 22:00
alyssaI just want to pass CTS, yo#asahi-gpu · 2023-06-14 22:00
alyssakeeps lowering the bar to produce the Easiest Possible Implementation#asahi-gpu · 2023-06-14 20:54
alyssaor maybe today. i wonder how far I can get in a few minutes so I can stop thinking about it#asahi-gpu · 2023-06-14 20:53
alyssa=)#asahi-gpu · 2023-06-14 20:53
alyssabut that's for tomorrow#asahi-gpu · 2023-06-14 20:52
alyssathere are times in driver dev to be clever and I don't think this is one#asahi-gpu · 2023-06-14 20:52
alyssaand if anything ever hits this other than the CTS we can revisit#asahi-gpu · 2023-06-14 20:52
alyssawhich I think should get similar performance, just with a dramatically worse (but still tolerable) memory footprint