#
#asahi-gpu · 2023-07-19 11:35
alyssabut I would definitely like us to know the r/e side at least :)
#asahi-gpu · 2023-07-19 11:35
alyssathe conversion part
#asahi-gpu · 2023-07-19 11:35
alyssaFWIW I don't care to support that in Mesa most likely
#asahi-gpu · 2023-07-19 11:34
linaOK ^^
#asahi-gpu · 2023-07-19 11:34
alyssaEasiest way will be if you watch a film with whole-system hv on, I think
#asahi-gpu · 2023-07-19 11:33
alyssaMetal doesn't support that publicly
#asahi-gpu · 2023-07-19 11:33
alyssaNo
#asahi-gpu · 2023-07-19 11:32
linaalyssa: By the way, did you ever look at YCbCr conversion? We're still not loading the conversion coefficients in the kernel, and it might be a good idea to test this and start doing that before upstreaming.
#asahi-gpu · 2023-07-19 11:18
linaThe compression meta buffers are directly after the main buffers with no page alignment, so that's probably just implied when using this configuration
#asahi-gpu · 2023-07-19 11:18
alyssathough none of this seems that weird
#asahi-gpu · 2023-07-19 11:17
alyssaI'll look when I'm awake in a few hours
#asahi-gpu · 2023-07-19 11:16
alyssaIDK
#asahi-gpu · 2023-07-19 11:16
alyssaok
#asahi-gpu · 2023-07-19 11:16
linaWhat patches?
#asahi-gpu · 2023-07-19 11:16
linaNo?
#asahi-gpu · 2023-07-19 11:16
alyssais this with Mesa patches?
#asahi-gpu · 2023-07-19 11:16
linaYes, and "Compressed 1" is true
#asahi-gpu · 2023-07-19 11:16
alyssabut it says Layout Compressed?
#asahi-gpu · 2023-07-19 11:16
alyssaI see
#asahi-gpu · 2023-07-19 11:16
alyssaooooooooh
#asahi-gpu · 2023-07-19 11:16
alyssaunkB1 is a PBE block write, the descriptor is the first one (the PBE descriptor)
#asahi-gpu · 2023-07-19 11:16
lina<field name="Compression" size="2" start="106" type="hex"/> <!-- 0 for uncompressed -->
#asahi-gpu · 2023-07-19 11:15
alyssawhat are you talking about compression=0
#asahi-gpu · 2023-07-19 11:15
linaSo it's just the fun descriptors then
#asahi-gpu · 2023-07-19 11:15
linaOhh OK, so that one is already known
#asahi-gpu · 2023-07-19 11:14
alyssato disassemble TODO.unkB1
#asahi-gpu · 2023-07-19 11:14
alyssahttps://github.com/dougallj/applegpu/pull/41
#asahi-gpu · 2023-07-19 11:14
linaalyssa: do you know if compression=0 works? also any idea about the TODO.unkB1?
#asahi-gpu · 2023-07-19 11:14
alyssaSpicy
#asahi-gpu · 2023-07-19 11:12
linaMind you, this is probably orthogonal to the actual compression
#asahi-gpu · 2023-07-19 11:12
linaYeah...
#asahi-gpu · 2023-07-19 11:12
jannaua new DRM format as well
#asahi-gpu · 2023-07-19 11:10
linaI guess this is a whole new PIPE_FORMAT, don't see anything matching it...
#asahi-gpu · 2023-07-19 11:05
linaAlso the store shader uses TODO.unkB1 ?
#asahi-gpu · 2023-07-19 11:05
linaSo then I'm not sure if the compression is the same or not because too many things changed, but at least "Compression" is 0x0 which seems different.
#asahi-gpu · 2023-07-19 11:04
linaAnd when you do that, the accel buffer field is the address of the second plane... and I guess the actual compression metadata offset is implied?
#asahi-gpu · 2023-07-19 11:04
linaIt turns out it *does* have support for X2R10G10B10 + A8 biplanar formats directly
#asahi-gpu · 2023-07-19 11:03
linaalyssa: Sooo about that DCP compression thing... https://gist.github.com/asahilina/59cf953b82dd1675909f1cbb1a650fd4
#asahi-gpu · 2023-07-19 10:03
jannaulina: https://github.com/jannau/m1n1/tree/m2_dptx_v13_3
#asahi-gpu · 2023-07-19 10:00
jannaulooking for the right branch
#asahi-gpu · 2023-07-19 09:59
jannaulina: not yet
#asahi-gpu · 2023-07-19 02:50
alyssa(I hope.)
#asahi-gpu · 2023-07-19 02:50
alyssathis code has passed All The Tests and all the important stuff was discussed on stream so any review at this point would likely be finding local style things and not Big Problems
#asahi-gpu · 2023-07-19 02:49
alyssalina: i'm about to go to sleep. i'll merge tomorrow my time barring discovered issues. that gives you all of today JST to review if you want. or to do nothing if you want.
#asahi-gpu · 2023-07-19 01:57
linaalyssa: I think you can just merge it if you're comfortable without line by line review, unless you want me to just review it today ^^
#asahi-gpu · 2023-07-18 20:44
alyssawhat value of $TIME?
#asahi-gpu · 2023-07-18 20:43
alyssashould I wait $TIME to let you review?
#asahi-gpu · 2023-07-18 20:43
alyssalina: should I merge https://gitlab.freedesktop.org/asahi/mesa/-/merge_requests/108 ?
#asahi-gpu · 2023-07-17 22:52
linaalyssa: Because gettimeofday is a complex function of the raw CPU timer counter ^^
#asahi-gpu · 2023-07-17 20:32
alyssawhy can't mesa just do gettimeofday and call it a day?

plus ›